All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Sean Paul <sean@poorly.run>
Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
	freedreno@lists.freedesktop.org, swboyd@chromium.org,
	Sean Paul <seanpaul@chromium.org>,
	Rob Clark <robdclark@gmail.com>, David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Kuogee Hsieh <khsieh@codeaurora.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 12/13] dt-bindings: msm/dp: Add bindings for HDCP registers
Date: Thu, 16 Sep 2021 07:58:38 -0500	[thread overview]
Message-ID: <YUM/fl0U95Cxc+iM@robh.at.kernel.org> (raw)
In-Reply-To: <20210915203834.1439-13-sean@poorly.run>

On Wed, Sep 15, 2021 at 04:38:31PM -0400, Sean Paul wrote:
> From: Sean Paul <seanpaul@chromium.org>
> 
> This patch adds the bindings for the MSM DisplayPort HDCP registers
> which are required to write the HDCP key into the display controller as
> well as the registers to enable HDCP authentication/key
> exchange/encryption.
> 
> Cc: Rob Herring <robh@kernel.org>
> Cc: Stephen Boyd <swboyd@chromium.org>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-13-sean@poorly.run #v1
> 
> Changes in v2:
> -Drop register range names (Stephen)
> -Fix yaml errors (Rob)
> ---
>  .../devicetree/bindings/display/msm/dp-controller.yaml     | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> index 64d8d9e5e47a..80a55e9ff532 100644
> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> @@ -19,7 +19,7 @@ properties:
>        - qcom,sc7180-dp
>  
>    reg:
> -    maxItems: 1
> +    maxItems: 3

You need to define what each entry is.

items:
  - description: ...
  - description: ...
  - description: ...

>  
>    interrupts:
>      maxItems: 1
> @@ -99,8 +99,9 @@ examples:
>      #include <dt-bindings/power/qcom-rpmpd.h>
>  
>      displayport-controller@ae90000 {
> -        compatible = "qcom,sc7180-dp";
> -        reg = <0xae90000 0x1400>;
> +        reg = <0 0x0ae90000 0 0x1400>,
> +              <0 0x0aed1000 0 0x174>,
> +              <0 0x0aee1000 0 0x2c>;
>          interrupt-parent = <&mdss>;
>          interrupts = <12>;
>          clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
> -- 
> Sean Paul, Software Engineer, Google / Chromium OS
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Sean Paul <sean@poorly.run>
Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
	freedreno@lists.freedesktop.org, swboyd@chromium.org,
	Sean Paul <seanpaul@chromium.org>,
	Rob Clark <robdclark@gmail.com>, David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Kuogee Hsieh <khsieh@codeaurora.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH v2 12/13] dt-bindings: msm/dp: Add bindings for HDCP registers
Date: Thu, 16 Sep 2021 07:58:38 -0500	[thread overview]
Message-ID: <YUM/fl0U95Cxc+iM@robh.at.kernel.org> (raw)
In-Reply-To: <20210915203834.1439-13-sean@poorly.run>

On Wed, Sep 15, 2021 at 04:38:31PM -0400, Sean Paul wrote:
> From: Sean Paul <seanpaul@chromium.org>
> 
> This patch adds the bindings for the MSM DisplayPort HDCP registers
> which are required to write the HDCP key into the display controller as
> well as the registers to enable HDCP authentication/key
> exchange/encryption.
> 
> Cc: Rob Herring <robh@kernel.org>
> Cc: Stephen Boyd <swboyd@chromium.org>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-13-sean@poorly.run #v1
> 
> Changes in v2:
> -Drop register range names (Stephen)
> -Fix yaml errors (Rob)
> ---
>  .../devicetree/bindings/display/msm/dp-controller.yaml     | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> index 64d8d9e5e47a..80a55e9ff532 100644
> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> @@ -19,7 +19,7 @@ properties:
>        - qcom,sc7180-dp
>  
>    reg:
> -    maxItems: 1
> +    maxItems: 3

You need to define what each entry is.

items:
  - description: ...
  - description: ...
  - description: ...

>  
>    interrupts:
>      maxItems: 1
> @@ -99,8 +99,9 @@ examples:
>      #include <dt-bindings/power/qcom-rpmpd.h>
>  
>      displayport-controller@ae90000 {
> -        compatible = "qcom,sc7180-dp";
> -        reg = <0xae90000 0x1400>;
> +        reg = <0 0x0ae90000 0 0x1400>,
> +              <0 0x0aed1000 0 0x174>,
> +              <0 0x0aee1000 0 0x2c>;
>          interrupt-parent = <&mdss>;
>          interrupts = <12>;
>          clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
> -- 
> Sean Paul, Software Engineer, Google / Chromium OS
> 
> 

  parent reply	other threads:[~2021-09-16 12:58 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15 20:38 [PATCH v2 00/13] drm/hdcp: Pull HDCP auth/exchange/check into helpers Sean Paul
2021-09-15 20:38 ` [Intel-gfx] " Sean Paul
2021-09-15 20:38 ` [PATCH v2 01/13] drm/hdcp: Add drm_hdcp_atomic_check() Sean Paul
2021-09-15 20:38   ` [Intel-gfx] " Sean Paul
2021-09-15 20:38 ` [PATCH v2 02/13] drm/hdcp: Avoid changing crtc state in hdcp atomic check Sean Paul
2021-09-15 20:38   ` [Intel-gfx] " Sean Paul
2021-09-15 20:38 ` [PATCH v2 03/13] drm/hdcp: Update property value on content type and user changes Sean Paul
2021-09-15 20:38   ` [Intel-gfx] " Sean Paul
2021-09-16 22:48   ` kernel test robot
2021-09-16 22:48     ` kernel test robot
2021-09-15 20:38 ` [PATCH v2 04/13] drm/hdcp: Expand HDCP helper library for enable/disable/check Sean Paul
2021-09-15 20:38   ` [Intel-gfx] " Sean Paul
2021-09-21 23:34   ` [Freedreno] " abhinavk
2021-09-21 23:34     ` [Intel-gfx] " abhinavk
2021-09-28 17:33     ` Sean Paul
2021-09-28 17:33       ` [Intel-gfx] " Sean Paul
2021-09-28 21:28       ` abhinavk
2021-09-28 21:28         ` abhinavk
2021-09-15 20:38 ` [PATCH v2 05/13] drm/i915/hdcp: Consolidate HDCP setup/state cache Sean Paul
2021-09-15 20:38   ` [Intel-gfx] " Sean Paul
2021-09-15 20:38 ` [PATCH v2 06/13] drm/i915/hdcp: Retain hdcp_capable return codes Sean Paul
2021-09-15 20:38   ` [Intel-gfx] " Sean Paul
2021-09-15 20:38 ` [PATCH v2 07/13] drm/i915/hdcp: Use HDCP helpers for i915 Sean Paul
2021-09-15 20:38   ` [Intel-gfx] " Sean Paul
2021-09-17  0:10   ` kernel test robot
2021-09-17  0:10     ` kernel test robot
2021-09-15 20:38 ` [PATCH v2 08/13] drm/msm/dpu_kms: Re-order dpu includes Sean Paul
2021-09-15 20:38   ` [Intel-gfx] " Sean Paul
2021-09-17  3:54   ` Stephen Boyd
2021-09-17  3:54     ` Stephen Boyd
2021-09-17  3:54     ` [Intel-gfx] " Stephen Boyd
2021-09-22  2:26   ` [Freedreno] " abhinavk
2021-09-22  2:26     ` [Intel-gfx] " abhinavk
2021-09-15 20:38 ` [PATCH v2 09/13] drm/msm/dpu: Remove useless checks in dpu_encoder Sean Paul
2021-09-15 20:38   ` [Intel-gfx] " Sean Paul
2021-09-17  3:54   ` Stephen Boyd
2021-09-17  3:54     ` Stephen Boyd
2021-09-17  3:54     ` [Intel-gfx] " Stephen Boyd
2021-09-15 20:38 ` [PATCH v2 10/13] drm/msm/dpu: Remove encoder->enable() hack Sean Paul
2021-09-15 20:38   ` [Intel-gfx] " Sean Paul
2021-09-17  3:53   ` Stephen Boyd
2021-09-17  3:53     ` Stephen Boyd
2021-09-17  3:53     ` [Intel-gfx] " Stephen Boyd
2021-09-17 17:25     ` Sean Paul
2021-09-17 17:25       ` [Intel-gfx] " Sean Paul
2021-09-15 20:38 ` [PATCH v2 11/13] drm/msm/dp: Re-order dp_audio_put in deinit_sub_modules Sean Paul
2021-09-15 20:38   ` [Intel-gfx] " Sean Paul
2021-09-17  3:51   ` Stephen Boyd
2021-09-17  3:51     ` [Intel-gfx] " Stephen Boyd
2021-09-17  3:51     ` Stephen Boyd
2021-09-15 20:38 ` [PATCH v2 12/13] dt-bindings: msm/dp: Add bindings for HDCP registers Sean Paul
2021-09-15 20:38   ` [Intel-gfx] " Sean Paul
2021-09-16 12:21   ` Rob Herring
2021-09-16 12:21     ` [Intel-gfx] " Rob Herring
2021-09-16 12:58   ` Rob Herring [this message]
2021-09-16 12:58     ` Rob Herring
2021-09-15 20:38 ` [PATCH v2 13/13] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers Sean Paul
2021-09-15 20:38   ` [Intel-gfx] " Sean Paul
2021-09-17  4:30   ` kernel test robot
2021-09-17  4:30     ` kernel test robot
2021-09-17  4:30     ` [Intel-gfx] " kernel test robot
2021-09-17  6:00   ` Stephen Boyd
2021-09-17  6:00     ` [Intel-gfx] " Stephen Boyd
2021-09-17  6:00     ` Stephen Boyd
2021-09-17 21:05     ` Sean Paul
2021-09-17 21:05       ` [Intel-gfx] " Sean Paul
2021-09-22  2:25   ` [Intel-gfx] [Freedreno] " abhinavk
2021-09-22  2:25     ` abhinavk
2021-09-28 18:02     ` Sean Paul
2021-09-28 18:02       ` [Intel-gfx] " Sean Paul
2021-09-28 21:35       ` abhinavk
2021-09-28 21:35         ` [Intel-gfx] " abhinavk
2021-09-29 14:52         ` Sean Paul
2021-09-29 14:52           ` [Intel-gfx] " Sean Paul
2021-09-15 21:58 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/hdcp: Pull HDCP auth/exchange/check into helpers Patchwork
2021-09-17 12:49   ` Jani Nikula
2021-09-17 12:51 ` [Intel-gfx] [PATCH v2 00/13] " Jani Nikula
2021-09-22  2:30 ` [Freedreno] " abhinavk
2021-09-22  2:30   ` [Intel-gfx] " abhinavk
2021-09-28 18:06   ` Sean Paul
2021-09-28 18:06     ` [Intel-gfx] " Sean Paul
2021-09-28 21:23     ` abhinavk
2021-09-28 21:23       ` [Intel-gfx] " abhinavk
2021-09-17  1:29 [PATCH v2 04/13] drm/hdcp: Expand HDCP helper library for enable/disable/check kernel test robot
2021-09-17 10:58 ` [kbuild] " Dan Carpenter
2021-09-17 10:58 ` Dan Carpenter
2021-09-17 10:58 ` [Intel-gfx] " Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YUM/fl0U95Cxc+iM@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=khsieh@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    --cc=seanpaul@chromium.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.