All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH libnetfilter_queue] src: build: Stop build_man.sh from deleting short Detailed Descriptions
@ 2021-09-17  8:45 Duncan Roe
  2021-09-20 11:39 ` Florian Westphal
  0 siblings, 1 reply; 2+ messages in thread
From: Duncan Roe @ 2021-09-17  8:45 UTC (permalink / raw)
  To: pablo; +Cc: netfilter-devel

An empty Detailed Description is 3 lines long but a short (1-para) DD is also 3
lines. Check that the 3rd line really is empty.

Signed-off-by: Duncan Roe <duncan_roe@optusnet.com.au>
---
 doxygen/build_man.sh | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/doxygen/build_man.sh b/doxygen/build_man.sh
index 63e02dc..852c7b8 100755
--- a/doxygen/build_man.sh
+++ b/doxygen/build_man.sh
@@ -116,7 +116,11 @@ del_empty_det_desc(){
   mygrep "^\\.SH \"Detailed Description" $target
   [ $linnum -ne 0  ] || return 0
   [ $(($i - $linnum)) -eq 3 ] || return 0
-  delete_lines $linnum $(($i -1))
+  # A 1-line Detailed Description is also 3 lines long,
+  # but the 3rd line is not empty
+  i=$(($i -1))
+  [ $(tail -n+$i $target | head -n1 | wc -c) -le 2 ] || return 0
+  delete_lines $linnum $i
 }
 
 move_synopsis(){
-- 
2.17.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH libnetfilter_queue] src: build: Stop build_man.sh from deleting short Detailed Descriptions
  2021-09-17  8:45 [PATCH libnetfilter_queue] src: build: Stop build_man.sh from deleting short Detailed Descriptions Duncan Roe
@ 2021-09-20 11:39 ` Florian Westphal
  0 siblings, 0 replies; 2+ messages in thread
From: Florian Westphal @ 2021-09-20 11:39 UTC (permalink / raw)
  To: Duncan Roe; +Cc: pablo, netfilter-devel

Duncan Roe <duncan_roe@optusnet.com.au> wrote:
> An empty Detailed Description is 3 lines long but a short (1-para) DD is also 3
> lines. Check that the 3rd line really is empty.

applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-20 11:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-17  8:45 [PATCH libnetfilter_queue] src: build: Stop build_man.sh from deleting short Detailed Descriptions Duncan Roe
2021-09-20 11:39 ` Florian Westphal

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.