From: Andrew Lunn <andrew@lunn.ch>
To: Min Li <min.li.xe@renesas.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
"richardcochran@gmail.com" <richardcochran@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v2 2/2] ptp: idt82p33: implement double dco time correction
Date: Mon, 20 Sep 2021 18:49:20 +0200 [thread overview]
Message-ID: <YUi7kMkUI/69wHD/@lunn.ch> (raw)
In-Reply-To: <OS3PR01MB65936F7C178EC44467285F2BBAA09@OS3PR01MB6593.jpnprd01.prod.outlook.com>
On Mon, Sep 20, 2021 at 03:13:14PM +0000, Min Li wrote:
> >
> > > On Fri, Jun 25, 2021 at 02:24:24PM +0000, Min Li wrote:
> > > > How would you suggest to implement the change that make the new
> > driver behavior optional?
> > > I would say, module parameter or debugfs knob.
> >
> > Aright, in which case devlink or debugfs, please.
> >
> Hi Jakub
>
> The target platform BSP is little old and doesn't support devlink_params_register yet.
>
> And our design doesn't allow debugfs to be used in released software.
That does not matter. You are not submitting code to your BSP, you are
submitting to mainline. Please use the features mainline provides.
Andrew
next prev parent reply other threads:[~2021-09-20 16:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 14:39 [PATCH net v2 1/2] ptp: idt82p33: optimize idt82p33_adjtime min.li.xe
2021-09-17 14:39 ` [PATCH net v2 2/2] ptp: idt82p33: implement double dco time correction min.li.xe
2021-09-17 19:54 ` Jakub Kicinski
2021-09-17 20:19 ` Min Li
2021-09-17 21:06 ` Jakub Kicinski
2021-09-20 14:08 ` Min Li
2021-09-20 19:14 ` Jakub Kicinski
2021-09-20 15:13 ` Min Li
2021-09-20 16:49 ` Andrew Lunn [this message]
2021-09-17 19:58 ` [PATCH net v2 1/2] ptp: idt82p33: optimize idt82p33_adjtime Andrew Lunn
-- strict thread matches above, loose matches on Subject: below --
2021-09-17 20:50 min.li.xe
2021-09-17 20:50 ` [PATCH net v2 2/2] ptp: idt82p33: implement double dco time correction min.li.xe
2021-09-17 21:08 ` Jakub Kicinski
2021-09-17 21:14 ` Andrew Lunn
2021-06-29 18:29 [PATCH net v2 1/2] ptp: idt82p33: optimize idt82p33_adjtime min.li.xe
2021-06-29 18:29 ` [PATCH net v2 2/2] ptp: idt82p33: implement double dco time correction min.li.xe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUi7kMkUI/69wHD/@lunn.ch \
--to=andrew@lunn.ch \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=min.li.xe@renesas.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.