From: Rob Herring <robh@kernel.org>
To: Alexandre Bailon <abailon@baylibre.com>
Cc: airlied@linux.ie, daniel@ffwll.ch, matthias.bgg@gmail.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, ohad@wizery.com, bjorn.andersson@linaro.org,
mathieu.poirier@linaro.org, sumit.semwal@linaro.org,
christian.koenig@amd.com, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-remoteproc@vger.kernel.org, linux-media@vger.kernel.org,
linaro-mm-sig@lists.linaro.org, khilman@baylibre.com,
gpain@baylibre.com
Subject: Re: [RFC PATCH 1/4] dt-bindings: Add bidings for mtk,apu-drm
Date: Mon, 20 Sep 2021 15:55:58 -0500 [thread overview]
Message-ID: <YUj1XnBbyNEqrV2g@robh.at.kernel.org> (raw)
In-Reply-To: <20210917125945.620097-2-abailon@baylibre.com>
On Fri, Sep 17, 2021 at 02:59:42PM +0200, Alexandre Bailon wrote:
> This adds the device tree bindings for the APU DRM driver.
>
> Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
> ---
> .../devicetree/bindings/gpu/mtk,apu-drm.yaml | 38 +++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpu/mtk,apu-drm.yaml
>
> diff --git a/Documentation/devicetree/bindings/gpu/mtk,apu-drm.yaml b/Documentation/devicetree/bindings/gpu/mtk,apu-drm.yaml
> new file mode 100644
> index 0000000000000..6f432d3ea478c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpu/mtk,apu-drm.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpu/mediatek,apu-drm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AI Processor Unit DRM
DRM is a linux thing, not h/w.
> +
> +properties:
> + compatible:
> + const: mediatek,apu-drm
> +
> + remoteproc:
So is remoteproc.
Why don't you have the remoteproc driver create the DRM device?
> + maxItems: 2
> + description:
> + Handle to remoteproc devices controlling the APU
> +
> + iova:
> + maxItems: 1
> + description:
> + Address and size of virtual memory that could used by the APU
Why does this need to be in DT? If you need to reserve certain VAs, then
this discussion[1] might be of interest.
Rob
[1] https://lore.kernel.org/all/YUIPCxnyRutMS47%2F@orome.fritz.box/
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Alexandre Bailon <abailon@baylibre.com>
Cc: airlied@linux.ie, daniel@ffwll.ch, matthias.bgg@gmail.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, ohad@wizery.com, bjorn.andersson@linaro.org,
mathieu.poirier@linaro.org, sumit.semwal@linaro.org,
christian.koenig@amd.com, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-remoteproc@vger.kernel.org, linux-media@vger.kernel.org,
linaro-mm-sig@lists.linaro.org, khilman@baylibre.com,
gpain@baylibre.com
Subject: Re: [RFC PATCH 1/4] dt-bindings: Add bidings for mtk,apu-drm
Date: Mon, 20 Sep 2021 15:55:58 -0500 [thread overview]
Message-ID: <YUj1XnBbyNEqrV2g@robh.at.kernel.org> (raw)
In-Reply-To: <20210917125945.620097-2-abailon@baylibre.com>
On Fri, Sep 17, 2021 at 02:59:42PM +0200, Alexandre Bailon wrote:
> This adds the device tree bindings for the APU DRM driver.
>
> Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
> ---
> .../devicetree/bindings/gpu/mtk,apu-drm.yaml | 38 +++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpu/mtk,apu-drm.yaml
>
> diff --git a/Documentation/devicetree/bindings/gpu/mtk,apu-drm.yaml b/Documentation/devicetree/bindings/gpu/mtk,apu-drm.yaml
> new file mode 100644
> index 0000000000000..6f432d3ea478c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpu/mtk,apu-drm.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpu/mediatek,apu-drm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AI Processor Unit DRM
DRM is a linux thing, not h/w.
> +
> +properties:
> + compatible:
> + const: mediatek,apu-drm
> +
> + remoteproc:
So is remoteproc.
Why don't you have the remoteproc driver create the DRM device?
> + maxItems: 2
> + description:
> + Handle to remoteproc devices controlling the APU
> +
> + iova:
> + maxItems: 1
> + description:
> + Address and size of virtual memory that could used by the APU
Why does this need to be in DT? If you need to reserve certain VAs, then
this discussion[1] might be of interest.
Rob
[1] https://lore.kernel.org/all/YUIPCxnyRutMS47%2F@orome.fritz.box/
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Alexandre Bailon <abailon@baylibre.com>
Cc: airlied@linux.ie, daniel@ffwll.ch, matthias.bgg@gmail.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, ohad@wizery.com, bjorn.andersson@linaro.org,
mathieu.poirier@linaro.org, sumit.semwal@linaro.org,
christian.koenig@amd.com, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-remoteproc@vger.kernel.org, linux-media@vger.kernel.org,
linaro-mm-sig@lists.linaro.org, khilman@baylibre.com,
gpain@baylibre.com
Subject: Re: [RFC PATCH 1/4] dt-bindings: Add bidings for mtk,apu-drm
Date: Mon, 20 Sep 2021 15:55:58 -0500 [thread overview]
Message-ID: <YUj1XnBbyNEqrV2g@robh.at.kernel.org> (raw)
In-Reply-To: <20210917125945.620097-2-abailon@baylibre.com>
On Fri, Sep 17, 2021 at 02:59:42PM +0200, Alexandre Bailon wrote:
> This adds the device tree bindings for the APU DRM driver.
>
> Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
> ---
> .../devicetree/bindings/gpu/mtk,apu-drm.yaml | 38 +++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpu/mtk,apu-drm.yaml
>
> diff --git a/Documentation/devicetree/bindings/gpu/mtk,apu-drm.yaml b/Documentation/devicetree/bindings/gpu/mtk,apu-drm.yaml
> new file mode 100644
> index 0000000000000..6f432d3ea478c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpu/mtk,apu-drm.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpu/mediatek,apu-drm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AI Processor Unit DRM
DRM is a linux thing, not h/w.
> +
> +properties:
> + compatible:
> + const: mediatek,apu-drm
> +
> + remoteproc:
So is remoteproc.
Why don't you have the remoteproc driver create the DRM device?
> + maxItems: 2
> + description:
> + Handle to remoteproc devices controlling the APU
> +
> + iova:
> + maxItems: 1
> + description:
> + Address and size of virtual memory that could used by the APU
Why does this need to be in DT? If you need to reserve certain VAs, then
this discussion[1] might be of interest.
Rob
[1] https://lore.kernel.org/all/YUIPCxnyRutMS47%2F@orome.fritz.box/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-20 20:56 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 12:59 [RFC PATCH 0/4] Add a DRM driver to support AI Processing Unit (APU) Alexandre Bailon
2021-09-17 12:59 ` Alexandre Bailon
2021-09-17 12:59 ` Alexandre Bailon
2021-09-17 12:59 ` Alexandre Bailon
2021-09-17 12:59 ` [RFC PATCH 1/4] dt-bindings: Add bidings for mtk,apu-drm Alexandre Bailon
2021-09-17 12:59 ` Alexandre Bailon
2021-09-17 12:59 ` Alexandre Bailon
2021-09-17 19:48 ` Rob Herring
2021-09-17 19:48 ` Rob Herring
2021-09-17 19:48 ` Rob Herring
2021-09-20 20:55 ` Rob Herring [this message]
2021-09-20 20:55 ` Rob Herring
2021-09-20 20:55 ` Rob Herring
2021-09-17 12:59 ` [RFC PATCH 2/4] DRM: Add support of AI Processor Unit (APU) Alexandre Bailon
2021-09-17 12:59 ` Alexandre Bailon
2021-09-17 12:59 ` Alexandre Bailon
2021-09-19 3:19 ` Hillf Danton
2021-09-23 0:58 ` Dave Airlie
2021-09-23 0:58 ` Dave Airlie
2021-09-23 0:58 ` Dave Airlie
2021-09-23 0:58 ` Dave Airlie
2021-09-23 6:17 ` Christian König
2021-09-23 6:17 ` Christian König
2021-09-23 6:17 ` Christian König
2021-09-23 6:17 ` Christian König
2021-09-17 12:59 ` [RFC PATCH 3/4] rpmsg: " Alexandre Bailon
2021-09-17 12:59 ` Alexandre Bailon
2021-09-17 12:59 ` Alexandre Bailon
2021-09-23 3:31 ` Bjorn Andersson
2021-09-23 3:31 ` Bjorn Andersson
2021-09-23 3:31 ` Bjorn Andersson
2021-09-17 12:59 ` [RFC PATCH 4/4] ARM64: mt8183-pumpkin: Add the APU DRM device Alexandre Bailon
2021-09-17 12:59 ` Alexandre Bailon
2021-09-17 12:59 ` Alexandre Bailon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUj1XnBbyNEqrV2g@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=abailon@baylibre.com \
--cc=airlied@linux.ie \
--cc=bjorn.andersson@linaro.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gpain@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mathieu.poirier@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=mripard@kernel.org \
--cc=ohad@wizery.com \
--cc=sumit.semwal@linaro.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.