All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Fabio Estevam <festevam@gmail.com>
Cc: shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org,
	m.felsch@pengutronix.de, tharvey@gateworks.com,
	stable@vger.kernel.org
Subject: Re: [PATCH] Revert "ARM: imx6q: drop of_platform_default_populate() from init_machine"
Date: Tue, 21 Sep 2021 00:48:25 +0100	[thread overview]
Message-ID: <YUkdybUJZY+/5UO2@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210920234311.682163-1-festevam@gmail.com>

On Mon, Sep 20, 2021 at 08:43:11PM -0300, Fabio Estevam wrote:
> This reverts commit cc8870bf4c3ab0af385538460500a9d342ed945f.
>  
> Since commit cc8870bf4c3a ("ARM: imx6q: drop of_platform_default_populate()
> from init_machine") the following errors are seen on boot:
> 
> [    0.123372] imx6q_suspend_init: failed to find ocram device!
> [    0.123537] imx6_pm_common_init: No DDR LPM support with suspend -19! 
> 
> , which break suspend/resume on imx6q/dl.
> 
> Revert the offeding commit to avoid the regression.
> 
> Thanks to Tim Harvey for bisecting this problem.
> 
> Cc: stable@vger.kernel.org

Thanks Fabio.

Acked-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

> Fixes: cc8870bf4c3a ("ARM: imx6q: drop of_platform_default_populate() from  init_machine")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  arch/arm/mach-imx/mach-imx6q.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/mach-imx/mach-imx6q.c b/arch/arm/mach-imx/mach-imx6q.c
> index 11dcc369ec14..c9d7c29d95e1 100644
> --- a/arch/arm/mach-imx/mach-imx6q.c
> +++ b/arch/arm/mach-imx/mach-imx6q.c
> @@ -172,6 +172,9 @@ static void __init imx6q_init_machine(void)
>  				imx_get_soc_revision());
>  
>  	imx6q_enet_phy_init();
> +
> +	of_platform_default_populate(NULL, NULL, NULL);
> +
>  	imx_anatop_init();
>  	cpu_is_imx6q() ?  imx6q_pm_init() : imx6dl_pm_init();
>  	imx6q_1588_init();
> -- 
> 2.25.1
> 
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Fabio Estevam <festevam@gmail.com>
Cc: shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org,
	m.felsch@pengutronix.de, tharvey@gateworks.com,
	stable@vger.kernel.org
Subject: Re: [PATCH] Revert "ARM: imx6q: drop of_platform_default_populate() from init_machine"
Date: Tue, 21 Sep 2021 00:48:25 +0100	[thread overview]
Message-ID: <YUkdybUJZY+/5UO2@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210920234311.682163-1-festevam@gmail.com>

On Mon, Sep 20, 2021 at 08:43:11PM -0300, Fabio Estevam wrote:
> This reverts commit cc8870bf4c3ab0af385538460500a9d342ed945f.
>  
> Since commit cc8870bf4c3a ("ARM: imx6q: drop of_platform_default_populate()
> from init_machine") the following errors are seen on boot:
> 
> [    0.123372] imx6q_suspend_init: failed to find ocram device!
> [    0.123537] imx6_pm_common_init: No DDR LPM support with suspend -19! 
> 
> , which break suspend/resume on imx6q/dl.
> 
> Revert the offeding commit to avoid the regression.
> 
> Thanks to Tim Harvey for bisecting this problem.
> 
> Cc: stable@vger.kernel.org

Thanks Fabio.

Acked-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

> Fixes: cc8870bf4c3a ("ARM: imx6q: drop of_platform_default_populate() from  init_machine")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  arch/arm/mach-imx/mach-imx6q.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/mach-imx/mach-imx6q.c b/arch/arm/mach-imx/mach-imx6q.c
> index 11dcc369ec14..c9d7c29d95e1 100644
> --- a/arch/arm/mach-imx/mach-imx6q.c
> +++ b/arch/arm/mach-imx/mach-imx6q.c
> @@ -172,6 +172,9 @@ static void __init imx6q_init_machine(void)
>  				imx_get_soc_revision());
>  
>  	imx6q_enet_phy_init();
> +
> +	of_platform_default_populate(NULL, NULL, NULL);
> +
>  	imx_anatop_init();
>  	cpu_is_imx6q() ?  imx6q_pm_init() : imx6dl_pm_init();
>  	imx6q_1588_init();
> -- 
> 2.25.1
> 
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

  reply	other threads:[~2021-09-20 23:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-20 23:43 [PATCH] Revert "ARM: imx6q: drop of_platform_default_populate() from init_machine" Fabio Estevam
2021-09-20 23:43 ` Fabio Estevam
2021-09-20 23:48 ` Russell King (Oracle) [this message]
2021-09-20 23:48   ` Russell King (Oracle)
2021-09-22  3:49 ` Shawn Guo
2021-09-22  3:49   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YUkdybUJZY+/5UO2@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=festevam@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=m.felsch@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tharvey@gateworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.