[PATCH] usb: usb-skeleton: remove obsolete comment

[PATCH] usb: usb-skeleton: remove obsolete comment

[Philipp Hortmann]

This patch fixes the checkpatch.pl warning:
WARNING: It's generally not useful to have the filename in the file
7: FILE: drivers/usb/usb-skeleton.c:7:
+ * This driver is based on the 2.6.3 version of drivers/usb/usb-skeleton.c

Deleting both lines as the -2.6.3- makes the reader belief this is an
unusable old file and the -rewritten to be easier ...- is only of value for
the reader that knows what the driver was before.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
 drivers/usb/usb-skeleton.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c
index d87deee3e26e..91da019a1171 100644
--- a/drivers/usb/usb-skeleton.c
+++ b/drivers/usb/usb-skeleton.c
@@ -4,8 +4,6 @@
  *
  * Copyright (C) 2001-2004 Greg Kroah-Hartman (greg@kroah.com)
  *
- * This driver is based on the 2.6.3 version of drivers/usb/usb-skeleton.c
- * but has been rewritten to be easier to read and use.
  */
 
 #include <linux/kernel.h>
-- 
2.25.1

Re: [PATCH] usb: usb-skeleton: remove obsolete comment

[Greg KH]

On Tue, Sep 21, 2021 at 11:41:47PM +0200, Philipp Hortmann wrote:
> This patch fixes the checkpatch.pl warning:
> WARNING: It's generally not useful to have the filename in the file
> 7: FILE: drivers/usb/usb-skeleton.c:7:
> + * This driver is based on the 2.6.3 version of drivers/usb/usb-skeleton.c
> 
> Deleting both lines as the -2.6.3- makes the reader belief this is an
> unusable old file and the -rewritten to be easier ...- is only of value for
> the reader that knows what the driver was before.
> 
> Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
> ---
>  drivers/usb/usb-skeleton.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c
> index d87deee3e26e..91da019a1171 100644
> --- a/drivers/usb/usb-skeleton.c
> +++ b/drivers/usb/usb-skeleton.c
> @@ -4,8 +4,6 @@
>   *
>   * Copyright (C) 2001-2004 Greg Kroah-Hartman (greg@kroah.com)
>   *
> - * This driver is based on the 2.6.3 version of drivers/usb/usb-skeleton.c
> - * but has been rewritten to be easier to read and use.

No, this is fine to keep in the source code, checkpatch is telling you
something else in the above "hint".

thanks,

greg k-h