From: Cyrill Gorcunov <gorcunov@gmail.com> To: Peter Collingbourne <pcc@google.com> Cc: Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>, Juri Lelli <juri.lelli@redhat.com>, Vincent Guittot <vincent.guittot@linaro.org>, Dietmar Eggemann <dietmar.eggemann@arm.com>, Steven Rostedt <rostedt@goodmis.org>, Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>, Daniel Bristot de Oliveira <bristot@redhat.com>, Thomas Gleixner <tglx@linutronix.de>, Andy Lutomirski <luto@kernel.org>, Kees Cook <keescook@chromium.org>, Andrew Morton <akpm@linux-foundation.org>, Masahiro Yamada <masahiroy@kernel.org>, Sami Tolvanen <samitolvanen@google.com>, YiFei Zhu <yifeifz2@illinois.edu>, Colin Ian King <colin.king@canonical.com>, Mark Rutland <mark.rutland@arm.com>, Frederic Weisbecker <frederic@kernel.org>, Viresh Kumar <viresh.kumar@linaro.org>, Andrey Konovalov <andreyknvl@gmail.com>, Gabriel Krisman Bertazi <krisman@collabora.com>, Balbir Singh <sblbir@amazon.com>, Chris Hyser <chris.hyser@oracle.com>, Daniel Vetter <daniel.vetter@ffwll.ch>, Chris Wilson <chris@chris-wilson.co.uk>, Arnd Bergmann <arnd@arndb.de>, Dmitry Vyukov <dvyukov@google.com>, Christian Brauner <christian.brauner@ubuntu.com>, "Eric W. Biederman" <ebiederm@xmission.com>, Alexey Gladkov <legion@kernel.org>, Ran Xiaokai <ran.xiaokai@zte.com.cn>, David Hildenbrand <david@redhat.com>, Xiaofeng Cao <caoxiaofeng@yulong.com>, Thomas Cedeno <thomascedeno@google.com>, Marco Elver <elver@google.com>, Alexander Potapenko <glider@google.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Evgenii Stepanov <eugenis@google.com> Subject: Re: [PATCH] kernel: introduce prctl(PR_LOG_UACCESS) Date: Wed, 22 Sep 2021 09:30:12 +0300 [thread overview] Message-ID: <YUrNdPLh+keAKPUy@grain> (raw) In-Reply-To: <20210922061809.736124-1-pcc@google.com> On Tue, Sep 21, 2021 at 11:18:09PM -0700, Peter Collingbourne wrote: > This patch introduces a kernel feature known as uaccess logging. > With uaccess logging, the userspace program passes the address and size > of a so-called uaccess buffer to the kernel via a prctl(). The prctl() > is a request for the kernel to log any uaccesses made during the next > syscall to the uaccess buffer. When the next syscall returns, the address > one past the end of the logged uaccess buffer entries is written to the > location specified by the third argument to the prctl(). In this way, > the userspace program may enumerate the uaccesses logged to the access > buffer to determine which accesses occurred. ... > diff --git a/include/linux/sched.h b/include/linux/sched.h > index e12b524426b0..3fecb0487b97 100644 > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -34,6 +34,7 @@ > #include <linux/rseq.h> > #include <linux/seqlock.h> > #include <linux/kcsan.h> > +#include <linux/uaccess_buffer_info.h> > #include <asm/kmap_size.h> > > /* task_struct member predeclarations (sorted alphabetically): */ > @@ -1487,6 +1488,8 @@ struct task_struct { > struct callback_head l1d_flush_kill; > #endif > > + struct uaccess_buffer_info uaccess_buffer; > + Hi, Peter! I didn't read the patch carefully yet (will do once time permit) but from a glance should not this member be under #ifdef CONFIG_UACCESS_BUFFER or something? task_struct is already bloated too much :( > + case PR_LOG_UACCESS: > + if (arg5) > + return -EINVAL; > + error = uaccess_buffer_set_logging(arg2, arg3, arg4); > + break; Same here (if only I didn't miss something obvious). If there is no support for CONFIG_UACCESS_BUFFER we should return an error I guess.
WARNING: multiple messages have this Message-ID (diff)
From: Cyrill Gorcunov <gorcunov@gmail.com> To: Peter Collingbourne <pcc@google.com> Cc: Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>, Juri Lelli <juri.lelli@redhat.com>, Vincent Guittot <vincent.guittot@linaro.org>, Dietmar Eggemann <dietmar.eggemann@arm.com>, Steven Rostedt <rostedt@goodmis.org>, Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>, Daniel Bristot de Oliveira <bristot@redhat.com>, Thomas Gleixner <tglx@linutronix.de>, Andy Lutomirski <luto@kernel.org>, Kees Cook <keescook@chromium.org>, Andrew Morton <akpm@linux-foundation.org>, Masahiro Yamada <masahiroy@kernel.org>, Sami Tolvanen <samitolvanen@google.com>, YiFei Zhu <yifeifz2@illinois.edu>, Colin Ian King <colin.king@canonical.com>, Mark Rutland <mark.rutland@arm.com>, Frederic Weisbecker <frederic@kernel.org>, Viresh Kumar <viresh.kumar@linaro.org>, Andrey Konovalov <andreyknvl@gmail.com>, Gabriel Krisman Bertazi <krisman@collabora.com>, Balbir Singh <sblbir@amazon.com>, Chris Hyser <chris.hyser@oracle.com>, Daniel Vetter <daniel.vetter@ffwll.ch>, Chris Wilson <chris@chris-wilson.co.uk>, Arnd Bergmann <arnd@arndb.de>, Dmitry Vyukov <dvyukov@google.com>, Christian Brauner <christian.brauner@ubuntu.com>, "Eric W. Biederman" <ebiederm@xmission.com>, Alexey Gladkov <legion@kernel.org>, Ran Xiaokai <ran.xiaokai@zte.com.cn>, David Hildenbrand <david@redhat.com>, Xiaofeng Cao <caoxiaofeng@yulong.com>, Thomas Cedeno <thomascedeno@google.com>, Marco Elver <elver@google.com>, Alexander Potapenko <glider@google.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Evgenii Stepanov <eugenis@google.com> Subject: Re: [PATCH] kernel: introduce prctl(PR_LOG_UACCESS) Date: Wed, 22 Sep 2021 09:30:12 +0300 [thread overview] Message-ID: <YUrNdPLh+keAKPUy@grain> (raw) In-Reply-To: <20210922061809.736124-1-pcc@google.com> On Tue, Sep 21, 2021 at 11:18:09PM -0700, Peter Collingbourne wrote: > This patch introduces a kernel feature known as uaccess logging. > With uaccess logging, the userspace program passes the address and size > of a so-called uaccess buffer to the kernel via a prctl(). The prctl() > is a request for the kernel to log any uaccesses made during the next > syscall to the uaccess buffer. When the next syscall returns, the address > one past the end of the logged uaccess buffer entries is written to the > location specified by the third argument to the prctl(). In this way, > the userspace program may enumerate the uaccesses logged to the access > buffer to determine which accesses occurred. ... > diff --git a/include/linux/sched.h b/include/linux/sched.h > index e12b524426b0..3fecb0487b97 100644 > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -34,6 +34,7 @@ > #include <linux/rseq.h> > #include <linux/seqlock.h> > #include <linux/kcsan.h> > +#include <linux/uaccess_buffer_info.h> > #include <asm/kmap_size.h> > > /* task_struct member predeclarations (sorted alphabetically): */ > @@ -1487,6 +1488,8 @@ struct task_struct { > struct callback_head l1d_flush_kill; > #endif > > + struct uaccess_buffer_info uaccess_buffer; > + Hi, Peter! I didn't read the patch carefully yet (will do once time permit) but from a glance should not this member be under #ifdef CONFIG_UACCESS_BUFFER or something? task_struct is already bloated too much :( > + case PR_LOG_UACCESS: > + if (arg5) > + return -EINVAL; > + error = uaccess_buffer_set_logging(arg2, arg3, arg4); > + break; Same here (if only I didn't miss something obvious). If there is no support for CONFIG_UACCESS_BUFFER we should return an error I guess. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-22 6:30 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-22 6:18 [PATCH] kernel: introduce prctl(PR_LOG_UACCESS) Peter Collingbourne 2021-09-22 6:18 ` Peter Collingbourne 2021-09-22 6:30 ` Cyrill Gorcunov [this message] 2021-09-22 6:30 ` Cyrill Gorcunov 2021-11-23 5:17 ` Peter Collingbourne 2021-11-23 5:17 ` Peter Collingbourne 2021-09-22 10:44 ` Marco Elver 2021-09-22 10:44 ` Marco Elver 2021-11-23 5:17 ` Peter Collingbourne 2021-11-23 5:17 ` Peter Collingbourne 2021-09-22 13:45 ` Dmitry Vyukov 2021-09-22 13:45 ` Dmitry Vyukov 2021-09-22 22:30 ` Peter Collingbourne 2021-09-22 22:30 ` Peter Collingbourne 2021-09-22 14:23 ` Eric W. Biederman 2021-09-22 14:23 ` Eric W. Biederman 2021-09-22 15:30 ` Kees Cook 2021-09-22 15:30 ` Kees Cook 2021-09-22 15:59 ` Jann Horn 2021-09-22 15:59 ` Jann Horn 2021-09-24 21:50 ` Peter Collingbourne 2021-09-24 21:50 ` Peter Collingbourne 2021-09-26 2:20 ` Kees Cook 2021-09-26 2:20 ` Kees Cook 2021-11-23 5:17 ` Peter Collingbourne 2021-11-23 5:17 ` Peter Collingbourne 2021-09-22 17:46 ` David Hildenbrand 2021-09-22 17:46 ` David Hildenbrand 2021-09-22 19:22 ` Steven Rostedt 2021-09-22 19:22 ` Steven Rostedt 2021-09-22 19:53 ` Peter Zijlstra 2021-09-22 19:53 ` Peter Zijlstra 2021-09-22 22:05 ` Peter Collingbourne 2021-09-22 22:05 ` Peter Collingbourne 2021-09-23 8:08 ` David Hildenbrand 2021-09-23 8:08 ` David Hildenbrand
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YUrNdPLh+keAKPUy@grain \ --to=gorcunov@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=andreyknvl@gmail.com \ --cc=arnd@arndb.de \ --cc=bristot@redhat.com \ --cc=bsegall@google.com \ --cc=caoxiaofeng@yulong.com \ --cc=catalin.marinas@arm.com \ --cc=chris.hyser@oracle.com \ --cc=chris@chris-wilson.co.uk \ --cc=christian.brauner@ubuntu.com \ --cc=colin.king@canonical.com \ --cc=daniel.vetter@ffwll.ch \ --cc=david@redhat.com \ --cc=dietmar.eggemann@arm.com \ --cc=dvyukov@google.com \ --cc=ebiederm@xmission.com \ --cc=elver@google.com \ --cc=eugenis@google.com \ --cc=frederic@kernel.org \ --cc=glider@google.com \ --cc=juri.lelli@redhat.com \ --cc=keescook@chromium.org \ --cc=krisman@collabora.com \ --cc=legion@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=luto@kernel.org \ --cc=mark.rutland@arm.com \ --cc=masahiroy@kernel.org \ --cc=mgorman@suse.de \ --cc=mingo@redhat.com \ --cc=pcc@google.com \ --cc=peterz@infradead.org \ --cc=ran.xiaokai@zte.com.cn \ --cc=rostedt@goodmis.org \ --cc=samitolvanen@google.com \ --cc=sblbir@amazon.com \ --cc=tglx@linutronix.de \ --cc=thomascedeno@google.com \ --cc=vincent.guittot@linaro.org \ --cc=viresh.kumar@linaro.org \ --cc=will@kernel.org \ --cc=yifeifz2@illinois.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.