* [PATCH] mfd: cros_ec: drop unneeded MODULE_ALIAS
@ 2021-09-16 17:05 Krzysztof Kozlowski
2021-09-22 14:44 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-16 17:05 UTC (permalink / raw)
To: linux-kernel
Cc: Krzysztof Kozlowski, Lee Jones, Benson Leung,
Enric Balletbo i Serra, Guenter Roeck
The MODULE_DEVICE_TABLE already creates proper alias. Having another
MODULE_ALIAS causes the alias to be duplicated:
$ modinfo cros_ec_dev.ko
alias: platform:cros-ec-dev
srcversion: F84A69D2156719A4F717A76
alias: platform:cros-ec-dev
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
drivers/mfd/cros_ec_dev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
index 8c08d1c55726..81cee1a5daa6 100644
--- a/drivers/mfd/cros_ec_dev.c
+++ b/drivers/mfd/cros_ec_dev.c
@@ -326,7 +326,6 @@ static void __exit cros_ec_dev_exit(void)
module_init(cros_ec_dev_init);
module_exit(cros_ec_dev_exit);
-MODULE_ALIAS("platform:" DRV_NAME);
MODULE_AUTHOR("Bill Richardson <wfrichar@chromium.org>");
MODULE_DESCRIPTION("Userspace interface to the Chrome OS Embedded Controller");
MODULE_VERSION("1.0");
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: cros_ec: drop unneeded MODULE_ALIAS
2021-09-16 17:05 [PATCH] mfd: cros_ec: drop unneeded MODULE_ALIAS Krzysztof Kozlowski
@ 2021-09-22 14:44 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2021-09-22 14:44 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-kernel, Benson Leung, Enric Balletbo i Serra, Guenter Roeck
On Thu, 16 Sep 2021, Krzysztof Kozlowski wrote:
> The MODULE_DEVICE_TABLE already creates proper alias. Having another
> MODULE_ALIAS causes the alias to be duplicated:
>
> $ modinfo cros_ec_dev.ko
>
> alias: platform:cros-ec-dev
> srcversion: F84A69D2156719A4F717A76
> alias: platform:cros-ec-dev
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> drivers/mfd/cros_ec_dev.c | 1 -
> 1 file changed, 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-22 14:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-16 17:05 [PATCH] mfd: cros_ec: drop unneeded MODULE_ALIAS Krzysztof Kozlowski
2021-09-22 14:44 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.