* [igt-dev] [PATCH i-g-t 0/3] Fix kms_psr2_sf test and add new test for FB_DAMAGE_CLIPS plane property
@ 2021-09-21 7:57 Jeevan B
2021-09-21 7:57 ` [igt-dev] [PATCH i-g-t 1/3] lib/igt_aux: Rename igt_debug_manual_check and assert check if all is supplied Jeevan B
` (4 more replies)
0 siblings, 5 replies; 9+ messages in thread
From: Jeevan B @ 2021-09-21 7:57 UTC (permalink / raw)
To: igt-dev; +Cc: daniel, jose.souza, Jeevan B
Make kms_psr2_sf test generic, rename igt_debug_manual_check, patch the
igt functions igt_debug_manual_check() and igt_debug_wait_for_keypress()
to assert if "all" is supplied and change testcase design and
add simple test cases to use FB_DAMAGE_CLIPS plane property.
Deepak Rawat (1):
tests/kms_atomic: Add a new test case for FB_DAMAGE_CLIPS plane
property
Jeevan B (2):
lib/igt_aux: Rename igt_debug_manual_check and assert check if all is
supplied
tests/kms_psr2_sf: Make this a generic test and change testcase design
lib/igt_aux.c | 18 ++-
lib/igt_aux.h | 2 +-
tests/i915/kms_dsc.c | 2 +-
tests/i915/kms_psr.c | 2 +-
tests/i915/kms_psr2_sf.c | 30 ++---
tests/kms_atomic.c | 232 +++++++++++++++++++++++++++++++++++++++
6 files changed, 262 insertions(+), 24 deletions(-)
--
2.19.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [igt-dev] [PATCH i-g-t 1/3] lib/igt_aux: Rename igt_debug_manual_check and assert check if all is supplied
2021-09-21 7:57 [igt-dev] [PATCH i-g-t 0/3] Fix kms_psr2_sf test and add new test for FB_DAMAGE_CLIPS plane property Jeevan B
@ 2021-09-21 7:57 ` Jeevan B
2021-09-21 12:48 ` Petri Latvala
2021-09-21 7:57 ` [igt-dev] [PATCH i-g-t 2/3] tests/kms_psr2_sf: Make this a generic test and change testcase design Jeevan B
` (3 subsequent siblings)
4 siblings, 1 reply; 9+ messages in thread
From: Jeevan B @ 2021-09-21 7:57 UTC (permalink / raw)
To: igt-dev; +Cc: daniel, jose.souza, Jeevan B
rename igt_debug_manual_check and patch the igt functions
igt_debug_manual_check() and igt_debug_wait_for_keypress()
to assert if "all" is supplied.
Signed-off-by: Jeevan B <jeevan.b@intel.com>
---
lib/igt_aux.c | 18 ++++++++++++------
lib/igt_aux.h | 2 +-
tests/i915/kms_dsc.c | 2 +-
tests/i915/kms_psr.c | 2 +-
tests/i915/kms_psr2_sf.c | 2 +-
5 files changed, 16 insertions(+), 10 deletions(-)
diff --git a/lib/igt_aux.c b/lib/igt_aux.c
index 1217f5e8..96929237 100644
--- a/lib/igt_aux.c
+++ b/lib/igt_aux.c
@@ -971,8 +971,7 @@ void igt_drop_root(void)
*
* Waits for a key press when run interactively and when the corresponding debug
* var is set in the --interactive-debug=$var variable. Multiple keys
- * can be specified as a comma-separated list or alternatively "all" if a wait
- * should happen for all cases.
+ * can be specified as a comma-separated list and assert if "all" is supplied.
*
* When not connected to a terminal interactive_debug is ignored
* and execution immediately continues.
@@ -993,6 +992,10 @@ void igt_debug_wait_for_keypress(const char *var)
if (!igt_interactive_debug)
return;
+ if (strstr(igt_interactive_debug, var) &&
+ strstr(igt_interactive_debug, "all"))
+ igt_assert(false);
+
if (!strstr(igt_interactive_debug, var) &&
!strstr(igt_interactive_debug, "all"))
return;
@@ -1008,14 +1011,13 @@ void igt_debug_wait_for_keypress(const char *var)
}
/**
- * igt_debug_manual_check:
+ * igt_debug_interactive_mode_check:
* @var: var lookup to to enable this wait
* @expected: message to be printed as expected behaviour before wait for keys Y/n
*
* Waits for a key press when run interactively and when the corresponding debug
* var is set in the --interactive-debug=$var variable. Multiple vars
- * can be specified as a comma-separated list or alternatively "all" if a wait
- * should happen for all cases.
+ * can be specified as a comma-separated list and assert if "all" is supplied.
*
* This is useful for display tests where under certain situation manual
* inspection of the display is useful. Or when running a testcase in the
@@ -1028,7 +1030,7 @@ void igt_debug_wait_for_keypress(const char *var)
*
* Force test fail when N/n is pressed.
*/
-void igt_debug_manual_check(const char *var, const char *expected)
+void igt_debug_interactive_mode_check(const char *var, const char *expected)
{
struct termios oldt, newt;
char key;
@@ -1041,6 +1043,10 @@ void igt_debug_manual_check(const char *var, const char *expected)
if (!igt_interactive_debug)
return;
+ if (strstr(igt_interactive_debug, var) &&
+ strstr(igt_interactive_debug, "all"))
+ igt_assert(false);
+
if (!strstr(igt_interactive_debug, var) &&
!strstr(igt_interactive_debug, "all"))
return;
diff --git a/lib/igt_aux.h b/lib/igt_aux.h
index bf57ccf5..a92eb799 100644
--- a/lib/igt_aux.h
+++ b/lib/igt_aux.h
@@ -193,7 +193,7 @@ int igt_get_autoresume_delay(enum igt_suspend_state state);
void igt_drop_root(void);
void igt_debug_wait_for_keypress(const char *var);
-void igt_debug_manual_check(const char *var, const char *expected);
+void igt_debug_interactive_mode_check(const char *var, const char *expected);
/* sysinfo cross-arch wrappers from intel_os.c */
diff --git a/tests/i915/kms_dsc.c b/tests/i915/kms_dsc.c
index 3e450207..772687f4 100644
--- a/tests/i915/kms_dsc.c
+++ b/tests/i915/kms_dsc.c
@@ -72,7 +72,7 @@ int force_dsc_restore_fd = -1;
static inline void manual(const char *expected)
{
- igt_debug_manual_check("all", expected);
+ igt_debug_interactive_mode_check("all", expected);
}
static void force_dsc_enable(data_t *data)
diff --git a/tests/i915/kms_psr.c b/tests/i915/kms_psr.c
index 270d3150..24a10676 100644
--- a/tests/i915/kms_psr.c
+++ b/tests/i915/kms_psr.c
@@ -246,7 +246,7 @@ static bool psr_enable_if_enabled(data_t *data)
static inline void manual(const char *expected)
{
- igt_debug_manual_check("all", expected);
+ igt_debug_interactive_mode_check("all", expected);
}
static bool drrs_disabled(data_t *data)
diff --git a/tests/i915/kms_psr2_sf.c b/tests/i915/kms_psr2_sf.c
index 1be8c3da..93347327 100644
--- a/tests/i915/kms_psr2_sf.c
+++ b/tests/i915/kms_psr2_sf.c
@@ -331,7 +331,7 @@ static void prepare(data_t *data)
static inline void manual(const char *expected)
{
- igt_debug_manual_check("all", expected);
+ igt_debug_interactive_mode_check("all", expected);
}
static void plane_update_expected_output(int plane_type, int box_count)
--
2.19.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [igt-dev] [PATCH i-g-t 2/3] tests/kms_psr2_sf: Make this a generic test and change testcase design
2021-09-21 7:57 [igt-dev] [PATCH i-g-t 0/3] Fix kms_psr2_sf test and add new test for FB_DAMAGE_CLIPS plane property Jeevan B
2021-09-21 7:57 ` [igt-dev] [PATCH i-g-t 1/3] lib/igt_aux: Rename igt_debug_manual_check and assert check if all is supplied Jeevan B
@ 2021-09-21 7:57 ` Jeevan B
2021-09-21 7:57 ` [igt-dev] [PATCH i-g-t 3/3] tests/kms_atomic: Add a new test case for FB_DAMAGE_CLIPS plane property Jeevan B
` (2 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Jeevan B @ 2021-09-21 7:57 UTC (permalink / raw)
To: igt-dev; +Cc: daniel, jose.souza, Jeevan B
Make this a generic kms test and change testcase design so that it avoids
new subtest for each block position
Signed-off-by: Jeevan B <jeevan.b@intel.com>
---
tests/i915/kms_psr2_sf.c | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/tests/i915/kms_psr2_sf.c b/tests/i915/kms_psr2_sf.c
index 93347327..c83120c4 100644
--- a/tests/i915/kms_psr2_sf.c
+++ b/tests/i915/kms_psr2_sf.c
@@ -550,7 +550,7 @@ igt_main
igt_fixture {
int r;
- data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
+ data.drm_fd = drm_open_driver_master(DRIVER_ANY);
data.debugfs_fd = igt_debugfs_dir(data.drm_fd);
kmstest_set_vt_graphics_mode();
@@ -582,9 +582,9 @@ igt_main
}
/* Verify primary plane selective fetch */
- for (i = 1; i <= MAX_DAMAGE_AREAS; i++) {
- igt_describe("Test that selective fetch works on primary plane");
- igt_subtest_f("primary-%s-sf-dmg-area-%d", op_str(data.op), i) {
+ igt_describe("Test that selective fetch works on primary plane");
+ igt_subtest_f("primary-%s-sf-dmg-area", op_str(data.op)) {
+ for (i = 1; i <= MAX_DAMAGE_AREAS; i++) {
data.damage_area_count = i;
data.test_plane_id = DRM_PLANE_TYPE_PRIMARY;
prepare(&data);
@@ -594,9 +594,9 @@ igt_main
}
/* Verify overlay plane selective fetch */
- for (i = 1; i <= MAX_DAMAGE_AREAS; i++) {
- igt_describe("Test that selective fetch works on overlay plane");
- igt_subtest_f("overlay-%s-sf-dmg-area-%d", op_str(data.op), i) {
+ igt_describe("Test that selective fetch works on overlay plane");
+ igt_subtest_f("overlay-%s-sf-dmg-area", op_str(data.op)) {
+ for (i = 1; i <= MAX_DAMAGE_AREAS; i++) {
data.damage_area_count = i;
data.test_plane_id = DRM_PLANE_TYPE_OVERLAY;
prepare(&data);
@@ -618,9 +618,9 @@ igt_main
/* Only for overlay plane */
data.op = PLANE_MOVE;
/* Verify overlay plane move selective fetch */
- for (i = POS_TOP_LEFT; i <= POS_BOTTOM_RIGHT ; i++) {
- igt_describe("Test that selective fetch works on moving overlay plane");
- igt_subtest_f("%s-sf-dmg-area-%d", op_str(data.op), i) {
+ igt_describe("Test that selective fetch works on moving overlay plane");
+ igt_subtest_f("%s-sf-dmg-area", op_str(data.op)) {
+ for (i = POS_TOP_LEFT; i <= POS_BOTTOM_RIGHT ; i++) {
data.pos = i;
data.test_plane_id = DRM_PLANE_TYPE_OVERLAY;
prepare(&data);
@@ -631,10 +631,10 @@ igt_main
/* Verify primary plane selective fetch with overplay plane blended */
data.op = OVERLAY_PRIM_UPDATE;
- for (i = 1; i <= MAX_DAMAGE_AREAS; i++) {
- igt_describe("Test that selective fetch works on primary plane "
- "with blended overlay plane");
- igt_subtest_f("%s-sf-dmg-area-%d", op_str(data.op), i) {
+ igt_describe("Test that selective fetch works on primary plane "
+ "with blended overlay plane");
+ igt_subtest_f("%s-sf-dmg-area", op_str(data.op)) {
+ for (i = 1; i <= MAX_DAMAGE_AREAS; i++) {
data.damage_area_count = i;
data.test_plane_id = DRM_PLANE_TYPE_PRIMARY;
prepare(&data);
--
2.19.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [igt-dev] [PATCH i-g-t 3/3] tests/kms_atomic: Add a new test case for FB_DAMAGE_CLIPS plane property
2021-09-21 7:57 [igt-dev] [PATCH i-g-t 0/3] Fix kms_psr2_sf test and add new test for FB_DAMAGE_CLIPS plane property Jeevan B
2021-09-21 7:57 ` [igt-dev] [PATCH i-g-t 1/3] lib/igt_aux: Rename igt_debug_manual_check and assert check if all is supplied Jeevan B
2021-09-21 7:57 ` [igt-dev] [PATCH i-g-t 2/3] tests/kms_psr2_sf: Make this a generic test and change testcase design Jeevan B
@ 2021-09-21 7:57 ` Jeevan B
2021-09-21 9:01 ` [igt-dev] ✓ Fi.CI.BAT: success for Fix kms_psr2_sf test and add new test " Patchwork
2021-09-21 10:05 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
4 siblings, 0 replies; 9+ messages in thread
From: Jeevan B @ 2021-09-21 7:57 UTC (permalink / raw)
To: igt-dev; +Cc: daniel, jose.souza, Deepak Rawat, Jeevan B
From: Deepak Rawat <drawat@vmware.com>
Some simple test cases to use FB_DAMAGE_CLIPS plane property.
Signed-off-by: Deepak Rawat <drawat@vmware.com>
Signed-off-by: Jeevan B <jeevan.b@intel.com>
---
tests/kms_atomic.c | 232 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 232 insertions(+)
diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c
index 3a0f76d9..08baf8f0 100644
--- a/tests/kms_atomic.c
+++ b/tests/kms_atomic.c
@@ -62,6 +62,25 @@ enum kms_atomic_check_relax {
PLANE_RELAX_FB = (1 << 1)
};
+/* signed32 drm_mode_rect declared here for use with drm damage for page-flip */
+struct damage_rect {
+ int x1;
+ int y1;
+ int x2;
+ int y2;
+};
+
+static inline int damage_rect_width(struct damage_rect *r)
+{
+ return r->x2 - r->x1;
+}
+
+static inline int damage_rect_height(struct damage_rect *r)
+{
+ return r->y2 - r->y1;
+}
+
+
static bool plane_filter(enum igt_atomic_plane_properties prop)
{
if ((1 << prop) & IGT_PLANE_COORD_CHANGED_MASK)
@@ -1060,6 +1079,210 @@ static void atomic_invalid_params(igt_pipe_t *pipe,
do_ioctl_err(display->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc, EFAULT);
}
+static void atomic_plane_damage(igt_pipe_t *pipe, igt_plane_t *plane, struct igt_fb *fb)
+{
+ struct damage_rect *damage;
+ struct igt_fb fb_1, fb_2;
+ cairo_t *cr_1, *cr_2;
+
+ damage = malloc(sizeof(*damage) * 2);
+ igt_assert(damage);
+
+ /* Color fb with white rect at center */
+ igt_create_color_fb(pipe->display->drm_fd, fb->width, fb->height,
+ fb->drm_format, I915_TILING_NONE, 0.2, 0.2, 0.2,
+ &fb_1);
+ cr_1 = igt_get_cairo_ctx(pipe->display->drm_fd, &fb_1);
+ igt_paint_color(cr_1, fb->width/4, fb->height/4, fb->width/2,
+ fb->height/2, 1.0, 1.0, 1.0);
+ igt_put_cairo_ctx(cr_1);
+
+ /*
+ * Flip the primary plane to new color fb using atomic API and check the
+ * state.
+ */
+ igt_plane_set_fb(plane, &fb_1);
+ crtc_commit(pipe, plane, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);
+
+ /*
+ * Change the color of top left clip from center and issue plane update
+ * with damage and verify the state.
+ */
+ damage[0].x1 = 0;
+ damage[0].y1 = 0;
+ damage[0].x2 = fb->width/2;
+ damage[0].y2 = fb->height/2;
+
+ cr_1 = igt_get_cairo_ctx(pipe->display->drm_fd, &fb_1);
+ igt_paint_color(cr_1, damage[0].x1, damage[0].y1,
+ damage_rect_width(&damage[0]),
+ damage_rect_height(&damage[0]), 1.0, 0, 0);
+ igt_put_cairo_ctx(cr_1);
+
+ igt_plane_set_fb(plane, &fb_1);
+ igt_plane_replace_prop_blob(plane, IGT_PLANE_FB_DAMAGE_CLIPS, damage,
+ sizeof(*damage));
+ crtc_commit(pipe, plane, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);
+
+ /*
+ * Change the color of top left and bottom right clip from center and
+ * issue plane update with damage and verify the state.
+ */
+ igt_create_color_fb(pipe->display->drm_fd, fb->width, fb->height,
+ fb->drm_format, I915_TILING_NONE, 0.2, 0.2, 0.2,
+ &fb_2);
+
+ damage[0].x1 = fb->width/2;
+ damage[0].y1 = 0;
+ damage[0].x2 = fb->width;
+ damage[0].y2 = fb->height/2;
+
+ cr_2 = igt_get_cairo_ctx(pipe->display->drm_fd, &fb_2);
+ cr_1 = igt_get_cairo_ctx(pipe->display->drm_fd, &fb_1);
+ cairo_set_source_surface(cr_2, fb_1.cairo_surface, 0, 0);
+ cairo_paint(cr_2);
+ igt_paint_color(cr_2, damage[0].x1, damage[0].y1,
+ damage_rect_width(&damage[0]),
+ damage_rect_height(&damage[0]), 0, 1.0, 0);
+ igt_put_cairo_ctx(cr_1);
+ igt_put_cairo_ctx(cr_2);
+ igt_plane_set_fb(plane, &fb_2);
+ igt_plane_replace_prop_blob(plane, IGT_PLANE_FB_DAMAGE_CLIPS, damage,
+ sizeof(*damage));
+ crtc_commit(pipe, plane, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);
+
+ /*
+ * Issue plane update with damage with a clip outside of plane src.
+ * NOTE: This will result in no update on plane as damage is outside, so
+ * will see no change on the screen.
+ */
+ /* Reszie fb_1 to be bigger than plane */
+ igt_remove_fb(pipe->display->drm_fd, &fb_1);
+ igt_create_color_fb(pipe->display->drm_fd, fb->width * 2, fb->height,
+ fb->drm_format, I915_TILING_NONE, 0.2, 0.2, 0.2,
+ &fb_1);
+
+ damage[0].x1 = fb->width;
+ damage[0].y1 = 0;
+ damage[0].x2 = fb->width + fb->width/2;
+ damage[0].y2 = fb->height/2;
+
+ cr_1 = igt_get_cairo_ctx(pipe->display->drm_fd, &fb_1);
+ cr_2 = igt_get_cairo_ctx(pipe->display->drm_fd, &fb_2);
+ cairo_set_source_surface(cr_1, fb_2.cairo_surface, 0, 0);
+ cairo_paint(cr_1);
+ igt_paint_color(cr_1, damage[0].x1, damage[0].y1,
+ damage_rect_width(&damage[0]),
+ damage_rect_height(&damage[0]), 0, 1.0, 0);
+ igt_put_cairo_ctx(cr_2);
+ igt_put_cairo_ctx(cr_1);
+ igt_plane_set_fb(plane, &fb_1);
+ igt_plane_set_size(plane, fb->width, fb->height);
+ igt_fb_set_position(&fb_1, plane, 0, 0);
+ igt_fb_set_size(&fb_1, plane, fb->width, fb->height);
+ igt_plane_replace_prop_blob(plane, IGT_PLANE_FB_DAMAGE_CLIPS, damage,
+ sizeof(*damage));
+ crtc_commit(pipe, plane, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);
+
+ /*
+ * Issue a plane update with damage with a clip that overlap with plane
+ * src (Top right from center extending outside src in below case).
+ * NOTE: Here drm core should take care of intersecting the clip to
+ * plane src.
+ */
+ damage[0].x1 = fb->width/2;
+ damage[0].y1 = 0;
+ damage[0].x2 = fb->width/2 + fb->width;
+ damage[0].y2 = fb->height/2;
+
+ cr_1 = igt_get_cairo_ctx(pipe->display->drm_fd, &fb_1);
+ igt_paint_color(cr_1, damage[0].x1, damage[0].y1,
+ damage_rect_width(&damage[0]),
+ damage_rect_height(&damage[0]), 1.0, 1.0, 0);
+ igt_put_cairo_ctx(cr_1);
+ igt_plane_set_fb(plane, &fb_1);
+ igt_plane_set_size(plane, fb->width, fb->height);
+ igt_fb_set_position(&fb_1, plane, 0, 0);
+ igt_fb_set_size(&fb_1, plane, fb->width, fb->height);
+ igt_plane_replace_prop_blob(plane, IGT_PLANE_FB_DAMAGE_CLIPS, damage,
+ sizeof(*damage));
+ crtc_commit(pipe, plane, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);
+
+ /*
+ * Issue a plane update with damage with two clips one inside plane src
+ * and one outside
+ * NOTE: This will result in plane update with clip inside plane src.
+ */
+ damage[0].x1 = 0;
+ damage[0].y1 = fb->height/2;
+ damage[0].x2 = fb->width/2;
+ damage[0].y2 = fb->height;
+
+ damage[1].x1 = fb->width + fb->width/2;
+ damage[1].y1 = fb->height/2;
+ damage[1].x2 = fb->width * 2;
+ damage[1].y2 = fb->height;
+
+ cr_1 = igt_get_cairo_ctx(pipe->display->drm_fd, &fb_1);
+ igt_paint_color(cr_1, damage[0].x1, damage[0].y1,
+ damage_rect_width(&damage[0]),
+ damage_rect_height(&damage[0]), 0, 1.0, 1.0);
+ igt_paint_color(cr_1, damage[1].x1, damage[1].y1,
+ damage_rect_width(&damage[1]),
+ damage_rect_height(&damage[1]), 0, 1.0, 0);
+ igt_put_cairo_ctx(cr_1);
+ igt_plane_set_fb(plane, &fb_1);
+ igt_plane_set_size(plane, fb->width, fb->height);
+ igt_fb_set_position(&fb_1, plane, 0, 0);
+ igt_fb_set_size(&fb_1, plane, fb->width, fb->height);
+ igt_plane_replace_prop_blob(plane, IGT_PLANE_FB_DAMAGE_CLIPS, damage,
+ sizeof(*damage) * 2);
+ crtc_commit(pipe, plane, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);
+
+ /*
+ * Issue a plane update with overlapping damage clips. White rect in
+ * center overlap partially with top left red rect.
+ * NOTE: Drm core does not error for overlapping damage clips so if any
+ * driver does not support overlapping should have their own
+ * validations.
+ */
+ damage[0].x1 = 0;
+ damage[0].y1 = 0;
+ damage[0].x2 = fb->width/2;
+ damage[0].y2 = fb->height/2;
+
+ damage[1].x1 = fb->width/4;
+ damage[1].y1 = fb->height/4;
+ damage[1].x2 = fb->width/4 + fb->width/2;
+ damage[1].y2 = fb->height/4 + fb->height/2;
+
+ cr_1 = igt_get_cairo_ctx(pipe->display->drm_fd, &fb_1);
+ igt_paint_color(cr_1, damage[0].x1, damage[0].y1,
+ damage_rect_width(&damage[0]),
+ damage_rect_height(&damage[0]), 1.0, 0, 0);
+ igt_paint_color(cr_1, damage[1].x1, damage[1].y1,
+ damage_rect_width(&damage[1]),
+ damage_rect_height(&damage[1]), 1.0, 1.0, 1.0);
+ igt_put_cairo_ctx(cr_1);
+ igt_plane_set_fb(plane, &fb_1);
+ igt_plane_set_size(plane, fb->width, fb->height);
+ igt_fb_set_position(&fb_1, plane, 0, 0);
+ igt_fb_set_size(&fb_1, plane, fb->width, fb->height);
+ igt_plane_replace_prop_blob(plane, IGT_PLANE_FB_DAMAGE_CLIPS, damage,
+ sizeof(*damage) * 2);
+ crtc_commit(pipe, plane, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);
+
+ /* Restore the primary plane */
+ igt_plane_set_fb(plane, fb);
+ plane_commit(plane, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);
+
+ /* Remove the fb created for this test */
+ igt_remove_fb(pipe->display->drm_fd, &fb_1);
+ igt_remove_fb(pipe->display->drm_fd, &fb_2);
+
+ free(damage);
+}
+
static void atomic_setup(igt_display_t *display, enum pipe pipe, igt_output_t *output, igt_plane_t *primary, struct igt_fb *fb)
{
igt_output_set_pipe(output, pipe);
@@ -1219,6 +1442,15 @@ igt_main
atomic_invalid_params(pipe_obj, primary, output, &fb);
}
+ igt_describe("Simple test cases to use FB_DAMAGE_CLIPS plane property");
+ igt_subtest("atomic_plane_damage") {
+ igt_require(igt_plane_has_prop(primary, IGT_PLANE_FB_DAMAGE_CLIPS));
+
+ atomic_setup(&display, pipe, output, primary, &fb);
+
+ atomic_plane_damage(pipe_obj, primary, &fb);
+ }
+
igt_fixture {
atomic_clear(&display, pipe, primary, output);
igt_remove_fb(display.drm_fd, &fb);
--
2.19.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for Fix kms_psr2_sf test and add new test for FB_DAMAGE_CLIPS plane property
2021-09-21 7:57 [igt-dev] [PATCH i-g-t 0/3] Fix kms_psr2_sf test and add new test for FB_DAMAGE_CLIPS plane property Jeevan B
` (2 preceding siblings ...)
2021-09-21 7:57 ` [igt-dev] [PATCH i-g-t 3/3] tests/kms_atomic: Add a new test case for FB_DAMAGE_CLIPS plane property Jeevan B
@ 2021-09-21 9:01 ` Patchwork
2021-09-21 10:05 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
4 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2021-09-21 9:01 UTC (permalink / raw)
To: Jeevan B; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 9505 bytes --]
== Series Details ==
Series: Fix kms_psr2_sf test and add new test for FB_DAMAGE_CLIPS plane property
URL : https://patchwork.freedesktop.org/series/94883/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10616 -> IGTPW_6242
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/index.html
New tests
---------
New tests have been introduced between CI_DRM_10616 and IGTPW_6242:
### New IGT tests (1) ###
* igt@core_hotunplug@unbind-rebind:
- Statuses : 4 incomplete(s) 22 pass(s) 2 warn(s)
- Exec time: [0.0, 6.43] s
Known issues
------------
Here are the changes found in IGTPW_6242 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@query-info:
- fi-bsw-kefka: NOTRUN -> [SKIP][1] ([fdo#109271]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/fi-bsw-kefka/igt@amdgpu/amd_basic@query-info.html
* igt@amdgpu/amd_basic@semaphore:
- fi-bsw-nick: NOTRUN -> [SKIP][2] ([fdo#109271]) +17 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/fi-bsw-nick/igt@amdgpu/amd_basic@semaphore.html
* igt@amdgpu/amd_basic@userptr:
- fi-bxt-dsi: NOTRUN -> [SKIP][3] ([fdo#109271]) +17 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/fi-bxt-dsi/igt@amdgpu/amd_basic@userptr.html
* igt@amdgpu/amd_cs_nop@sync-fork-gfx0:
- fi-skl-6600u: NOTRUN -> [SKIP][4] ([fdo#109271]) +17 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/fi-skl-6600u/igt@amdgpu/amd_cs_nop@sync-fork-gfx0.html
* igt@core_hotunplug@unbind-rebind (NEW):
- fi-rkl-guc: [PASS][5] -> [INCOMPLETE][6] ([i915#4130] / [i915#4136])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/fi-rkl-guc/igt@core_hotunplug@unbind-rebind.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/fi-rkl-guc/igt@core_hotunplug@unbind-rebind.html
- fi-icl-u2: [INCOMPLETE][7] ([i915#4130]) -> [INCOMPLETE][8] ([i915#4130] / [i915#4136])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/fi-icl-u2/igt@core_hotunplug@unbind-rebind.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/fi-icl-u2/igt@core_hotunplug@unbind-rebind.html
- fi-kbl-7500u: [PASS][9] -> [INCOMPLETE][10] ([i915#4130] / [i915#4136])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/fi-kbl-7500u/igt@core_hotunplug@unbind-rebind.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/fi-kbl-7500u/igt@core_hotunplug@unbind-rebind.html
- fi-kbl-7567u: [PASS][11] -> [INCOMPLETE][12] ([i915#4130])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/fi-kbl-7567u/igt@core_hotunplug@unbind-rebind.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/fi-kbl-7567u/igt@core_hotunplug@unbind-rebind.html
* igt@i915_module_load@reload:
- fi-cfl-8109u: NOTRUN -> [INCOMPLETE][13] ([i915#4136])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/fi-cfl-8109u/igt@i915_module_load@reload.html
* igt@i915_pm_rpm@module-reload:
- fi-snb-2600: NOTRUN -> [SKIP][14] ([fdo#109271])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/fi-snb-2600/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: NOTRUN -> [INCOMPLETE][15] ([i915#3921])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: [PASS][16] -> [DMESG-WARN][17] ([i915#2868])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
#### Possible fixes ####
* igt@core_hotunplug@unbind-rebind (NEW):
- fi-bxt-dsi: [INCOMPLETE][18] ([i915#4130]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/fi-bxt-dsi/igt@core_hotunplug@unbind-rebind.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/fi-bxt-dsi/igt@core_hotunplug@unbind-rebind.html
- fi-cfl-8109u: [INCOMPLETE][20] ([i915#4130]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/fi-cfl-8109u/igt@core_hotunplug@unbind-rebind.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/fi-cfl-8109u/igt@core_hotunplug@unbind-rebind.html
* igt@i915_module_load@reload:
- fi-skl-6600u: [INCOMPLETE][22] ([i915#4130]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/fi-skl-6600u/igt@i915_module_load@reload.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/fi-skl-6600u/igt@i915_module_load@reload.html
- fi-bsw-kefka: [INCOMPLETE][24] ([i915#4179]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/fi-bsw-kefka/igt@i915_module_load@reload.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/fi-bsw-kefka/igt@i915_module_load@reload.html
- fi-snb-2600: [INCOMPLETE][26] ([i915#4179]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/fi-snb-2600/igt@i915_module_load@reload.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/fi-snb-2600/igt@i915_module_load@reload.html
- fi-icl-y: [TIMEOUT][28] ([i915#4136]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/fi-icl-y/igt@i915_module_load@reload.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/fi-icl-y/igt@i915_module_load@reload.html
- fi-bsw-nick: [INCOMPLETE][30] ([i915#4179]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/fi-bsw-nick/igt@i915_module_load@reload.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/fi-bsw-nick/igt@i915_module_load@reload.html
#### Warnings ####
* igt@i915_module_load@reload:
- fi-cml-u2: [INCOMPLETE][32] ([i915#4130]) -> [INCOMPLETE][33] ([i915#4130] / [i915#4136])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/fi-cml-u2/igt@i915_module_load@reload.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/fi-cml-u2/igt@i915_module_load@reload.html
- fi-kbl-soraka: [INCOMPLETE][34] ([i915#4130]) -> [INCOMPLETE][35] ([i915#4136])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/fi-kbl-soraka/igt@i915_module_load@reload.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/fi-kbl-soraka/igt@i915_module_load@reload.html
- fi-glk-dsi: [INCOMPLETE][36] ([i915#4130]) -> [INCOMPLETE][37] ([i915#4130] / [i915#4136])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/fi-glk-dsi/igt@i915_module_load@reload.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/fi-glk-dsi/igt@i915_module_load@reload.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#2868]: https://gitlab.freedesktop.org/drm/intel/issues/2868
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4130]: https://gitlab.freedesktop.org/drm/intel/issues/4130
[i915#4136]: https://gitlab.freedesktop.org/drm/intel/issues/4136
[i915#4179]: https://gitlab.freedesktop.org/drm/intel/issues/4179
Participating hosts (35 -> 30)
------------------------------
Missing (5): fi-rkl-11600 bat-dg1-6 fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6213 -> IGTPW_6242
CI-20190529: 20190529
CI_DRM_10616: fd5d67615e07f5c10424ca704cb0c0243ea77643 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6242: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/index.html
IGT_6213: e9ae59cb8b4f1e7bc61a9261f33fc7e52ae06c65 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Testlist changes ==
+igt@kms_atomic@atomic_plane_damage
+igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area
+igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area
+igt@kms_psr2_sf@plane-move-sf-dmg-area
+igt@kms_psr2_sf@primary-plane-update-sf-dmg-area
-igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1
-igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2
-igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3
-igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4
-igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5
-igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1
-igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2
-igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3
-igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4
-igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5
-igt@kms_psr2_sf@plane-move-sf-dmg-area-0
-igt@kms_psr2_sf@plane-move-sf-dmg-area-1
-igt@kms_psr2_sf@plane-move-sf-dmg-area-2
-igt@kms_psr2_sf@plane-move-sf-dmg-area-3
-igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1
-igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2
-igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3
-igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4
-igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/index.html
[-- Attachment #2: Type: text/html, Size: 12398 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for Fix kms_psr2_sf test and add new test for FB_DAMAGE_CLIPS plane property
2021-09-21 7:57 [igt-dev] [PATCH i-g-t 0/3] Fix kms_psr2_sf test and add new test for FB_DAMAGE_CLIPS plane property Jeevan B
` (3 preceding siblings ...)
2021-09-21 9:01 ` [igt-dev] ✓ Fi.CI.BAT: success for Fix kms_psr2_sf test and add new test " Patchwork
@ 2021-09-21 10:05 ` Patchwork
4 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2021-09-21 10:05 UTC (permalink / raw)
To: Jeevan B; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 30288 bytes --]
== Series Details ==
Series: Fix kms_psr2_sf test and add new test for FB_DAMAGE_CLIPS plane property
URL : https://patchwork.freedesktop.org/series/94883/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10616_full -> IGTPW_6242_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_6242_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_6242_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_6242_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_atomic_transition@plane-toggle-modeset-transition:
- shard-iclb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/shard-iclb4/igt@kms_atomic_transition@plane-toggle-modeset-transition.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-iclb7/igt@kms_atomic_transition@plane-toggle-modeset-transition.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-apl: NOTRUN -> [INCOMPLETE][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-apl1/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* {igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area} (NEW):
- shard-tglb: NOTRUN -> [SKIP][4] +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb8/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html
* {igt@kms_psr2_sf@primary-plane-update-sf-dmg-area} (NEW):
- shard-iclb: NOTRUN -> [SKIP][5] +4 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-iclb8/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html
New tests
---------
New tests have been introduced between CI_DRM_10616_full and IGTPW_6242_full:
### New IGT tests (22) ###
* igt@api_intel_bb@lot-of-buffers:
- Statuses : 6 pass(s)
- Exec time: [0.58, 6.68] s
* igt@api_intel_bb@render:
- Statuses :
- Exec time: [None] s
* igt@api_intel_bb@render-ccs:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.00, 0.43] s
* igt@api_intel_bb@render@render-none-1024:
- Statuses : 4 pass(s)
- Exec time: [0.31, 0.47] s
* igt@api_intel_bb@render@render-none-512:
- Statuses : 4 pass(s)
- Exec time: [0.08, 0.12] s
* igt@api_intel_bb@render@render-none-reloc-1024:
- Statuses : 3 pass(s)
- Exec time: [0.31, 0.36] s
* igt@api_intel_bb@render@render-none-reloc-512:
- Statuses : 3 pass(s)
- Exec time: [0.08, 0.10] s
* igt@api_intel_bb@render@render-x-1024:
- Statuses : 4 pass(s)
- Exec time: [0.27, 0.42] s
* igt@api_intel_bb@render@render-x-512:
- Statuses : 4 pass(s)
- Exec time: [0.07, 0.11] s
* igt@api_intel_bb@render@render-x-reloc-1024:
- Statuses : 3 pass(s)
- Exec time: [0.27, 0.34] s
* igt@api_intel_bb@render@render-x-reloc-512:
- Statuses : 3 pass(s)
- Exec time: [0.08, 0.09] s
* igt@api_intel_bb@render@render-y-1024:
- Statuses : 4 pass(s)
- Exec time: [0.27, 0.42] s
* igt@api_intel_bb@render@render-y-512:
- Statuses : 4 pass(s)
- Exec time: [0.07, 0.11] s
* igt@api_intel_bb@render@render-y-reloc-1024:
- Statuses : 3 pass(s)
- Exec time: [0.27, 0.32] s
* igt@api_intel_bb@render@render-y-reloc-512:
- Statuses : 3 pass(s)
- Exec time: [0.07, 0.09] s
* igt@api_intel_bb@reset-flags:
- Statuses : 6 pass(s)
- Exec time: [0.01, 0.03] s
* igt@core_hotunplug@unbind-rebind:
- Statuses : 1 incomplete(s) 4 pass(s)
- Exec time: [0.0, 5.39] s
* igt@kms_atomic@atomic_plane_damage:
- Statuses : 1 pass(s) 5 skip(s)
- Exec time: [0.0, 0.24] s
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- Statuses : 5 skip(s)
- Exec time: [0.0] s
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
- Statuses : 4 skip(s)
- Exec time: [0.0] s
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- Statuses : 4 skip(s)
- Exec time: [0.0] s
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area:
- Statuses : 4 skip(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in IGTPW_6242_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_hotunplug@unbind-rebind (NEW):
- shard-kbl: [PASS][6] -> [INCOMPLETE][7] ([i915#4130] / [i915#4136])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/shard-kbl2/igt@core_hotunplug@unbind-rebind.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-kbl4/igt@core_hotunplug@unbind-rebind.html
* igt@feature_discovery@display-3x:
- shard-glk: NOTRUN -> [SKIP][8] ([fdo#109271]) +145 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-glk2/igt@feature_discovery@display-3x.html
- shard-iclb: NOTRUN -> [SKIP][9] ([i915#1839])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-iclb2/igt@feature_discovery@display-3x.html
- shard-tglb: NOTRUN -> [SKIP][10] ([i915#1839])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb3/igt@feature_discovery@display-3x.html
* igt@gem_create@create-massive:
- shard-apl: NOTRUN -> [DMESG-WARN][11] ([i915#3002])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-apl3/igt@gem_create@create-massive.html
* igt@gem_ctx_persistence@engines-hostile:
- shard-snb: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#1099]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-snb7/igt@gem_ctx_persistence@engines-hostile.html
* igt@gem_ctx_sseu@engines:
- shard-tglb: NOTRUN -> [SKIP][13] ([i915#280])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb8/igt@gem_ctx_sseu@engines.html
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: NOTRUN -> [FAIL][14] ([i915#2846])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-kbl2/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-glk: NOTRUN -> [FAIL][15] ([i915#2842])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-glk4/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-apl: [PASS][16] -> [SKIP][17] ([fdo#109271])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/shard-apl1/igt@gem_exec_fair@basic-none-share@rcs0.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-apl2/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-tglb: NOTRUN -> [FAIL][18] ([i915#2842])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb8/igt@gem_exec_fair@basic-none-vip@rcs0.html
* igt@gem_exec_fair@basic-none@vecs0:
- shard-kbl: NOTRUN -> [FAIL][19] ([i915#2842])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-kbl3/igt@gem_exec_fair@basic-none@vecs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][20] -> [FAIL][21] ([i915#2842])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/shard-tglb7/igt@gem_exec_fair@basic-pace-share@rcs0.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb8/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][22] ([i915#2842])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-iclb4/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [PASS][23] -> [FAIL][24] ([i915#2849])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/shard-iclb8/igt@gem_exec_fair@basic-throttle@rcs0.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_params@secure-non-master:
- shard-tglb: NOTRUN -> [SKIP][25] ([fdo#112283])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb1/igt@gem_exec_params@secure-non-master.html
* igt@gem_pread@exhaustion:
- shard-kbl: NOTRUN -> [WARN][26] ([i915#2658])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-kbl3/igt@gem_pread@exhaustion.html
* igt@gem_render_copy@y-tiled-ccs-to-yf-tiled-mc-ccs:
- shard-iclb: NOTRUN -> [SKIP][27] ([i915#768])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-iclb1/igt@gem_render_copy@y-tiled-ccs-to-yf-tiled-mc-ccs.html
* igt@gem_userptr_blits@coherency-sync:
- shard-iclb: NOTRUN -> [SKIP][28] ([fdo#109290])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-iclb3/igt@gem_userptr_blits@coherency-sync.html
* igt@gem_userptr_blits@dmabuf-unsync:
- shard-tglb: NOTRUN -> [SKIP][29] ([i915#3297])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb2/igt@gem_userptr_blits@dmabuf-unsync.html
* igt@gem_userptr_blits@vma-merge:
- shard-glk: NOTRUN -> [FAIL][30] ([i915#3318])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-glk3/igt@gem_userptr_blits@vma-merge.html
- shard-kbl: NOTRUN -> [FAIL][31] ([i915#3318])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-kbl6/igt@gem_userptr_blits@vma-merge.html
* igt@gen7_exec_parse@bitmasks:
- shard-iclb: NOTRUN -> [SKIP][32] ([fdo#109289]) +3 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-iclb5/igt@gen7_exec_parse@bitmasks.html
* igt@gen9_exec_parse@valid-registers:
- shard-tglb: NOTRUN -> [SKIP][33] ([i915#2856]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb7/igt@gen9_exec_parse@valid-registers.html
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-tglb: NOTRUN -> [SKIP][34] ([i915#1904])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb5/igt@i915_pm_dc@dc3co-vpb-simulation.html
- shard-glk: NOTRUN -> [SKIP][35] ([fdo#109271] / [i915#658])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-glk5/igt@i915_pm_dc@dc3co-vpb-simulation.html
- shard-apl: NOTRUN -> [SKIP][36] ([fdo#109271] / [i915#658])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-apl2/igt@i915_pm_dc@dc3co-vpb-simulation.html
- shard-iclb: NOTRUN -> [SKIP][37] ([i915#588])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-apl: NOTRUN -> [SKIP][38] ([fdo#109271] / [i915#1937])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-apl6/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- shard-glk: NOTRUN -> [SKIP][39] ([fdo#109271] / [i915#1937])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-glk6/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-tglb: NOTRUN -> [WARN][40] ([i915#2681] / [i915#2684])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb5/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- shard-iclb: NOTRUN -> [SKIP][41] ([fdo#109293] / [fdo#109506])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-iclb7/igt@i915_pm_rpm@gem-execbuf-stress-pc8.html
* igt@i915_pm_rpm@gem-idle:
- shard-tglb: [PASS][42] -> [SKIP][43] ([i915#2411] / [i915#579])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/shard-tglb2/igt@i915_pm_rpm@gem-idle.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb2/igt@i915_pm_rpm@gem-idle.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [PASS][44] -> [INCOMPLETE][45] ([i915#3921])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/shard-snb7/igt@i915_selftest@live@hangcheck.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-snb7/igt@i915_selftest@live@hangcheck.html
* igt@i915_suspend@fence-restore-untiled:
- shard-kbl: NOTRUN -> [DMESG-WARN][46] ([i915#180])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-kbl7/igt@i915_suspend@fence-restore-untiled.html
* igt@i915_suspend@forcewake:
- shard-tglb: [PASS][47] -> [INCOMPLETE][48] ([i915#2411] / [i915#456])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/shard-tglb5/igt@i915_suspend@forcewake.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb7/igt@i915_suspend@forcewake.html
* igt@i915_suspend@sysfs-reader:
- shard-tglb: [PASS][49] -> [INCOMPLETE][50] ([i915#456])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/shard-tglb8/igt@i915_suspend@sysfs-reader.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb7/igt@i915_suspend@sysfs-reader.html
* igt@kms_big_fb@linear-16bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][51] ([fdo#110725] / [fdo#111614])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-iclb5/igt@kms_big_fb@linear-16bpp-rotate-270.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-0:
- shard-glk: [PASS][52] -> [DMESG-WARN][53] ([i915#118] / [i915#95])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/shard-glk4/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-glk2/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html
* igt@kms_big_fb@y-tiled-64bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][54] ([fdo#111614]) +2 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb1/igt@kms_big_fb@y-tiled-64bpp-rotate-270.html
* igt@kms_big_fb@yf-tiled-8bpp-rotate-180:
- shard-tglb: NOTRUN -> [SKIP][55] ([fdo#111615]) +6 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb1/igt@kms_big_fb@yf-tiled-8bpp-rotate-180.html
- shard-iclb: NOTRUN -> [SKIP][56] ([fdo#110723]) +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-iclb6/igt@kms_big_fb@yf-tiled-8bpp-rotate-180.html
* igt@kms_big_joiner@2x-modeset:
- shard-tglb: NOTRUN -> [SKIP][57] ([i915#2705])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb1/igt@kms_big_joiner@2x-modeset.html
* igt@kms_big_joiner@invalid-modeset:
- shard-iclb: NOTRUN -> [SKIP][58] ([i915#2705])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-iclb7/igt@kms_big_joiner@invalid-modeset.html
* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][59] ([i915#3689] / [i915#3886]) +6 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb1/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#3886]) +14 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-apl2/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#3886]) +9 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-glk4/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#3886]) +14 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-kbl1/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][63] ([fdo#109278] / [i915#3886]) +5 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-iclb6/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs:
- shard-snb: NOTRUN -> [SKIP][64] ([fdo#109271]) +344 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-snb2/igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs.html
* igt@kms_ccs@pipe-d-missing-ccs-buffer-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][65] ([i915#3689]) +14 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb6/igt@kms_ccs@pipe-d-missing-ccs-buffer-yf_tiled_ccs.html
* igt@kms_cdclk@mode-transition:
- shard-apl: NOTRUN -> [SKIP][66] ([fdo#109271]) +243 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-apl7/igt@kms_cdclk@mode-transition.html
- shard-iclb: NOTRUN -> [SKIP][67] ([i915#3742])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-iclb5/igt@kms_cdclk@mode-transition.html
* igt@kms_chamelium@hdmi-edid-change-during-suspend:
- shard-apl: NOTRUN -> [SKIP][68] ([fdo#109271] / [fdo#111827]) +24 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-apl8/igt@kms_chamelium@hdmi-edid-change-during-suspend.html
* igt@kms_chamelium@hdmi-mode-timings:
- shard-iclb: NOTRUN -> [SKIP][69] ([fdo#109284] / [fdo#111827]) +7 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-iclb3/igt@kms_chamelium@hdmi-mode-timings.html
* igt@kms_color_chamelium@pipe-a-degamma:
- shard-kbl: NOTRUN -> [SKIP][70] ([fdo#109271] / [fdo#111827]) +23 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-kbl7/igt@kms_color_chamelium@pipe-a-degamma.html
* igt@kms_color_chamelium@pipe-d-ctm-0-5:
- shard-snb: NOTRUN -> [SKIP][71] ([fdo#109271] / [fdo#111827]) +18 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-snb6/igt@kms_color_chamelium@pipe-d-ctm-0-5.html
* igt@kms_color_chamelium@pipe-d-ctm-red-to-blue:
- shard-tglb: NOTRUN -> [SKIP][72] ([fdo#109284] / [fdo#111827]) +18 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb2/igt@kms_color_chamelium@pipe-d-ctm-red-to-blue.html
- shard-iclb: NOTRUN -> [SKIP][73] ([fdo#109278] / [fdo#109284] / [fdo#111827]) +2 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-iclb7/igt@kms_color_chamelium@pipe-d-ctm-red-to-blue.html
* igt@kms_color_chamelium@pipe-d-degamma:
- shard-glk: NOTRUN -> [SKIP][74] ([fdo#109271] / [fdo#111827]) +17 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-glk6/igt@kms_color_chamelium@pipe-d-degamma.html
* igt@kms_content_protection@dp-mst-type-1:
- shard-iclb: NOTRUN -> [SKIP][75] ([i915#3116])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-iclb3/igt@kms_content_protection@dp-mst-type-1.html
- shard-tglb: NOTRUN -> [SKIP][76] ([i915#3116])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb5/igt@kms_content_protection@dp-mst-type-1.html
* igt@kms_content_protection@legacy:
- shard-apl: NOTRUN -> [TIMEOUT][77] ([i915#1319])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-apl6/igt@kms_content_protection@legacy.html
* igt@kms_content_protection@lic:
- shard-tglb: NOTRUN -> [SKIP][78] ([fdo#111828])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb8/igt@kms_content_protection@lic.html
* igt@kms_cursor_crc@pipe-a-cursor-32x32-sliding:
- shard-tglb: NOTRUN -> [SKIP][79] ([i915#3319]) +2 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb3/igt@kms_cursor_crc@pipe-a-cursor-32x32-sliding.html
* igt@kms_cursor_crc@pipe-a-cursor-512x512-offscreen:
- shard-iclb: NOTRUN -> [SKIP][80] ([fdo#109278] / [fdo#109279]) +5 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-iclb1/igt@kms_cursor_crc@pipe-a-cursor-512x512-offscreen.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][81] -> [DMESG-WARN][82] ([i915#180]) +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-b-cursor-size-change:
- shard-glk: [PASS][83] -> [FAIL][84] ([i915#3444])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/shard-glk8/igt@kms_cursor_crc@pipe-b-cursor-size-change.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-glk2/igt@kms_cursor_crc@pipe-b-cursor-size-change.html
* igt@kms_cursor_crc@pipe-d-cursor-256x256-onscreen:
- shard-kbl: NOTRUN -> [SKIP][85] ([fdo#109271]) +286 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-kbl2/igt@kms_cursor_crc@pipe-d-cursor-256x256-onscreen.html
* igt@kms_cursor_crc@pipe-d-cursor-512x170-offscreen:
- shard-tglb: NOTRUN -> [SKIP][86] ([fdo#109279] / [i915#3359]) +8 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb1/igt@kms_cursor_crc@pipe-d-cursor-512x170-offscreen.html
* igt@kms_cursor_crc@pipe-d-cursor-max-size-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][87] ([i915#3359]) +5 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb6/igt@kms_cursor_crc@pipe-d-cursor-max-size-rapid-movement.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-iclb: NOTRUN -> [SKIP][88] ([fdo#109274] / [fdo#109278]) +2 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-iclb2/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
* igt@kms_dp_tiled_display@basic-test-pattern-with-chamelium:
- shard-tglb: NOTRUN -> [SKIP][89] ([i915#3528])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb1/igt@kms_dp_tiled_display@basic-test-pattern-with-chamelium.html
* igt@kms_flip@2x-flip-vs-panning-interruptible:
- shard-iclb: NOTRUN -> [SKIP][90] ([fdo#109274]) +2 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-iclb2/igt@kms_flip@2x-flip-vs-panning-interruptible.html
* igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1:
- shard-glk: [PASS][91] -> [FAIL][92] ([i915#79])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/shard-glk2/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-glk5/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-edp1:
- shard-tglb: [PASS][93] -> [INCOMPLETE][94] ([i915#4173] / [i915#456])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/shard-tglb5/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb7/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: [PASS][95] -> [DMESG-WARN][96] ([i915#180]) +1 similar issue
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/shard-apl7/igt@kms_flip@flip-vs-suspend@a-dp1.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-apl8/igt@kms_flip@flip-vs-suspend@a-dp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs:
- shard-tglb: NOTRUN -> [SKIP][97] ([i915#2587])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-apl: NOTRUN -> [SKIP][98] ([fdo#109271] / [i915#2672])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-apl3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-plflip-blt:
- shard-tglb: NOTRUN -> [SKIP][99] ([fdo#111825]) +40 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-pwrite:
- shard-iclb: NOTRUN -> [SKIP][100] ([fdo#109280]) +20 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-pwrite.html
* igt@kms_invalid_dotclock:
- shard-tglb: NOTRUN -> [SKIP][101] ([fdo#110577])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb8/igt@kms_invalid_dotclock.html
* igt@kms_pipe_b_c_ivb@pipe-b-dpms-off-modeset-pipe-c:
- shard-tglb: NOTRUN -> [SKIP][102] ([fdo#109289]) +1 similar issue
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb7/igt@kms_pipe_b_c_ivb@pipe-b-dpms-off-modeset-pipe-c.html
* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d:
- shard-kbl: NOTRUN -> [SKIP][103] ([fdo#109271] / [i915#533])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-kbl1/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][104] ([i915#265])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-apl7/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-apl: NOTRUN -> [FAIL][105] ([fdo#108145] / [i915#265]) +1 similar issue
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-apl2/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-kbl: NOTRUN -> [FAIL][106] ([fdo#108145] / [i915#265]) +1 similar issue
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-kbl2/igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb.html
* igt@kms_plane_alpha_blend@pipe-d-constant-alpha-min:
- shard-iclb: NOTRUN -> [SKIP][107] ([fdo#109278]) +21 similar issues
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-iclb5/igt@kms_plane_alpha_blend@pipe-d-constant-alpha-min.html
* igt@kms_plane_lowres@pipe-a-tiling-none:
- shard-tglb: NOTRUN -> [SKIP][108] ([i915#3536]) +2 similar issues
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb5/igt@kms_plane_lowres@pipe-a-tiling-none.html
- shard-iclb: NOTRUN -> [SKIP][109] ([i915#3536]) +2 similar issues
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-iclb2/igt@kms_plane_lowres@pipe-a-tiling-none.html
* igt@kms_plane_lowres@pipe-b-tiling-yf:
- shard-tglb: NOTRUN -> [SKIP][110] ([fdo#112054])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb2/igt@kms_plane_lowres@pipe-b-tiling-yf.html
* igt@kms_psr2_su@page_flip:
- shard-kbl: NOTRUN -> [SKIP][111] ([fdo#109271] / [i915#658])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-kbl3/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_cursor_mmap_gtt:
- shard-iclb: NOTRUN -> [SKIP][112] ([fdo#109441])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-iclb6/igt@kms_psr@psr2_cursor_mmap_gtt.html
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [PASS][113] -> [SKIP][114] ([fdo#109441])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-iclb1/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@kms_psr@psr2_primary_blt:
- shard-tglb: NOTRUN -> [FAIL][115] ([i915#132] / [i915#3467]) +3 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb2/igt@kms_psr@psr2_primary_blt.html
* igt@kms_tv_load_detect@load-detect:
- shard-tglb: NOTRUN -> [SKIP][116] ([fdo#109309])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb1/igt@kms_tv_load_detect@load-detect.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][117] -> [DMESG-WARN][118] ([i915#180] / [i915#295])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10616/shard-kbl6/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-kbl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_vrr@flip-suspend:
- shard-iclb: NOTRUN -> [SKIP][119] ([fdo#109502])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-iclb2/igt@kms_vrr@flip-suspend.html
* igt@kms_vrr@flipline:
- shard-tglb: NOTRUN -> [SKIP][120] ([fdo#109502]) +1 similar issue
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-tglb3/igt@kms_vrr@flipline.html
* igt@kms_writeback@writeback-fb-id:
- shard-apl: NOTRUN -> [SKIP][121] ([fdo#109271] / [i915#2437])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/shard-apl1/igt@kms_writeback@writeback-fb-id.html
* igt@nouveau_crc@pipe-a-ctx-flip-skip-current-frame:
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6242/index.html
[-- Attachment #2: Type: text/html, Size: 34412 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/3] lib/igt_aux: Rename igt_debug_manual_check and assert check if all is supplied
2021-09-21 7:57 ` [igt-dev] [PATCH i-g-t 1/3] lib/igt_aux: Rename igt_debug_manual_check and assert check if all is supplied Jeevan B
@ 2021-09-21 12:48 ` Petri Latvala
2021-09-22 16:45 ` B, Jeevan
0 siblings, 1 reply; 9+ messages in thread
From: Petri Latvala @ 2021-09-21 12:48 UTC (permalink / raw)
To: Jeevan B; +Cc: igt-dev, daniel, jose.souza
On Tue, Sep 21, 2021 at 01:27:47PM +0530, Jeevan B wrote:
> rename igt_debug_manual_check and patch the igt functions
> igt_debug_manual_check() and igt_debug_wait_for_keypress()
> to assert if "all" is supplied.
Why?
--
Petri Latvala
>
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> ---
> lib/igt_aux.c | 18 ++++++++++++------
> lib/igt_aux.h | 2 +-
> tests/i915/kms_dsc.c | 2 +-
> tests/i915/kms_psr.c | 2 +-
> tests/i915/kms_psr2_sf.c | 2 +-
> 5 files changed, 16 insertions(+), 10 deletions(-)
>
> diff --git a/lib/igt_aux.c b/lib/igt_aux.c
> index 1217f5e8..96929237 100644
> --- a/lib/igt_aux.c
> +++ b/lib/igt_aux.c
> @@ -971,8 +971,7 @@ void igt_drop_root(void)
> *
> * Waits for a key press when run interactively and when the corresponding debug
> * var is set in the --interactive-debug=$var variable. Multiple keys
> - * can be specified as a comma-separated list or alternatively "all" if a wait
> - * should happen for all cases.
> + * can be specified as a comma-separated list and assert if "all" is supplied.
> *
> * When not connected to a terminal interactive_debug is ignored
> * and execution immediately continues.
> @@ -993,6 +992,10 @@ void igt_debug_wait_for_keypress(const char *var)
> if (!igt_interactive_debug)
> return;
>
> + if (strstr(igt_interactive_debug, var) &&
> + strstr(igt_interactive_debug, "all"))
> + igt_assert(false);
> +
> if (!strstr(igt_interactive_debug, var) &&
> !strstr(igt_interactive_debug, "all"))
> return;
> @@ -1008,14 +1011,13 @@ void igt_debug_wait_for_keypress(const char *var)
> }
>
> /**
> - * igt_debug_manual_check:
> + * igt_debug_interactive_mode_check:
> * @var: var lookup to to enable this wait
> * @expected: message to be printed as expected behaviour before wait for keys Y/n
> *
> * Waits for a key press when run interactively and when the corresponding debug
> * var is set in the --interactive-debug=$var variable. Multiple vars
> - * can be specified as a comma-separated list or alternatively "all" if a wait
> - * should happen for all cases.
> + * can be specified as a comma-separated list and assert if "all" is supplied.
> *
> * This is useful for display tests where under certain situation manual
> * inspection of the display is useful. Or when running a testcase in the
> @@ -1028,7 +1030,7 @@ void igt_debug_wait_for_keypress(const char *var)
> *
> * Force test fail when N/n is pressed.
> */
> -void igt_debug_manual_check(const char *var, const char *expected)
> +void igt_debug_interactive_mode_check(const char *var, const char *expected)
> {
> struct termios oldt, newt;
> char key;
> @@ -1041,6 +1043,10 @@ void igt_debug_manual_check(const char *var, const char *expected)
> if (!igt_interactive_debug)
> return;
>
> + if (strstr(igt_interactive_debug, var) &&
> + strstr(igt_interactive_debug, "all"))
> + igt_assert(false);
> +
> if (!strstr(igt_interactive_debug, var) &&
> !strstr(igt_interactive_debug, "all"))
> return;
> diff --git a/lib/igt_aux.h b/lib/igt_aux.h
> index bf57ccf5..a92eb799 100644
> --- a/lib/igt_aux.h
> +++ b/lib/igt_aux.h
> @@ -193,7 +193,7 @@ int igt_get_autoresume_delay(enum igt_suspend_state state);
> void igt_drop_root(void);
>
> void igt_debug_wait_for_keypress(const char *var);
> -void igt_debug_manual_check(const char *var, const char *expected);
> +void igt_debug_interactive_mode_check(const char *var, const char *expected);
>
> /* sysinfo cross-arch wrappers from intel_os.c */
>
> diff --git a/tests/i915/kms_dsc.c b/tests/i915/kms_dsc.c
> index 3e450207..772687f4 100644
> --- a/tests/i915/kms_dsc.c
> +++ b/tests/i915/kms_dsc.c
> @@ -72,7 +72,7 @@ int force_dsc_restore_fd = -1;
>
> static inline void manual(const char *expected)
> {
> - igt_debug_manual_check("all", expected);
> + igt_debug_interactive_mode_check("all", expected);
> }
>
> static void force_dsc_enable(data_t *data)
> diff --git a/tests/i915/kms_psr.c b/tests/i915/kms_psr.c
> index 270d3150..24a10676 100644
> --- a/tests/i915/kms_psr.c
> +++ b/tests/i915/kms_psr.c
> @@ -246,7 +246,7 @@ static bool psr_enable_if_enabled(data_t *data)
>
> static inline void manual(const char *expected)
> {
> - igt_debug_manual_check("all", expected);
> + igt_debug_interactive_mode_check("all", expected);
> }
>
> static bool drrs_disabled(data_t *data)
> diff --git a/tests/i915/kms_psr2_sf.c b/tests/i915/kms_psr2_sf.c
> index 1be8c3da..93347327 100644
> --- a/tests/i915/kms_psr2_sf.c
> +++ b/tests/i915/kms_psr2_sf.c
> @@ -331,7 +331,7 @@ static void prepare(data_t *data)
>
> static inline void manual(const char *expected)
> {
> - igt_debug_manual_check("all", expected);
> + igt_debug_interactive_mode_check("all", expected);
> }
>
> static void plane_update_expected_output(int plane_type, int box_count)
> --
> 2.19.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/3] lib/igt_aux: Rename igt_debug_manual_check and assert check if all is supplied
2021-09-21 12:48 ` Petri Latvala
@ 2021-09-22 16:45 ` B, Jeevan
2021-09-22 17:12 ` Petri Latvala
0 siblings, 1 reply; 9+ messages in thread
From: B, Jeevan @ 2021-09-22 16:45 UTC (permalink / raw)
To: Latvala, Petri; +Cc: igt-dev, daniel, Souza, Jose
>-----Original Message-----
>From: Latvala, Petri <petri.latvala@intel.com>
>Sent: Tuesday, September 21, 2021 6:19 PM
>To: B, Jeevan <jeevan.b@intel.com>
>Cc: igt-dev@lists.freedesktop.org; daniel@ffwll.ch; Souza, Jose
><jose.souza@intel.com>
>Subject: Re: [igt-dev] [PATCH i-g-t 1/3] lib/igt_aux: Rename
>igt_debug_manual_check and assert check if all is supplied
>
>On Tue, Sep 21, 2021 at 01:27:47PM +0530, Jeevan B wrote:
>> rename igt_debug_manual_check and patch the igt functions
>> igt_debug_manual_check() and igt_debug_wait_for_keypress() to assert
>> if "all" is supplied.
>
>Why?
Addressing comments given here. (https://lore.kernel.org/intel-gfx/CAKMK7uE0Hd34fOobDZT27MhOYE1qjXdD1Yzn9C0B+u=RCXLi8w@mail.gmail.com/)
Thanks
Jeevan B
>
>
>--
>Petri Latvala
>
>
>>
>> Signed-off-by: Jeevan B <jeevan.b@intel.com>
>> ---
>> lib/igt_aux.c | 18 ++++++++++++------
>> lib/igt_aux.h | 2 +-
>> tests/i915/kms_dsc.c | 2 +-
>> tests/i915/kms_psr.c | 2 +-
>> tests/i915/kms_psr2_sf.c | 2 +-
>> 5 files changed, 16 insertions(+), 10 deletions(-)
>>
>> diff --git a/lib/igt_aux.c b/lib/igt_aux.c
>> index 1217f5e8..96929237 100644
>> --- a/lib/igt_aux.c
>> +++ b/lib/igt_aux.c
>> @@ -971,8 +971,7 @@ void igt_drop_root(void)
>> *
>> * Waits for a key press when run interactively and when the corresponding
>debug
>> * var is set in the --interactive-debug=$var variable. Multiple keys
>> - * can be specified as a comma-separated list or alternatively "all" if a wait
>> - * should happen for all cases.
>> + * can be specified as a comma-separated list and assert if "all" is supplied.
>> *
>> * When not connected to a terminal interactive_debug is ignored
>> * and execution immediately continues.
>> @@ -993,6 +992,10 @@ void igt_debug_wait_for_keypress(const char *var)
>> if (!igt_interactive_debug)
>> return;
>>
>> + if (strstr(igt_interactive_debug, var) &&
>> + strstr(igt_interactive_debug, "all"))
>> + igt_assert(false);
>> +
>> if (!strstr(igt_interactive_debug, var) &&
>> !strstr(igt_interactive_debug, "all"))
>> return;
>> @@ -1008,14 +1011,13 @@ void igt_debug_wait_for_keypress(const char
>*var)
>> }
>>
>> /**
>> - * igt_debug_manual_check:
>> + * igt_debug_interactive_mode_check:
>> * @var: var lookup to to enable this wait
>> * @expected: message to be printed as expected behaviour before wait for
>keys Y/n
>> *
>> * Waits for a key press when run interactively and when the corresponding
>debug
>> * var is set in the --interactive-debug=$var variable. Multiple vars
>> - * can be specified as a comma-separated list or alternatively "all" if a wait
>> - * should happen for all cases.
>> + * can be specified as a comma-separated list and assert if "all" is supplied.
>> *
>> * This is useful for display tests where under certain situation manual
>> * inspection of the display is useful. Or when running a testcase in the
>> @@ -1028,7 +1030,7 @@ void igt_debug_wait_for_keypress(const char *var)
>> *
>> * Force test fail when N/n is pressed.
>> */
>> -void igt_debug_manual_check(const char *var, const char *expected)
>> +void igt_debug_interactive_mode_check(const char *var, const char
>*expected)
>> {
>> struct termios oldt, newt;
>> char key;
>> @@ -1041,6 +1043,10 @@ void igt_debug_manual_check(const char *var,
>const char *expected)
>> if (!igt_interactive_debug)
>> return;
>>
>> + if (strstr(igt_interactive_debug, var) &&
>> + strstr(igt_interactive_debug, "all"))
>> + igt_assert(false);
>> +
>> if (!strstr(igt_interactive_debug, var) &&
>> !strstr(igt_interactive_debug, "all"))
>> return;
>> diff --git a/lib/igt_aux.h b/lib/igt_aux.h
>> index bf57ccf5..a92eb799 100644
>> --- a/lib/igt_aux.h
>> +++ b/lib/igt_aux.h
>> @@ -193,7 +193,7 @@ int igt_get_autoresume_delay(enum igt_suspend_state
>state);
>> void igt_drop_root(void);
>>
>> void igt_debug_wait_for_keypress(const char *var);
>> -void igt_debug_manual_check(const char *var, const char *expected);
>> +void igt_debug_interactive_mode_check(const char *var, const char
>*expected);
>>
>> /* sysinfo cross-arch wrappers from intel_os.c */
>>
>> diff --git a/tests/i915/kms_dsc.c b/tests/i915/kms_dsc.c
>> index 3e450207..772687f4 100644
>> --- a/tests/i915/kms_dsc.c
>> +++ b/tests/i915/kms_dsc.c
>> @@ -72,7 +72,7 @@ int force_dsc_restore_fd = -1;
>>
>> static inline void manual(const char *expected)
>> {
>> - igt_debug_manual_check("all", expected);
>> + igt_debug_interactive_mode_check("all", expected);
>> }
>>
>> static void force_dsc_enable(data_t *data)
>> diff --git a/tests/i915/kms_psr.c b/tests/i915/kms_psr.c
>> index 270d3150..24a10676 100644
>> --- a/tests/i915/kms_psr.c
>> +++ b/tests/i915/kms_psr.c
>> @@ -246,7 +246,7 @@ static bool psr_enable_if_enabled(data_t *data)
>>
>> static inline void manual(const char *expected)
>> {
>> - igt_debug_manual_check("all", expected);
>> + igt_debug_interactive_mode_check("all", expected);
>> }
>>
>> static bool drrs_disabled(data_t *data)
>> diff --git a/tests/i915/kms_psr2_sf.c b/tests/i915/kms_psr2_sf.c
>> index 1be8c3da..93347327 100644
>> --- a/tests/i915/kms_psr2_sf.c
>> +++ b/tests/i915/kms_psr2_sf.c
>> @@ -331,7 +331,7 @@ static void prepare(data_t *data)
>>
>> static inline void manual(const char *expected)
>> {
>> - igt_debug_manual_check("all", expected);
>> + igt_debug_interactive_mode_check("all", expected);
>> }
>>
>> static void plane_update_expected_output(int plane_type, int box_count)
>> --
>> 2.19.1
>>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/3] lib/igt_aux: Rename igt_debug_manual_check and assert check if all is supplied
2021-09-22 16:45 ` B, Jeevan
@ 2021-09-22 17:12 ` Petri Latvala
0 siblings, 0 replies; 9+ messages in thread
From: Petri Latvala @ 2021-09-22 17:12 UTC (permalink / raw)
To: B, Jeevan; +Cc: igt-dev, daniel, Souza, Jose
On Wed, Sep 22, 2021 at 07:45:54PM +0300, B, Jeevan wrote:
> >-----Original Message-----
> >From: Latvala, Petri <petri.latvala@intel.com>
> >Sent: Tuesday, September 21, 2021 6:19 PM
> >To: B, Jeevan <jeevan.b@intel.com>
> >Cc: igt-dev@lists.freedesktop.org; daniel@ffwll.ch; Souza, Jose
> ><jose.souza@intel.com>
> >Subject: Re: [igt-dev] [PATCH i-g-t 1/3] lib/igt_aux: Rename
> >igt_debug_manual_check and assert check if all is supplied
> >
> >On Tue, Sep 21, 2021 at 01:27:47PM +0530, Jeevan B wrote:
> >> rename igt_debug_manual_check and patch the igt functions
> >> igt_debug_manual_check() and igt_debug_wait_for_keypress() to assert
> >> if "all" is supplied.
> >
> >Why?
>
> Addressing comments given here. (https://lore.kernel.org/intel-gfx/CAKMK7uE0Hd34fOobDZT27MhOYE1qjXdD1Yzn9C0B+u=RCXLi8w@mail.gmail.com/)
The code changes are doing the opposite though, probaly by mistake.
The point was that calling igt_debug_wait_for_keypress() with "all"
should assert. Executing a test with --interactive-debug=all should
not.
--
Petri Latvala
>
> Thanks
> Jeevan B
> >
> >
> >--
> >Petri Latvala
> >
> >
> >>
> >> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> >> ---
> >> lib/igt_aux.c | 18 ++++++++++++------
> >> lib/igt_aux.h | 2 +-
> >> tests/i915/kms_dsc.c | 2 +-
> >> tests/i915/kms_psr.c | 2 +-
> >> tests/i915/kms_psr2_sf.c | 2 +-
> >> 5 files changed, 16 insertions(+), 10 deletions(-)
> >>
> >> diff --git a/lib/igt_aux.c b/lib/igt_aux.c
> >> index 1217f5e8..96929237 100644
> >> --- a/lib/igt_aux.c
> >> +++ b/lib/igt_aux.c
> >> @@ -971,8 +971,7 @@ void igt_drop_root(void)
> >> *
> >> * Waits for a key press when run interactively and when the corresponding
> >debug
> >> * var is set in the --interactive-debug=$var variable. Multiple keys
> >> - * can be specified as a comma-separated list or alternatively "all" if a wait
> >> - * should happen for all cases.
> >> + * can be specified as a comma-separated list and assert if "all" is supplied.
> >> *
> >> * When not connected to a terminal interactive_debug is ignored
> >> * and execution immediately continues.
> >> @@ -993,6 +992,10 @@ void igt_debug_wait_for_keypress(const char *var)
> >> if (!igt_interactive_debug)
> >> return;
> >>
> >> + if (strstr(igt_interactive_debug, var) &&
> >> + strstr(igt_interactive_debug, "all"))
> >> + igt_assert(false);
> >> +
> >> if (!strstr(igt_interactive_debug, var) &&
> >> !strstr(igt_interactive_debug, "all"))
> >> return;
> >> @@ -1008,14 +1011,13 @@ void igt_debug_wait_for_keypress(const char
> >*var)
> >> }
> >>
> >> /**
> >> - * igt_debug_manual_check:
> >> + * igt_debug_interactive_mode_check:
> >> * @var: var lookup to to enable this wait
> >> * @expected: message to be printed as expected behaviour before wait for
> >keys Y/n
> >> *
> >> * Waits for a key press when run interactively and when the corresponding
> >debug
> >> * var is set in the --interactive-debug=$var variable. Multiple vars
> >> - * can be specified as a comma-separated list or alternatively "all" if a wait
> >> - * should happen for all cases.
> >> + * can be specified as a comma-separated list and assert if "all" is supplied.
> >> *
> >> * This is useful for display tests where under certain situation manual
> >> * inspection of the display is useful. Or when running a testcase in the
> >> @@ -1028,7 +1030,7 @@ void igt_debug_wait_for_keypress(const char *var)
> >> *
> >> * Force test fail when N/n is pressed.
> >> */
> >> -void igt_debug_manual_check(const char *var, const char *expected)
> >> +void igt_debug_interactive_mode_check(const char *var, const char
> >*expected)
> >> {
> >> struct termios oldt, newt;
> >> char key;
> >> @@ -1041,6 +1043,10 @@ void igt_debug_manual_check(const char *var,
> >const char *expected)
> >> if (!igt_interactive_debug)
> >> return;
> >>
> >> + if (strstr(igt_interactive_debug, var) &&
> >> + strstr(igt_interactive_debug, "all"))
> >> + igt_assert(false);
> >> +
> >> if (!strstr(igt_interactive_debug, var) &&
> >> !strstr(igt_interactive_debug, "all"))
> >> return;
> >> diff --git a/lib/igt_aux.h b/lib/igt_aux.h
> >> index bf57ccf5..a92eb799 100644
> >> --- a/lib/igt_aux.h
> >> +++ b/lib/igt_aux.h
> >> @@ -193,7 +193,7 @@ int igt_get_autoresume_delay(enum igt_suspend_state
> >state);
> >> void igt_drop_root(void);
> >>
> >> void igt_debug_wait_for_keypress(const char *var);
> >> -void igt_debug_manual_check(const char *var, const char *expected);
> >> +void igt_debug_interactive_mode_check(const char *var, const char
> >*expected);
> >>
> >> /* sysinfo cross-arch wrappers from intel_os.c */
> >>
> >> diff --git a/tests/i915/kms_dsc.c b/tests/i915/kms_dsc.c
> >> index 3e450207..772687f4 100644
> >> --- a/tests/i915/kms_dsc.c
> >> +++ b/tests/i915/kms_dsc.c
> >> @@ -72,7 +72,7 @@ int force_dsc_restore_fd = -1;
> >>
> >> static inline void manual(const char *expected)
> >> {
> >> - igt_debug_manual_check("all", expected);
> >> + igt_debug_interactive_mode_check("all", expected);
> >> }
> >>
> >> static void force_dsc_enable(data_t *data)
> >> diff --git a/tests/i915/kms_psr.c b/tests/i915/kms_psr.c
> >> index 270d3150..24a10676 100644
> >> --- a/tests/i915/kms_psr.c
> >> +++ b/tests/i915/kms_psr.c
> >> @@ -246,7 +246,7 @@ static bool psr_enable_if_enabled(data_t *data)
> >>
> >> static inline void manual(const char *expected)
> >> {
> >> - igt_debug_manual_check("all", expected);
> >> + igt_debug_interactive_mode_check("all", expected);
> >> }
> >>
> >> static bool drrs_disabled(data_t *data)
> >> diff --git a/tests/i915/kms_psr2_sf.c b/tests/i915/kms_psr2_sf.c
> >> index 1be8c3da..93347327 100644
> >> --- a/tests/i915/kms_psr2_sf.c
> >> +++ b/tests/i915/kms_psr2_sf.c
> >> @@ -331,7 +331,7 @@ static void prepare(data_t *data)
> >>
> >> static inline void manual(const char *expected)
> >> {
> >> - igt_debug_manual_check("all", expected);
> >> + igt_debug_interactive_mode_check("all", expected);
> >> }
> >>
> >> static void plane_update_expected_output(int plane_type, int box_count)
> >> --
> >> 2.19.1
> >>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-09-22 17:08 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-21 7:57 [igt-dev] [PATCH i-g-t 0/3] Fix kms_psr2_sf test and add new test for FB_DAMAGE_CLIPS plane property Jeevan B
2021-09-21 7:57 ` [igt-dev] [PATCH i-g-t 1/3] lib/igt_aux: Rename igt_debug_manual_check and assert check if all is supplied Jeevan B
2021-09-21 12:48 ` Petri Latvala
2021-09-22 16:45 ` B, Jeevan
2021-09-22 17:12 ` Petri Latvala
2021-09-21 7:57 ` [igt-dev] [PATCH i-g-t 2/3] tests/kms_psr2_sf: Make this a generic test and change testcase design Jeevan B
2021-09-21 7:57 ` [igt-dev] [PATCH i-g-t 3/3] tests/kms_atomic: Add a new test case for FB_DAMAGE_CLIPS plane property Jeevan B
2021-09-21 9:01 ` [igt-dev] ✓ Fi.CI.BAT: success for Fix kms_psr2_sf test and add new test " Patchwork
2021-09-21 10:05 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.