All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Jeffle Xu <jefflexu@linux.alibaba.com>
Cc: stefanha@redhat.com, miklos@szeredi.hu,
	linux-fsdevel@vger.kernel.org, virtio-fs@redhat.com,
	bo.liu@linux.alibaba.com, joseph.qi@linux.alibaba.com
Subject: Re: [PATCH v5 1/5] fuse: add fuse_should_enable_dax() helper
Date: Thu, 23 Sep 2021 14:58:52 -0400	[thread overview]
Message-ID: <YUzObLV8SB4EqaTD@redhat.com> (raw)
In-Reply-To: <20210923092526.72341-2-jefflexu@linux.alibaba.com>

On Thu, Sep 23, 2021 at 05:25:22PM +0800, Jeffle Xu wrote:
> This is in prep for following per-file DAX checking.
> 
> Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com>
> ---
>  fs/fuse/dax.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/fuse/dax.c b/fs/fuse/dax.c
> index 281d79f8b3d3..28db96ea23e2 100644
> --- a/fs/fuse/dax.c
> +++ b/fs/fuse/dax.c
> @@ -1330,11 +1330,19 @@ static const struct address_space_operations fuse_dax_file_aops  = {
>  	.invalidatepage	= noop_invalidatepage,
>  };
>  
> -void fuse_dax_inode_init(struct inode *inode)
> +static bool fuse_should_enable_dax(struct inode *inode)
>  {
>  	struct fuse_conn *fc = get_fuse_conn(inode);
>  
>  	if (!fc->dax)
> +		return false;
> +
> +	return true;
> +}

It probably is easier to read if we flip the logic.

{
	if (fc->dax)
		return true;
	return false;
}

> +
> +void fuse_dax_inode_init(struct inode *inode)
> +{
> +	if (!fuse_should_enable_dax(inode))
>  		return;
>  
>  	inode->i_flags |= S_DAX;
> -- 
> 2.27.0
> 


WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com>
To: Jeffle Xu <jefflexu@linux.alibaba.com>
Cc: miklos@szeredi.hu, virtio-fs@redhat.com,
	joseph.qi@linux.alibaba.com, linux-fsdevel@vger.kernel.org
Subject: Re: [Virtio-fs] [PATCH v5 1/5] fuse: add fuse_should_enable_dax() helper
Date: Thu, 23 Sep 2021 14:58:52 -0400	[thread overview]
Message-ID: <YUzObLV8SB4EqaTD@redhat.com> (raw)
In-Reply-To: <20210923092526.72341-2-jefflexu@linux.alibaba.com>

On Thu, Sep 23, 2021 at 05:25:22PM +0800, Jeffle Xu wrote:
> This is in prep for following per-file DAX checking.
> 
> Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com>
> ---
>  fs/fuse/dax.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/fuse/dax.c b/fs/fuse/dax.c
> index 281d79f8b3d3..28db96ea23e2 100644
> --- a/fs/fuse/dax.c
> +++ b/fs/fuse/dax.c
> @@ -1330,11 +1330,19 @@ static const struct address_space_operations fuse_dax_file_aops  = {
>  	.invalidatepage	= noop_invalidatepage,
>  };
>  
> -void fuse_dax_inode_init(struct inode *inode)
> +static bool fuse_should_enable_dax(struct inode *inode)
>  {
>  	struct fuse_conn *fc = get_fuse_conn(inode);
>  
>  	if (!fc->dax)
> +		return false;
> +
> +	return true;
> +}

It probably is easier to read if we flip the logic.

{
	if (fc->dax)
		return true;
	return false;
}

> +
> +void fuse_dax_inode_init(struct inode *inode)
> +{
> +	if (!fuse_should_enable_dax(inode))
>  		return;
>  
>  	inode->i_flags |= S_DAX;
> -- 
> 2.27.0
> 


  reply	other threads:[~2021-09-23 18:59 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-23  9:25 [PATCH v5 0/5] fuse,virtiofs: support per-file DAX Jeffle Xu
2021-09-23  9:25 ` [Virtio-fs] " Jeffle Xu
2021-09-23  9:25 ` [PATCH v5 1/5] fuse: add fuse_should_enable_dax() helper Jeffle Xu
2021-09-23  9:25   ` [Virtio-fs] " Jeffle Xu
2021-09-23 18:58   ` Vivek Goyal [this message]
2021-09-23 18:58     ` Vivek Goyal
2021-09-23  9:25 ` [PATCH v5 2/5] fuse: make DAX mount option a tri-state Jeffle Xu
2021-09-23  9:25   ` [Virtio-fs] " Jeffle Xu
2021-09-23 19:02   ` Vivek Goyal
2021-09-23 19:02     ` [Virtio-fs] " Vivek Goyal
2021-09-23 22:26     ` Dave Chinner
2021-09-23 22:26       ` [Virtio-fs] " Dave Chinner
2021-09-24  1:02       ` Vivek Goyal
2021-09-24  1:02         ` [Virtio-fs] " Vivek Goyal
2021-09-24  3:06         ` JeffleXu
2021-09-24  3:06           ` [Virtio-fs] " JeffleXu
2021-09-24 12:43           ` Vivek Goyal
2021-09-24 12:43             ` [Virtio-fs] " Vivek Goyal
2021-09-26  2:06             ` JeffleXu
2021-09-26  2:06               ` [Virtio-fs] " JeffleXu
2021-09-27  0:21         ` Dave Chinner
2021-09-27  0:21           ` [Virtio-fs] " Dave Chinner
2021-09-27  2:28           ` JeffleXu
2021-09-27  2:28             ` [Virtio-fs] " JeffleXu
2021-09-28  3:44             ` Dave Chinner
2021-09-28  3:44               ` [Virtio-fs] " Dave Chinner
2021-09-28  5:17               ` JeffleXu
2021-09-28  5:17                 ` [Virtio-fs] " JeffleXu
2021-09-28 14:34                 ` Vivek Goyal
2021-09-28 14:34                   ` [Virtio-fs] " Vivek Goyal
2021-09-27 15:32           ` Vivek Goyal
2021-09-27 15:32             ` [Virtio-fs] " Vivek Goyal
2021-09-28  3:23             ` Dave Chinner
2021-09-28  3:23               ` [Virtio-fs] " Dave Chinner
2021-09-23  9:25 ` [PATCH v5 3/5] fuse: support per-file DAX Jeffle Xu
2021-09-23  9:25   ` [Virtio-fs] " Jeffle Xu
2021-09-23  9:25 ` [PATCH v5 4/5] fuse: enable " Jeffle Xu
2021-09-23  9:25   ` [Virtio-fs] " Jeffle Xu
2021-09-23  9:25 ` [PATCH v5 5/5] fuse: mark inode DONT_CACHE when per-file DAX hint changes Jeffle Xu
2021-09-23  9:25   ` [Virtio-fs] " Jeffle Xu
2021-09-23  9:35 ` [virtiofsd PATCH v5 0/2] virtiofsd: support per-file DAX Jeffle Xu
2021-09-23  9:35   ` [Virtio-fs] " Jeffle Xu
2021-09-23  9:35   ` [virtiofsd PATCH v5 1/2] virtiofsd: add FUSE_ATTR_DAX to fuse protocol Jeffle Xu
2021-09-23  9:35     ` [Virtio-fs] " Jeffle Xu
2021-09-23  9:35   ` [virtiofsd PATCH v5 2/2] virtiofsd: support per-file DAX Jeffle Xu
2021-09-23  9:35     ` [Virtio-fs] " Jeffle Xu
2021-09-23 18:57 ` [PATCH v5 0/5] fuse,virtiofs: " Vivek Goyal
2021-09-23 18:57   ` [Virtio-fs] " Vivek Goyal
2021-10-27  3:42   ` JeffleXu
2021-10-27  3:42     ` [Virtio-fs] " JeffleXu
2021-10-27 14:45     ` Vivek Goyal
2021-10-27 14:45       ` [Virtio-fs] " Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YUzObLV8SB4EqaTD@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=bo.liu@linux.alibaba.com \
    --cc=jefflexu@linux.alibaba.com \
    --cc=joseph.qi@linux.alibaba.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=stefanha@redhat.com \
    --cc=virtio-fs@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.