All of lore.kernel.org
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Taylor Blau <me@ttaylorr.com>, Derrick Stolee <stolee@gmail.com>,
	Eric Wong <e@80x24.org>,
	git@vger.kernel.org, Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH] doc/technical: remove outdated MIDX default note
Date: Thu, 23 Sep 2021 16:32:58 -0400	[thread overview]
Message-ID: <YUzketzIpMqI8wbE@nand.local> (raw)
In-Reply-To: <xmqq8rznyr4c.fsf@gitster.g>

On Thu, Sep 23, 2021 at 01:27:31PM -0700, Junio C Hamano wrote:
> Taylor Blau <me@ttaylorr.com> writes:
>
> > On Thu, Sep 23, 2021 at 09:47:03AM -0400, Derrick Stolee wrote:
> >> On 9/22/2021 6:13 PM, Eric Wong wrote:
> >> > Multi-pack-index files are used by default since
> >> > commit 18e449f86b74bab35b150549c8342d252fe7ae00, so the
> >> > outdated note was misleading.
> >>
> >> You are correct that the note is misleading, but it is still correct.
> >>
> >> A user can _disable_ reading MIDX files by setting core.multiPackIndex
> >> to false. If this was in the user-facing docs, not the technical docs,
> >> then I might push back on trying to make that distinction.
> >
> > It may present a fuller picture to instead say:
> >
> >   The core.multiPackIndex config setting must be on (which is the default)
> >   to consume MIDX files. Setting it to `false` prevents Git from reading a
> >   MIDX file, even if one exists.
>
> Do you want to replace the one-line sentence with that paragraph,
> instead of removing it, in a replacement patch?

That's what I was hoping for, and Eric did that here:

    https://lore.kernel.org/git/20210923201252.GA25980@dcvr/

Thanks,
Taylor

      reply	other threads:[~2021-09-23 20:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-22 22:13 [PATCH] doc/technical: remove outdated MIDX default note Eric Wong
2021-09-23 13:47 ` Derrick Stolee
2021-09-23 17:45   ` Taylor Blau
2021-09-23 20:12     ` [PATCH v2] doc/technical: update note about core.multiPackIndex Eric Wong
2021-09-23 20:21       ` Taylor Blau
2021-09-24 11:11       ` [PATCH v3] " Eric Wong
2021-09-25 17:17         ` Derrick Stolee
2021-09-23 20:27     ` [PATCH] doc/technical: remove outdated MIDX default note Junio C Hamano
2021-09-23 20:32       ` Taylor Blau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YUzketzIpMqI8wbE@nand.local \
    --to=me@ttaylorr.com \
    --cc=dstolee@microsoft.com \
    --cc=e@80x24.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.