All of lore.kernel.org
 help / color / mirror / Atom feed
From: Derrick Stolee <stolee@gmail.com>
To: Eric Wong <e@80x24.org>, Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Derrick Stolee <dstolee@microsoft.com>,
	Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH v3] doc/technical: update note about core.multiPackIndex
Date: Sat, 25 Sep 2021 13:17:56 -0400	[thread overview]
Message-ID: <be95aff9-b2e4-c3b8-a32a-375a3053fdfb@gmail.com> (raw)
In-Reply-To: <20210924111136.GA15127@dcvr>

On 9/24/2021 7:11 AM, Eric Wong wrote:
> MIDX files are used by default since commit 18e449f86b74
> (midx: enable core.multiPackIndex by default, 2020-09-25)
> 
> Helped-by: Taylor Blau <me@ttaylorr.com>
> Signed-off-by: Eric Wong <e@80x24.org>
> ---
>  v3: I cited the wrong commit in the commit message of v2 :x

Good catch.
 
>  Documentation/technical/multi-pack-index.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/technical/multi-pack-index.txt b/Documentation/technical/multi-pack-index.txt
> index 1a73c3ee203e..86f40f24909a 100644
> --- a/Documentation/technical/multi-pack-index.txt
> +++ b/Documentation/technical/multi-pack-index.txt
> @@ -36,7 +36,9 @@ Design Details
>    directory of an alternate. It refers only to packfiles in that
>    same directory.
>  
> -- The core.multiPackIndex config setting must be on to consume MIDX files.
> +- The core.multiPackIndex config setting must be on (which is the
> +  default) to consume MIDX files.  Setting it to `false` prevents
> +  Git from reading a MIDX file, even if one exists.
>  
>  - The file format includes parameters for the object ID hash
>    function, so a future change of hash algorithm does not require

This looks good to me, too!

Thanks,
-Stolee

  reply	other threads:[~2021-09-25 17:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-22 22:13 [PATCH] doc/technical: remove outdated MIDX default note Eric Wong
2021-09-23 13:47 ` Derrick Stolee
2021-09-23 17:45   ` Taylor Blau
2021-09-23 20:12     ` [PATCH v2] doc/technical: update note about core.multiPackIndex Eric Wong
2021-09-23 20:21       ` Taylor Blau
2021-09-24 11:11       ` [PATCH v3] " Eric Wong
2021-09-25 17:17         ` Derrick Stolee [this message]
2021-09-23 20:27     ` [PATCH] doc/technical: remove outdated MIDX default note Junio C Hamano
2021-09-23 20:32       ` Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be95aff9-b2e4-c3b8-a32a-375a3053fdfb@gmail.com \
    --to=stolee@gmail.com \
    --cc=dstolee@microsoft.com \
    --cc=e@80x24.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=me@ttaylorr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.