[PATCH] clk: imx: Make CLK_IMX8ULP select MXC_CLK

[PATCH] clk: imx: Make CLK_IMX8ULP select MXC_CLK

[Fabio Estevam]

Building CLK_IMX8ULP without selecting MXC_CLK causes the following
build errors:

ld: drivers/clk/imx/clk-imx8ulp.o: in function `imx8ulp_clk_cgc2_init':
clk-imx8ulp.c:(.text+0xd0): undefined reference to `imx_ccm_lock'
ld: clk-imx8ulp.c:(.text+0x14f): undefined reference to `imx_clk_hw_pllv4'
ld: clk-imx8ulp.c:(.text+0x15a): undefined reference to `imx_ccm_lock'

Avoid this problem by making CLK_IMX8ULP select MXC_CLK.

Fixes: c43a801a5789 ("clk: imx: Add clock driver for imx8ulp")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 drivers/clk/imx/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
index b81d6437ed95..c08edbd04d22 100644
--- a/drivers/clk/imx/Kconfig
+++ b/drivers/clk/imx/Kconfig
@@ -102,5 +102,6 @@ config CLK_IMX8QXP
 config CLK_IMX8ULP
 	tristate "IMX8ULP CCM Clock Driver"
 	depends on ARCH_MXC || COMPILE_TEST
+	select MXC_CLK
 	help
 	    Build the driver for i.MX8ULP CCM Clock Driver
-- 
2.25.1

Re: [PATCH] clk: imx: Make CLK_IMX8ULP select MXC_CLK

[Randy Dunlap]

On 10/6/21 12:00 PM, Fabio Estevam wrote:
> Building CLK_IMX8ULP without selecting MXC_CLK causes the following
> build errors:
> 
> ld: drivers/clk/imx/clk-imx8ulp.o: in function `imx8ulp_clk_cgc2_init':
> clk-imx8ulp.c:(.text+0xd0): undefined reference to `imx_ccm_lock'
> ld: clk-imx8ulp.c:(.text+0x14f): undefined reference to `imx_clk_hw_pllv4'
> ld: clk-imx8ulp.c:(.text+0x15a): undefined reference to `imx_ccm_lock'
> 
> Avoid this problem by making CLK_IMX8ULP select MXC_CLK.
> 
> Fixes: c43a801a5789 ("clk: imx: Add clock driver for imx8ulp")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

Thanks.

> ---
>   drivers/clk/imx/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
> index b81d6437ed95..c08edbd04d22 100644
> --- a/drivers/clk/imx/Kconfig
> +++ b/drivers/clk/imx/Kconfig
> @@ -102,5 +102,6 @@ config CLK_IMX8QXP
>   config CLK_IMX8ULP
>   	tristate "IMX8ULP CCM Clock Driver"
>   	depends on ARCH_MXC || COMPILE_TEST
> +	select MXC_CLK
>   	help
>   	    Build the driver for i.MX8ULP CCM Clock Driver
> 


-- 
~Randy

Re: [PATCH] clk: imx: Make CLK_IMX8ULP select MXC_CLK

[Abel Vesa]

On 21-10-06 16:00:08, Fabio Estevam wrote:
> Building CLK_IMX8ULP without selecting MXC_CLK causes the following
> build errors:
> 
> ld: drivers/clk/imx/clk-imx8ulp.o: in function `imx8ulp_clk_cgc2_init':
> clk-imx8ulp.c:(.text+0xd0): undefined reference to `imx_ccm_lock'
> ld: clk-imx8ulp.c:(.text+0x14f): undefined reference to `imx_clk_hw_pllv4'
> ld: clk-imx8ulp.c:(.text+0x15a): undefined reference to `imx_ccm_lock'
> 
> Avoid this problem by making CLK_IMX8ULP select MXC_CLK.
> 
> Fixes: c43a801a5789 ("clk: imx: Add clock driver for imx8ulp")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Reviewed-by: Abel Vesa <abel.vesa@nxp.com>

Good catch, Randy.

Thanks for the fix, Fabio.

> ---
>  drivers/clk/imx/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
> index b81d6437ed95..c08edbd04d22 100644
> --- a/drivers/clk/imx/Kconfig
> +++ b/drivers/clk/imx/Kconfig
> @@ -102,5 +102,6 @@ config CLK_IMX8QXP
>  config CLK_IMX8ULP
>  	tristate "IMX8ULP CCM Clock Driver"
>  	depends on ARCH_MXC || COMPILE_TEST
> +	select MXC_CLK
>  	help
>  	    Build the driver for i.MX8ULP CCM Clock Driver
> -- 
> 2.25.1
> 

Re: [PATCH] clk: imx: Make CLK_IMX8ULP select MXC_CLK

[Abel Vesa]

On 21-10-06 16:00:08, Fabio Estevam wrote:
> Building CLK_IMX8ULP without selecting MXC_CLK causes the following
> build errors:
> 
> ld: drivers/clk/imx/clk-imx8ulp.o: in function `imx8ulp_clk_cgc2_init':
> clk-imx8ulp.c:(.text+0xd0): undefined reference to `imx_ccm_lock'
> ld: clk-imx8ulp.c:(.text+0x14f): undefined reference to `imx_clk_hw_pllv4'
> ld: clk-imx8ulp.c:(.text+0x15a): undefined reference to `imx_ccm_lock'
> 
> Avoid this problem by making CLK_IMX8ULP select MXC_CLK.
> 
> Fixes: c43a801a5789 ("clk: imx: Add clock driver for imx8ulp")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Applied with Randy's ack and my R-b tag. Thanks.

> ---
>  drivers/clk/imx/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
> index b81d6437ed95..c08edbd04d22 100644
> --- a/drivers/clk/imx/Kconfig
> +++ b/drivers/clk/imx/Kconfig
> @@ -102,5 +102,6 @@ config CLK_IMX8QXP
>  config CLK_IMX8ULP
>  	tristate "IMX8ULP CCM Clock Driver"
>  	depends on ARCH_MXC || COMPILE_TEST
> +	select MXC_CLK
>  	help
>  	    Build the driver for i.MX8ULP CCM Clock Driver
> -- 
> 2.25.1
>