* [PATCH] spapr/xive: Use xive_esb_rw() to trigger interrupts
@ 2021-10-06 21:05 Cédric Le Goater
2021-10-07 0:47 ` David Gibson
0 siblings, 1 reply; 2+ messages in thread
From: Cédric Le Goater @ 2021-10-06 21:05 UTC (permalink / raw)
To: David Gibson, Greg Kurz; +Cc: qemu-ppc, qemu-devel, Cédric Le Goater
xive_esb_rw() is the common routine used for memory accesses on ESB
page. Use it for triggers also.
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
hw/intc/spapr_xive_kvm.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/intc/spapr_xive_kvm.c b/hw/intc/spapr_xive_kvm.c
index 630a719d578e..2f79950a644e 100644
--- a/hw/intc/spapr_xive_kvm.c
+++ b/hw/intc/spapr_xive_kvm.c
@@ -318,9 +318,7 @@ static uint8_t xive_esb_read(XiveSource *xsrc, int srcno, uint32_t offset)
static void kvmppc_xive_esb_trigger(XiveSource *xsrc, int srcno)
{
- uint64_t *addr = xsrc->esb_mmap + xive_source_esb_page(xsrc, srcno);
-
- *addr = 0x0;
+ xive_esb_rw(xsrc, srcno, 0, 0, true);
}
uint64_t kvmppc_xive_esb_rw(XiveSource *xsrc, int srcno, uint32_t offset,
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] spapr/xive: Use xive_esb_rw() to trigger interrupts
2021-10-06 21:05 [PATCH] spapr/xive: Use xive_esb_rw() to trigger interrupts Cédric Le Goater
@ 2021-10-07 0:47 ` David Gibson
0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2021-10-07 0:47 UTC (permalink / raw)
To: Cédric Le Goater; +Cc: qemu-ppc, Greg Kurz, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1155 bytes --]
On Wed, Oct 06, 2021 at 11:05:46PM +0200, Cédric Le Goater wrote:
> xive_esb_rw() is the common routine used for memory accesses on ESB
> page. Use it for triggers also.
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
Applied to ppc-fot-6.2, thanks.
> ---
> hw/intc/spapr_xive_kvm.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/intc/spapr_xive_kvm.c b/hw/intc/spapr_xive_kvm.c
> index 630a719d578e..2f79950a644e 100644
> --- a/hw/intc/spapr_xive_kvm.c
> +++ b/hw/intc/spapr_xive_kvm.c
> @@ -318,9 +318,7 @@ static uint8_t xive_esb_read(XiveSource *xsrc, int srcno, uint32_t offset)
>
> static void kvmppc_xive_esb_trigger(XiveSource *xsrc, int srcno)
> {
> - uint64_t *addr = xsrc->esb_mmap + xive_source_esb_page(xsrc, srcno);
> -
> - *addr = 0x0;
> + xive_esb_rw(xsrc, srcno, 0, 0, true);
> }
>
> uint64_t kvmppc_xive_esb_rw(XiveSource *xsrc, int srcno, uint32_t offset,
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-07 0:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-06 21:05 [PATCH] spapr/xive: Use xive_esb_rw() to trigger interrupts Cédric Le Goater
2021-10-07 0:47 ` David Gibson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.