All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dove: mark 'putc' as inline
@ 2021-09-27  9:53 ` Arnd Bergmann
  2021-09-27 12:40     ` Andrew Lunn
  2021-10-05 13:50   ` patchwork-bot+linux-soc
  0 siblings, 2 replies; 4+ messages in thread
From: Arnd Bergmann @ 2021-09-27  9:53 UTC (permalink / raw)
  To: soc, Andrew Lunn, Sebastian Hesselbarth, Gregory Clement
  Cc: Arnd Bergmann, linux-arm-kernel, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

This can cause a randconfig warning without the 'inline' flag
that every other platform uses:

In file included from arch/arm/boot/compressed/misc.c:29:
arch/arm/mach-dove/include/mach/uncompress.h:14:13: error: 'putc' defined but not used [-Werror=unused-function]
   14 | static void putc(const char c)
      |             ^~~~

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/mach-dove/include/mach/uncompress.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-dove/include/mach/uncompress.h b/arch/arm/mach-dove/include/mach/uncompress.h
index 7a4bd8838036..ddf873f35e2b 100644
--- a/arch/arm/mach-dove/include/mach/uncompress.h
+++ b/arch/arm/mach-dove/include/mach/uncompress.h
@@ -11,7 +11,7 @@
 
 #define LSR_THRE	0x20
 
-static void putc(const char c)
+static inline void putc(const char c)
 {
 	int i;
 
@@ -24,7 +24,7 @@ static void putc(const char c)
 	*UART_THR = c;
 }
 
-static void flush(void)
+static inline void flush(void)
 {
 }
 
-- 
2.29.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] dove: mark 'putc' as inline
@ 2021-09-27 12:40     ` Andrew Lunn
  0 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2021-09-27 12:40 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: soc, Sebastian Hesselbarth, Gregory Clement, Arnd Bergmann,
	linux-arm-kernel, linux-kernel

On Mon, Sep 27, 2021 at 11:53:33AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> This can cause a randconfig warning without the 'inline' flag
> that every other platform uses:
> 
> In file included from arch/arm/boot/compressed/misc.c:29:
> arch/arm/mach-dove/include/mach/uncompress.h:14:13: error: 'putc' defined but not used [-Werror=unused-function]
>    14 | static void putc(const char c)
>       |             ^~~~
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dove: mark 'putc' as inline
@ 2021-09-27 12:40     ` Andrew Lunn
  0 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2021-09-27 12:40 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: soc, Sebastian Hesselbarth, Gregory Clement, Arnd Bergmann,
	linux-arm-kernel, linux-kernel

On Mon, Sep 27, 2021 at 11:53:33AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> This can cause a randconfig warning without the 'inline' flag
> that every other platform uses:
> 
> In file included from arch/arm/boot/compressed/misc.c:29:
> arch/arm/mach-dove/include/mach/uncompress.h:14:13: error: 'putc' defined but not used [-Werror=unused-function]
>    14 | static void putc(const char c)
>       |             ^~~~
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dove: mark 'putc' as inline
  2021-09-27  9:53 ` Arnd Bergmann
  2021-09-27 12:40     ` Andrew Lunn
@ 2021-10-05 13:50   ` patchwork-bot+linux-soc
  1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+linux-soc @ 2021-10-05 13:50 UTC (permalink / raw)
  To: Arnd Bergmann; +Cc: soc

Hello:

This patch was applied to soc/soc.git (refs/heads/arm/fixes):

On Mon, 27 Sep 2021 11:53:33 +0200 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> This can cause a randconfig warning without the 'inline' flag
> that every other platform uses:
> 
> In file included from arch/arm/boot/compressed/misc.c:29:
> arch/arm/mach-dove/include/mach/uncompress.h:14:13: error: 'putc' defined but not used [-Werror=unused-function]
>    14 | static void putc(const char c)
>       |             ^~~~
> 
> [...]

Here is the summary with links:
  - dove: mark 'putc' as inline
    https://git.kernel.org/soc/soc/c/b9af50bcbcd2

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-10-05 13:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-27  9:53 [PATCH] dove: mark 'putc' as inline Arnd Bergmann
2021-09-27  9:53 ` Arnd Bergmann
2021-09-27 12:40   ` Andrew Lunn
2021-09-27 12:40     ` Andrew Lunn
2021-10-05 13:50   ` patchwork-bot+linux-soc

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.