* [igt-dev] [PATCH] tests/kms_addfb_basic: Remove handling for Unknown Vendor.
@ 2021-09-24 18:55 Mark Yacoub
2021-09-24 20:18 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Mark Yacoub @ 2021-09-24 18:55 UTC (permalink / raw)
To: igt-dev
Cc: seanpaul, petri.latvala, arek, Rodrigo.Siqueira, anson.jacob,
abhinavk, robdclark, Mark Yacoub, Mark Yacoub
From: Mark Yacoub <markyacoub@google.com>
[Why]
Looking at multiple drivers such as i915, amdgpu, and msm, EINVAL is the
standard errno when failing some fb errors.
Unless it's an exception like nouveau, every driver should act in a
standard manner and return EINVAL just like every other driver. Hence,
no special handling for unknown vendor is needed.
[How]
Remove asserts for specific drivers except for a known exception.
Tested on ChromeOS Trogdor(msm).
Signed-off-by: Mark Yacoub <markyacoub@chromium.org>
---
tests/kms_addfb_basic.c | 26 +++++++-------------------
1 file changed, 7 insertions(+), 19 deletions(-)
diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
index 082f10ee..35c2ae2c 100644
--- a/tests/kms_addfb_basic.c
+++ b/tests/kms_addfb_basic.c
@@ -307,17 +307,10 @@ static void pitch_tests(int fd)
igt_subtest_f("bad-pitch-%i", bad_pitches[i]) {
f.pitches[0] = bad_pitches[i];
igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &f), -1);
- igt_assert(errno != 0);
- if (is_i915_device(fd) || is_amdgpu_device(fd) || is_msm_device(fd)) {
+ if (is_nouveau_device(fd) && bad_pitches[i] > 4 * 1024)
+ igt_assert_eq(errno, ERANGE);
+ else
igt_assert_eq(errno, EINVAL);
- } else if (is_nouveau_device(fd)) {
- if (bad_pitches[i] > 4 * 1024)
- igt_assert_eq(errno, ERANGE);
- else
- igt_assert_eq(errno, EINVAL);
- } else {
- igt_info("Unknown vendor; errno unchecked (returned %i)", errno);
- }
errno = 0;
}
}
@@ -479,13 +472,10 @@ static void size_tests(int fd)
for (i = 0; i < ARRAY_SIZE(framebuffers); i++) {
igt_debug("Checking framebuffer %i\n", i);
igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, framebuffers[i]), -1);
- igt_assert(errno != 0);
- if (is_i915_device(fd))
- igt_assert_eq(errno, EINVAL);
- else if (is_nouveau_device(fd))
+ if (is_nouveau_device(fd))
igt_assert_eq(errno, ERANGE);
else
- igt_info("Unknown vendor; errno unchecked (returned %i)", errno);
+ igt_assert_eq(errno, EINVAL);
errno = 0;
}
}
@@ -495,12 +485,10 @@ static void size_tests(int fd)
igt_subtest("bo-too-small") {
igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &f), -1);
igt_assert(errno != 0);
- if (is_i915_device(fd))
- igt_assert_eq(errno, EINVAL);
- else if (is_nouveau_device(fd))
+ if (is_nouveau_device(fd))
igt_assert_eq(errno, ERANGE);
else
- igt_info("Unknown vendor; errno unchecked (returned %i)", errno);
+ igt_assert_eq(errno, EINVAL);
errno = 0;
}
--
2.33.0.685.g46640cef36-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_addfb_basic: Remove handling for Unknown Vendor.
2021-09-24 18:55 [igt-dev] [PATCH] tests/kms_addfb_basic: Remove handling for Unknown Vendor Mark Yacoub
@ 2021-09-24 20:18 ` Patchwork
2021-09-25 0:27 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-09-27 13:00 ` [igt-dev] [PATCH] " Petri Latvala
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2021-09-24 20:18 UTC (permalink / raw)
To: Mark Yacoub; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 7239 bytes --]
== Series Details ==
Series: tests/kms_addfb_basic: Remove handling for Unknown Vendor.
URL : https://patchwork.freedesktop.org/series/95037/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10641 -> IGTPW_6261
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/index.html
Known issues
------------
Here are the changes found in IGTPW_6261 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@query-info:
- fi-bsw-kefka: NOTRUN -> [SKIP][1] ([fdo#109271]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/fi-bsw-kefka/igt@amdgpu/amd_basic@query-info.html
* igt@gem_exec_suspend@basic-s0:
- fi-tgl-u2: [PASS][2] -> [FAIL][3] ([i915#1888])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html
* igt@i915_selftest@live@gt_timelines:
- fi-rkl-guc: [PASS][4] -> [INCOMPLETE][5] ([i915#4034])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/fi-rkl-guc/igt@i915_selftest@live@gt_timelines.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/fi-rkl-guc/igt@i915_selftest@live@gt_timelines.html
* igt@kms_flip@basic-flip-vs-dpms:
- fi-kbl-8809g: NOTRUN -> [SKIP][6] ([fdo#109271]) +4 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/fi-kbl-8809g/igt@kms_flip@basic-flip-vs-dpms.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
- fi-kbl-8809g: [PASS][7] -> [SKIP][8] ([fdo#109271]) +15 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/fi-kbl-8809g/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/fi-kbl-8809g/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-kbl-8809g: [PASS][9] -> [SKIP][10] ([fdo#109271] / [i915#533])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/fi-kbl-8809g/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/fi-kbl-8809g/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@runner@aborted:
- fi-rkl-guc: NOTRUN -> [FAIL][11] ([i915#3928])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/fi-rkl-guc/igt@runner@aborted.html
#### Possible fixes ####
* igt@core_hotunplug@unbind-rebind:
- fi-kbl-8809g: [INCOMPLETE][12] ([i915#4130]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/fi-kbl-8809g/igt@core_hotunplug@unbind-rebind.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/fi-kbl-8809g/igt@core_hotunplug@unbind-rebind.html
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-1115g4: [FAIL][14] ([i915#1888]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html
* igt@i915_module_load@reload:
- {fi-tgl-dsi}: [DMESG-WARN][16] ([i915#1982] / [i915#4136]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/fi-tgl-dsi/igt@i915_module_load@reload.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/fi-tgl-dsi/igt@i915_module_load@reload.html
* igt@i915_selftest@live@execlists:
- fi-bsw-kefka: [INCOMPLETE][18] ([i915#2940]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
* igt@kms_addfb_basic@bad-pitch-65536:
- fi-kbl-8809g: [FAIL][20] -> [PASS][21] +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/fi-kbl-8809g/igt@kms_addfb_basic@bad-pitch-65536.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/fi-kbl-8809g/igt@kms_addfb_basic@bad-pitch-65536.html
* igt@kms_addfb_basic@too-high:
- fi-kbl-8809g: [FAIL][22] ([i915#2774]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/fi-kbl-8809g/igt@kms_addfb_basic@too-high.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/fi-kbl-8809g/igt@kms_addfb_basic@too-high.html
* igt@kms_addfb_basic@unused-modifier:
- fi-kbl-8809g: [SKIP][24] ([fdo#109271]) -> [PASS][25] +18 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/fi-kbl-8809g/igt@kms_addfb_basic@unused-modifier.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/fi-kbl-8809g/igt@kms_addfb_basic@unused-modifier.html
* igt@kms_force_connector_basic@force-connector-state:
- fi-kbl-8809g: [DMESG-FAIL][26] -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/fi-kbl-8809g/igt@kms_force_connector_basic@force-connector-state.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/fi-kbl-8809g/igt@kms_force_connector_basic@force-connector-state.html
* igt@kms_force_connector_basic@force-edid:
- fi-kbl-8809g: [CRASH][28] -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/fi-kbl-8809g/igt@kms_force_connector_basic@force-edid.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/fi-kbl-8809g/igt@kms_force_connector_basic@force-edid.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2774]: https://gitlab.freedesktop.org/drm/intel/issues/2774
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#3928]: https://gitlab.freedesktop.org/drm/intel/issues/3928
[i915#4034]: https://gitlab.freedesktop.org/drm/intel/issues/4034
[i915#4130]: https://gitlab.freedesktop.org/drm/intel/issues/4130
[i915#4136]: https://gitlab.freedesktop.org/drm/intel/issues/4136
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Participating hosts (40 -> 34)
------------------------------
Missing (6): bat-dg1-6 bat-dg1-5 fi-bsw-cyan bat-adlp-4 fi-bdw-samus bat-jsl-1
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6218 -> IGTPW_6261
CI-20190529: 20190529
CI_DRM_10641: 7ed675211034f2d6fd57c0e6388081d5d008e2d4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6261: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/index.html
IGT_6218: 8d4169d9543d8e5c01f0c746f603801a4d65ead0 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/index.html
[-- Attachment #2: Type: text/html, Size: 8579 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_addfb_basic: Remove handling for Unknown Vendor.
2021-09-24 18:55 [igt-dev] [PATCH] tests/kms_addfb_basic: Remove handling for Unknown Vendor Mark Yacoub
2021-09-24 20:18 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2021-09-25 0:27 ` Patchwork
2021-09-27 13:00 ` [igt-dev] [PATCH] " Petri Latvala
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2021-09-25 0:27 UTC (permalink / raw)
To: Mark Yacoub; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 30276 bytes --]
== Series Details ==
Series: tests/kms_addfb_basic: Remove handling for Unknown Vendor.
URL : https://patchwork.freedesktop.org/series/95037/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10641_full -> IGTPW_6261_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/index.html
Known issues
------------
Here are the changes found in IGTPW_6261_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-massive:
- shard-kbl: NOTRUN -> [DMESG-WARN][1] ([i915#3002])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-kbl4/igt@gem_create@create-massive.html
- shard-glk: NOTRUN -> [DMESG-WARN][2] ([i915#3002])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-glk4/igt@gem_create@create-massive.html
* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-tglb: [PASS][3] -> [INCOMPLETE][4] ([i915#456])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/shard-tglb1/igt@gem_ctx_isolation@preservation-s3@bcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb7/igt@gem_ctx_isolation@preservation-s3@bcs0.html
* igt@gem_ctx_persistence@engines-queued:
- shard-snb: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#1099]) +4 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-snb5/igt@gem_ctx_persistence@engines-queued.html
* igt@gem_ctx_persistence@many-contexts:
- shard-tglb: [PASS][6] -> [FAIL][7] ([i915#2410])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/shard-tglb3/igt@gem_ctx_persistence@many-contexts.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb5/igt@gem_ctx_persistence@many-contexts.html
* igt@gem_ctx_sseu@engines:
- shard-tglb: NOTRUN -> [SKIP][8] ([i915#280])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb8/igt@gem_ctx_sseu@engines.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-tglb: [PASS][9] -> [FAIL][10] ([i915#2842])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/shard-tglb6/igt@gem_exec_fair@basic-none-share@rcs0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb2/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-tglb: NOTRUN -> [FAIL][11] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb1/igt@gem_exec_fair@basic-none-vip@rcs0.html
- shard-glk: [PASS][12] -> [FAIL][13] ([i915#2842])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/shard-glk5/igt@gem_exec_fair@basic-none-vip@rcs0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-glk1/igt@gem_exec_fair@basic-none-vip@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][14] ([i915#2842])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-iclb2/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [PASS][15] -> [FAIL][16] ([i915#2842]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/shard-kbl7/igt@gem_exec_fair@basic-pace@vecs0.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-kbl2/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [PASS][17] -> [FAIL][18] ([i915#2849])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/shard-iclb4/igt@gem_exec_fair@basic-throttle@rcs0.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-iclb5/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_huc_copy@huc-copy:
- shard-apl: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#2190])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-apl7/igt@gem_huc_copy@huc-copy.html
* igt@gem_pread@exhaustion:
- shard-tglb: NOTRUN -> [WARN][20] ([i915#2658])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb6/igt@gem_pread@exhaustion.html
- shard-glk: NOTRUN -> [WARN][21] ([i915#2658])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-glk2/igt@gem_pread@exhaustion.html
- shard-iclb: NOTRUN -> [WARN][22] ([i915#2658])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-iclb5/igt@gem_pread@exhaustion.html
- shard-kbl: NOTRUN -> [WARN][23] ([i915#2658])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-kbl7/igt@gem_pread@exhaustion.html
* igt@gem_render_copy@x-tiled-to-vebox-yf-tiled:
- shard-kbl: NOTRUN -> [SKIP][24] ([fdo#109271]) +164 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-kbl6/igt@gem_render_copy@x-tiled-to-vebox-yf-tiled.html
* igt@gem_userptr_blits@create-destroy-unsync:
- shard-tglb: NOTRUN -> [SKIP][25] ([i915#3297])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb2/igt@gem_userptr_blits@create-destroy-unsync.html
- shard-iclb: NOTRUN -> [SKIP][26] ([i915#3297])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-iclb4/igt@gem_userptr_blits@create-destroy-unsync.html
* igt@gen9_exec_parse@bb-start-param:
- shard-tglb: NOTRUN -> [SKIP][27] ([i915#2856]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb5/igt@gen9_exec_parse@bb-start-param.html
- shard-iclb: NOTRUN -> [SKIP][28] ([i915#2856]) +2 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-iclb1/igt@gen9_exec_parse@bb-start-param.html
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-tglb: NOTRUN -> [SKIP][29] ([i915#1904])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb5/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-kbl: NOTRUN -> [SKIP][30] ([fdo#109271] / [i915#1937])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-kbl2/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html
- shard-apl: NOTRUN -> [SKIP][31] ([fdo#109271] / [i915#1937])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-apl8/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- shard-glk: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#1937])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-glk9/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-tglb: NOTRUN -> [SKIP][33] ([fdo#111644] / [i915#1397] / [i915#2411])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb8/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
* igt@i915_pm_sseu@full-enable:
- shard-tglb: NOTRUN -> [SKIP][34] ([fdo#109288])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb7/igt@i915_pm_sseu@full-enable.html
- shard-iclb: NOTRUN -> [SKIP][35] ([fdo#109288])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-iclb8/igt@i915_pm_sseu@full-enable.html
* igt@i915_suspend@sysfs-reader:
- shard-tglb: NOTRUN -> [INCOMPLETE][36] ([i915#456])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb7/igt@i915_suspend@sysfs-reader.html
* igt@kms_atomic@plane-primary-overlay-mutable-zpos:
- shard-tglb: NOTRUN -> [SKIP][37] ([i915#404])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb5/igt@kms_atomic@plane-primary-overlay-mutable-zpos.html
- shard-iclb: NOTRUN -> [SKIP][38] ([i915#404])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-iclb8/igt@kms_atomic@plane-primary-overlay-mutable-zpos.html
* igt@kms_big_fb@linear-32bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][39] ([fdo#110725] / [fdo#111614])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-iclb6/igt@kms_big_fb@linear-32bpp-rotate-270.html
* igt@kms_big_fb@linear-8bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][40] ([fdo#111614]) +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb8/igt@kms_big_fb@linear-8bpp-rotate-90.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-kbl: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#3777]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-kbl4/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
- shard-apl: NOTRUN -> [SKIP][42] ([fdo#109271] / [i915#3777])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-apl6/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-glk: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#3777])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-glk7/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
* igt@kms_big_fb@yf-tiled-8bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][44] ([fdo#110723])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-iclb5/igt@kms_big_fb@yf-tiled-8bpp-rotate-270.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0:
- shard-tglb: NOTRUN -> [SKIP][45] ([fdo#111615]) +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb2/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0.html
* igt@kms_big_joiner@invalid-modeset:
- shard-iclb: NOTRUN -> [SKIP][46] ([i915#2705])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-iclb4/igt@kms_big_joiner@invalid-modeset.html
- shard-tglb: NOTRUN -> [SKIP][47] ([i915#2705])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb2/igt@kms_big_joiner@invalid-modeset.html
* igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][48] ([i915#3689] / [i915#3886]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb2/igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][49] ([fdo#109271] / [i915#3886]) +5 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-kbl3/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][50] ([fdo#109271] / [i915#3886]) +7 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-glk4/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html
- shard-iclb: NOTRUN -> [SKIP][51] ([fdo#109278] / [i915#3886]) +2 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-iclb6/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#3886]) +16 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-apl6/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-bad-rotation-90-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][53] ([i915#3689]) +2 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb8/igt@kms_ccs@pipe-d-bad-rotation-90-yf_tiled_ccs.html
* igt@kms_chamelium@hdmi-hpd-enable-disable-mode:
- shard-iclb: NOTRUN -> [SKIP][54] ([fdo#109284] / [fdo#111827]) +2 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-iclb4/igt@kms_chamelium@hdmi-hpd-enable-disable-mode.html
* igt@kms_chamelium@vga-hpd:
- shard-apl: NOTRUN -> [SKIP][55] ([fdo#109271] / [fdo#111827]) +15 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-apl3/igt@kms_chamelium@vga-hpd.html
* igt@kms_chamelium@vga-hpd-without-ddc:
- shard-snb: NOTRUN -> [SKIP][56] ([fdo#109271] / [fdo#111827]) +16 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-snb5/igt@kms_chamelium@vga-hpd-without-ddc.html
* igt@kms_color@pipe-d-invalid-ctm-matrix-sizes:
- shard-iclb: NOTRUN -> [SKIP][57] ([fdo#109278]) +19 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-iclb4/igt@kms_color@pipe-d-invalid-ctm-matrix-sizes.html
* igt@kms_color_chamelium@pipe-a-ctm-max:
- shard-glk: NOTRUN -> [SKIP][58] ([fdo#109271] / [fdo#111827]) +8 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-glk2/igt@kms_color_chamelium@pipe-a-ctm-max.html
* igt@kms_color_chamelium@pipe-b-ctm-0-25:
- shard-kbl: NOTRUN -> [SKIP][59] ([fdo#109271] / [fdo#111827]) +7 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-kbl4/igt@kms_color_chamelium@pipe-b-ctm-0-25.html
* igt@kms_color_chamelium@pipe-d-ctm-blue-to-red:
- shard-tglb: NOTRUN -> [SKIP][60] ([fdo#109284] / [fdo#111827]) +6 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb6/igt@kms_color_chamelium@pipe-d-ctm-blue-to-red.html
- shard-iclb: NOTRUN -> [SKIP][61] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-iclb5/igt@kms_color_chamelium@pipe-d-ctm-blue-to-red.html
* igt@kms_cursor_crc@pipe-b-cursor-32x10-sliding:
- shard-tglb: NOTRUN -> [SKIP][62] ([i915#3359]) +3 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb6/igt@kms_cursor_crc@pipe-b-cursor-32x10-sliding.html
* igt@kms_cursor_crc@pipe-b-cursor-512x512-sliding:
- shard-iclb: NOTRUN -> [SKIP][63] ([fdo#109278] / [fdo#109279]) +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-iclb8/igt@kms_cursor_crc@pipe-b-cursor-512x512-sliding.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: NOTRUN -> [DMESG-WARN][64] ([i915#180]) +5 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_cursor_crc@pipe-d-cursor-512x512-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][65] ([fdo#109279] / [i915#3359]) +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb8/igt@kms_cursor_crc@pipe-d-cursor-512x512-rapid-movement.html
* igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge:
- shard-snb: NOTRUN -> [SKIP][66] ([fdo#109271]) +434 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-snb6/igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [PASS][67] -> [FAIL][68] ([i915#72])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/shard-glk9/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-glk8/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
* igt@kms_cursor_legacy@cursora-vs-flipb-atomic:
- shard-tglb: NOTRUN -> [SKIP][69] ([fdo#111825]) +22 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb5/igt@kms_cursor_legacy@cursora-vs-flipb-atomic.html
* igt@kms_cursor_legacy@cursora-vs-flipb-toggle:
- shard-iclb: NOTRUN -> [SKIP][70] ([fdo#109274] / [fdo#109278]) +1 similar issue
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-iclb6/igt@kms_cursor_legacy@cursora-vs-flipb-toggle.html
* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-apl: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#533]) +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-apl7/igt@kms_cursor_legacy@pipe-d-torture-bo.html
- shard-glk: NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#533]) +2 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-glk4/igt@kms_cursor_legacy@pipe-d-torture-bo.html
* igt@kms_flip@2x-flip-vs-rmfb-interruptible:
- shard-iclb: NOTRUN -> [SKIP][73] ([fdo#109274]) +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-iclb7/igt@kms_flip@2x-flip-vs-rmfb-interruptible.html
* igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1:
- shard-glk: [PASS][74] -> [FAIL][75] ([i915#2122])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/shard-glk7/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-glk8/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-apl: [PASS][76] -> [DMESG-WARN][77] ([i915#180]) +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/shard-apl2/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-tglb: [PASS][78] -> [INCOMPLETE][79] ([i915#2411] / [i915#456])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-suspend.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-cpu:
- shard-glk: NOTRUN -> [SKIP][80] ([fdo#109271]) +112 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-glk1/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-shrfb-fliptrack-mmap-gtt:
- shard-iclb: NOTRUN -> [SKIP][81] ([fdo#109280]) +14 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-2p-shrfb-fliptrack-mmap-gtt.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [PASS][82] -> [DMESG-WARN][83] ([i915#180]) +3 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/shard-kbl4/igt@kms_hdr@bpc-switch-suspend.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-kbl6/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_pipe_b_c_ivb@pipe-b-double-modeset-then-modeset-pipe-c:
- shard-tglb: NOTRUN -> [SKIP][84] ([fdo#109289]) +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb7/igt@kms_pipe_b_c_ivb@pipe-b-double-modeset-then-modeset-pipe-c.html
- shard-iclb: NOTRUN -> [SKIP][85] ([fdo#109289])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-iclb2/igt@kms_pipe_b_c_ivb@pipe-b-double-modeset-then-modeset-pipe-c.html
* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d:
- shard-kbl: NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#533])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-kbl1/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
- shard-kbl: NOTRUN -> [FAIL][87] ([i915#265])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-kbl3/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
- shard-glk: NOTRUN -> [FAIL][88] ([fdo#108145] / [i915#265]) +1 similar issue
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-glk1/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html
- shard-kbl: NOTRUN -> [FAIL][89] ([fdo#108145] / [i915#265])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-kbl3/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-apl: NOTRUN -> [FAIL][90] ([fdo#108145] / [i915#265]) +2 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-apl1/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max.html
* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-tglb: NOTRUN -> [SKIP][91] ([i915#3536]) +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb7/igt@kms_plane_lowres@pipe-a-tiling-y.html
* igt@kms_plane_lowres@pipe-b-tiling-x:
- shard-iclb: NOTRUN -> [SKIP][92] ([i915#3536])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-iclb6/igt@kms_plane_lowres@pipe-b-tiling-x.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2:
- shard-kbl: NOTRUN -> [SKIP][93] ([fdo#109271] / [i915#658]) +2 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-kbl6/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html
- shard-iclb: NOTRUN -> [SKIP][94] ([i915#658])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-iclb8/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html
- shard-tglb: NOTRUN -> [SKIP][95] ([i915#2920])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb5/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5:
- shard-apl: NOTRUN -> [SKIP][96] ([fdo#109271] / [i915#658]) +3 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-apl1/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5.html
* igt@kms_psr2_su@frontbuffer:
- shard-glk: NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#658]) +3 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-glk2/igt@kms_psr2_su@frontbuffer.html
- shard-tglb: NOTRUN -> [SKIP][98] ([i915#1911])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb5/igt@kms_psr2_su@frontbuffer.html
- shard-iclb: NOTRUN -> [SKIP][99] ([fdo#109642] / [fdo#111068] / [i915#658])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-iclb8/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][100] -> [SKIP][101] ([fdo#109441])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-iclb4/igt@kms_psr@psr2_cursor_render.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: NOTRUN -> [SKIP][102] ([fdo#109441])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-iclb8/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@kms_sysfs_edid_timing:
- shard-apl: NOTRUN -> [FAIL][103] ([IGT#2])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-apl6/igt@kms_sysfs_edid_timing.html
- shard-kbl: NOTRUN -> [FAIL][104] ([IGT#2])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-kbl4/igt@kms_sysfs_edid_timing.html
* igt@kms_vblank@pipe-d-wait-forked-hang:
- shard-apl: NOTRUN -> [SKIP][105] ([fdo#109271]) +250 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-apl6/igt@kms_vblank@pipe-d-wait-forked-hang.html
* igt@kms_vrr@flip-dpms:
- shard-iclb: NOTRUN -> [SKIP][106] ([fdo#109502])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-iclb6/igt@kms_vrr@flip-dpms.html
- shard-tglb: NOTRUN -> [SKIP][107] ([fdo#109502])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb8/igt@kms_vrr@flip-dpms.html
* igt@kms_writeback@writeback-fb-id:
- shard-glk: NOTRUN -> [SKIP][108] ([fdo#109271] / [i915#2437])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-glk7/igt@kms_writeback@writeback-fb-id.html
- shard-apl: NOTRUN -> [SKIP][109] ([fdo#109271] / [i915#2437])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-apl8/igt@kms_writeback@writeback-fb-id.html
- shard-kbl: NOTRUN -> [SKIP][110] ([fdo#109271] / [i915#2437])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-kbl7/igt@kms_writeback@writeback-fb-id.html
* igt@nouveau_crc@pipe-b-source-outp-complete:
- shard-tglb: NOTRUN -> [SKIP][111] ([i915#2530])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb6/igt@nouveau_crc@pipe-b-source-outp-complete.html
* igt@prime_nv_api@i915_self_import:
- shard-iclb: NOTRUN -> [SKIP][112] ([fdo#109291]) +1 similar issue
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-iclb1/igt@prime_nv_api@i915_self_import.html
* igt@prime_nv_pcopy@test3_1:
- shard-tglb: NOTRUN -> [SKIP][113] ([fdo#109291]) +2 similar issues
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb5/igt@prime_nv_pcopy@test3_1.html
* igt@sysfs_clients@busy:
- shard-tglb: NOTRUN -> [SKIP][114] ([i915#2994]) +2 similar issues
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb7/igt@sysfs_clients@busy.html
* igt@sysfs_clients@fair-1:
- shard-apl: NOTRUN -> [SKIP][115] ([fdo#109271] / [i915#2994]) +3 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-apl6/igt@sysfs_clients@fair-1.html
* igt@sysfs_clients@split-25:
- shard-glk: NOTRUN -> [SKIP][116] ([fdo#109271] / [i915#2994]) +2 similar issues
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-glk4/igt@sysfs_clients@split-25.html
* igt@sysfs_clients@split-50:
- shard-kbl: NOTRUN -> [SKIP][117] ([fdo#109271] / [i915#2994]) +2 similar issues
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-kbl1/igt@sysfs_clients@split-50.html
- shard-iclb: NOTRUN -> [SKIP][118] ([i915#2994]) +1 similar issue
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-iclb5/igt@sysfs_clients@split-50.html
#### Possible fixes ####
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [FAIL][119] ([i915#2846]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/shard-glk7/igt@gem_exec_fair@basic-deadline.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-glk8/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-iclb: [FAIL][121] ([i915#2842]) -> [PASS][122] +1 similar issue
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/shard-iclb8/igt@gem_exec_fair@basic-none-vip@rcs0.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-iclb7/igt@gem_exec_fair@basic-none-vip@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][123] ([i915#2842]) -> [PASS][124] +1 similar issue
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/shard-glk3/igt@gem_exec_fair@basic-pace-share@rcs0.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-glk8/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-tglb: [FAIL][125] ([i915#2842]) -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/shard-tglb2/igt@gem_exec_fair@basic-pace@rcs0.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb7/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-kbl: [DMESG-WARN][127] ([i915#180]) -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/shard-kbl1/igt@i915_suspend@fence-restore-tiled2untiled.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-kbl6/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_big_fb@linear-32bpp-rotate-180:
- shard-glk: [DMESG-WARN][129] ([i915#118] / [i915#95]) -> [PASS][130] +2 similar issues
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/shard-glk5/igt@kms_big_fb@linear-32bpp-rotate-180.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-glk6/igt@kms_big_fb@linear-32bpp-rotate-180.html
* igt@kms_cursor_crc@pipe-a-cursor-size-change:
- shard-snb: [FAIL][131] ([i915#4024]) -> [PASS][132]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/shard-snb7/igt@kms_cursor_crc@pipe-a-cursor-size-change.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-snb6/igt@kms_cursor_crc@pipe-a-cursor-size-change.html
- shard-kbl: [FAIL][133] ([i915#3444]) -> [PASS][134]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-size-change.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-size-change.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-tglb: [INCOMPLETE][135] ([i915#456]) -> [PASS][136]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/shard-tglb7/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb1/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_cursor_crc@pipe-d-cursor-alpha-opaque:
- shard-tglb: [FAIL][137] ([i915#2124]) -> [PASS][138]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10641/shard-tglb1/igt@kms_cursor_crc@pipe-d-cursor-alpha-opaque.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/shard-tglb1/igt@kms_cursor_crc@pipe-d-cursor-alpha-opaque.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-h
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6261/index.html
[-- Attachment #2: Type: text/html, Size: 33914 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH] tests/kms_addfb_basic: Remove handling for Unknown Vendor.
2021-09-24 18:55 [igt-dev] [PATCH] tests/kms_addfb_basic: Remove handling for Unknown Vendor Mark Yacoub
2021-09-24 20:18 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-09-25 0:27 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2021-09-27 13:00 ` Petri Latvala
2021-09-27 14:32 ` Mark Yacoub
2 siblings, 1 reply; 6+ messages in thread
From: Petri Latvala @ 2021-09-27 13:00 UTC (permalink / raw)
To: Mark Yacoub
Cc: igt-dev, seanpaul, arek, Rodrigo.Siqueira, anson.jacob, abhinavk,
robdclark, Mark Yacoub
On Fri, Sep 24, 2021 at 02:55:10PM -0400, Mark Yacoub wrote:
> From: Mark Yacoub <markyacoub@google.com>
>
> [Why]
> Looking at multiple drivers such as i915, amdgpu, and msm, EINVAL is the
> standard errno when failing some fb errors.
> Unless it's an exception like nouveau, every driver should act in a
> standard manner and return EINVAL just like every other driver. Hence,
> no special handling for unknown vendor is needed.
>
> [How]
> Remove asserts for specific drivers except for a known exception.
>
> Tested on ChromeOS Trogdor(msm).
>
> Signed-off-by: Mark Yacoub <markyacoub@chromium.org>
> ---
> tests/kms_addfb_basic.c | 26 +++++++-------------------
> 1 file changed, 7 insertions(+), 19 deletions(-)
>
> diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
> index 082f10ee..35c2ae2c 100644
> --- a/tests/kms_addfb_basic.c
> +++ b/tests/kms_addfb_basic.c
> @@ -307,17 +307,10 @@ static void pitch_tests(int fd)
> igt_subtest_f("bad-pitch-%i", bad_pitches[i]) {
> f.pitches[0] = bad_pitches[i];
> igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &f), -1);
> - igt_assert(errno != 0);
> - if (is_i915_device(fd) || is_amdgpu_device(fd) || is_msm_device(fd)) {
> + if (is_nouveau_device(fd) && bad_pitches[i] > 4 * 1024)
> + igt_assert_eq(errno, ERANGE);
> + else
> igt_assert_eq(errno, EINVAL);
> - } else if (is_nouveau_device(fd)) {
> - if (bad_pitches[i] > 4 * 1024)
> - igt_assert_eq(errno, ERANGE);
> - else
> - igt_assert_eq(errno, EINVAL);
> - } else {
> - igt_info("Unknown vendor; errno unchecked (returned %i)", errno);
> - }
> errno = 0;
> }
> }
> @@ -479,13 +472,10 @@ static void size_tests(int fd)
> for (i = 0; i < ARRAY_SIZE(framebuffers); i++) {
> igt_debug("Checking framebuffer %i\n", i);
> igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, framebuffers[i]), -1);
> - igt_assert(errno != 0);
> - if (is_i915_device(fd))
> - igt_assert_eq(errno, EINVAL);
> - else if (is_nouveau_device(fd))
> + if (is_nouveau_device(fd))
> igt_assert_eq(errno, ERANGE);
> else
> - igt_info("Unknown vendor; errno unchecked (returned %i)", errno);
> + igt_assert_eq(errno, EINVAL);
> errno = 0;
> }
> }
> @@ -495,12 +485,10 @@ static void size_tests(int fd)
> igt_subtest("bo-too-small") {
> igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &f), -1);
> igt_assert(errno != 0);
> - if (is_i915_device(fd))
> - igt_assert_eq(errno, EINVAL);
> - else if (is_nouveau_device(fd))
> + if (is_nouveau_device(fd))
> igt_assert_eq(errno, ERANGE);
> else
> - igt_info("Unknown vendor; errno unchecked (returned %i)", errno);
> + igt_assert_eq(errno, EINVAL);
> errno = 0;
> }
Tentatively,
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
How does this map to the holy trinity of
1) documentation for the ioctl
2) actual behaviour of the ioctl across drivers (this one is already answered in the commit message though)
3) how non-IGT userspace handles the ioctl
--
Petri Latvala
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH] tests/kms_addfb_basic: Remove handling for Unknown Vendor.
2021-09-27 13:00 ` [igt-dev] [PATCH] " Petri Latvala
@ 2021-09-27 14:32 ` Mark Yacoub
2021-09-27 16:09 ` Mark Yacoub
0 siblings, 1 reply; 6+ messages in thread
From: Mark Yacoub @ 2021-09-27 14:32 UTC (permalink / raw)
To: Petri Latvala
Cc: Development mailing list for IGT GPU Tools, Sean Paul,
Arkadiusz Hiler, Siqueira, Rodrigo, Anson Jacob, abhinavk,
Rob Clark, Mark Yacoub
1) I looked at the IOCTL implementation. the IOCTL function makes its
way to drm_internal_framebuffer_create() [1] and framebuffer_check()
[2] where the return values are -EINVAL everywhere except for 2 cases
[3] where they return as handled by Nouveau. Given that it's in DRM,
I think I can assume it would be a consistent behavior across drivers.
2) yeah, within the tests I ran, it was consistently an EINVAL except
for nouveau, which is still a fair return value.
3) I checked Chrome and it just checks that it's 0, otherwise, it
returns false to the operation.
[1] https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_framebuffer.c#L287
[2] https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_framebuffer.c#L172
[3] https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_framebuffer.c#L214
On Mon, Sep 27, 2021 at 8:57 AM Petri Latvala <petri.latvala@intel.com> wrote:
>
> On Fri, Sep 24, 2021 at 02:55:10PM -0400, Mark Yacoub wrote:
> > From: Mark Yacoub <markyacoub@google.com>
> >
> > [Why]
> > Looking at multiple drivers such as i915, amdgpu, and msm, EINVAL is the
> > standard errno when failing some fb errors.
> > Unless it's an exception like nouveau, every driver should act in a
> > standard manner and return EINVAL just like every other driver. Hence,
> > no special handling for unknown vendor is needed.
> >
> > [How]
> > Remove asserts for specific drivers except for a known exception.
> >
> > Tested on ChromeOS Trogdor(msm).
> >
> > Signed-off-by: Mark Yacoub <markyacoub@chromium.org>
> > ---
> > tests/kms_addfb_basic.c | 26 +++++++-------------------
> > 1 file changed, 7 insertions(+), 19 deletions(-)
> >
> > diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
> > index 082f10ee..35c2ae2c 100644
> > --- a/tests/kms_addfb_basic.c
> > +++ b/tests/kms_addfb_basic.c
> > @@ -307,17 +307,10 @@ static void pitch_tests(int fd)
> > igt_subtest_f("bad-pitch-%i", bad_pitches[i]) {
> > f.pitches[0] = bad_pitches[i];
> > igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &f), -1);
> > - igt_assert(errno != 0);
> > - if (is_i915_device(fd) || is_amdgpu_device(fd) || is_msm_device(fd)) {
> > + if (is_nouveau_device(fd) && bad_pitches[i] > 4 * 1024)
> > + igt_assert_eq(errno, ERANGE);
> > + else
> > igt_assert_eq(errno, EINVAL);
> > - } else if (is_nouveau_device(fd)) {
> > - if (bad_pitches[i] > 4 * 1024)
> > - igt_assert_eq(errno, ERANGE);
> > - else
> > - igt_assert_eq(errno, EINVAL);
> > - } else {
> > - igt_info("Unknown vendor; errno unchecked (returned %i)", errno);
> > - }
> > errno = 0;
> > }
> > }
> > @@ -479,13 +472,10 @@ static void size_tests(int fd)
> > for (i = 0; i < ARRAY_SIZE(framebuffers); i++) {
> > igt_debug("Checking framebuffer %i\n", i);
> > igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, framebuffers[i]), -1);
> > - igt_assert(errno != 0);
> > - if (is_i915_device(fd))
> > - igt_assert_eq(errno, EINVAL);
> > - else if (is_nouveau_device(fd))
> > + if (is_nouveau_device(fd))
> > igt_assert_eq(errno, ERANGE);
> > else
> > - igt_info("Unknown vendor; errno unchecked (returned %i)", errno);
> > + igt_assert_eq(errno, EINVAL);
> > errno = 0;
> > }
> > }
> > @@ -495,12 +485,10 @@ static void size_tests(int fd)
> > igt_subtest("bo-too-small") {
> > igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &f), -1);
> > igt_assert(errno != 0);
> > - if (is_i915_device(fd))
> > - igt_assert_eq(errno, EINVAL);
> > - else if (is_nouveau_device(fd))
> > + if (is_nouveau_device(fd))
> > igt_assert_eq(errno, ERANGE);
> > else
> > - igt_info("Unknown vendor; errno unchecked (returned %i)", errno);
> > + igt_assert_eq(errno, EINVAL);
> > errno = 0;
> > }
>
> Tentatively,
> Reviewed-by: Petri Latvala <petri.latvala@intel.com>
>
> How does this map to the holy trinity of
>
> 1) documentation for the ioctl
> 2) actual behaviour of the ioctl across drivers (this one is already answered in the commit message though)
> 3) how non-IGT userspace handles the ioctl
>
>
> --
> Petri Latvala
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH] tests/kms_addfb_basic: Remove handling for Unknown Vendor.
2021-09-27 14:32 ` Mark Yacoub
@ 2021-09-27 16:09 ` Mark Yacoub
0 siblings, 0 replies; 6+ messages in thread
From: Mark Yacoub @ 2021-09-27 16:09 UTC (permalink / raw)
To: Petri Latvala
Cc: Development mailing list for IGT GPU Tools, Sean Paul,
Arkadiusz Hiler, Siqueira, Rodrigo, Anson Jacob, abhinavk,
Rob Clark, Mark Yacoub
*talked offline*
Applied. Thanks for reviewing.
On Mon, Sep 27, 2021 at 10:32 AM Mark Yacoub <markyacoub@chromium.org> wrote:
>
> 1) I looked at the IOCTL implementation. the IOCTL function makes its
> way to drm_internal_framebuffer_create() [1] and framebuffer_check()
> [2] where the return values are -EINVAL everywhere except for 2 cases
> [3] where they return as handled by Nouveau. Given that it's in DRM,
> I think I can assume it would be a consistent behavior across drivers.
>
> 2) yeah, within the tests I ran, it was consistently an EINVAL except
> for nouveau, which is still a fair return value.
>
> 3) I checked Chrome and it just checks that it's 0, otherwise, it
> returns false to the operation.
>
> [1] https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_framebuffer.c#L287
> [2] https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_framebuffer.c#L172
> [3] https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_framebuffer.c#L214
>
> On Mon, Sep 27, 2021 at 8:57 AM Petri Latvala <petri.latvala@intel.com> wrote:
> >
> > On Fri, Sep 24, 2021 at 02:55:10PM -0400, Mark Yacoub wrote:
> > > From: Mark Yacoub <markyacoub@google.com>
> > >
> > > [Why]
> > > Looking at multiple drivers such as i915, amdgpu, and msm, EINVAL is the
> > > standard errno when failing some fb errors.
> > > Unless it's an exception like nouveau, every driver should act in a
> > > standard manner and return EINVAL just like every other driver. Hence,
> > > no special handling for unknown vendor is needed.
> > >
> > > [How]
> > > Remove asserts for specific drivers except for a known exception.
> > >
> > > Tested on ChromeOS Trogdor(msm).
> > >
> > > Signed-off-by: Mark Yacoub <markyacoub@chromium.org>
> > > ---
> > > tests/kms_addfb_basic.c | 26 +++++++-------------------
> > > 1 file changed, 7 insertions(+), 19 deletions(-)
> > >
> > > diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
> > > index 082f10ee..35c2ae2c 100644
> > > --- a/tests/kms_addfb_basic.c
> > > +++ b/tests/kms_addfb_basic.c
> > > @@ -307,17 +307,10 @@ static void pitch_tests(int fd)
> > > igt_subtest_f("bad-pitch-%i", bad_pitches[i]) {
> > > f.pitches[0] = bad_pitches[i];
> > > igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &f), -1);
> > > - igt_assert(errno != 0);
> > > - if (is_i915_device(fd) || is_amdgpu_device(fd) || is_msm_device(fd)) {
> > > + if (is_nouveau_device(fd) && bad_pitches[i] > 4 * 1024)
> > > + igt_assert_eq(errno, ERANGE);
> > > + else
> > > igt_assert_eq(errno, EINVAL);
> > > - } else if (is_nouveau_device(fd)) {
> > > - if (bad_pitches[i] > 4 * 1024)
> > > - igt_assert_eq(errno, ERANGE);
> > > - else
> > > - igt_assert_eq(errno, EINVAL);
> > > - } else {
> > > - igt_info("Unknown vendor; errno unchecked (returned %i)", errno);
> > > - }
> > > errno = 0;
> > > }
> > > }
> > > @@ -479,13 +472,10 @@ static void size_tests(int fd)
> > > for (i = 0; i < ARRAY_SIZE(framebuffers); i++) {
> > > igt_debug("Checking framebuffer %i\n", i);
> > > igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, framebuffers[i]), -1);
> > > - igt_assert(errno != 0);
> > > - if (is_i915_device(fd))
> > > - igt_assert_eq(errno, EINVAL);
> > > - else if (is_nouveau_device(fd))
> > > + if (is_nouveau_device(fd))
> > > igt_assert_eq(errno, ERANGE);
> > > else
> > > - igt_info("Unknown vendor; errno unchecked (returned %i)", errno);
> > > + igt_assert_eq(errno, EINVAL);
> > > errno = 0;
> > > }
> > > }
> > > @@ -495,12 +485,10 @@ static void size_tests(int fd)
> > > igt_subtest("bo-too-small") {
> > > igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &f), -1);
> > > igt_assert(errno != 0);
> > > - if (is_i915_device(fd))
> > > - igt_assert_eq(errno, EINVAL);
> > > - else if (is_nouveau_device(fd))
> > > + if (is_nouveau_device(fd))
> > > igt_assert_eq(errno, ERANGE);
> > > else
> > > - igt_info("Unknown vendor; errno unchecked (returned %i)", errno);
> > > + igt_assert_eq(errno, EINVAL);
> > > errno = 0;
> > > }
> >
> > Tentatively,
> > Reviewed-by: Petri Latvala <petri.latvala@intel.com>
> >
> > How does this map to the holy trinity of
> >
> > 1) documentation for the ioctl
> > 2) actual behaviour of the ioctl across drivers (this one is already answered in the commit message though)
> > 3) how non-IGT userspace handles the ioctl
> >
> >
> > --
> > Petri Latvala
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-09-27 16:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-24 18:55 [igt-dev] [PATCH] tests/kms_addfb_basic: Remove handling for Unknown Vendor Mark Yacoub
2021-09-24 20:18 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-09-25 0:27 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-09-27 13:00 ` [igt-dev] [PATCH] " Petri Latvala
2021-09-27 14:32 ` Mark Yacoub
2021-09-27 16:09 ` Mark Yacoub
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.