All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: zhuyinbo <zhuyinbo@loongson.cn>
Cc: Alan Stern <stern@rowland.harvard.edu>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [v0] usb: ohci: add check for start frame in host controller functional states
Date: Wed, 29 Sep 2021 11:22:47 +0200	[thread overview]
Message-ID: <YVQwZ8ed4od0q/Jh@kroah.com> (raw)
In-Reply-To: <bf56ff89-3800-9786-bba3-53175822a5d3@loongson.cn>

On Wed, Sep 29, 2021 at 04:58:15PM +0800, zhuyinbo wrote:
> 
> 在 2021/9/29 下午3:50, Greg Kroah-Hartman 写道:
> > On Wed, Sep 29, 2021 at 03:40:59PM +0800, Yinbo Zhu wrote:
> > > The pm states of ohci include UsbOperational、UsbReset、UsbSuspend、UsbResume
> > > , among them only the UsbOperational state supports launching the start frame
> > > for host controller according the ohci protocol spec, but in S3/S4 press test
> > > procedure, it may happen that the start frame was launched in other pm states
> > > and cause ohci works abnormally then kernel will allways report rcu CallTrace
> > > . This patch was to add check for start frame in host controller functional
> > > states for fixing above issue.
> > 
> > > Odd use of punctuation :(
> > 
> > > Change-Id: Ic5c2c0a41d01d9396a9452f3eb64acc52b4cbf76
> > > Always run checkpatch.pl on your patches do you do not get grumpy
> > > maintainers asking you to run checkpatch.pl on your patches.
> > 
> > > and what does "v0" on the subject line mean?
> > 
> > > thanks,
> > 
> > > greg k-h
> 
> Hi greg k-h,
> 
> 
> The string "v0" of subject line is patch version,  as for the punctuation
> I'll revise it,
> 
> and I don't find any error that use checkpatch.pl to check patch. then
> please you

You had a Change-Id: in the changelog, that is not needed or allowed in
the kernel tree.

thanks,

greg k-h

      parent reply	other threads:[~2021-09-29  9:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1632901259-32746-1-git-send-email-zhuyinbo@loongson.cn>
2021-09-29  7:50 ` [v0] usb: ohci: add check for start frame in host controller functional states Greg Kroah-Hartman
     [not found]   ` <bf56ff89-3800-9786-bba3-53175822a5d3@loongson.cn>
2021-09-29  9:22     ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YVQwZ8ed4od0q/Jh@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=zhuyinbo@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.