* Re: [v0] usb: ohci: add check for start frame in host controller functional states
[not found] <1632901259-32746-1-git-send-email-zhuyinbo@loongson.cn>
@ 2021-09-29 7:50 ` Greg Kroah-Hartman
[not found] ` <bf56ff89-3800-9786-bba3-53175822a5d3@loongson.cn>
0 siblings, 1 reply; 2+ messages in thread
From: Greg Kroah-Hartman @ 2021-09-29 7:50 UTC (permalink / raw)
To: Yinbo Zhu; +Cc: Alan Stern, linux-usb, linux-kernel
On Wed, Sep 29, 2021 at 03:40:59PM +0800, Yinbo Zhu wrote:
> The pm states of ohci include UsbOperational、UsbReset、UsbSuspend、UsbResume
> , among them only the UsbOperational state supports launching the start frame
> for host controller according the ohci protocol spec, but in S3/S4 press test
> procedure, it may happen that the start frame was launched in other pm states
> and cause ohci works abnormally then kernel will allways report rcu CallTrace
> . This patch was to add check for start frame in host controller functional
> states for fixing above issue.
Odd use of punctuation :(
>
> Change-Id: Ic5c2c0a41d01d9396a9452f3eb64acc52b4cbf76
Always run checkpatch.pl on your patches do you do not get grumpy
maintainers asking you to run checkpatch.pl on your patches.
and what does "v0" on the subject line mean?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [v0] usb: ohci: add check for start frame in host controller functional states
[not found] ` <bf56ff89-3800-9786-bba3-53175822a5d3@loongson.cn>
@ 2021-09-29 9:22 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2021-09-29 9:22 UTC (permalink / raw)
To: zhuyinbo; +Cc: Alan Stern, linux-usb, linux-kernel
On Wed, Sep 29, 2021 at 04:58:15PM +0800, zhuyinbo wrote:
>
> 在 2021/9/29 下午3:50, Greg Kroah-Hartman 写道:
> > On Wed, Sep 29, 2021 at 03:40:59PM +0800, Yinbo Zhu wrote:
> > > The pm states of ohci include UsbOperational、UsbReset、UsbSuspend、UsbResume
> > > , among them only the UsbOperational state supports launching the start frame
> > > for host controller according the ohci protocol spec, but in S3/S4 press test
> > > procedure, it may happen that the start frame was launched in other pm states
> > > and cause ohci works abnormally then kernel will allways report rcu CallTrace
> > > . This patch was to add check for start frame in host controller functional
> > > states for fixing above issue.
> >
> > > Odd use of punctuation :(
> >
> > > Change-Id: Ic5c2c0a41d01d9396a9452f3eb64acc52b4cbf76
> > > Always run checkpatch.pl on your patches do you do not get grumpy
> > > maintainers asking you to run checkpatch.pl on your patches.
> >
> > > and what does "v0" on the subject line mean?
> >
> > > thanks,
> >
> > > greg k-h
>
> Hi greg k-h,
>
>
> The string "v0" of subject line is patch version, as for the punctuation
> I'll revise it,
>
> and I don't find any error that use checkpatch.pl to check patch. then
> please you
You had a Change-Id: in the changelog, that is not needed or allowed in
the kernel tree.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-29 9:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1632901259-32746-1-git-send-email-zhuyinbo@loongson.cn>
2021-09-29 7:50 ` [v0] usb: ohci: add check for start frame in host controller functional states Greg Kroah-Hartman
[not found] ` <bf56ff89-3800-9786-bba3-53175822a5d3@loongson.cn>
2021-09-29 9:22 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.