All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@nvidia.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: kernel test robot <lkp@intel.com>,
	"llvm@lists.linux.dev" <llvm@lists.linux.dev>,
	"kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Jiri Pirko <jiri@nvidia.com>
Subject: Re: drivers/net/ethernet/mellanox/mlxsw/core_acl_flex_actions.c:2022:1: warning: unused function 'mlxsw_afa_sampler_mirror_agent_get'
Date: Thu, 30 Sep 2021 09:41:40 +0300	[thread overview]
Message-ID: <YVVcJLSwGPWyFXKl@shredder> (raw)
In-Reply-To: <YVSWzZvv5fX4iDb7@archlinux-ax161>

On Wed, Sep 29, 2021 at 09:39:41AM -0700, Nathan Chancellor wrote:
> Yes, I would say this is a perfectly fine solution. The warning is there
> to make you consider if you have forgotten to use or remove a function
> depending on the context and if this is expected behavior, silencing the
> compiler with the __maybe_unused attribute is the right thing to do. The
> kernel does this for resume and suspend functions as CONFIG_PM might not
> be set.

Thanks, Nathan. Will send the patch to net-next (most likely next week)
and copy you.

WARNING: multiple messages have this Message-ID (diff)
From: Ido Schimmel <idosch@nvidia.com>
To: kbuild-all@lists.01.org
Subject: Re: drivers/net/ethernet/mellanox/mlxsw/core_acl_flex_actions.c:2022:1: warning: unused function 'mlxsw_afa_sampler_mirror_agent_get'
Date: Thu, 30 Sep 2021 09:41:40 +0300	[thread overview]
Message-ID: <YVVcJLSwGPWyFXKl@shredder> (raw)
In-Reply-To: <YVSWzZvv5fX4iDb7@archlinux-ax161>

[-- Attachment #1: Type: text/plain, Size: 545 bytes --]

On Wed, Sep 29, 2021 at 09:39:41AM -0700, Nathan Chancellor wrote:
> Yes, I would say this is a perfectly fine solution. The warning is there
> to make you consider if you have forgotten to use or remove a function
> depending on the context and if this is expected behavior, silencing the
> compiler with the __maybe_unused attribute is the right thing to do. The
> kernel does this for resume and suspend functions as CONFIG_PM might not
> be set.

Thanks, Nathan. Will send the patch to net-next (most likely next week)
and copy you.

  reply	other threads:[~2021-09-30  6:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28 18:06 drivers/net/ethernet/mellanox/mlxsw/core_acl_flex_actions.c:2022:1: warning: unused function 'mlxsw_afa_sampler_mirror_agent_get' kernel test robot
2021-09-28 18:06 ` kernel test robot
2021-09-29  9:44 ` Ido Schimmel
2021-09-29  9:44   ` Ido Schimmel
2021-09-29 16:39   ` Nathan Chancellor
2021-09-29 16:39     ` Nathan Chancellor
2021-09-30  6:41     ` Ido Schimmel [this message]
2021-09-30  6:41       ` Ido Schimmel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YVVcJLSwGPWyFXKl@shredder \
    --to=idosch@nvidia.com \
    --cc=jiri@nvidia.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=llvm@lists.linux.dev \
    --cc=nathan@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.