From: Pingfan Liu <kernelfans@gmail.com> To: Mark Rutland <mark.rutland@arm.com> Cc: linux-arm-kernel@lists.infradead.org, "Paul E. McKenney" <paulmck@kernel.org>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Marc Zyngier <maz@kernel.org>, Joey Gouly <joey.gouly@arm.com>, Sami Tolvanen <samitolvanen@google.com>, Julien Thierry <julien.thierry@arm.com>, Thomas Gleixner <tglx@linutronix.de>, Yuichi Ito <ito-yuichi@fujitsu.com>, linux-kernel@vger.kernel.org Subject: Re: [PATCHv3 2/3] arm64: entry: refactor EL1 interrupt entry logic Date: Fri, 1 Oct 2021 10:27:24 +0800 [thread overview] Message-ID: <YVZyDIRnIMaxQjg9@piliu.users.ipa.redhat.com> (raw) In-Reply-To: <20210930140058.GD18258@lakrids.cambridge.arm.com> On Thu, Sep 30, 2021 at 03:00:59PM +0100, Mark Rutland wrote: > On Thu, Sep 30, 2021 at 09:17:07PM +0800, Pingfan Liu wrote: > > From: Mark Rutland <mark.rutland@arm.com> > > > > Currently we distinguish IRQ and definitely-PNMI at entry/exit time > > via the enter_el1_irq_or_nmi() and enter_el1_irq_or_nmi() helpers. In > > subsequent patches we'll need to handle the two cases more distinctly > > in the body of the exception handler. > > > > To make this possible, this patch refactors el1_interrupt to be a > > top-level dispatcher to separate handlers for the IRQ and PNMI cases, > > removing the need for the enter_el1_irq_or_nmi() and > > exit_el1_irq_or_nmi() helpers. > > > > Note that since arm64_enter_nmi() calls __nmi_enter(), which > > increments the preemt_count, we could never preempt when handling a > > PNMI. We now only check for preemption in the IRQ case, which makes > > this clearer. > > > > There should be no functional change as a result of this patch. > > > > Signed-off-by: Mark Rutland <mark.rutland@arm.com> > > Cc: "Paul E. McKenney" <paulmck@kernel.org> > > Cc: Catalin Marinas <catalin.marinas@arm.com> > > Cc: Will Deacon <will@kernel.org> > > Cc: Marc Zyngier <maz@kernel.org> > > Cc: Joey Gouly <joey.gouly@arm.com> > > Cc: Sami Tolvanen <samitolvanen@google.com> > > Cc: Julien Thierry <julien.thierry@arm.com> > > Cc: Thomas Gleixner <tglx@linutronix.de> > > Cc: Yuichi Ito <ito-yuichi@fujitsu.com> > > Cc: Pingfan Liu <kernelfans@gmail.com> > > Cc: linux-kernel@vger.kernel.org > > To: linux-arm-kernel@lists.infradead.org > > As a heads-up, you need to add your Signed-off-by tag when you post > patches from other people, even if you make no changes. See: > > https://www.kernel.org/doc/html/v5.14/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin > Oh, thanks and I realize it is a serious license issue. > Other than that, this looks fine to me. > Thank you very much. Regards, Pingfan
WARNING: multiple messages have this Message-ID (diff)
From: Pingfan Liu <kernelfans@gmail.com> To: Mark Rutland <mark.rutland@arm.com> Cc: linux-arm-kernel@lists.infradead.org, "Paul E. McKenney" <paulmck@kernel.org>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Marc Zyngier <maz@kernel.org>, Joey Gouly <joey.gouly@arm.com>, Sami Tolvanen <samitolvanen@google.com>, Julien Thierry <julien.thierry@arm.com>, Thomas Gleixner <tglx@linutronix.de>, Yuichi Ito <ito-yuichi@fujitsu.com>, linux-kernel@vger.kernel.org Subject: Re: [PATCHv3 2/3] arm64: entry: refactor EL1 interrupt entry logic Date: Fri, 1 Oct 2021 10:27:24 +0800 [thread overview] Message-ID: <YVZyDIRnIMaxQjg9@piliu.users.ipa.redhat.com> (raw) In-Reply-To: <20210930140058.GD18258@lakrids.cambridge.arm.com> On Thu, Sep 30, 2021 at 03:00:59PM +0100, Mark Rutland wrote: > On Thu, Sep 30, 2021 at 09:17:07PM +0800, Pingfan Liu wrote: > > From: Mark Rutland <mark.rutland@arm.com> > > > > Currently we distinguish IRQ and definitely-PNMI at entry/exit time > > via the enter_el1_irq_or_nmi() and enter_el1_irq_or_nmi() helpers. In > > subsequent patches we'll need to handle the two cases more distinctly > > in the body of the exception handler. > > > > To make this possible, this patch refactors el1_interrupt to be a > > top-level dispatcher to separate handlers for the IRQ and PNMI cases, > > removing the need for the enter_el1_irq_or_nmi() and > > exit_el1_irq_or_nmi() helpers. > > > > Note that since arm64_enter_nmi() calls __nmi_enter(), which > > increments the preemt_count, we could never preempt when handling a > > PNMI. We now only check for preemption in the IRQ case, which makes > > this clearer. > > > > There should be no functional change as a result of this patch. > > > > Signed-off-by: Mark Rutland <mark.rutland@arm.com> > > Cc: "Paul E. McKenney" <paulmck@kernel.org> > > Cc: Catalin Marinas <catalin.marinas@arm.com> > > Cc: Will Deacon <will@kernel.org> > > Cc: Marc Zyngier <maz@kernel.org> > > Cc: Joey Gouly <joey.gouly@arm.com> > > Cc: Sami Tolvanen <samitolvanen@google.com> > > Cc: Julien Thierry <julien.thierry@arm.com> > > Cc: Thomas Gleixner <tglx@linutronix.de> > > Cc: Yuichi Ito <ito-yuichi@fujitsu.com> > > Cc: Pingfan Liu <kernelfans@gmail.com> > > Cc: linux-kernel@vger.kernel.org > > To: linux-arm-kernel@lists.infradead.org > > As a heads-up, you need to add your Signed-off-by tag when you post > patches from other people, even if you make no changes. See: > > https://www.kernel.org/doc/html/v5.14/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin > Oh, thanks and I realize it is a serious license issue. > Other than that, this looks fine to me. > Thank you very much. Regards, Pingfan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-01 2:27 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-30 13:17 [PATCHv3 0/3] arm64/irqentry: remove duplicate housekeeping of rcu Pingfan Liu 2021-09-30 13:17 ` Pingfan Liu 2021-09-30 13:17 ` [PATCHv3 1/3] kernel/irq: make irq_{enter,exit}() in handle_domain_irq() arch optional Pingfan Liu 2021-09-30 13:17 ` [PATCHv3 1/3] kernel/irq: make irq_{enter, exit}() " Pingfan Liu 2021-10-01 9:15 ` [PATCHv3 1/3] kernel/irq: make irq_{enter,exit}() " Marc Zyngier 2021-10-01 9:15 ` [PATCHv3 1/3] kernel/irq: make irq_{enter, exit}() " Marc Zyngier 2021-10-01 14:33 ` Pingfan Liu 2021-10-01 14:33 ` Pingfan Liu 2021-09-30 13:17 ` [PATCHv3 2/3] arm64: entry: refactor EL1 interrupt entry logic Pingfan Liu 2021-09-30 13:17 ` Pingfan Liu 2021-09-30 14:00 ` Mark Rutland 2021-09-30 14:00 ` Mark Rutland 2021-10-01 2:27 ` Pingfan Liu [this message] 2021-10-01 2:27 ` Pingfan Liu 2021-10-01 9:21 ` Marc Zyngier 2021-10-01 9:21 ` Marc Zyngier 2021-10-01 14:12 ` Pingfan Liu 2021-10-01 14:12 ` Pingfan Liu 2021-09-30 13:17 ` [PATCHv3 3/3] arm64/entry-common: supplement irq accounting Pingfan Liu 2021-09-30 13:17 ` Pingfan Liu 2021-09-30 13:53 ` Mark Rutland 2021-09-30 13:53 ` Mark Rutland 2021-10-01 9:22 ` Marc Zyngier 2021-10-01 9:22 ` Marc Zyngier 2021-10-01 14:10 ` Pingfan Liu 2021-10-01 14:10 ` Pingfan Liu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YVZyDIRnIMaxQjg9@piliu.users.ipa.redhat.com \ --to=kernelfans@gmail.com \ --cc=catalin.marinas@arm.com \ --cc=ito-yuichi@fujitsu.com \ --cc=joey.gouly@arm.com \ --cc=julien.thierry@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=maz@kernel.org \ --cc=paulmck@kernel.org \ --cc=samitolvanen@google.com \ --cc=tglx@linutronix.de \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.