* [PATCH iproute2] mptcp: unbreak JSON endpoint list
@ 2021-09-30 15:19 Davide Caratti
2021-10-01 9:35 ` Andrea Claudi
0 siblings, 1 reply; 2+ messages in thread
From: Davide Caratti @ 2021-09-30 15:19 UTC (permalink / raw)
To: aclaudi, pabeni, Stephen Hemminger; +Cc: mptcp, netdev
the following command:
# ip -j mptcp endpoint show
prints a JSON array that misses the terminating bracket. Fix this calling
delete_json_obj() to balance the call to new_json_obj().
Fixes: 7e0767cd862b ("add support for mptcp netlink interface")
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
---
ip/ipmptcp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ip/ipmptcp.c b/ip/ipmptcp.c
index bc12418bd39c..25d7d6784f89 100644
--- a/ip/ipmptcp.c
+++ b/ip/ipmptcp.c
@@ -262,7 +262,7 @@ static int mptcp_addr_dump(void)
return -2;
}
- close_json_object();
+ delete_json_obj();
fflush(stdout);
return 0;
}
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH iproute2] mptcp: unbreak JSON endpoint list
2021-09-30 15:19 [PATCH iproute2] mptcp: unbreak JSON endpoint list Davide Caratti
@ 2021-10-01 9:35 ` Andrea Claudi
0 siblings, 0 replies; 2+ messages in thread
From: Andrea Claudi @ 2021-10-01 9:35 UTC (permalink / raw)
To: Davide Caratti; +Cc: pabeni, Stephen Hemminger, mptcp, netdev
On Thu, Sep 30, 2021 at 05:19:25PM +0200, Davide Caratti wrote:
> the following command:
>
> # ip -j mptcp endpoint show
>
> prints a JSON array that misses the terminating bracket. Fix this calling
> delete_json_obj() to balance the call to new_json_obj().
>
> Fixes: 7e0767cd862b ("add support for mptcp netlink interface")
> Signed-off-by: Davide Caratti <dcaratti@redhat.com>
> ---
LGTM.
Acked-by: Andrea Claudi <aclaudi@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-01 9:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-30 15:19 [PATCH iproute2] mptcp: unbreak JSON endpoint list Davide Caratti
2021-10-01 9:35 ` Andrea Claudi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.