All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fernando Ramos <greenfoo@u92.eu>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Sean Paul <sean@poorly.run>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH v2 00/17] drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers where possible
Date: Sat, 2 Oct 2021 09:13:22 +0200	[thread overview]
Message-ID: <YVgGklsHT5fkavDL@zacax395.localdomain> (raw)
In-Reply-To: <YVfEWaLfYWdhezCa@intel.com>

On 21/10/02 05:30AM, Ville Syrjälä wrote:
> On Sat, Oct 02, 2021 at 01:05:47AM +0300, Ville Syrjälä wrote:
> > On Fri, Oct 01, 2021 at 04:48:15PM -0400, Sean Paul wrote:
> > > On Fri, Oct 01, 2021 at 10:00:50PM +0300, Ville Syrjälä wrote:
> > > > On Fri, Oct 01, 2021 at 02:36:55PM -0400, Sean Paul wrote:
> > > > > 
> > > > > Thank you for revising, Fernando! I've pushed the set to drm-misc-next (along
> > > > > with the necessary drm-tip conflict resolutions).
> > > > 
> > > > Ugh. Did anyone actually review the locking changes this does?
> > > > I shot the previous i915 stuff down because the commit messages
> > > > did not address any of it.
> > > 
> > > I reviewed the set on 9/17, I didn't see your feedback on that thread.
> > 
> > It was much earlir than that.
> > https://lists.freedesktop.org/archives/dri-devel/2021-June/313193.html
> > 
> > And I think I might have also shot down a similar thing earlier.
> > 
> > I was actually half considering sending a patch to nuke that
> > misleading TODO item. I don't think anything which changes
> > which locks are taken should be considred a starter level task.
> > And the commit messages here don't seem to address any of it.
> 
> And i915 is now broken :(
> 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10680/fi-bwr-2160/boot.html

I completely overlooked the side effects of not having a global context anymore.
Sorry for all the trouble.

Sean, could you revert the whole patch series? I'll have a deeper look into the
patch set and come up with a v3 where all these issues will be addressed.

Thanks and sorry once again for the extra overhead this might have caused.



WARNING: multiple messages have this Message-ID (diff)
From: Fernando Ramos <greenfoo@u92.eu>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Sean Paul <sean@poorly.run>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [Nouveau] [Intel-gfx] [PATCH v2 00/17] drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers where possible
Date: Sat, 2 Oct 2021 09:13:22 +0200	[thread overview]
Message-ID: <YVgGklsHT5fkavDL@zacax395.localdomain> (raw)
In-Reply-To: <YVfEWaLfYWdhezCa@intel.com>

On 21/10/02 05:30AM, Ville Syrjälä wrote:
> On Sat, Oct 02, 2021 at 01:05:47AM +0300, Ville Syrjälä wrote:
> > On Fri, Oct 01, 2021 at 04:48:15PM -0400, Sean Paul wrote:
> > > On Fri, Oct 01, 2021 at 10:00:50PM +0300, Ville Syrjälä wrote:
> > > > On Fri, Oct 01, 2021 at 02:36:55PM -0400, Sean Paul wrote:
> > > > > 
> > > > > Thank you for revising, Fernando! I've pushed the set to drm-misc-next (along
> > > > > with the necessary drm-tip conflict resolutions).
> > > > 
> > > > Ugh. Did anyone actually review the locking changes this does?
> > > > I shot the previous i915 stuff down because the commit messages
> > > > did not address any of it.
> > > 
> > > I reviewed the set on 9/17, I didn't see your feedback on that thread.
> > 
> > It was much earlir than that.
> > https://lists.freedesktop.org/archives/dri-devel/2021-June/313193.html
> > 
> > And I think I might have also shot down a similar thing earlier.
> > 
> > I was actually half considering sending a patch to nuke that
> > misleading TODO item. I don't think anything which changes
> > which locks are taken should be considred a starter level task.
> > And the commit messages here don't seem to address any of it.
> 
> And i915 is now broken :(
> 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10680/fi-bwr-2160/boot.html

I completely overlooked the side effects of not having a global context anymore.
Sorry for all the trouble.

Sean, could you revert the whole patch series? I'll have a deeper look into the
patch set and come up with a v3 where all these issues will be addressed.

Thanks and sorry once again for the extra overhead this might have caused.



  reply	other threads:[~2021-10-02  7:13 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-24  6:43 [PATCH v2 00/17] drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers where possible Fernando Ramos
2021-09-24  6:43 ` [Nouveau] " Fernando Ramos
2021-09-24  6:43 ` [Intel-gfx] " Fernando Ramos
2021-09-24  6:43 ` [PATCH v2 01/17] drm: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN() Fernando Ramos
2021-09-24  6:43   ` [Nouveau] " Fernando Ramos
2021-09-24  6:43   ` [Intel-gfx] " Fernando Ramos
2021-09-24  6:43 ` [PATCH v2 02/17] drm/i915: " Fernando Ramos
2021-09-24  6:43   ` [Nouveau] " Fernando Ramos
2021-09-24  6:43   ` [Intel-gfx] " Fernando Ramos
2021-09-24  6:43 ` [PATCH v2 03/17] drm/msm: " Fernando Ramos
2021-09-24  6:43   ` [Nouveau] " Fernando Ramos
2021-09-24  6:43   ` [Intel-gfx] " Fernando Ramos
2021-09-24  6:43 ` [PATCH v2 04/17] drm: cleanup: drm_modeset_lock_all() " Fernando Ramos
2021-09-24  6:43   ` [Nouveau] " Fernando Ramos
2021-09-24  6:43   ` [Intel-gfx] " Fernando Ramos
2021-09-24  6:43 ` [PATCH v2 05/17] drm/vmwgfx: " Fernando Ramos
2021-09-24  6:43   ` [Nouveau] " Fernando Ramos
2021-09-24  6:43   ` [Intel-gfx] " Fernando Ramos
2021-09-24  6:43 ` [PATCH v2 06/17] drm/tegra: " Fernando Ramos
2021-09-24  6:43   ` [Nouveau] " Fernando Ramos
2021-09-24  6:43   ` [Intel-gfx] " Fernando Ramos
2021-09-24  6:43 ` [PATCH v2 07/17] drm/shmobile: " Fernando Ramos
2021-09-24  6:43   ` [Nouveau] " Fernando Ramos
2021-09-24  6:43   ` [Intel-gfx] " Fernando Ramos
2021-09-24  6:43 ` [PATCH v2 08/17] drm/radeon: " Fernando Ramos
2021-09-24  6:43   ` [Nouveau] " Fernando Ramos
2021-09-24  6:43   ` [Intel-gfx] " Fernando Ramos
2021-09-24  6:43 ` [PATCH v2 09/17] drm/omapdrm: " Fernando Ramos
2021-09-24  6:43   ` [Nouveau] " Fernando Ramos
2021-09-24  6:43   ` [Intel-gfx] " Fernando Ramos
2021-09-24  6:43 ` [PATCH v2 10/17] drm/nouveau: " Fernando Ramos
2021-09-24  6:43   ` [Nouveau] " Fernando Ramos
2021-09-24  6:43   ` [Intel-gfx] " Fernando Ramos
2021-09-24  6:43 ` [PATCH v2 11/17] drm/msm: " Fernando Ramos
2021-09-24  6:43   ` [Nouveau] " Fernando Ramos
2021-09-24  6:43   ` [Intel-gfx] " Fernando Ramos
2021-09-24  6:43 ` [PATCH v2 12/17] drm/i915: " Fernando Ramos
2021-09-24  6:43   ` [Nouveau] " Fernando Ramos
2021-09-24  6:43   ` [Intel-gfx] " Fernando Ramos
2021-09-24  6:43 ` [PATCH v2 13/17] drm/i915: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN() part 2 Fernando Ramos
2021-09-24  6:43   ` [Nouveau] " Fernando Ramos
2021-09-24  6:43   ` [Intel-gfx] " Fernando Ramos
2021-09-24  6:43 ` [PATCH v2 14/17] drm/gma500: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN() Fernando Ramos
2021-09-24  6:43   ` [Nouveau] " Fernando Ramos
2021-09-24  6:43   ` [Intel-gfx] " Fernando Ramos
2021-09-24  6:43 ` [PATCH v2 15/17] drm/amd: " Fernando Ramos
2021-09-24  6:43   ` [Nouveau] " Fernando Ramos
2021-09-24  6:43   ` [Intel-gfx] " Fernando Ramos
2021-09-24  6:43 ` [PATCH v2 16/17] drm: cleanup: remove drm_modeset_(un)lock_all() Fernando Ramos
2021-09-24  6:43   ` [Nouveau] " Fernando Ramos
2021-09-24  6:43   ` [Intel-gfx] " Fernando Ramos
2021-09-24  6:43 ` [PATCH v2 17/17] doc: drm: remove TODO entry regarding DRM_MODSET_LOCK_ALL cleanup Fernando Ramos
2021-09-24  6:43   ` [Nouveau] " Fernando Ramos
2021-09-24  6:43   ` [Intel-gfx] " Fernando Ramos
2021-09-24  7:04 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers where possible (rev2) Patchwork
2021-10-01 18:36 ` [PATCH v2 00/17] drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers where possible Sean Paul
2021-10-01 18:36   ` [Intel-gfx] " Sean Paul
2021-10-01 18:36   ` [Nouveau] " Sean Paul
2021-10-01 19:00   ` Ville Syrjälä
2021-10-01 19:00     ` [Intel-gfx] " Ville Syrjälä
2021-10-01 19:00     ` [Nouveau] " Ville Syrjälä
2021-10-01 20:48     ` Sean Paul
2021-10-01 20:48       ` [Intel-gfx] " Sean Paul
2021-10-01 20:48       ` [Nouveau] " Sean Paul
2021-10-01 22:05       ` Ville Syrjälä
2021-10-01 22:05         ` [Intel-gfx] " Ville Syrjälä
2021-10-01 22:05         ` Ville Syrjälä
2021-10-02  2:30         ` [Intel-gfx] " Ville Syrjälä
2021-10-02  2:30           ` [Nouveau] " Ville Syrjälä
2021-10-02  7:13           ` Fernando Ramos [this message]
2021-10-02  7:13             ` Fernando Ramos
2021-10-02 17:28             ` Fernando Ramos
2021-10-02 17:28               ` [Nouveau] " Fernando Ramos
2021-10-04  8:01               ` Ville Syrjälä
2021-10-04  8:01                 ` Ville Syrjälä
2021-10-02 22:32             ` Fernando Ramos
2021-10-02 22:32               ` [Nouveau] " Fernando Ramos
2021-10-04  8:19               ` Ville Syrjälä
2021-10-04  8:19                 ` [Nouveau] " Ville Syrjälä
2021-10-04  8:39                 ` Jani Nikula
2021-10-04  8:39                   ` [Nouveau] " Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YVgGklsHT5fkavDL@zacax395.localdomain \
    --to=greenfoo@u92.eu \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=sean@poorly.run \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.