From: Stefan Hajnoczi <stefanha@redhat.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: miklos@szeredi.hu, qemu-devel@nongnu.org, iangelak@redhat.com,
dgilbert@redhat.com, virtio-fs@redhat.com, jaggel@bu.edu
Subject: Re: [PATCH 04/13] virtiofsd: Add a helper to send element on virtqueue
Date: Mon, 4 Oct 2021 14:19:46 +0100 [thread overview]
Message-ID: <YVr/clKO1o2RoG+Z@stefanha-x1.localdomain> (raw)
In-Reply-To: <20210930153037.1194279-5-vgoyal@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 494 bytes --]
On Thu, Sep 30, 2021 at 11:30:28AM -0400, Vivek Goyal wrote:
> We have open coded logic to take locks and push element on virtqueue at
> three places. Add a helper and use it everywhere. Code is easier to read and
> less number of lines of code.
>
> Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
> ---
> tools/virtiofsd/fuse_virtio.c | 45 ++++++++++++++---------------------
> 1 file changed, 18 insertions(+), 27 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: miklos@szeredi.hu, qemu-devel@nongnu.org, virtio-fs@redhat.com
Subject: Re: [Virtio-fs] [PATCH 04/13] virtiofsd: Add a helper to send element on virtqueue
Date: Mon, 4 Oct 2021 14:19:46 +0100 [thread overview]
Message-ID: <YVr/clKO1o2RoG+Z@stefanha-x1.localdomain> (raw)
In-Reply-To: <20210930153037.1194279-5-vgoyal@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 494 bytes --]
On Thu, Sep 30, 2021 at 11:30:28AM -0400, Vivek Goyal wrote:
> We have open coded logic to take locks and push element on virtqueue at
> three places. Add a helper and use it everywhere. Code is easier to read and
> less number of lines of code.
>
> Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
> ---
> tools/virtiofsd/fuse_virtio.c | 45 ++++++++++++++---------------------
> 1 file changed, 18 insertions(+), 27 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-10-04 13:22 UTC|newest]
Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 15:30 [PATCH 00/13] virtiofsd: Support notification queue and Vivek Goyal
2021-09-30 15:30 ` [Virtio-fs] " Vivek Goyal
2021-09-30 15:30 ` [PATCH 01/13] virtio_fs.h: Add notification queue feature bit Vivek Goyal
2021-09-30 15:30 ` [Virtio-fs] " Vivek Goyal
2021-10-04 13:12 ` Stefan Hajnoczi
2021-10-04 13:12 ` [Virtio-fs] " Stefan Hajnoczi
2021-09-30 15:30 ` [PATCH 02/13] virtiofsd: fuse.h header file changes for lock notification Vivek Goyal
2021-09-30 15:30 ` [Virtio-fs] " Vivek Goyal
2021-10-04 13:16 ` Stefan Hajnoczi
2021-10-04 13:16 ` [Virtio-fs] " Stefan Hajnoczi
2021-10-04 14:01 ` Vivek Goyal
2021-10-04 14:01 ` [Virtio-fs] " Vivek Goyal
2021-09-30 15:30 ` [PATCH 03/13] virtiofsd: Remove unused virtio_fs_config definition Vivek Goyal
2021-09-30 15:30 ` [Virtio-fs] " Vivek Goyal
2021-10-04 13:17 ` Stefan Hajnoczi
2021-10-04 13:17 ` [Virtio-fs] " Stefan Hajnoczi
2021-09-30 15:30 ` [PATCH 04/13] virtiofsd: Add a helper to send element on virtqueue Vivek Goyal
2021-09-30 15:30 ` [Virtio-fs] " Vivek Goyal
2021-10-04 13:19 ` Stefan Hajnoczi [this message]
2021-10-04 13:19 ` Stefan Hajnoczi
2021-09-30 15:30 ` [PATCH 05/13] virtiofsd: Add a helper to stop all queues Vivek Goyal
2021-09-30 15:30 ` [Virtio-fs] " Vivek Goyal
2021-10-04 13:22 ` Stefan Hajnoczi
2021-10-04 13:22 ` [Virtio-fs] " Stefan Hajnoczi
2021-09-30 15:30 ` [PATCH 06/13] vhost-user-fs: Use helpers to create/cleanup virtqueue Vivek Goyal
2021-09-30 15:30 ` [Virtio-fs] " Vivek Goyal
2021-10-04 13:54 ` Stefan Hajnoczi
2021-10-04 13:54 ` [Virtio-fs] " Stefan Hajnoczi
2021-10-04 19:58 ` Vivek Goyal
2021-10-04 19:58 ` [Virtio-fs] " Vivek Goyal
2021-10-05 8:09 ` Stefan Hajnoczi
2021-10-05 8:09 ` [Virtio-fs] " Stefan Hajnoczi
2021-10-06 13:35 ` Christophe de Dinechin
2021-10-06 13:35 ` Christophe de Dinechin
2021-10-06 17:40 ` Vivek Goyal
2021-10-06 17:40 ` Vivek Goyal
2021-09-30 15:30 ` [PATCH 07/13] virtiofsd: Release file locks using F_UNLCK Vivek Goyal
2021-09-30 15:30 ` [Virtio-fs] " Vivek Goyal
2021-10-05 13:37 ` Christophe de Dinechin
2021-10-05 13:37 ` Christophe de Dinechin
2021-10-05 15:38 ` Vivek Goyal
2021-10-05 15:38 ` Vivek Goyal
2021-09-30 15:30 ` [PATCH 08/13] virtiofsd: Create a notification queue Vivek Goyal
2021-09-30 15:30 ` [Virtio-fs] " Vivek Goyal
2021-10-04 14:30 ` Stefan Hajnoczi
2021-10-04 14:30 ` [Virtio-fs] " Stefan Hajnoczi
2021-10-04 21:01 ` Vivek Goyal
2021-10-04 21:01 ` [Virtio-fs] " Vivek Goyal
2021-10-05 8:14 ` Stefan Hajnoczi
2021-10-05 8:14 ` [Virtio-fs] " Stefan Hajnoczi
2021-10-05 12:31 ` Vivek Goyal
2021-10-05 12:31 ` [Virtio-fs] " Vivek Goyal
2021-09-30 15:30 ` [PATCH 09/13] virtiofsd: Specify size of notification buffer using config space Vivek Goyal
2021-09-30 15:30 ` [Virtio-fs] " Vivek Goyal
2021-10-04 14:33 ` Stefan Hajnoczi
2021-10-04 14:33 ` [Virtio-fs] " Stefan Hajnoczi
2021-10-04 21:10 ` Vivek Goyal
2021-10-04 21:10 ` [Virtio-fs] " Vivek Goyal
2021-10-06 10:05 ` Christophe de Dinechin
2021-10-06 10:05 ` Christophe de Dinechin
2021-09-30 15:30 ` [PATCH 10/13] virtiofsd: Custom threadpool for remote blocking posix locks requests Vivek Goyal
2021-09-30 15:30 ` [Virtio-fs] " Vivek Goyal
2021-10-04 14:54 ` Stefan Hajnoczi
2021-10-04 14:54 ` [Virtio-fs] " Stefan Hajnoczi
2021-10-05 13:06 ` Vivek Goyal
2021-10-05 13:06 ` [Virtio-fs] " Vivek Goyal
2021-10-05 20:09 ` Vivek Goyal
2021-10-05 20:09 ` [Virtio-fs] " Vivek Goyal
2021-10-06 10:26 ` Stefan Hajnoczi
2021-10-06 10:26 ` [Virtio-fs] " Stefan Hajnoczi
2021-09-30 15:30 ` [PATCH 11/13] virtiofsd: Shutdown notification queue in the end Vivek Goyal
2021-09-30 15:30 ` [Virtio-fs] " Vivek Goyal
2021-10-04 15:01 ` Stefan Hajnoczi
2021-10-04 15:01 ` [Virtio-fs] " Stefan Hajnoczi
2021-10-05 13:19 ` Vivek Goyal
2021-10-05 13:19 ` [Virtio-fs] " Vivek Goyal
2021-10-06 15:15 ` Christophe de Dinechin
2021-10-06 15:15 ` Christophe de Dinechin
2021-10-06 17:58 ` Vivek Goyal
2021-10-06 17:58 ` Vivek Goyal
2021-09-30 15:30 ` [PATCH 12/13] virtiofsd: Implement blocking posix locks Vivek Goyal
2021-09-30 15:30 ` [Virtio-fs] " Vivek Goyal
2021-10-04 15:07 ` Stefan Hajnoczi
2021-10-04 15:07 ` [Virtio-fs] " Stefan Hajnoczi
2021-10-05 13:26 ` Vivek Goyal
2021-10-05 13:26 ` [Virtio-fs] " Vivek Goyal
2021-10-05 12:22 ` Stefan Hajnoczi
2021-10-05 12:22 ` [Virtio-fs] " Stefan Hajnoczi
2021-10-05 15:14 ` Vivek Goyal
2021-10-05 15:14 ` [Virtio-fs] " Vivek Goyal
2021-10-05 15:49 ` Stefan Hajnoczi
2021-10-05 15:49 ` [Virtio-fs] " Stefan Hajnoczi
2021-10-06 15:34 ` Christophe de Dinechin
2021-10-06 15:34 ` Christophe de Dinechin
2021-10-06 18:17 ` Vivek Goyal
2021-10-06 18:17 ` Vivek Goyal
2021-09-30 15:30 ` [PATCH 13/13] virtiofsd, seccomp: Add clock_nanosleep() to allow list Vivek Goyal
2021-09-30 15:30 ` [Virtio-fs] " Vivek Goyal
2021-10-05 12:22 ` Stefan Hajnoczi
2021-10-05 12:22 ` [Virtio-fs] " Stefan Hajnoczi
2021-10-05 15:16 ` Vivek Goyal
2021-10-05 15:50 ` Stefan Hajnoczi
2021-10-05 17:28 ` Vivek Goyal
2021-10-06 10:27 ` Stefan Hajnoczi
2021-10-25 18:00 ` [PATCH 00/13] virtiofsd: Support notification queue and Dr. David Alan Gilbert
2021-10-25 18:00 ` [Virtio-fs] " Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVr/clKO1o2RoG+Z@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=dgilbert@redhat.com \
--cc=iangelak@redhat.com \
--cc=jaggel@bu.edu \
--cc=miklos@szeredi.hu \
--cc=qemu-devel@nongnu.org \
--cc=vgoyal@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.