* [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add retry mechanism for async flip subtests
@ 2021-10-04 8:56 Karthik B S
2021-10-04 9:19 ` Ville Syrjälä
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Karthik B S @ 2021-10-04 8:56 UTC (permalink / raw)
To: igt-dev; +Cc: juha-pekka.heikkila, Karthik B S
Async flip subtests fail sporadically with CRC failure on CI.
This is expected as these tests are not run on highest priority by the
scheduler, but this creates noise on CI. Add retry mechanism to rerun
the test once if failure is seen.
Signed-off-by: Karthik B S <karthik.b.s@intel.com>
---
tests/i915/kms_big_fb.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/tests/i915/kms_big_fb.c b/tests/i915/kms_big_fb.c
index 308227c9..8c09f59e 100644
--- a/tests/i915/kms_big_fb.c
+++ b/tests/i915/kms_big_fb.c
@@ -481,6 +481,7 @@ max_hw_stride_async_flip_test(data_t *data)
h = data->output->config.default_mode.vdisplay;
igt_plane_t *primary;
igt_crc_t compare_crc, async_crc;
+ bool retried = false;
igt_require(data->display.is_atomic);
igt_output_set_pipe(data->output, data->pipe);
@@ -513,6 +514,7 @@ max_hw_stride_async_flip_test(data_t *data)
INTEL_PIPE_CRC_SOURCE_AUTO);
igt_pipe_crc_start(data->pipe_crc);
+retry:
igt_set_timeout(5, "Async pageflipping loop got stuck!\n");
for (int i = 0; i < 2; i++) {
igt_plane_set_fb(primary, &data->big_fb);
@@ -548,6 +550,13 @@ max_hw_stride_async_flip_test(data_t *data)
igt_assert_f(kmstest_get_vblank(data->drm_fd, data->pipe, 0) -
startframe == 1, "lost frames\n");
+ /* Test is not running at real time priority, so allow one failure*/
+ if (!(igt_check_crc_equal(&compare_crc, &async_crc)^(i^1)) && !retried) {
+ retried = true;
+ igt_reset_timeout();
+ goto retry;
+ }
+
igt_assert_f(igt_check_crc_equal(&compare_crc, &async_crc)^(i^1),
"CRC failure with async flip, crc %s match for checked round\n",
i?"should":"shouldn't");
--
2.22.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add retry mechanism for async flip subtests
2021-10-04 8:56 [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add retry mechanism for async flip subtests Karthik B S
@ 2021-10-04 9:19 ` Ville Syrjälä
2021-10-04 15:43 ` Ville Syrjälä
2021-10-04 13:31 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-10-04 16:31 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 1 reply; 10+ messages in thread
From: Ville Syrjälä @ 2021-10-04 9:19 UTC (permalink / raw)
To: Karthik B S; +Cc: igt-dev, juha-pekka.heikkila
On Mon, Oct 04, 2021 at 02:26:29PM +0530, Karthik B S wrote:
> Async flip subtests fail sporadically with CRC failure on CI.
> This is expected as these tests are not run on highest priority by the
> scheduler, but this creates noise on CI. Add retry mechanism to rerun
> the test once if failure is seen.
>
> Signed-off-by: Karthik B S <karthik.b.s@intel.com>
> ---
> tests/i915/kms_big_fb.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/tests/i915/kms_big_fb.c b/tests/i915/kms_big_fb.c
> index 308227c9..8c09f59e 100644
> --- a/tests/i915/kms_big_fb.c
> +++ b/tests/i915/kms_big_fb.c
> @@ -481,6 +481,7 @@ max_hw_stride_async_flip_test(data_t *data)
> h = data->output->config.default_mode.vdisplay;
> igt_plane_t *primary;
> igt_crc_t compare_crc, async_crc;
> + bool retried = false;
>
> igt_require(data->display.is_atomic);
> igt_output_set_pipe(data->output, data->pipe);
> @@ -513,6 +514,7 @@ max_hw_stride_async_flip_test(data_t *data)
> INTEL_PIPE_CRC_SOURCE_AUTO);
> igt_pipe_crc_start(data->pipe_crc);
>
> +retry:
> igt_set_timeout(5, "Async pageflipping loop got stuck!\n");
> for (int i = 0; i < 2; i++) {
> igt_plane_set_fb(primary, &data->big_fb);
> @@ -548,6 +550,13 @@ max_hw_stride_async_flip_test(data_t *data)
> igt_assert_f(kmstest_get_vblank(data->drm_fd, data->pipe, 0) -
> startframe == 1, "lost frames\n");
>
> + /* Test is not running at real time priority, so allow one failure*/
> + if (!(igt_check_crc_equal(&compare_crc, &async_crc)^(i^1)) && !retried) {
> + retried = true;
> + igt_reset_timeout();
> + goto retry;
> + }
> +
This test seems to entirely fit kms_big_fb in general. I don't
think kms_big_fb should be testing any timing sensitive stuff.
So I think we should change this to a form that follows the rest
of kms_big_fb to validate that each page flip just presents the
correct data on screen. The timing sensitive stuff is best left
for kms_async_flip.
So this should maybe be something like: flip to a correctly sized
temp fb with the wrong contents and change the plane src coordinates,
and then async flip back to the correct fb and validate the
correct data is now on screen.
Oh and the async flip test should not be limited to the
max-hw-stride part. We should test that async flips do the
right thing with gtt remapping as well.
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_big_fb: Add retry mechanism for async flip subtests
2021-10-04 8:56 [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add retry mechanism for async flip subtests Karthik B S
2021-10-04 9:19 ` Ville Syrjälä
@ 2021-10-04 13:31 ` Patchwork
2021-10-04 16:31 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2021-10-04 13:31 UTC (permalink / raw)
To: Karthik B S; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 5294 bytes --]
== Series Details ==
Series: tests/kms_big_fb: Add retry mechanism for async flip subtests
URL : https://patchwork.freedesktop.org/series/95395/
State : success
== Summary ==
CI Bug Log - changes from IGT_6229 -> IGTPW_6278
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/index.html
Known issues
------------
Here are the changes found in IGTPW_6278 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@cs-gfx:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271]) +7 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/fi-kbl-soraka/igt@amdgpu/amd_basic@cs-gfx.html
* igt@amdgpu/amd_cs_nop@nop-compute0:
- fi-ilk-650: NOTRUN -> [SKIP][2] ([fdo#109271]) +35 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/fi-ilk-650/igt@amdgpu/amd_cs_nop@nop-compute0.html
* igt@core_hotunplug@unbind-rebind:
- fi-bdw-samus: NOTRUN -> [WARN][3] ([i915#3718])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/fi-bdw-samus/igt@core_hotunplug@unbind-rebind.html
* igt@kms_chamelium@dp-hpd-fast:
- fi-ilk-650: NOTRUN -> [SKIP][4] ([fdo#109271] / [fdo#111827]) +8 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/fi-ilk-650/igt@kms_chamelium@dp-hpd-fast.html
* igt@kms_chamelium@hdmi-edid-read:
- fi-bdw-samus: NOTRUN -> [SKIP][5] ([fdo#109271] / [fdo#111827]) +8 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/fi-bdw-samus/igt@kms_chamelium@hdmi-edid-read.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-bdw-samus: NOTRUN -> [SKIP][6] ([fdo#109271]) +29 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/fi-bdw-samus/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@prime_vgem@basic-userptr:
- fi-pnv-d510: NOTRUN -> [SKIP][7] ([fdo#109271]) +48 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/fi-pnv-d510/igt@prime_vgem@basic-userptr.html
#### Possible fixes ####
* igt@gem_exec_parallel@engines@userptr:
- fi-pnv-d510: [INCOMPLETE][8] ([i915#299]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/fi-pnv-d510/igt@gem_exec_parallel@engines@userptr.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/fi-pnv-d510/igt@gem_exec_parallel@engines@userptr.html
* igt@gem_exec_suspend@basic-s3:
- fi-bdw-samus: [INCOMPLETE][10] ([i915#146] / [i915#4173]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/fi-bdw-samus/igt@gem_exec_suspend@basic-s3.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/fi-bdw-samus/igt@gem_exec_suspend@basic-s3.html
- fi-tgl-1115g4: [FAIL][12] ([i915#1888]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html
* igt@kms_chamelium@hdmi-edid-read:
- fi-kbl-7500u: [FAIL][14] ([i915#3449]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/fi-kbl-7500u/igt@kms_chamelium@hdmi-edid-read.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/fi-kbl-7500u/igt@kms_chamelium@hdmi-edid-read.html
* igt@kms_frontbuffer_tracking@basic:
- fi-cml-u2: [DMESG-WARN][16] ([i915#95]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1993]: https://gitlab.freedesktop.org/drm/intel/issues/1993
[i915#299]: https://gitlab.freedesktop.org/drm/intel/issues/299
[i915#3449]: https://gitlab.freedesktop.org/drm/intel/issues/3449
[i915#3718]: https://gitlab.freedesktop.org/drm/intel/issues/3718
[i915#4173]: https://gitlab.freedesktop.org/drm/intel/issues/4173
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (33 -> 33)
------------------------------
Additional (1): fi-ilk-650
Missing (1): fi-bsw-cyan
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6229 -> IGTPW_6278
CI-20190529: 20190529
CI_DRM_10681: fe9b639a95a08713c8ee4ef110ce6a6388c9f9f2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6278: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/index.html
IGT_6229: dff598c339a2da647f15c86d0015e16378c7ea9b @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/index.html
[-- Attachment #2: Type: text/html, Size: 6526 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add retry mechanism for async flip subtests
2021-10-04 9:19 ` Ville Syrjälä
@ 2021-10-04 15:43 ` Ville Syrjälä
2021-10-05 10:00 ` Karthik B S
0 siblings, 1 reply; 10+ messages in thread
From: Ville Syrjälä @ 2021-10-04 15:43 UTC (permalink / raw)
To: Karthik B S; +Cc: igt-dev, juha-pekka.heikkila
On Mon, Oct 04, 2021 at 12:19:01PM +0300, Ville Syrjälä wrote:
> On Mon, Oct 04, 2021 at 02:26:29PM +0530, Karthik B S wrote:
> > Async flip subtests fail sporadically with CRC failure on CI.
> > This is expected as these tests are not run on highest priority by the
> > scheduler, but this creates noise on CI. Add retry mechanism to rerun
> > the test once if failure is seen.
> >
> > Signed-off-by: Karthik B S <karthik.b.s@intel.com>
> > ---
> > tests/i915/kms_big_fb.c | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/tests/i915/kms_big_fb.c b/tests/i915/kms_big_fb.c
> > index 308227c9..8c09f59e 100644
> > --- a/tests/i915/kms_big_fb.c
> > +++ b/tests/i915/kms_big_fb.c
> > @@ -481,6 +481,7 @@ max_hw_stride_async_flip_test(data_t *data)
> > h = data->output->config.default_mode.vdisplay;
> > igt_plane_t *primary;
> > igt_crc_t compare_crc, async_crc;
> > + bool retried = false;
> >
> > igt_require(data->display.is_atomic);
> > igt_output_set_pipe(data->output, data->pipe);
> > @@ -513,6 +514,7 @@ max_hw_stride_async_flip_test(data_t *data)
> > INTEL_PIPE_CRC_SOURCE_AUTO);
> > igt_pipe_crc_start(data->pipe_crc);
> >
> > +retry:
> > igt_set_timeout(5, "Async pageflipping loop got stuck!\n");
> > for (int i = 0; i < 2; i++) {
> > igt_plane_set_fb(primary, &data->big_fb);
> > @@ -548,6 +550,13 @@ max_hw_stride_async_flip_test(data_t *data)
> > igt_assert_f(kmstest_get_vblank(data->drm_fd, data->pipe, 0) -
> > startframe == 1, "lost frames\n");
> >
> > + /* Test is not running at real time priority, so allow one failure*/
> > + if (!(igt_check_crc_equal(&compare_crc, &async_crc)^(i^1)) && !retried) {
> > + retried = true;
> > + igt_reset_timeout();
> > + goto retry;
> > + }
> > +
>
> This test seems to entirely fit kms_big_fb in general. I don't
^
not
is what I meant to write. Somewhat important small word.
> think kms_big_fb should be testing any timing sensitive stuff.
>
> So I think we should change this to a form that follows the rest
> of kms_big_fb to validate that each page flip just presents the
> correct data on screen. The timing sensitive stuff is best left
> for kms_async_flip.
>
> So this should maybe be something like: flip to a correctly sized
> temp fb with the wrong contents and change the plane src coordinates,
> and then async flip back to the correct fb and validate the
> correct data is now on screen.
>
> Oh and the async flip test should not be limited to the
> max-hw-stride part. We should test that async flips do the
> right thing with gtt remapping as well.
>
> --
> Ville Syrjälä
> Intel
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_big_fb: Add retry mechanism for async flip subtests
2021-10-04 8:56 [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add retry mechanism for async flip subtests Karthik B S
2021-10-04 9:19 ` Ville Syrjälä
2021-10-04 13:31 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2021-10-04 16:31 ` Patchwork
2 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2021-10-04 16:31 UTC (permalink / raw)
To: Karthik B S; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 30278 bytes --]
== Series Details ==
Series: tests/kms_big_fb: Add retry mechanism for async flip subtests
URL : https://patchwork.freedesktop.org/series/95395/
State : success
== Summary ==
CI Bug Log - changes from IGT_6229_full -> IGTPW_6278_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/index.html
Known issues
------------
Here are the changes found in IGTPW_6278_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@preservation-s3@rcs0:
- shard-apl: [PASS][1] -> [DMESG-WARN][2] ([i915#180]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-apl3/igt@gem_ctx_isolation@preservation-s3@rcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-apl2/igt@gem_ctx_isolation@preservation-s3@rcs0.html
* igt@gem_ctx_persistence@legacy-engines-queued:
- shard-snb: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#1099]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-snb6/igt@gem_ctx_persistence@legacy-engines-queued.html
* igt@gem_eio@unwedge-stress:
- shard-tglb: NOTRUN -> [TIMEOUT][4] ([i915#2369] / [i915#3063] / [i915#3648])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb3/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [PASS][5] -> [FAIL][6] ([i915#2842]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-tglb6/igt@gem_exec_fair@basic-flow@rcs0.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb1/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-glk: [PASS][7] -> [FAIL][8] ([i915#2842])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-glk7/igt@gem_exec_fair@basic-none-share@rcs0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-glk3/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-kbl: NOTRUN -> [FAIL][9] ([i915#2842])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-kbl3/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [PASS][10] -> [FAIL][11] ([i915#2842]) +3 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-kbl1/igt@gem_exec_fair@basic-pace@vecs0.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-kbl3/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-tglb: NOTRUN -> [FAIL][12] ([i915#2842])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb8/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- shard-iclb: NOTRUN -> [SKIP][13] ([fdo#109313])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-iclb5/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html
- shard-tglb: NOTRUN -> [SKIP][14] ([fdo#109313])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb8/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html
* igt@gem_exec_suspend@basic-s3:
- shard-tglb: NOTRUN -> [INCOMPLETE][15] ([i915#4173] / [i915#456])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb7/igt@gem_exec_suspend@basic-s3.html
- shard-apl: NOTRUN -> [DMESG-WARN][16] ([i915#180])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-apl2/igt@gem_exec_suspend@basic-s3.html
* igt@gem_huc_copy@huc-copy:
- shard-apl: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#2190])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-apl8/igt@gem_huc_copy@huc-copy.html
* igt@gem_pread@exhaustion:
- shard-apl: NOTRUN -> [WARN][18] ([i915#2658])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-apl7/igt@gem_pread@exhaustion.html
* igt@gem_render_copy@y-tiled-to-vebox-linear:
- shard-iclb: NOTRUN -> [SKIP][19] ([i915#768]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-iclb6/igt@gem_render_copy@y-tiled-to-vebox-linear.html
* igt@gen3_render_mixed_blits:
- shard-iclb: NOTRUN -> [SKIP][20] ([fdo#109289])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-iclb8/igt@gen3_render_mixed_blits.html
* igt@gen3_render_tiledy_blits:
- shard-tglb: NOTRUN -> [SKIP][21] ([fdo#109289]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb3/igt@gen3_render_tiledy_blits.html
* igt@gen9_exec_parse@bb-chained:
- shard-tglb: NOTRUN -> [SKIP][22] ([i915#2856])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb8/igt@gen9_exec_parse@bb-chained.html
* igt@i915_pm_dc@dc6-dpms:
- shard-kbl: NOTRUN -> [FAIL][23] ([i915#454])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-kbl6/igt@i915_pm_dc@dc6-dpms.html
- shard-tglb: NOTRUN -> [FAIL][24] ([i915#454])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb3/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][25] -> [FAIL][26] ([i915#454])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-iclb4/igt@i915_pm_dc@dc6-psr.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-iclb6/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-apl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#1937])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-apl3/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-tglb: NOTRUN -> [WARN][28] ([i915#2681] / [i915#2684])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb1/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- shard-iclb: NOTRUN -> [SKIP][29] ([fdo#109293] / [fdo#109506])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-iclb8/igt@i915_pm_rpm@gem-execbuf-stress-pc8.html
- shard-tglb: NOTRUN -> [SKIP][30] ([fdo#109506] / [i915#2411])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb1/igt@i915_pm_rpm@gem-execbuf-stress-pc8.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [PASS][31] -> [INCOMPLETE][32] ([i915#3921])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-snb6/igt@i915_selftest@live@hangcheck.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-snb6/igt@i915_selftest@live@hangcheck.html
* igt@i915_suspend@fence-restore-untiled:
- shard-kbl: NOTRUN -> [DMESG-WARN][33] ([i915#180])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-kbl4/igt@i915_suspend@fence-restore-untiled.html
* igt@kms_atomic_transition@plane-all-modeset-transition:
- shard-iclb: NOTRUN -> [SKIP][34] ([i915#1769])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-iclb1/igt@kms_atomic_transition@plane-all-modeset-transition.html
* igt@kms_big_fb@linear-32bpp-rotate-180:
- shard-glk: [PASS][35] -> [DMESG-WARN][36] ([i915#118] / [i915#95]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-glk5/igt@kms_big_fb@linear-32bpp-rotate-180.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-glk7/igt@kms_big_fb@linear-32bpp-rotate-180.html
* igt@kms_big_fb@x-tiled-8bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][37] ([fdo#111614]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb3/igt@kms_big_fb@x-tiled-8bpp-rotate-270.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-apl: NOTRUN -> [SKIP][38] ([fdo#109271] / [i915#3777]) +1 similar issue
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-apl7/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-kbl: NOTRUN -> [SKIP][39] ([fdo#109271] / [i915#3777])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-kbl4/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
* igt@kms_big_fb@yf-tiled-64bpp-rotate-0:
- shard-iclb: NOTRUN -> [SKIP][40] ([fdo#110723])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-iclb3/igt@kms_big_fb@yf-tiled-64bpp-rotate-0.html
* igt@kms_big_joiner@2x-modeset:
- shard-iclb: NOTRUN -> [SKIP][41] ([i915#2705])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-iclb1/igt@kms_big_joiner@2x-modeset.html
- shard-tglb: NOTRUN -> [SKIP][42] ([i915#2705])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb5/igt@kms_big_joiner@2x-modeset.html
* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][43] ([i915#3689] / [i915#3886]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb1/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#3886]) +7 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-kbl3/igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#3886]) +12 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-apl7/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][46] ([fdo#109271] / [i915#3886])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-glk4/igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html
- shard-iclb: NOTRUN -> [SKIP][47] ([fdo#109278] / [i915#3886])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-iclb8/igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][48] ([i915#3689]) +12 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb8/igt@kms_ccs@pipe-d-bad-aux-stride-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@dp-hpd-fast:
- shard-glk: NOTRUN -> [SKIP][49] ([fdo#109271] / [fdo#111827]) +7 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-glk3/igt@kms_chamelium@dp-hpd-fast.html
* igt@kms_chamelium@hdmi-audio:
- shard-iclb: NOTRUN -> [SKIP][50] ([fdo#109284] / [fdo#111827]) +7 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-iclb3/igt@kms_chamelium@hdmi-audio.html
* igt@kms_chamelium@hdmi-edid-change-during-suspend:
- shard-apl: NOTRUN -> [SKIP][51] ([fdo#109271] / [fdo#111827]) +14 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-apl2/igt@kms_chamelium@hdmi-edid-change-during-suspend.html
* igt@kms_chamelium@hdmi-hpd-enable-disable-mode:
- shard-snb: NOTRUN -> [SKIP][52] ([fdo#109271] / [fdo#111827]) +23 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-snb6/igt@kms_chamelium@hdmi-hpd-enable-disable-mode.html
* igt@kms_color@pipe-d-ctm-blue-to-red:
- shard-iclb: NOTRUN -> [SKIP][53] ([fdo#109278] / [i915#1149])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-iclb4/igt@kms_color@pipe-d-ctm-blue-to-red.html
* igt@kms_color_chamelium@pipe-a-degamma:
- shard-kbl: NOTRUN -> [SKIP][54] ([fdo#109271] / [fdo#111827]) +19 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-kbl4/igt@kms_color_chamelium@pipe-a-degamma.html
* igt@kms_color_chamelium@pipe-d-ctm-blue-to-red:
- shard-tglb: NOTRUN -> [SKIP][55] ([fdo#109284] / [fdo#111827]) +10 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb7/igt@kms_color_chamelium@pipe-d-ctm-blue-to-red.html
- shard-iclb: NOTRUN -> [SKIP][56] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-iclb3/igt@kms_color_chamelium@pipe-d-ctm-blue-to-red.html
* igt@kms_concurrent@pipe-d:
- shard-tglb: NOTRUN -> [FAIL][57] ([i915#1385])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb3/igt@kms_concurrent@pipe-d.html
* igt@kms_content_protection@atomic-dpms:
- shard-apl: NOTRUN -> [TIMEOUT][58] ([i915#1319]) +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-apl1/igt@kms_content_protection@atomic-dpms.html
* igt@kms_content_protection@dp-mst-lic-type-0:
- shard-iclb: NOTRUN -> [SKIP][59] ([i915#3116])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-iclb8/igt@kms_content_protection@dp-mst-lic-type-0.html
- shard-tglb: NOTRUN -> [SKIP][60] ([i915#3116])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb1/igt@kms_content_protection@dp-mst-lic-type-0.html
* igt@kms_content_protection@legacy:
- shard-kbl: NOTRUN -> [TIMEOUT][61] ([i915#1319]) +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-kbl6/igt@kms_content_protection@legacy.html
- shard-tglb: NOTRUN -> [SKIP][62] ([fdo#111828]) +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb3/igt@kms_content_protection@legacy.html
* igt@kms_cursor_crc@pipe-a-cursor-512x512-rapid-movement:
- shard-iclb: NOTRUN -> [SKIP][63] ([fdo#109278] / [fdo#109279]) +2 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-iclb8/igt@kms_cursor_crc@pipe-a-cursor-512x512-rapid-movement.html
* igt@kms_cursor_crc@pipe-b-cursor-32x10-random:
- shard-tglb: NOTRUN -> [SKIP][64] ([i915#3359]) +3 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb8/igt@kms_cursor_crc@pipe-b-cursor-32x10-random.html
* igt@kms_cursor_crc@pipe-c-cursor-32x32-random:
- shard-tglb: NOTRUN -> [SKIP][65] ([i915#3319]) +3 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb2/igt@kms_cursor_crc@pipe-c-cursor-32x32-random.html
* igt@kms_cursor_crc@pipe-d-cursor-256x256-onscreen:
- shard-kbl: NOTRUN -> [SKIP][66] ([fdo#109271]) +198 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-kbl7/igt@kms_cursor_crc@pipe-d-cursor-256x256-onscreen.html
* igt@kms_cursor_crc@pipe-d-cursor-512x512-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][67] ([fdo#109279] / [i915#3359]) +3 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb5/igt@kms_cursor_crc@pipe-d-cursor-512x512-rapid-movement.html
* igt@kms_cursor_edge_walk@pipe-d-256x256-left-edge:
- shard-iclb: NOTRUN -> [SKIP][68] ([fdo#109278]) +24 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-iclb5/igt@kms_cursor_edge_walk@pipe-d-256x256-left-edge.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: NOTRUN -> [FAIL][69] ([i915#72])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
* igt@kms_cursor_legacy@cursora-vs-flipb-atomic:
- shard-iclb: NOTRUN -> [SKIP][70] ([fdo#109274] / [fdo#109278]) +4 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-iclb2/igt@kms_cursor_legacy@cursora-vs-flipb-atomic.html
* igt@kms_cursor_legacy@cursorb-vs-flipb-atomic:
- shard-tglb: NOTRUN -> [SKIP][71] ([fdo#111825]) +35 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb5/igt@kms_cursor_legacy@cursorb-vs-flipb-atomic.html
* igt@kms_dither@fb-8bpc-vs-panel-8bpc@edp-1-pipe-a:
- shard-tglb: NOTRUN -> [SKIP][72] ([i915#3788])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb1/igt@kms_dither@fb-8bpc-vs-panel-8bpc@edp-1-pipe-a.html
* igt@kms_flip@2x-flip-vs-wf_vblank-interruptible:
- shard-iclb: NOTRUN -> [SKIP][73] ([fdo#109274]) +5 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-iclb4/igt@kms_flip@2x-flip-vs-wf_vblank-interruptible.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1:
- shard-glk: [PASS][74] -> [FAIL][75] ([i915#79])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-glk2/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-glk4/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-tglb: NOTRUN -> [SKIP][76] ([i915#2587])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb8/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-tglb: [PASS][77] -> [INCOMPLETE][78] ([i915#456])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-suspend.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-onoff:
- shard-snb: NOTRUN -> [SKIP][79] ([fdo#109271]) +457 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-snb7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-onoff.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-iclb: NOTRUN -> [SKIP][80] ([fdo#109280]) +18 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-iclb5/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-mmap-wc.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [PASS][81] -> [DMESG-WARN][82] ([i915#180]) +7 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-kbl2/igt@kms_hdr@bpc-switch-suspend.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-kbl6/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_lease@invalid-create-leases:
- shard-kbl: NOTRUN -> [FAIL][83] ([i915#4262])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-kbl7/igt@kms_lease@invalid-create-leases.html
- shard-apl: NOTRUN -> [FAIL][84] ([i915#4262])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-apl6/igt@kms_lease@invalid-create-leases.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][85] ([fdo#108145] / [i915#265]) +2 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-apl7/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-glk: NOTRUN -> [FAIL][86] ([i915#265])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-glk4/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html
- shard-apl: NOTRUN -> [FAIL][87] ([i915#265])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-apl6/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html
- shard-kbl: NOTRUN -> [FAIL][88] ([i915#265])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-kbl7/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-kbl: NOTRUN -> [FAIL][89] ([fdo#108145] / [i915#265]) +3 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-kbl7/igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-glk: NOTRUN -> [FAIL][90] ([fdo#108145] / [i915#265]) +1 similar issue
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-glk9/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max.html
* igt@kms_plane_cursor@pipe-d-viewport-size-256:
- shard-glk: NOTRUN -> [SKIP][91] ([fdo#109271]) +74 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-glk3/igt@kms_plane_cursor@pipe-d-viewport-size-256.html
* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-iclb: NOTRUN -> [SKIP][92] ([i915#3536]) +1 similar issue
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-iclb6/igt@kms_plane_lowres@pipe-a-tiling-y.html
* igt@kms_plane_lowres@pipe-b-tiling-none:
- shard-tglb: NOTRUN -> [SKIP][93] ([i915#3536]) +3 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb6/igt@kms_plane_lowres@pipe-b-tiling-none.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2:
- shard-glk: NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#658])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-glk6/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
- shard-tglb: NOTRUN -> [SKIP][95] ([i915#2920]) +2 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb1/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
- shard-apl: NOTRUN -> [SKIP][96] ([fdo#109271] / [i915#658]) +5 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-apl1/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2:
- shard-kbl: NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#658]) +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-kbl3/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: NOTRUN -> [SKIP][98] ([fdo#109441]) +4 similar issues
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-iclb7/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-tglb: NOTRUN -> [FAIL][99] ([i915#132] / [i915#3467]) +3 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb3/igt@kms_psr@psr2_sprite_mmap_cpu.html
* igt@kms_psr@psr2_sprite_plane_onoff:
- shard-iclb: [PASS][100] -> [SKIP][101] ([fdo#109441])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-iclb2/igt@kms_psr@psr2_sprite_plane_onoff.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-iclb7/igt@kms_psr@psr2_sprite_plane_onoff.html
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-0:
- shard-tglb: NOTRUN -> [SKIP][102] ([fdo#111615]) +5 similar issues
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb8/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-0.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [PASS][103] -> [DMESG-WARN][104] ([i915#180] / [i915#295])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-apl3/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-apl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_vblank@pipe-d-ts-continuation-idle:
- shard-apl: NOTRUN -> [SKIP][105] ([fdo#109271]) +238 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-apl8/igt@kms_vblank@pipe-d-ts-continuation-idle.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-kbl: NOTRUN -> [SKIP][106] ([fdo#109271] / [i915#533]) +1 similar issue
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-kbl7/igt@kms_vblank@pipe-d-wait-idle.html
- shard-apl: NOTRUN -> [SKIP][107] ([fdo#109271] / [i915#533]) +1 similar issue
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-apl6/igt@kms_vblank@pipe-d-wait-idle.html
* igt@kms_writeback@writeback-fb-id:
- shard-glk: NOTRUN -> [SKIP][108] ([fdo#109271] / [i915#2437])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-glk8/igt@kms_writeback@writeback-fb-id.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-kbl: NOTRUN -> [SKIP][109] ([fdo#109271] / [i915#2437])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-kbl1/igt@kms_writeback@writeback-pixel-formats.html
* igt@nouveau_crc@pipe-c-source-rg:
- shard-iclb: NOTRUN -> [SKIP][110] ([i915#2530]) +1 similar issue
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-iclb1/igt@nouveau_crc@pipe-c-source-rg.html
- shard-tglb: NOTRUN -> [SKIP][111] ([i915#2530])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb1/igt@nouveau_crc@pipe-c-source-rg.html
* igt@perf@polling-parameterized:
- shard-apl: [PASS][112] -> [FAIL][113] ([i915#1542])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-apl6/igt@perf@polling-parameterized.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-apl7/igt@perf@polling-parameterized.html
* igt@prime_nv_pcopy@test3_5:
- shard-tglb: NOTRUN -> [SKIP][114] ([fdo#109291]) +2 similar issues
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb8/igt@prime_nv_pcopy@test3_5.html
* igt@sysfs_clients@recycle-many:
- shard-apl: NOTRUN -> [SKIP][115] ([fdo#109271] / [i915#2994]) +2 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-apl3/igt@sysfs_clients@recycle-many.html
#### Possible fixes ####
* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][116] ([i915#658]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-iclb7/igt@feature_discovery@psr2.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-iclb2/igt@feature_discovery@psr2.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-kbl: [FAIL][118] ([i915#2842]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-kbl1/igt@gem_exec_fair@basic-pace@rcs0.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-kbl3/igt@gem_exec_fair@basic-pace@rcs0.html
- shard-glk: [FAIL][120] ([i915#2842]) -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-glk7/igt@gem_exec_fair@basic-pace@rcs0.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-glk8/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-iclb: [FAIL][122] ([i915#2842]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-iclb2/igt@gem_exec_fair@basic-pace@vcs0.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-iclb3/igt@gem_exec_fair@basic-pace@vcs0.html
- shard-tglb: [FAIL][124] ([i915#2842]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-tglb5/igt@gem_exec_fair@basic-pace@vcs0.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb7/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@i915_suspend@debugfs-reader:
- shard-apl: [DMESG-WARN][126] ([i915#180]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-apl7/igt@i915_suspend@debugfs-reader.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-apl8/igt@i915_suspend@debugfs-reader.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-0:
- shard-glk: [DMESG-WARN][128] ([i915#118] / [i915#95]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-glk9/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-glk1/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html
* igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque:
- shard-glk: [FAIL][130] ([i915#3444]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-glk8/igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-glk5/igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque.html
- shard-tglb: [FAIL][132] ([i915#2124] / [i915#4024]) -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-tglb3/igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-tglb5/igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque.html
- shard-snb: [FAIL][134] ([i915#4024]) -> [PASS][135]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-snb2/igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-snb5/igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque.html
- shard-iclb: [FAIL][136] ([i915#3444]) -> [PASS][137]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-iclb4/igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/shard-iclb5/igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-edp1:
- shard-tglb: [INCOMPLETE][138] ([i915#2411] / [i915#4173] / [i915#456]) -> [PASS][139]
[138]:
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6278/index.html
[-- Attachment #2: Type: text/html, Size: 33910 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add retry mechanism for async flip subtests
2021-10-04 15:43 ` Ville Syrjälä
@ 2021-10-05 10:00 ` Karthik B S
2021-10-05 10:22 ` Ville Syrjälä
0 siblings, 1 reply; 10+ messages in thread
From: Karthik B S @ 2021-10-05 10:00 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: igt-dev, juha-pekka.heikkila
On 10/4/2021 9:13 PM, Ville Syrjälä wrote:
> On Mon, Oct 04, 2021 at 12:19:01PM +0300, Ville Syrjälä wrote:
>> On Mon, Oct 04, 2021 at 02:26:29PM +0530, Karthik B S wrote:
>>> Async flip subtests fail sporadically with CRC failure on CI.
>>> This is expected as these tests are not run on highest priority by the
>>> scheduler, but this creates noise on CI. Add retry mechanism to rerun
>>> the test once if failure is seen.
>>>
>>> Signed-off-by: Karthik B S <karthik.b.s@intel.com>
>>> ---
>>> tests/i915/kms_big_fb.c | 9 +++++++++
>>> 1 file changed, 9 insertions(+)
>>>
>>> diff --git a/tests/i915/kms_big_fb.c b/tests/i915/kms_big_fb.c
>>> index 308227c9..8c09f59e 100644
>>> --- a/tests/i915/kms_big_fb.c
>>> +++ b/tests/i915/kms_big_fb.c
>>> @@ -481,6 +481,7 @@ max_hw_stride_async_flip_test(data_t *data)
>>> h = data->output->config.default_mode.vdisplay;
>>> igt_plane_t *primary;
>>> igt_crc_t compare_crc, async_crc;
>>> + bool retried = false;
>>>
>>> igt_require(data->display.is_atomic);
>>> igt_output_set_pipe(data->output, data->pipe);
>>> @@ -513,6 +514,7 @@ max_hw_stride_async_flip_test(data_t *data)
>>> INTEL_PIPE_CRC_SOURCE_AUTO);
>>> igt_pipe_crc_start(data->pipe_crc);
>>>
>>> +retry:
>>> igt_set_timeout(5, "Async pageflipping loop got stuck!\n");
>>> for (int i = 0; i < 2; i++) {
>>> igt_plane_set_fb(primary, &data->big_fb);
>>> @@ -548,6 +550,13 @@ max_hw_stride_async_flip_test(data_t *data)
>>> igt_assert_f(kmstest_get_vblank(data->drm_fd, data->pipe, 0) -
>>> startframe == 1, "lost frames\n");
>>>
>>> + /* Test is not running at real time priority, so allow one failure*/
>>> + if (!(igt_check_crc_equal(&compare_crc, &async_crc)^(i^1)) && !retried) {
>>> + retried = true;
>>> + igt_reset_timeout();
>>> + goto retry;
>>> + }
>>> +
>> This test seems to entirely fit kms_big_fb in general. I don't
> ^
> not
>
> is what I meant to write. Somewhat important small word.
>
>> think kms_big_fb should be testing any timing sensitive stuff.
>>
>> So I think we should change this to a form that follows the rest
>> of kms_big_fb to validate that each page flip just presents the
>> correct data on screen. The timing sensitive stuff is best left
>> for kms_async_flip.
>>
>> So this should maybe be something like: flip to a correctly sized
>> temp fb with the wrong contents and change the plane src coordinates,
>> and then async flip back to the correct fb and validate the
>> correct data is now on screen.
Thank you for the feedback.
Is this because we can handle any timing related failures in the same
test (may be using some common mechanism)? So add a subtest for
max-hw-stride in kms_async_flips and rewrite this subtest as mentioned
above?
>>
>> Oh and the async flip test should not be limited to the
>> max-hw-stride part. We should test that async flips do the
>> right thing with gtt remapping as well.
Sure. Will work on adding this coverage.
Thanks,
Karthik.B.S
>>
>> --
>> Ville Syrjälä
>> Intel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add retry mechanism for async flip subtests
2021-10-05 10:00 ` Karthik B S
@ 2021-10-05 10:22 ` Ville Syrjälä
2021-10-05 10:46 ` Juha-Pekka Heikkila
0 siblings, 1 reply; 10+ messages in thread
From: Ville Syrjälä @ 2021-10-05 10:22 UTC (permalink / raw)
To: Karthik B S; +Cc: igt-dev, juha-pekka.heikkila
On Tue, Oct 05, 2021 at 03:30:01PM +0530, Karthik B S wrote:
> On 10/4/2021 9:13 PM, Ville Syrjälä wrote:
> > On Mon, Oct 04, 2021 at 12:19:01PM +0300, Ville Syrjälä wrote:
> >> On Mon, Oct 04, 2021 at 02:26:29PM +0530, Karthik B S wrote:
> >>> Async flip subtests fail sporadically with CRC failure on CI.
> >>> This is expected as these tests are not run on highest priority by the
> >>> scheduler, but this creates noise on CI. Add retry mechanism to rerun
> >>> the test once if failure is seen.
> >>>
> >>> Signed-off-by: Karthik B S <karthik.b.s@intel.com>
> >>> ---
> >>> tests/i915/kms_big_fb.c | 9 +++++++++
> >>> 1 file changed, 9 insertions(+)
> >>>
> >>> diff --git a/tests/i915/kms_big_fb.c b/tests/i915/kms_big_fb.c
> >>> index 308227c9..8c09f59e 100644
> >>> --- a/tests/i915/kms_big_fb.c
> >>> +++ b/tests/i915/kms_big_fb.c
> >>> @@ -481,6 +481,7 @@ max_hw_stride_async_flip_test(data_t *data)
> >>> h = data->output->config.default_mode.vdisplay;
> >>> igt_plane_t *primary;
> >>> igt_crc_t compare_crc, async_crc;
> >>> + bool retried = false;
> >>>
> >>> igt_require(data->display.is_atomic);
> >>> igt_output_set_pipe(data->output, data->pipe);
> >>> @@ -513,6 +514,7 @@ max_hw_stride_async_flip_test(data_t *data)
> >>> INTEL_PIPE_CRC_SOURCE_AUTO);
> >>> igt_pipe_crc_start(data->pipe_crc);
> >>>
> >>> +retry:
> >>> igt_set_timeout(5, "Async pageflipping loop got stuck!\n");
> >>> for (int i = 0; i < 2; i++) {
> >>> igt_plane_set_fb(primary, &data->big_fb);
> >>> @@ -548,6 +550,13 @@ max_hw_stride_async_flip_test(data_t *data)
> >>> igt_assert_f(kmstest_get_vblank(data->drm_fd, data->pipe, 0) -
> >>> startframe == 1, "lost frames\n");
> >>>
> >>> + /* Test is not running at real time priority, so allow one failure*/
> >>> + if (!(igt_check_crc_equal(&compare_crc, &async_crc)^(i^1)) && !retried) {
> >>> + retried = true;
> >>> + igt_reset_timeout();
> >>> + goto retry;
> >>> + }
> >>> +
> >> This test seems to entirely fit kms_big_fb in general. I don't
> > ^
> > not
> >
> > is what I meant to write. Somewhat important small word.
> >
> >> think kms_big_fb should be testing any timing sensitive stuff.
> >>
> >> So I think we should change this to a form that follows the rest
> >> of kms_big_fb to validate that each page flip just presents the
> >> correct data on screen. The timing sensitive stuff is best left
> >> for kms_async_flip.
> >>
> >> So this should maybe be something like: flip to a correctly sized
> >> temp fb with the wrong contents and change the plane src coordinates,
> >> and then async flip back to the correct fb and validate the
> >> correct data is now on screen.
>
> Thank you for the feedback.
>
> Is this because we can handle any timing related failures in the same
> test (may be using some common mechanism)? So add a subtest for
> max-hw-stride in kms_async_flips and rewrite this subtest as mentioned
> above?
I don't think there's anything specifically about max stride
that needs timing sensitive tests. In theory kms_async_flip/crc
already tests what we need, which is that there are no visual
artifacts when flipping between two identical framebuffers.
The only exception would be if there's some very specific
hardware issue with big stride + async flip.
We could perhaps split kms_async_flip/crc into two tests
actually: one is the current test that scribbles into the
backbuffer between the flips, the other one would be otherwise
identical but it would just skip the scribbling. The difference
is that the scribbling takes a bit of time (esp. as the igt
rendering routines aren't particularly fast) so it may not get
as many flips in as we would otherwise. So the second test
would only confirm that the async flip itself is working without
any visual artifacts/underruns/etc. This split could also help
in determining whether some failure is due to perhaps the flip
event being delivered too early (should fail the current test)
vs. the hardware just causing visual artifacts on its own
(should fail both tests). An example of the latter case is
the HSW+ VT-d+async flip bug.
And then we'd just leave it to kms_big_fb to validate that the
async flip does in fact flip to the correct framebuffer (and
position inside said framebuffer). No timing sensitive bits
needed in that test.
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add retry mechanism for async flip subtests
2021-10-05 10:22 ` Ville Syrjälä
@ 2021-10-05 10:46 ` Juha-Pekka Heikkila
2021-10-05 11:06 ` Ville Syrjälä
0 siblings, 1 reply; 10+ messages in thread
From: Juha-Pekka Heikkila @ 2021-10-05 10:46 UTC (permalink / raw)
To: Ville Syrjälä, Karthik B S; +Cc: igt-dev
On 5.10.2021 13.22, Ville Syrjälä wrote:
> On Tue, Oct 05, 2021 at 03:30:01PM +0530, Karthik B S wrote:
>> On 10/4/2021 9:13 PM, Ville Syrjälä wrote:
>>> On Mon, Oct 04, 2021 at 12:19:01PM +0300, Ville Syrjälä wrote:
>>>> On Mon, Oct 04, 2021 at 02:26:29PM +0530, Karthik B S wrote:
>>>>> Async flip subtests fail sporadically with CRC failure on CI.
>>>>> This is expected as these tests are not run on highest priority by the
>>>>> scheduler, but this creates noise on CI. Add retry mechanism to rerun
>>>>> the test once if failure is seen.
>>>>>
>>>>> Signed-off-by: Karthik B S <karthik.b.s@intel.com>
>>>>> ---
>>>>> tests/i915/kms_big_fb.c | 9 +++++++++
>>>>> 1 file changed, 9 insertions(+)
>>>>>
>>>>> diff --git a/tests/i915/kms_big_fb.c b/tests/i915/kms_big_fb.c
>>>>> index 308227c9..8c09f59e 100644
>>>>> --- a/tests/i915/kms_big_fb.c
>>>>> +++ b/tests/i915/kms_big_fb.c
>>>>> @@ -481,6 +481,7 @@ max_hw_stride_async_flip_test(data_t *data)
>>>>> h = data->output->config.default_mode.vdisplay;
>>>>> igt_plane_t *primary;
>>>>> igt_crc_t compare_crc, async_crc;
>>>>> + bool retried = false;
>>>>>
>>>>> igt_require(data->display.is_atomic);
>>>>> igt_output_set_pipe(data->output, data->pipe);
>>>>> @@ -513,6 +514,7 @@ max_hw_stride_async_flip_test(data_t *data)
>>>>> INTEL_PIPE_CRC_SOURCE_AUTO);
>>>>> igt_pipe_crc_start(data->pipe_crc);
>>>>>
>>>>> +retry:
>>>>> igt_set_timeout(5, "Async pageflipping loop got stuck!\n");
>>>>> for (int i = 0; i < 2; i++) {
>>>>> igt_plane_set_fb(primary, &data->big_fb);
>>>>> @@ -548,6 +550,13 @@ max_hw_stride_async_flip_test(data_t *data)
>>>>> igt_assert_f(kmstest_get_vblank(data->drm_fd, data->pipe, 0) -
>>>>> startframe == 1, "lost frames\n");
>>>>>
>>>>> + /* Test is not running at real time priority, so allow one failure*/
>>>>> + if (!(igt_check_crc_equal(&compare_crc, &async_crc)^(i^1)) && !retried) {
>>>>> + retried = true;
>>>>> + igt_reset_timeout();
>>>>> + goto retry;
>>>>> + }
>>>>> +
>>>> This test seems to entirely fit kms_big_fb in general. I don't
>>> ^
>>> not
>>>
>>> is what I meant to write. Somewhat important small word.
>>>
>>>> think kms_big_fb should be testing any timing sensitive stuff.
>>>>
>>>> So I think we should change this to a form that follows the rest
>>>> of kms_big_fb to validate that each page flip just presents the
>>>> correct data on screen. The timing sensitive stuff is best left
>>>> for kms_async_flip.
>>>>
>>>> So this should maybe be something like: flip to a correctly sized
>>>> temp fb with the wrong contents and change the plane src coordinates,
>>>> and then async flip back to the correct fb and validate the
>>>> correct data is now on screen.
>> Thank you for the feedback.
>>
>> Is this because we can handle any timing related failures in the same
>> test (may be using some common mechanism)? So add a subtest for
>> max-hw-stride in kms_async_flips and rewrite this subtest as mentioned
>> above?
> I don't think there's anything specifically about max stride
> that needs timing sensitive tests. In theory kms_async_flip/crc
> already tests what we need, which is that there are no visual
> artifacts when flipping between two identical framebuffers.
> The only exception would be if there's some very specific
> hardware issue with big stride + async flip.
At a time there was explicit wishes from hw guys how this test was to be
performed with strides past 64K size. I have no idea if their worries
are still valid.
Timing sensitivity comes just from the fact when async flip is made the
full stride flips as expected and it need to be captured with crc from
that flipping frame.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add retry mechanism for async flip subtests
2021-10-05 10:46 ` Juha-Pekka Heikkila
@ 2021-10-05 11:06 ` Ville Syrjälä
2021-10-08 10:56 ` Karthik B S
0 siblings, 1 reply; 10+ messages in thread
From: Ville Syrjälä @ 2021-10-05 11:06 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: Karthik B S, igt-dev
On Tue, Oct 05, 2021 at 01:46:54PM +0300, Juha-Pekka Heikkila wrote:
>
> On 5.10.2021 13.22, Ville Syrjälä wrote:
> > On Tue, Oct 05, 2021 at 03:30:01PM +0530, Karthik B S wrote:
> >> On 10/4/2021 9:13 PM, Ville Syrjälä wrote:
> >>> On Mon, Oct 04, 2021 at 12:19:01PM +0300, Ville Syrjälä wrote:
> >>>> On Mon, Oct 04, 2021 at 02:26:29PM +0530, Karthik B S wrote:
> >>>>> Async flip subtests fail sporadically with CRC failure on CI.
> >>>>> This is expected as these tests are not run on highest priority by the
> >>>>> scheduler, but this creates noise on CI. Add retry mechanism to rerun
> >>>>> the test once if failure is seen.
> >>>>>
> >>>>> Signed-off-by: Karthik B S <karthik.b.s@intel.com>
> >>>>> ---
> >>>>> tests/i915/kms_big_fb.c | 9 +++++++++
> >>>>> 1 file changed, 9 insertions(+)
> >>>>>
> >>>>> diff --git a/tests/i915/kms_big_fb.c b/tests/i915/kms_big_fb.c
> >>>>> index 308227c9..8c09f59e 100644
> >>>>> --- a/tests/i915/kms_big_fb.c
> >>>>> +++ b/tests/i915/kms_big_fb.c
> >>>>> @@ -481,6 +481,7 @@ max_hw_stride_async_flip_test(data_t *data)
> >>>>> h = data->output->config.default_mode.vdisplay;
> >>>>> igt_plane_t *primary;
> >>>>> igt_crc_t compare_crc, async_crc;
> >>>>> + bool retried = false;
> >>>>>
> >>>>> igt_require(data->display.is_atomic);
> >>>>> igt_output_set_pipe(data->output, data->pipe);
> >>>>> @@ -513,6 +514,7 @@ max_hw_stride_async_flip_test(data_t *data)
> >>>>> INTEL_PIPE_CRC_SOURCE_AUTO);
> >>>>> igt_pipe_crc_start(data->pipe_crc);
> >>>>>
> >>>>> +retry:
> >>>>> igt_set_timeout(5, "Async pageflipping loop got stuck!\n");
> >>>>> for (int i = 0; i < 2; i++) {
> >>>>> igt_plane_set_fb(primary, &data->big_fb);
> >>>>> @@ -548,6 +550,13 @@ max_hw_stride_async_flip_test(data_t *data)
> >>>>> igt_assert_f(kmstest_get_vblank(data->drm_fd, data->pipe, 0) -
> >>>>> startframe == 1, "lost frames\n");
> >>>>>
> >>>>> + /* Test is not running at real time priority, so allow one failure*/
> >>>>> + if (!(igt_check_crc_equal(&compare_crc, &async_crc)^(i^1)) && !retried) {
> >>>>> + retried = true;
> >>>>> + igt_reset_timeout();
> >>>>> + goto retry;
> >>>>> + }
> >>>>> +
> >>>> This test seems to entirely fit kms_big_fb in general. I don't
> >>> ^
> >>> not
> >>>
> >>> is what I meant to write. Somewhat important small word.
> >>>
> >>>> think kms_big_fb should be testing any timing sensitive stuff.
> >>>>
> >>>> So I think we should change this to a form that follows the rest
> >>>> of kms_big_fb to validate that each page flip just presents the
> >>>> correct data on screen. The timing sensitive stuff is best left
> >>>> for kms_async_flip.
> >>>>
> >>>> So this should maybe be something like: flip to a correctly sized
> >>>> temp fb with the wrong contents and change the plane src coordinates,
> >>>> and then async flip back to the correct fb and validate the
> >>>> correct data is now on screen.
> >> Thank you for the feedback.
> >>
> >> Is this because we can handle any timing related failures in the same
> >> test (may be using some common mechanism)? So add a subtest for
> >> max-hw-stride in kms_async_flips and rewrite this subtest as mentioned
> >> above?
> > I don't think there's anything specifically about max stride
> > that needs timing sensitive tests. In theory kms_async_flip/crc
> > already tests what we need, which is that there are no visual
> > artifacts when flipping between two identical framebuffers.
> > The only exception would be if there's some very specific
> > hardware issue with big stride + async flip.
>
> At a time there was explicit wishes from hw guys how this test was to be
> performed with strides past 64K size. I have no idea if their worries
> are still valid.
>
> Timing sensitivity comes just from the fact when async flip is made the
> full stride flips as expected and it need to be captured with crc from
> that flipping frame.
kms_async_flip/crc just keeps flipping all the time, and checks
every frame that the crc remains the same.
Though atm it uses a solid color fb, so maybe not the best thing
necessarily for detecting weird stuff. Should change it to use the
normal pattern fb perhaps (+ the stripe on one edge we clobber/unclobber).
Though a lot of the normal pattern fb is just black. Maybe we should
have a some kind of standard pattern fb with a bit more of the area
filled with interesting shapes that are easily corrupted by eg. any
single tile fetch going into the weeds...
I guess we could add a big-stride variant there too. For that we'd
probably want to put the "what is the max supported hw stride?"
stuff somewhere into lib/ (and extend it for all the platforms).
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add retry mechanism for async flip subtests
2021-10-05 11:06 ` Ville Syrjälä
@ 2021-10-08 10:56 ` Karthik B S
0 siblings, 0 replies; 10+ messages in thread
From: Karthik B S @ 2021-10-08 10:56 UTC (permalink / raw)
To: Ville Syrjälä, Juha-Pekka Heikkila; +Cc: igt-dev
On 10/5/2021 4:36 PM, Ville Syrjälä wrote:
> On Tue, Oct 05, 2021 at 01:46:54PM +0300, Juha-Pekka Heikkila wrote:
>> On 5.10.2021 13.22, Ville Syrjälä wrote:
>>> On Tue, Oct 05, 2021 at 03:30:01PM +0530, Karthik B S wrote:
>>>> On 10/4/2021 9:13 PM, Ville Syrjälä wrote:
>>>>> On Mon, Oct 04, 2021 at 12:19:01PM +0300, Ville Syrjälä wrote:
>>>>>> On Mon, Oct 04, 2021 at 02:26:29PM +0530, Karthik B S wrote:
>>>>>>> Async flip subtests fail sporadically with CRC failure on CI.
>>>>>>> This is expected as these tests are not run on highest priority by the
>>>>>>> scheduler, but this creates noise on CI. Add retry mechanism to rerun
>>>>>>> the test once if failure is seen.
>>>>>>>
>>>>>>> Signed-off-by: Karthik B S <karthik.b.s@intel.com>
>>>>>>> ---
>>>>>>> tests/i915/kms_big_fb.c | 9 +++++++++
>>>>>>> 1 file changed, 9 insertions(+)
>>>>>>>
>>>>>>> diff --git a/tests/i915/kms_big_fb.c b/tests/i915/kms_big_fb.c
>>>>>>> index 308227c9..8c09f59e 100644
>>>>>>> --- a/tests/i915/kms_big_fb.c
>>>>>>> +++ b/tests/i915/kms_big_fb.c
>>>>>>> @@ -481,6 +481,7 @@ max_hw_stride_async_flip_test(data_t *data)
>>>>>>> h = data->output->config.default_mode.vdisplay;
>>>>>>> igt_plane_t *primary;
>>>>>>> igt_crc_t compare_crc, async_crc;
>>>>>>> + bool retried = false;
>>>>>>>
>>>>>>> igt_require(data->display.is_atomic);
>>>>>>> igt_output_set_pipe(data->output, data->pipe);
>>>>>>> @@ -513,6 +514,7 @@ max_hw_stride_async_flip_test(data_t *data)
>>>>>>> INTEL_PIPE_CRC_SOURCE_AUTO);
>>>>>>> igt_pipe_crc_start(data->pipe_crc);
>>>>>>>
>>>>>>> +retry:
>>>>>>> igt_set_timeout(5, "Async pageflipping loop got stuck!\n");
>>>>>>> for (int i = 0; i < 2; i++) {
>>>>>>> igt_plane_set_fb(primary, &data->big_fb);
>>>>>>> @@ -548,6 +550,13 @@ max_hw_stride_async_flip_test(data_t *data)
>>>>>>> igt_assert_f(kmstest_get_vblank(data->drm_fd, data->pipe, 0) -
>>>>>>> startframe == 1, "lost frames\n");
>>>>>>>
>>>>>>> + /* Test is not running at real time priority, so allow one failure*/
>>>>>>> + if (!(igt_check_crc_equal(&compare_crc, &async_crc)^(i^1)) && !retried) {
>>>>>>> + retried = true;
>>>>>>> + igt_reset_timeout();
>>>>>>> + goto retry;
>>>>>>> + }
>>>>>>> +
>>>>>> This test seems to entirely fit kms_big_fb in general. I don't
>>>>> ^
>>>>> not
>>>>>
>>>>> is what I meant to write. Somewhat important small word.
>>>>>
>>>>>> think kms_big_fb should be testing any timing sensitive stuff.
>>>>>>
>>>>>> So I think we should change this to a form that follows the rest
>>>>>> of kms_big_fb to validate that each page flip just presents the
>>>>>> correct data on screen. The timing sensitive stuff is best left
>>>>>> for kms_async_flip.
>>>>>>
>>>>>> So this should maybe be something like: flip to a correctly sized
>>>>>> temp fb with the wrong contents and change the plane src coordinates,
>>>>>> and then async flip back to the correct fb and validate the
>>>>>> correct data is now on screen.
>>>> Thank you for the feedback.
>>>>
>>>> Is this because we can handle any timing related failures in the same
>>>> test (may be using some common mechanism)? So add a subtest for
>>>> max-hw-stride in kms_async_flips and rewrite this subtest as mentioned
>>>> above?
>>> I don't think there's anything specifically about max stride
>>> that needs timing sensitive tests. In theory kms_async_flip/crc
>>> already tests what we need, which is that there are no visual
>>> artifacts when flipping between two identical framebuffers.
>>> The only exception would be if there's some very specific
>>> hardware issue with big stride + async flip.
>> At a time there was explicit wishes from hw guys how this test was to be
>> performed with strides past 64K size. I have no idea if their worries
>> are still valid.
>>
>> Timing sensitivity comes just from the fact when async flip is made the
>> full stride flips as expected and it need to be captured with crc from
>> that flipping frame.
> kms_async_flip/crc just keeps flipping all the time, and checks
> every frame that the crc remains the same.
>
> Though atm it uses a solid color fb, so maybe not the best thing
> necessarily for detecting weird stuff. Should change it to use the
> normal pattern fb perhaps (+ the stripe on one edge we clobber/unclobber).
> Though a lot of the normal pattern fb is just black. Maybe we should
> have a some kind of standard pattern fb with a bit more of the area
> filled with interesting shapes that are easily corrupted by eg. any
> single tile fetch going into the weeds...
>
> I guess we could add a big-stride variant there too. For that we'd
> probably want to put the "what is the max supported hw stride?"
> stuff somewhere into lib/ (and extend it for all the platforms).
>
Thanks Ville, JP for the inputs. Will work on the above mentioned
changes and resubmit the patch.
Thanks,
Karthik.B.S
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-10-08 10:56 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-04 8:56 [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add retry mechanism for async flip subtests Karthik B S
2021-10-04 9:19 ` Ville Syrjälä
2021-10-04 15:43 ` Ville Syrjälä
2021-10-05 10:00 ` Karthik B S
2021-10-05 10:22 ` Ville Syrjälä
2021-10-05 10:46 ` Juha-Pekka Heikkila
2021-10-05 11:06 ` Ville Syrjälä
2021-10-08 10:56 ` Karthik B S
2021-10-04 13:31 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-10-04 16:31 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.