From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH 6/6] nvme: wire up completion batching for the IRQ path
Date: Mon, 18 Oct 2021 03:22:37 -0700 [thread overview]
Message-ID: <YW1K7RR2F+dL9ntI@infradead.org> (raw)
In-Reply-To: <20211017020623.77815-7-axboe@kernel.dk>
On Sat, Oct 16, 2021 at 08:06:23PM -0600, Jens Axboe wrote:
> static inline int nvme_process_cq(struct nvme_queue *nvmeq)
> {
> - return nvme_poll_cq(nvmeq, NULL);
> + DEFINE_IO_COMP_BATCH(iob);
> + int found;
> +
> + found = nvme_poll_cq(nvmeq, &iob);
> + if (iob.req_list)
> + nvme_pci_complete_batch(&iob);
> + return found;
Ok, here the splitt makes sense. That being said I'd rather only add
what is nvme_poll_cq as a separate function here, and I'd probably
name it __nvme_process_cq as the poll name could create some confusion.
next prev parent reply other threads:[~2021-10-18 10:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-17 2:06 [PATCHSET v3] Batched completions Jens Axboe
2021-10-17 2:06 ` [PATCH 1/6] block: add a struct io_comp_batch argument to fops->iopoll() Jens Axboe
2021-10-18 10:16 ` Christoph Hellwig
2021-10-17 2:06 ` [PATCH 2/6] sbitmap: add helper to clear a batch of tags Jens Axboe
2021-10-17 2:06 ` [PATCH 3/6] block: add support for blk_mq_end_request_batch() Jens Axboe
2021-10-18 10:18 ` Christoph Hellwig
2021-10-18 13:40 ` Jens Axboe
2021-10-17 2:06 ` [PATCH 4/6] nvme: add support for batched completion of polled IO Jens Axboe
2021-10-18 10:20 ` Christoph Hellwig
2021-10-17 2:06 ` [PATCH 5/6] io_uring: utilize the io batching infrastructure for more efficient " Jens Axboe
2021-10-18 10:20 ` Christoph Hellwig
2021-10-17 2:06 ` [PATCH 6/6] nvme: wire up completion batching for the IRQ path Jens Axboe
2021-10-18 10:22 ` Christoph Hellwig [this message]
2021-10-18 13:41 ` Jens Axboe
2021-10-18 15:14 ` Christoph Hellwig
2021-10-18 15:25 ` Jens Axboe
2021-10-20 11:14 ` [PATCHSET v3] Batched completions John Garry
2021-10-20 14:02 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YW1K7RR2F+dL9ntI@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.