All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: Jens Axboe <axboe@kernel.dk>, <linux-block@vger.kernel.org>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCHSET v3] Batched completions
Date: Wed, 20 Oct 2021 12:14:37 +0100	[thread overview]
Message-ID: <b47e9ae3-52e0-8cfa-9dcb-bfd46ad4c46d@huawei.com> (raw)
In-Reply-To: <20211017020623.77815-1-axboe@kernel.dk>

On 17/10/2021 03:06, Jens Axboe wrote:
> Hi,

+linux-scsi

> 
> We now do decent batching of allocations for submit, but we still
> complete requests individually. This costs a lot of CPU cycles.
> 
> This patchset adds support for collecting requests for completion,
> and then completing them as a batch. This includes things like freeing
> a batch of tags.
> 
> This version is looking pretty good to me now, and should be ready
> for 5.16.

Just wondering if anyone was looking at supporting this for SCSI 
midlayer? I was thinking about looking at it...

> 
> Changes since v2:
> - Get rid of dev_id
> - Get rid of mq_ops->complete_batch
> - Drop now unnecessary ib->complete setting in blk_poll()
> - Drop one sbitmap patch that was questionnable
> - Rename io_batch to io_comp_batch
> - Track need_timestamp on per-iob basis instead of for each request
> - Drop elevator support for batching, cleaner without
> - Make the batched driver addition simpler
> - Unify nvme polled/irq handling
> - Drop io_uring file checking, no longer neededd
> - Cleanup io_uring completion side
> 


  parent reply	other threads:[~2021-10-20 11:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-17  2:06 [PATCHSET v3] Batched completions Jens Axboe
2021-10-17  2:06 ` [PATCH 1/6] block: add a struct io_comp_batch argument to fops->iopoll() Jens Axboe
2021-10-18 10:16   ` Christoph Hellwig
2021-10-17  2:06 ` [PATCH 2/6] sbitmap: add helper to clear a batch of tags Jens Axboe
2021-10-17  2:06 ` [PATCH 3/6] block: add support for blk_mq_end_request_batch() Jens Axboe
2021-10-18 10:18   ` Christoph Hellwig
2021-10-18 13:40     ` Jens Axboe
2021-10-17  2:06 ` [PATCH 4/6] nvme: add support for batched completion of polled IO Jens Axboe
2021-10-18 10:20   ` Christoph Hellwig
2021-10-17  2:06 ` [PATCH 5/6] io_uring: utilize the io batching infrastructure for more efficient " Jens Axboe
2021-10-18 10:20   ` Christoph Hellwig
2021-10-17  2:06 ` [PATCH 6/6] nvme: wire up completion batching for the IRQ path Jens Axboe
2021-10-18 10:22   ` Christoph Hellwig
2021-10-18 13:41     ` Jens Axboe
2021-10-18 15:14       ` Christoph Hellwig
2021-10-18 15:25         ` Jens Axboe
2021-10-20 11:14 ` John Garry [this message]
2021-10-20 14:02   ` [PATCHSET v3] Batched completions Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b47e9ae3-52e0-8cfa-9dcb-bfd46ad4c46d@huawei.com \
    --to=john.garry@huawei.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.