* [PATCH] staging: rtl8723bs: hal: remove duplicate check
@ 2021-10-10 7:08 Saurav Girepunje
2021-10-10 12:45 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Saurav Girepunje @ 2021-10-10 7:08 UTC (permalink / raw)
To: gregkh, fabioaiuto83, marcocesati, dan.carpenter, hdegoede,
saurav.girepunje, linux-staging, linux-kernel
Cc: saurav.girepunje
Remove 'bPerformance' from if condition check. As on previous
if condition it is already check for same variable.
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
drivers/staging/rtl8723bs/hal/odm_DIG.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/hal/odm_DIG.c b/drivers/staging/rtl8723bs/hal/odm_DIG.c
index beda7b8a7c6a..7e92c373cddb 100644
--- a/drivers/staging/rtl8723bs/hal/odm_DIG.c
+++ b/drivers/staging/rtl8723bs/hal/odm_DIG.c
@@ -544,7 +544,7 @@ void odm_DIG(void *pDM_VOID)
/* 1 Adjust initial gain by false alarm */
if (pDM_Odm->bLinked && bPerformance) {
- if (bFirstTpTarget || (FirstConnect && bPerformance)) {
+ if (bFirstTpTarget || FirstConnect) {
pDM_DigTable->LargeFAHit = 0;
if (pDM_Odm->RSSI_Min < DIG_MaxOfMin) {
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8723bs: hal: remove duplicate check
2021-10-10 7:08 [PATCH] staging: rtl8723bs: hal: remove duplicate check Saurav Girepunje
@ 2021-10-10 12:45 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2021-10-10 12:45 UTC (permalink / raw)
To: Saurav Girepunje, gregkh, fabioaiuto83, marcocesati,
dan.carpenter, linux-staging, linux-kernel
Cc: saurav.girepunje
Hi,
On 10/10/21 9:08 AM, Saurav Girepunje wrote:
> Remove 'bPerformance' from if condition check. As on previous
> if condition it is already check for same variable.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/staging/rtl8723bs/hal/odm_DIG.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/odm_DIG.c b/drivers/staging/rtl8723bs/hal/odm_DIG.c
> index beda7b8a7c6a..7e92c373cddb 100644
> --- a/drivers/staging/rtl8723bs/hal/odm_DIG.c
> +++ b/drivers/staging/rtl8723bs/hal/odm_DIG.c
> @@ -544,7 +544,7 @@ void odm_DIG(void *pDM_VOID)
> /* 1 Adjust initial gain by false alarm */
> if (pDM_Odm->bLinked && bPerformance) {
>
> - if (bFirstTpTarget || (FirstConnect && bPerformance)) {
> + if (bFirstTpTarget || FirstConnect) {
> pDM_DigTable->LargeFAHit = 0;
>
> if (pDM_Odm->RSSI_Min < DIG_MaxOfMin) {
> --
> 2.32.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-10 12:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-10 7:08 [PATCH] staging: rtl8723bs: hal: remove duplicate check Saurav Girepunje
2021-10-10 12:45 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.