From: Petr Vorel <petr.vorel@gmail.com>
To: Peter Korsgaard <peter@korsgaard.com>
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>, buildroot@buildroot.org
Subject: Re: [Buildroot] [RFC PATCH 0/2] use `command -v' instead of `which'
Date: Sun, 10 Oct 2021 23:12:14 +0200 [thread overview]
Message-ID: <YWNXLl5AEUGtvMK8@pevik> (raw)
In-Reply-To: <87r1cuwm8d.fsf@dell.be.48ers.dk>
Hi all,
> >>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
> Hi,
> > From this, I actually conclude that it is indeed safer to go to
> > command -v, with a wrapper script that we add to $PATH to handle the
> > case where make tries to bypass the shell.
> If command is always a shell builtin and we already do the dance to find
> bash, how about just doing something like:
> $(shell $(SHELL) -c "command -v ...")?
Peter, good point, thanks! That would safe us to modify path.
This works on make 4.3 on Debian with /bin/sh, I'll try to test it on more VMs
(+ find one where plain $(shell command -v ...) does not work).
Kind regards,
Petr
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2021-10-10 21:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 20:51 [Buildroot] [RFC PATCH 0/2] use `command -v' instead of `which' Petr Vorel
2021-09-21 20:51 ` [Buildroot] [RFC PATCH 1/2] make: support: " Petr Vorel
2021-09-21 20:51 ` [Buildroot] [RFC PATCH 2/2] support/dependencies: don't check for `which' Petr Vorel
2021-09-26 21:32 ` [Buildroot] [RFC PATCH 0/2] use `command -v' instead of `which' Arnout Vandecappelle
2021-09-30 20:04 ` Yann E. MORIN
2021-09-30 20:16 ` Petr Vorel
2021-09-30 20:41 ` Yann E. MORIN
2021-10-01 18:03 ` Yann E. MORIN
2021-10-02 19:22 ` Petr Vorel
2021-10-03 9:49 ` Arnout Vandecappelle
2021-10-03 18:05 ` Petr Vorel
2021-10-09 10:01 ` Peter Korsgaard
2021-10-10 21:12 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWNXLl5AEUGtvMK8@pevik \
--to=petr.vorel@gmail.com \
--cc=buildroot@buildroot.org \
--cc=peter@korsgaard.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.