From: Arnout Vandecappelle <arnout@mind.be>
To: Petr Vorel <petr.vorel@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [RFC PATCH 0/2] use `command -v' instead of `which'
Date: Sun, 26 Sep 2021 23:32:54 +0200 [thread overview]
Message-ID: <fee5adb3-0cd8-3538-bf3e-d04af8153007@mind.be> (raw)
In-Reply-To: <20210921205112.39176-1-petr.vorel@gmail.com>
On 21/09/2021 22:51, Petr Vorel wrote:
> Hi,
>
> I've tested the patchset on dash as the default shell. But it certainly
> deserve more people to have look and test.
Well, as the commit message says: it's POSIX so it should be supported by
everything. which has a much smaller chance of being supported.
>
> NOTE: If accepted, we might want to use `command -v' also in scripts:
>
> $ git grep '$(which'
> package/fakedate/fakedate:for date in $(which -a date |tac); do
> package/transmission/S92transmission:DAEMON=$(which $NAME)
Also:
- remove it from the documentation (adding-packages-asciidoc.txt)
- remove it from docs/manual/prerequisite.txt
- it's still used in package/doc-asciidoc.mk
- package/libxml-parser-perl/libxml-parser-perl.mk
- utils/brmake
But these two are already applied to master, thanks!
Regards,
Arnout
>
> Kind regards,
> Petr
>
> Petr Vorel (2):
> make: support: use `command -v' instead of `which'
> support/dependencies: don't check for `which'
>
> Makefile | 22 +++++++++----------
> package/Makefile.in | 8 +++----
> support/dependencies/check-host-bison-flex.mk | 4 ++--
> support/dependencies/check-host-cmake.sh | 2 +-
> support/dependencies/check-host-gzip.sh | 2 +-
> support/dependencies/check-host-lzip.sh | 4 ++--
> support/dependencies/check-host-python3.sh | 2 +-
> support/dependencies/check-host-tar.sh | 4 ++--
> support/dependencies/check-host-xzcat.sh | 4 ++--
> support/dependencies/dependencies.sh | 18 +++++++--------
> .../pkg-toolchain-external.mk | 2 +-
> 11 files changed, 35 insertions(+), 37 deletions(-)
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-09-26 21:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 20:51 [Buildroot] [RFC PATCH 0/2] use `command -v' instead of `which' Petr Vorel
2021-09-21 20:51 ` [Buildroot] [RFC PATCH 1/2] make: support: " Petr Vorel
2021-09-21 20:51 ` [Buildroot] [RFC PATCH 2/2] support/dependencies: don't check for `which' Petr Vorel
2021-09-26 21:32 ` Arnout Vandecappelle [this message]
2021-09-30 20:04 ` [Buildroot] [RFC PATCH 0/2] use `command -v' instead of `which' Yann E. MORIN
2021-09-30 20:16 ` Petr Vorel
2021-09-30 20:41 ` Yann E. MORIN
2021-10-01 18:03 ` Yann E. MORIN
2021-10-02 19:22 ` Petr Vorel
2021-10-03 9:49 ` Arnout Vandecappelle
2021-10-03 18:05 ` Petr Vorel
2021-10-09 10:01 ` Peter Korsgaard
2021-10-10 21:12 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fee5adb3-0cd8-3538-bf3e-d04af8153007@mind.be \
--to=arnout@mind.be \
--cc=buildroot@buildroot.org \
--cc=petr.vorel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.