* [PATCH] staging/fbtft: Fix backlight
@ 2021-10-30 16:29 Noralf Trønnes
2021-10-30 18:50 ` Sam Ravnborg
2021-11-05 20:26 ` Noralf Trønnes
0 siblings, 2 replies; 4+ messages in thread
From: Noralf Trønnes @ 2021-10-30 16:29 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, dri-devel, linux-fbdev, Noralf Trønnes, stable
Commit b4a1ed0cd18b ("fbdev: make FB_BACKLIGHT a tristate") forgot to
update fbtft breaking its backlight support when FB_BACKLIGHT is a module.
Fix this by using IS_ENABLED().
Fixes: b4a1ed0cd18b ("fbdev: make FB_BACKLIGHT a tristate")
Cc: <stable@vger.kernel.org>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
---
drivers/staging/fbtft/fbtft-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
index ed992ca605eb..ff979f1eeee8 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -128,7 +128,7 @@ static int fbtft_request_gpios(struct fbtft_par *par)
return 0;
}
-#ifdef CONFIG_FB_BACKLIGHT
+#if IS_ENABLED(CONFIG_FB_BACKLIGHT)
static int fbtft_backlight_update_status(struct backlight_device *bd)
{
struct fbtft_par *par = bl_get_data(bd);
@@ -853,7 +853,7 @@ int fbtft_register_framebuffer(struct fb_info *fb_info)
fb_info->fix.smem_len >> 10, text1,
HZ / fb_info->fbdefio->delay, text2);
-#ifdef CONFIG_FB_BACKLIGHT
+#if IS_ENABLED(CONFIG_FB_BACKLIGHT)
/* Turn on backlight if available */
if (fb_info->bl_dev) {
fb_info->bl_dev->props.power = FB_BLANK_UNBLANK;
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging/fbtft: Fix backlight
2021-10-30 16:29 [PATCH] staging/fbtft: Fix backlight Noralf Trønnes
@ 2021-10-30 18:50 ` Sam Ravnborg
2021-11-05 20:26 ` Noralf Trønnes
1 sibling, 0 replies; 4+ messages in thread
From: Sam Ravnborg @ 2021-10-30 18:50 UTC (permalink / raw)
To: Noralf Trønnes; +Cc: gregkh, linux-staging, dri-devel, linux-fbdev, stable
On Sat, Oct 30, 2021 at 06:29:01PM +0200, Noralf Trønnes wrote:
> Commit b4a1ed0cd18b ("fbdev: make FB_BACKLIGHT a tristate") forgot to
> update fbtft breaking its backlight support when FB_BACKLIGHT is a module.
>
> Fix this by using IS_ENABLED().
>
> Fixes: b4a1ed0cd18b ("fbdev: make FB_BACKLIGHT a tristate")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging/fbtft: Fix backlight
2021-10-30 16:29 [PATCH] staging/fbtft: Fix backlight Noralf Trønnes
@ 2021-11-05 20:26 ` Noralf Trønnes
2021-11-05 20:26 ` Noralf Trønnes
1 sibling, 0 replies; 4+ messages in thread
From: Noralf Trønnes @ 2021-11-05 20:26 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, dri-devel, linux-fbdev, stable
Den 30.10.2021 18.29, skrev Noralf Trønnes:
> Commit b4a1ed0cd18b ("fbdev: make FB_BACKLIGHT a tristate") forgot to
> update fbtft breaking its backlight support when FB_BACKLIGHT is a module.
>
> Fix this by using IS_ENABLED().
>
> Fixes: b4a1ed0cd18b ("fbdev: make FB_BACKLIGHT a tristate")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
> ---
I discovered that fb_ssd1351 also has this #ifdef, so need to fix that
as well. Will send a new version.
Noralf.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging/fbtft: Fix backlight
@ 2021-11-05 20:26 ` Noralf Trønnes
0 siblings, 0 replies; 4+ messages in thread
From: Noralf Trønnes @ 2021-11-05 20:26 UTC (permalink / raw)
To: gregkh; +Cc: linux-fbdev, linux-staging, stable, dri-devel
Den 30.10.2021 18.29, skrev Noralf Trønnes:
> Commit b4a1ed0cd18b ("fbdev: make FB_BACKLIGHT a tristate") forgot to
> update fbtft breaking its backlight support when FB_BACKLIGHT is a module.
>
> Fix this by using IS_ENABLED().
>
> Fixes: b4a1ed0cd18b ("fbdev: make FB_BACKLIGHT a tristate")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
> ---
I discovered that fb_ssd1351 also has this #ifdef, so need to fix that
as well. Will send a new version.
Noralf.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-05 20:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-30 16:29 [PATCH] staging/fbtft: Fix backlight Noralf Trønnes
2021-10-30 18:50 ` Sam Ravnborg
2021-11-05 20:26 ` Noralf Trønnes
2021-11-05 20:26 ` Noralf Trønnes
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.