All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <guan@eryu.me>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Brian Foster <bfoster@redhat.com>,
	fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH v2] tests/xfs: test COW writeback failure when overlapping non-shared blocks
Date: Sun, 31 Oct 2021 23:20:04 +0800	[thread overview]
Message-ID: <YX60JOknF5F5cvLJ@desktop> (raw)
In-Reply-To: <20211025161022.GM24282@magnolia>

On Mon, Oct 25, 2021 at 09:10:22AM -0700, Darrick J. Wong wrote:
> On Mon, Oct 25, 2021 at 09:00:53AM -0400, Brian Foster wrote:
> > Test that COW writeback that overlaps non-shared delalloc blocks
> > does not leave around stale delalloc blocks on I/O failure. This
> > triggers assert failures and free space accounting corruption on
> > XFS.
> > 
> > Signed-off-by: Brian Foster <bfoster@redhat.com>
> 
> LGTM.  Thanks for the patch + reproducer!
> 
> At some point this test ought to grow a link to the upstream fix patch,
> which is currently in the 5.16 merge branch, e.g.:
> 
> # Regression test for kernel commit:
> #
> # 5ca5916b6bc9 ("xfs: punch out data fork delalloc blocks on COW
> # writeback failure")

And this test triggers an ASSERT (though it won't crash the kernel
unless XFS_ASSERT_FATAL is set), I'd like wait for the fix to land so we
could have the correct commit ID by then.

> 
> ...but as Sunday afternoon came and went with neither -rc7 nor a final
> release being tagged, I'm not sure when that commit will appear
> upstream.  It's entirely possible that Linus is sitting in the dark
> right now, since I came back from my long weekend to a noticeable
> amount of downed trees around town.
> 
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>

Thanks for the review, and for all the other reviews!

Eryu

  reply	other threads:[~2021-10-31 15:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-25 13:00 [PATCH v2] tests/xfs: test COW writeback failure when overlapping non-shared blocks Brian Foster
2021-10-25 16:10 ` Darrick J. Wong
2021-10-31 15:20   ` Eryu Guan [this message]
2021-11-03 16:10     ` Darrick J. Wong
2021-11-17 18:01 ` Darrick J. Wong
2021-12-17 15:19   ` Brian Foster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YX60JOknF5F5cvLJ@desktop \
    --to=guan@eryu.me \
    --cc=bfoster@redhat.com \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.