* [PATCH] of/unittest: Add of_node_put() before return
@ 2021-10-15 8:26 Wan Jiabing
2021-10-20 17:58 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Wan Jiabing @ 2021-10-15 8:26 UTC (permalink / raw)
To: Rob Herring, Frank Rowand, devicetree, linux-kernel; +Cc: kael_w, Wan Jiabing
Fix following coccicheck warning:
./drivers/of/unittest.c:3091:1-23: WARNING: Function
for_each_child_of_node should have of_node_put() before return
Early exits from for_each_child_of_node should decrement the
node reference counter.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
drivers/of/unittest.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 8c056972a6dd..b8d2b669408a 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -3094,6 +3094,8 @@ static __init void of_unittest_overlay_high_level(void)
if (!strcmp(np->full_name, base_child->full_name)) {
unittest(0, "illegal node name in overlay_base %pOFn",
np);
+ of_node_put(np);
+ of_node_put(base_child);
return;
}
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] of/unittest: Add of_node_put() before return
2021-10-15 8:26 [PATCH] of/unittest: Add of_node_put() before return Wan Jiabing
@ 2021-10-20 17:58 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2021-10-20 17:58 UTC (permalink / raw)
To: Wan Jiabing; +Cc: linux-kernel, devicetree, kael_w, Frank Rowand, Rob Herring
On Fri, 15 Oct 2021 04:26:58 -0400, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./drivers/of/unittest.c:3091:1-23: WARNING: Function
> for_each_child_of_node should have of_node_put() before return
>
> Early exits from for_each_child_of_node should decrement the
> node reference counter.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/of/unittest.c | 2 ++
> 1 file changed, 2 insertions(+)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-20 17:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-15 8:26 [PATCH] of/unittest: Add of_node_put() before return Wan Jiabing
2021-10-20 17:58 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.