* [PATCH] KVM: x86: check for interrupts before deciding whether to exit the fast path
@ 2021-10-20 14:52 Paolo Bonzini
2021-10-20 19:42 ` Sean Christopherson
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2021-10-20 14:52 UTC (permalink / raw)
To: linux-kernel, kvm; +Cc: wanpengli, seanjc, stable
The kvm_x86_sync_pir_to_irr callback can sometimes set KVM_REQ_EVENT.
If that happens exactly at the time that an exit is handled as
EXIT_FASTPATH_REENTER_GUEST, vcpu_enter_guest will go incorrectly
through the loop that calls kvm_x86_run, instead of processing
the request promptly.
Fixes: 379a3c8ee444 ("KVM: VMX: Optimize posted-interrupt delivery for timer fastpath")
Cc: stable@vger.kernel.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
arch/x86/kvm/x86.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index fa48948b4934..b9b31e5f72b0 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -9781,14 +9781,14 @@ static int vcpu_enter_guest(struct kvm_vcpu *vcpu)
if (likely(exit_fastpath != EXIT_FASTPATH_REENTER_GUEST))
break;
- if (unlikely(kvm_vcpu_exit_request(vcpu))) {
+ if (vcpu->arch.apicv_active)
+ static_call(kvm_x86_sync_pir_to_irr)(vcpu);
+
+ if (unlikely(kvm_vcpu_exit_request(vcpu))) {
exit_fastpath = EXIT_FASTPATH_EXIT_HANDLED;
break;
}
-
- if (vcpu->arch.apicv_active)
- static_call(kvm_x86_sync_pir_to_irr)(vcpu);
- }
+ }
/*
* Do this here before restoring debug registers on the host. And
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: x86: check for interrupts before deciding whether to exit the fast path
2021-10-20 14:52 [PATCH] KVM: x86: check for interrupts before deciding whether to exit the fast path Paolo Bonzini
@ 2021-10-20 19:42 ` Sean Christopherson
0 siblings, 0 replies; 2+ messages in thread
From: Sean Christopherson @ 2021-10-20 19:42 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: linux-kernel, kvm, wanpengli, stable
On Wed, Oct 20, 2021, Paolo Bonzini wrote:
> The kvm_x86_sync_pir_to_irr callback can sometimes set KVM_REQ_EVENT.
> If that happens exactly at the time that an exit is handled as
> EXIT_FASTPATH_REENTER_GUEST, vcpu_enter_guest will go incorrectly
> through the loop that calls kvm_x86_run, instead of processing
> the request promptly.
>
> Fixes: 379a3c8ee444 ("KVM: VMX: Optimize posted-interrupt delivery for timer fastpath")
> Cc: stable@vger.kernel.org
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
Reviewed-by: Sean Christopherson <seanjc@google.com>
> arch/x86/kvm/x86.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index fa48948b4934..b9b31e5f72b0 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -9781,14 +9781,14 @@ static int vcpu_enter_guest(struct kvm_vcpu *vcpu)
> if (likely(exit_fastpath != EXIT_FASTPATH_REENTER_GUEST))
> break;
>
> - if (unlikely(kvm_vcpu_exit_request(vcpu))) {
> + if (vcpu->arch.apicv_active)
> + static_call(kvm_x86_sync_pir_to_irr)(vcpu);
> +
> + if (unlikely(kvm_vcpu_exit_request(vcpu))) {
> exit_fastpath = EXIT_FASTPATH_EXIT_HANDLED;
> break;
> }
> -
> - if (vcpu->arch.apicv_active)
> - static_call(kvm_x86_sync_pir_to_irr)(vcpu);
> - }
> + }
I think someone working on git has a meta-entry in the obfuscated C context.
This is the most convoluted diff possible for a simple code move :-)
> /*
> * Do this here before restoring debug registers on the host. And
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-20 19:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-20 14:52 [PATCH] KVM: x86: check for interrupts before deciding whether to exit the fast path Paolo Bonzini
2021-10-20 19:42 ` Sean Christopherson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.