* [PATCHv2] usbnet: sanity check for maxpacket
@ 2021-10-21 12:29 Oliver Neukum
2021-10-21 12:38 ` Johan Hovold
2021-10-21 15:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Oliver Neukum @ 2021-10-21 12:29 UTC (permalink / raw)
To: syzkaller-bugs, netdev, linux-usb, davem, kuba
Cc: Oliver Neukum, syzbot+76bb1d34ffa0adc03baa
maxpacket of 0 makes no sense and oopses as we need to divide
by it. Give up.
V2: fixed typo in log and stylistic issues
Signed-off-by: Oliver Neukum <oneukum@suse.com>
Reported-by: syzbot+76bb1d34ffa0adc03baa@syzkaller.appspotmail.com
---
drivers/net/usb/usbnet.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 840c1c2ab16a..80432ee0ce69 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -1788,6 +1788,10 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
if (!dev->rx_urb_size)
dev->rx_urb_size = dev->hard_mtu;
dev->maxpacket = usb_maxpacket (dev->udev, dev->out, 1);
+ if (dev->maxpacket == 0) {
+ /* that is a broken device */
+ goto out4;
+ }
/* let userspace know we have a random address */
if (ether_addr_equal(net->dev_addr, node_id))
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCHv2] usbnet: sanity check for maxpacket
2021-10-21 12:29 [PATCHv2] usbnet: sanity check for maxpacket Oliver Neukum
@ 2021-10-21 12:38 ` Johan Hovold
2021-10-21 15:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Johan Hovold @ 2021-10-21 12:38 UTC (permalink / raw)
To: Oliver Neukum
Cc: syzkaller-bugs, netdev, linux-usb, davem, kuba,
syzbot+76bb1d34ffa0adc03baa
On Thu, Oct 21, 2021 at 02:29:44PM +0200, Oliver Neukum wrote:
> maxpacket of 0 makes no sense and oopses as we need to divide
> by it. Give up.
>
> V2: fixed typo in log and stylistic issues
Changelog goes below the ---
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> Reported-by: syzbot+76bb1d34ffa0adc03baa@syzkaller.appspotmail.com
Again,
Reviewed-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/net/usb/usbnet.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
> index 840c1c2ab16a..80432ee0ce69 100644
> --- a/drivers/net/usb/usbnet.c
> +++ b/drivers/net/usb/usbnet.c
> @@ -1788,6 +1788,10 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
> if (!dev->rx_urb_size)
> dev->rx_urb_size = dev->hard_mtu;
> dev->maxpacket = usb_maxpacket (dev->udev, dev->out, 1);
> + if (dev->maxpacket == 0) {
> + /* that is a broken device */
> + goto out4;
> + }
>
> /* let userspace know we have a random address */
> if (ether_addr_equal(net->dev_addr, node_id))
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCHv2] usbnet: sanity check for maxpacket
2021-10-21 12:29 [PATCHv2] usbnet: sanity check for maxpacket Oliver Neukum
2021-10-21 12:38 ` Johan Hovold
@ 2021-10-21 15:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-10-21 15:10 UTC (permalink / raw)
To: Oliver Neukum
Cc: syzkaller-bugs, netdev, linux-usb, davem, kuba,
syzbot+76bb1d34ffa0adc03baa
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 21 Oct 2021 14:29:44 +0200 you wrote:
> maxpacket of 0 makes no sense and oopses as we need to divide
> by it. Give up.
>
> V2: fixed typo in log and stylistic issues
>
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> Reported-by: syzbot+76bb1d34ffa0adc03baa@syzkaller.appspotmail.com
>
> [...]
Here is the summary with links:
- [PATCHv2] usbnet: sanity check for maxpacket
https://git.kernel.org/netdev/net/c/397430b50a36
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-21 15:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-21 12:29 [PATCHv2] usbnet: sanity check for maxpacket Oliver Neukum
2021-10-21 12:38 ` Johan Hovold
2021-10-21 15:10 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.