All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: kernel test robot <lkp@intel.com>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	llvm@lists.linux.dev, kbuild-all@lists.01.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v2 1/2] serial: 8250_pci: Replace custom pci_match_id() implementation
Date: Tue, 26 Oct 2021 16:25:58 +0300	[thread overview]
Message-ID: <YXgB5vt8+r/Tdo07@smile.fi.intel.com> (raw)
In-Reply-To: <202110262029.9bqOz12y-lkp@intel.com>

On Tue, Oct 26, 2021 at 08:45:48PM +0800, kernel test robot wrote:
> Hi Andy,
> 
> I love your patch! Perhaps something to improve:
> 
> [auto build test WARNING on tty/tty-testing]
> [cannot apply to v5.15-rc7 next-20211026]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:    https://github.com/0day-ci/linux/commits/Andy-Shevchenko/serial-8250_pci-Replace-custom-pci_match_id-implementation/20211025-204752
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
> config: i386-randconfig-a003-20211025 (attached as .config)
> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project a461fa64bb37cffd73f683c74f6b0780379fc2ca)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/0day-ci/linux/commit/24a32531ba63f472ec6f40c4d431cb5369b29818
>         git remote add linux-review https://github.com/0day-ci/linux
>         git fetch --no-tags linux-review Andy-Shevchenko/serial-8250_pci-Replace-custom-pci_match_id-implementation/20211025-204752
>         git checkout 24a32531ba63f472ec6f40c4d431cb5369b29818
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=i386 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
> >> drivers/tty/serial/8250/8250_pci.c:1268:6: warning: variable 'amcc' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
>            if (match)
>                ^~~~~
>    drivers/tty/serial/8250/8250_pci.c:1273:6: note: uninitialized use occurs here
>            if (amcc) {
>                ^~~~
>    drivers/tty/serial/8250/8250_pci.c:1268:2: note: remove the 'if' if its condition is always true
>            if (match)
>            ^~~~~~~~~~
>    drivers/tty/serial/8250/8250_pci.c:1265:11: note: initialize the variable 'amcc' to silence this warning
>            bool amcc;
>                     ^
>                      = 0

Clang gives a right and wrong advice at the same time.
Thank you for the uninitialized case, but variable is boolean, what's 0 here?

I'll send a fix ASAP.

>    1 warning generated.

-- 
With Best Regards,
Andy Shevchenko



WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v2 1/2] serial: 8250_pci: Replace custom pci_match_id() implementation
Date: Tue, 26 Oct 2021 16:25:58 +0300	[thread overview]
Message-ID: <YXgB5vt8+r/Tdo07@smile.fi.intel.com> (raw)
In-Reply-To: <202110262029.9bqOz12y-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 2619 bytes --]

On Tue, Oct 26, 2021 at 08:45:48PM +0800, kernel test robot wrote:
> Hi Andy,
> 
> I love your patch! Perhaps something to improve:
> 
> [auto build test WARNING on tty/tty-testing]
> [cannot apply to v5.15-rc7 next-20211026]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:    https://github.com/0day-ci/linux/commits/Andy-Shevchenko/serial-8250_pci-Replace-custom-pci_match_id-implementation/20211025-204752
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
> config: i386-randconfig-a003-20211025 (attached as .config)
> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project a461fa64bb37cffd73f683c74f6b0780379fc2ca)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/0day-ci/linux/commit/24a32531ba63f472ec6f40c4d431cb5369b29818
>         git remote add linux-review https://github.com/0day-ci/linux
>         git fetch --no-tags linux-review Andy-Shevchenko/serial-8250_pci-Replace-custom-pci_match_id-implementation/20211025-204752
>         git checkout 24a32531ba63f472ec6f40c4d431cb5369b29818
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=i386 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
> >> drivers/tty/serial/8250/8250_pci.c:1268:6: warning: variable 'amcc' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
>            if (match)
>                ^~~~~
>    drivers/tty/serial/8250/8250_pci.c:1273:6: note: uninitialized use occurs here
>            if (amcc) {
>                ^~~~
>    drivers/tty/serial/8250/8250_pci.c:1268:2: note: remove the 'if' if its condition is always true
>            if (match)
>            ^~~~~~~~~~
>    drivers/tty/serial/8250/8250_pci.c:1265:11: note: initialize the variable 'amcc' to silence this warning
>            bool amcc;
>                     ^
>                      = 0

Clang gives a right and wrong advice at the same time.
Thank you for the uninitialized case, but variable is boolean, what's 0 here?

I'll send a fix ASAP.

>    1 warning generated.

-- 
With Best Regards,
Andy Shevchenko


  reply	other threads:[~2021-10-26 13:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-25 12:45 [PATCH v2 1/2] serial: 8250_pci: Replace custom pci_match_id() implementation Andy Shevchenko
2021-10-25 12:45 ` [PATCH v2 2/2] serial: 8250_pci: Remove empty stub pci_quatech_exit() Andy Shevchenko
2021-10-26 12:45 ` [PATCH v2 1/2] serial: 8250_pci: Replace custom pci_match_id() implementation kernel test robot
2021-10-26 12:45   ` kernel test robot
2021-10-26 13:25   ` Andy Shevchenko [this message]
2021-10-26 13:25     ` Andy Shevchenko
2021-10-26 13:35     ` Andy Shevchenko
2021-10-26 13:35       ` Andy Shevchenko
2021-10-26 14:47 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YXgB5vt8+r/Tdo07@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=llvm@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.