From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>,
Mike Christie <michael.christie@oracle.com>,
target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
pbonzini@redhat.com, sgarzare@redhat.com,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH V3 11/11] vhost: allow userspace to create workers
Date: Tue, 26 Oct 2021 17:36:56 +0100 [thread overview]
Message-ID: <YXguqJmsWVEnrgA7@stefanha-x1.localdomain> (raw)
In-Reply-To: <20211026090923-mutt-send-email-mst@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
On Tue, Oct 26, 2021 at 09:09:52AM -0400, Michael S. Tsirkin wrote:
> On Tue, Oct 26, 2021 at 01:37:14PM +0800, Jason Wang wrote:
> >
> > 在 2021/10/22 下午1:19, Mike Christie 写道:
> > > This patch allows userspace to create workers and bind them to vqs. You
> > > can have N workers per dev and also share N workers with M vqs.
> > >
> > > Signed-off-by: Mike Christie <michael.christie@oracle.com>
> >
> >
> > A question, who is the best one to determine the binding? Is it the VMM
> > (Qemu etc) or the management stack? If the latter, it looks to me it's
> > better to expose this via sysfs?
>
> I think it's a bit much to expect this from management.
The management stack controls the number of vqs used as well as the vCPU
and IOThread CPU affinity. It seems natural for it to also control the
vhost worker CPU affinity. Where else should that be controlled?
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-scsi@vger.kernel.org,
virtualization@lists.linux-foundation.org,
target-devel@vger.kernel.org, pbonzini@redhat.com
Subject: Re: [PATCH V3 11/11] vhost: allow userspace to create workers
Date: Tue, 26 Oct 2021 17:36:56 +0100 [thread overview]
Message-ID: <YXguqJmsWVEnrgA7@stefanha-x1.localdomain> (raw)
In-Reply-To: <20211026090923-mutt-send-email-mst@kernel.org>
[-- Attachment #1.1: Type: text/plain, Size: 906 bytes --]
On Tue, Oct 26, 2021 at 09:09:52AM -0400, Michael S. Tsirkin wrote:
> On Tue, Oct 26, 2021 at 01:37:14PM +0800, Jason Wang wrote:
> >
> > 在 2021/10/22 下午1:19, Mike Christie 写道:
> > > This patch allows userspace to create workers and bind them to vqs. You
> > > can have N workers per dev and also share N workers with M vqs.
> > >
> > > Signed-off-by: Mike Christie <michael.christie@oracle.com>
> >
> >
> > A question, who is the best one to determine the binding? Is it the VMM
> > (Qemu etc) or the management stack? If the latter, it looks to me it's
> > better to expose this via sysfs?
>
> I think it's a bit much to expect this from management.
The management stack controls the number of vqs used as well as the vCPU
and IOThread CPU affinity. It seems natural for it to also control the
vhost worker CPU affinity. Where else should that be controlled?
Stefan
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 183 bytes --]
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-10-26 16:37 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 5:18 [PATCH V3 00/11] vhost: multiple worker support Mike Christie
2021-10-22 5:18 ` Mike Christie
2021-10-22 5:19 ` [PATCH] QEMU vhost-scsi: add support for VHOST_SET_VRING_WORKER Mike Christie
2021-10-22 5:19 ` Mike Christie
2021-10-22 5:19 ` [PATCH V3 01/11] vhost: add vhost_worker pointer to vhost_virtqueue Mike Christie
2021-10-22 5:19 ` Mike Christie
2021-10-22 5:19 ` [PATCH V3 02/11] vhost, vhost-net: add helper to check if vq has work Mike Christie
2021-10-22 5:19 ` Mike Christie
2021-10-22 5:19 ` [PATCH V3 03/11] vhost: take worker or vq instead of dev for queueing Mike Christie
2021-10-22 5:19 ` Mike Christie
2021-10-22 5:19 ` [PATCH V3 04/11] vhost: take worker or vq instead of dev for flushing Mike Christie
2021-10-22 5:19 ` Mike Christie
2021-10-22 5:19 ` [PATCH V3 05/11] vhost: convert poll work to be vq based Mike Christie
2021-10-22 5:19 ` Mike Christie
2021-10-22 5:19 ` [PATCH V3 06/11] vhost-sock: convert to vq helpers Mike Christie
2021-10-22 5:19 ` Mike Christie
2021-10-25 9:08 ` Stefano Garzarella
2021-10-25 9:08 ` Stefano Garzarella
2021-10-25 16:09 ` michael.christie
2021-10-25 16:09 ` michael.christie
2021-10-22 5:19 ` [PATCH V3 07/11] vhost-scsi: make SCSI cmd completion per vq Mike Christie
2021-10-22 5:19 ` Mike Christie
2021-10-22 5:19 ` [PATCH V3 08/11] vhost-scsi: convert to vq helpers Mike Christie
2021-10-22 5:19 ` Mike Christie
2021-10-22 5:19 ` [PATCH V3 09/11] vhost-scsi: flush IO vqs then send TMF rsp Mike Christie
2021-10-22 5:19 ` Mike Christie
2021-10-22 5:19 ` [PATCH V3 10/11] vhost: remove device wide queu/flushing helpers Mike Christie
2021-10-22 5:19 ` Mike Christie
2021-10-22 5:19 ` [PATCH V3 11/11] vhost: allow userspace to create workers Mike Christie
2021-10-22 5:19 ` Mike Christie
2021-10-22 10:47 ` Michael S. Tsirkin
2021-10-22 10:47 ` Michael S. Tsirkin
2021-10-22 16:12 ` michael.christie
2021-10-22 16:12 ` michael.christie
2021-10-22 18:17 ` michael.christie
2021-10-22 18:17 ` michael.christie
2021-10-23 20:11 ` Michael S. Tsirkin
2021-10-23 20:11 ` Michael S. Tsirkin
2021-10-25 16:04 ` michael.christie
2021-10-25 16:04 ` michael.christie
2021-10-25 17:14 ` Michael S. Tsirkin
2021-10-25 17:14 ` Michael S. Tsirkin
2021-10-26 5:37 ` Jason Wang
2021-10-26 5:37 ` Jason Wang
2021-10-26 13:09 ` Michael S. Tsirkin
2021-10-26 13:09 ` Michael S. Tsirkin
2021-10-26 16:36 ` Stefan Hajnoczi [this message]
2021-10-26 16:36 ` Stefan Hajnoczi
2021-10-26 15:44 ` Stefan Hajnoczi
2021-10-26 15:44 ` Stefan Hajnoczi
2021-10-27 2:55 ` Jason Wang
2021-10-27 2:55 ` Jason Wang
2021-10-27 9:01 ` Stefan Hajnoczi
2021-10-27 9:01 ` Stefan Hajnoczi
2021-10-26 16:49 ` michael.christie
2021-10-26 16:49 ` michael.christie
2021-10-27 6:02 ` Jason Wang
2021-10-27 6:02 ` Jason Wang
2021-10-27 9:03 ` Stefan Hajnoczi
2021-10-27 9:03 ` Stefan Hajnoczi
2021-10-26 15:22 ` Stefan Hajnoczi
2021-10-26 15:22 ` Stefan Hajnoczi
2021-10-26 15:24 ` Stefan Hajnoczi
2021-10-26 15:24 ` Stefan Hajnoczi
2021-10-22 6:02 ` [PATCH V3 00/11] vhost: multiple worker support michael.christie
2021-10-22 6:02 ` michael.christie
2021-10-22 9:49 ` Michael S. Tsirkin
2021-10-22 9:49 ` Michael S. Tsirkin
2021-10-22 9:48 ` Michael S. Tsirkin
2021-10-22 9:48 ` Michael S. Tsirkin
2021-10-22 15:54 ` michael.christie
2021-10-22 15:54 ` michael.christie
2021-10-23 20:12 ` Michael S. Tsirkin
2021-10-23 20:12 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXguqJmsWVEnrgA7@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michael.christie@oracle.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=sgarzare@redhat.com \
--cc=target-devel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.