* [PATCH net-next] staging: use of_get_ethdev_address()
@ 2021-10-26 17:50 Jakub Kicinski
2021-10-26 19:12 ` Greg KH
2021-10-28 1:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Jakub Kicinski @ 2021-10-26 17:50 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-staging, gregkh, Jakub Kicinski
Use the new of_get_ethdev_address() helper for the cases
where dev->dev_addr is passed in directly as the destination.
@@
expression dev, np;
@@
- of_get_mac_address(np, dev->dev_addr)
+ of_get_ethdev_address(np, dev)
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
Hi Greg, this needs to go to net-next, the helper is new.
---
drivers/staging/octeon/ethernet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
index bf8c5443a218..f662739137b5 100644
--- a/drivers/staging/octeon/ethernet.c
+++ b/drivers/staging/octeon/ethernet.c
@@ -409,7 +409,7 @@ int cvm_oct_common_init(struct net_device *dev)
struct octeon_ethernet *priv = netdev_priv(dev);
int ret;
- ret = of_get_mac_address(priv->of_node, dev->dev_addr);
+ ret = of_get_ethdev_address(priv->of_node, dev);
if (ret)
eth_hw_addr_random(dev);
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] staging: use of_get_ethdev_address()
2021-10-26 17:50 [PATCH net-next] staging: use of_get_ethdev_address() Jakub Kicinski
@ 2021-10-26 19:12 ` Greg KH
2021-10-28 1:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2021-10-26 19:12 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, netdev, linux-staging
On Tue, Oct 26, 2021 at 10:50:38AM -0700, Jakub Kicinski wrote:
> Use the new of_get_ethdev_address() helper for the cases
> where dev->dev_addr is passed in directly as the destination.
>
> @@
> expression dev, np;
> @@
> - of_get_mac_address(np, dev->dev_addr)
> + of_get_ethdev_address(np, dev)
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> Hi Greg, this needs to go to net-next, the helper is new.
> ---
> drivers/staging/octeon/ethernet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] staging: use of_get_ethdev_address()
2021-10-26 17:50 [PATCH net-next] staging: use of_get_ethdev_address() Jakub Kicinski
2021-10-26 19:12 ` Greg KH
@ 2021-10-28 1:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-10-28 1:10 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, netdev, linux-staging, gregkh
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 26 Oct 2021 10:50:38 -0700 you wrote:
> Use the new of_get_ethdev_address() helper for the cases
> where dev->dev_addr is passed in directly as the destination.
>
> @@
> expression dev, np;
> @@
> - of_get_mac_address(np, dev->dev_addr)
> + of_get_ethdev_address(np, dev)
>
> [...]
Here is the summary with links:
- [net-next] staging: use of_get_ethdev_address()
https://git.kernel.org/netdev/net-next/c/8b6ce9b02672
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-28 1:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-26 17:50 [PATCH net-next] staging: use of_get_ethdev_address() Jakub Kicinski
2021-10-26 19:12 ` Greg KH
2021-10-28 1:10 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.