All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: vchiq_core: get rid of typedef
@ 2021-10-26 21:27 ` Gaston Gonzalez
  0 siblings, 0 replies; 4+ messages in thread
From: Gaston Gonzalez @ 2021-10-26 21:27 UTC (permalink / raw)
  To: linux-staging
  Cc: gregkh, nsaenz, stefan.wahren, arnd, dan.carpenter, ojaswin98,
	amarjargal16, linux-rpi-kernel, linux-arm-kernel,
	bcm-kernel-feedback-list, linux-kernel, gascoar

Get rid of typedef and use proper kernel type instead.

Signed-off-by: Gaston Gonzalez <gascoar@gmail.com>
---
 .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c  | 6 +++---
 .../staging/vc04_services/interface/vchiq_arm/vchiq_core.h  | 4 +---
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
index ab97a35e63f9..7fe20d4b7ba2 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
@@ -711,7 +711,7 @@ reserve_space(struct vchiq_state *state, size_t space, int is_blocking)
 }
 
 static void
-process_free_data_message(struct vchiq_state *state, BITSET_T *service_found,
+process_free_data_message(struct vchiq_state *state, u32 *service_found,
 			  struct vchiq_header *header)
 {
 	int msgid = header->msgid;
@@ -767,7 +767,7 @@ process_free_data_message(struct vchiq_state *state, BITSET_T *service_found,
 
 /* Called by the recycle thread. */
 static void
-process_free_queue(struct vchiq_state *state, BITSET_T *service_found,
+process_free_queue(struct vchiq_state *state, u32 *service_found,
 		   size_t length)
 {
 	struct vchiq_shared_state *local = state->local;
@@ -1981,7 +1981,7 @@ recycle_func(void *v)
 {
 	struct vchiq_state *state = v;
 	struct vchiq_shared_state *local = state->local;
-	BITSET_T *found;
+	u32 *found;
 	size_t length;
 
 	length = sizeof(*found) * BITSET_SIZE(VCHIQ_MAX_SERVICES);
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
index 3e50910ecba3..53a98949b294 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
@@ -74,9 +74,7 @@
 	((fourcc) >>  8) & 0xff, \
 	(fourcc) & 0xff
 
-typedef u32 BITSET_T;
-
-static_assert((sizeof(BITSET_T) * 8) == 32);
+static_assert((sizeof(u32) * 8) == 32);
 
 #define BITSET_SIZE(b)        ((b + 31) >> 5)
 #define BITSET_WORD(b)        (b >> 5)
-- 
2.33.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] staging: vchiq_core: get rid of typedef
@ 2021-10-26 21:27 ` Gaston Gonzalez
  0 siblings, 0 replies; 4+ messages in thread
From: Gaston Gonzalez @ 2021-10-26 21:27 UTC (permalink / raw)
  To: linux-staging
  Cc: gregkh, nsaenz, stefan.wahren, arnd, dan.carpenter, ojaswin98,
	amarjargal16, linux-rpi-kernel, linux-arm-kernel,
	bcm-kernel-feedback-list, linux-kernel, gascoar

Get rid of typedef and use proper kernel type instead.

Signed-off-by: Gaston Gonzalez <gascoar@gmail.com>
---
 .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c  | 6 +++---
 .../staging/vc04_services/interface/vchiq_arm/vchiq_core.h  | 4 +---
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
index ab97a35e63f9..7fe20d4b7ba2 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
@@ -711,7 +711,7 @@ reserve_space(struct vchiq_state *state, size_t space, int is_blocking)
 }
 
 static void
-process_free_data_message(struct vchiq_state *state, BITSET_T *service_found,
+process_free_data_message(struct vchiq_state *state, u32 *service_found,
 			  struct vchiq_header *header)
 {
 	int msgid = header->msgid;
@@ -767,7 +767,7 @@ process_free_data_message(struct vchiq_state *state, BITSET_T *service_found,
 
 /* Called by the recycle thread. */
 static void
-process_free_queue(struct vchiq_state *state, BITSET_T *service_found,
+process_free_queue(struct vchiq_state *state, u32 *service_found,
 		   size_t length)
 {
 	struct vchiq_shared_state *local = state->local;
@@ -1981,7 +1981,7 @@ recycle_func(void *v)
 {
 	struct vchiq_state *state = v;
 	struct vchiq_shared_state *local = state->local;
-	BITSET_T *found;
+	u32 *found;
 	size_t length;
 
 	length = sizeof(*found) * BITSET_SIZE(VCHIQ_MAX_SERVICES);
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
index 3e50910ecba3..53a98949b294 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
@@ -74,9 +74,7 @@
 	((fourcc) >>  8) & 0xff, \
 	(fourcc) & 0xff
 
-typedef u32 BITSET_T;
-
-static_assert((sizeof(BITSET_T) * 8) == 32);
+static_assert((sizeof(u32) * 8) == 32);
 
 #define BITSET_SIZE(b)        ((b + 31) >> 5)
 #define BITSET_WORD(b)        (b >> 5)
-- 
2.33.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] staging: vchiq_core: get rid of typedef
  2021-10-26 21:27 ` Gaston Gonzalez
@ 2021-10-27  5:01   ` Greg KH
  -1 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2021-10-27  5:01 UTC (permalink / raw)
  To: Gaston Gonzalez
  Cc: linux-staging, nsaenz, stefan.wahren, arnd, dan.carpenter,
	ojaswin98, amarjargal16, linux-rpi-kernel, linux-arm-kernel,
	bcm-kernel-feedback-list, linux-kernel

On Tue, Oct 26, 2021 at 06:27:56PM -0300, Gaston Gonzalez wrote:
> Get rid of typedef and use proper kernel type instead.

which typedef?  Please be specific.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] staging: vchiq_core: get rid of typedef
@ 2021-10-27  5:01   ` Greg KH
  0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2021-10-27  5:01 UTC (permalink / raw)
  To: Gaston Gonzalez
  Cc: linux-staging, nsaenz, stefan.wahren, arnd, dan.carpenter,
	ojaswin98, amarjargal16, linux-rpi-kernel, linux-arm-kernel,
	bcm-kernel-feedback-list, linux-kernel

On Tue, Oct 26, 2021 at 06:27:56PM -0300, Gaston Gonzalez wrote:
> Get rid of typedef and use proper kernel type instead.

which typedef?  Please be specific.

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-27  5:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-26 21:27 [PATCH] staging: vchiq_core: get rid of typedef Gaston Gonzalez
2021-10-26 21:27 ` Gaston Gonzalez
2021-10-27  5:01 ` Greg KH
2021-10-27  5:01   ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.