All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Sameer Pujar <spujar@nvidia.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
	lgirdwood@gmail.com, tiwai@suse.com, jonathanh@nvidia.com,
	thierry.reding@gmail.com, alsa-devel@alsa-project.org,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: tegra: Add master volume/mute control support
Date: Fri, 29 Oct 2021 16:22:09 +0100	[thread overview]
Message-ID: <YXwRoWPF+ctNJRyp@sirena.org.uk> (raw)
In-Reply-To: <18b61046-ac0b-0fb3-669c-6524a03eecf0@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 861 bytes --]

On Fri, Oct 29, 2021 at 08:38:54PM +0530, Sameer Pujar wrote:
> On 10/26/2021 11:53 AM, Sameer Pujar wrote:
> > On 10/25/2021 6:28 PM, Jaroslav Kysela wrote:

> > > It's a bit unrelated comment to this change, but it may be worth to
> > > verify all
> > > kcontrol put callbacks in the tegra code. Ensure that value 1 is
> > > returned only
> > > when something was really changed in hardware.

> There are cases when the mixer control update is not immediately written to
> HW, instead the update is ACKed (stored in variable) and writen to HW at a
> later point of time. Do these cases qualify for "return 1" as well?

What matters is the user visible effect.  It doesn't matter when the
change gets written to the hardware, the important thing is that an
applicaton will read back a new value and users will observe whatver
change the control change caused.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Sameer Pujar <spujar@nvidia.com>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
	linux-kernel@vger.kernel.org, tiwai@suse.com,
	jonathanh@nvidia.com, thierry.reding@gmail.com,
	linux-tegra@vger.kernel.org
Subject: Re: [PATCH] ASoC: tegra: Add master volume/mute control support
Date: Fri, 29 Oct 2021 16:22:09 +0100	[thread overview]
Message-ID: <YXwRoWPF+ctNJRyp@sirena.org.uk> (raw)
In-Reply-To: <18b61046-ac0b-0fb3-669c-6524a03eecf0@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 861 bytes --]

On Fri, Oct 29, 2021 at 08:38:54PM +0530, Sameer Pujar wrote:
> On 10/26/2021 11:53 AM, Sameer Pujar wrote:
> > On 10/25/2021 6:28 PM, Jaroslav Kysela wrote:

> > > It's a bit unrelated comment to this change, but it may be worth to
> > > verify all
> > > kcontrol put callbacks in the tegra code. Ensure that value 1 is
> > > returned only
> > > when something was really changed in hardware.

> There are cases when the mixer control update is not immediately written to
> HW, instead the update is ACKed (stored in variable) and writen to HW at a
> later point of time. Do these cases qualify for "return 1" as well?

What matters is the user visible effect.  It doesn't matter when the
change gets written to the hardware, the important thing is that an
applicaton will read back a new value and users will observe whatver
change the control change caused.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2021-10-29 15:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-25 11:06 [PATCH] ASoC: tegra: Add master volume/mute control support Sameer Pujar
2021-10-25 11:06 ` Sameer Pujar
2021-10-25 12:58 ` Jaroslav Kysela
2021-10-25 12:58   ` Jaroslav Kysela
2021-10-26  6:23   ` Sameer Pujar
2021-10-26  6:23     ` Sameer Pujar
2021-10-29 15:08     ` Sameer Pujar
2021-10-29 15:08       ` Sameer Pujar
2021-10-29 15:22       ` Mark Brown [this message]
2021-10-29 15:22         ` Mark Brown
2021-10-29 15:26       ` Jaroslav Kysela
2021-10-29 15:26         ` Jaroslav Kysela
2021-11-03  5:12         ` Sameer Pujar
2021-11-03  5:12           ` Sameer Pujar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YXwRoWPF+ctNJRyp@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=jonathanh@nvidia.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=spujar@nvidia.com \
    --cc=thierry.reding@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.