All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: export this_cpu_has_cap
@ 2021-11-11  3:21 Jackie Liu
  2021-11-11 15:32 ` Catalin Marinas
  0 siblings, 1 reply; 3+ messages in thread
From: Jackie Liu @ 2021-11-11  3:21 UTC (permalink / raw)
  To: catalin.marinas, will; +Cc: mark.rutland, suzuki.poulose, linux-arm-kernel

From: Jackie Liu <liuyun01@kylinos.cn>

After commit 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling"),
driver coresight use this_cpu_has_cap for check feature, but if we compile it
as a module, it will cause a compilation error.

[...]
ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:134: modules-only.symvers] Error 1
make[1]: *** Deleting file 'modules-only.symvers'
make: *** [Makefile:1765: modules] Error 2
make: *** Waiting for unfinished jobs....
[...]

Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling")
Reported-by: kernelbot <kernel-bot@kylinos.cn>
Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
---
 arch/arm64/kernel/cpufeature.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
index ecbdff795f5e..646662407a07 100644
--- a/arch/arm64/kernel/cpufeature.c
+++ b/arch/arm64/kernel/cpufeature.c
@@ -2864,6 +2864,7 @@ bool this_cpu_has_cap(unsigned int n)
 
 	return false;
 }
+EXPORT_SYMBOL_GPL(this_cpu_has_cap);
 
 /*
  * This helper function is used in a narrow window when,
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: export this_cpu_has_cap
  2021-11-11  3:21 [PATCH] arm64: export this_cpu_has_cap Jackie Liu
@ 2021-11-11 15:32 ` Catalin Marinas
  2021-11-11 16:59   ` Suzuki K Poulose
  0 siblings, 1 reply; 3+ messages in thread
From: Catalin Marinas @ 2021-11-11 15:32 UTC (permalink / raw)
  To: Jackie Liu
  Cc: will, mark.rutland, suzuki.poulose, linux-arm-kernel, mathieu.poirier

On Thu, Nov 11, 2021 at 11:21:38AM +0800, Jackie Liu wrote:
> From: Jackie Liu <liuyun01@kylinos.cn>
> 
> After commit 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling"),
> driver coresight use this_cpu_has_cap for check feature, but if we compile it
> as a module, it will cause a compilation error.
> 
> [...]
> ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:134: modules-only.symvers] Error 1
> make[1]: *** Deleting file 'modules-only.symvers'
> make: *** [Makefile:1765: modules] Error 2
> make: *** Waiting for unfinished jobs....
> [...]
> 
> Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling")
> Reported-by: kernelbot <kernel-bot@kylinos.cn>
> Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>

There is a patch already, not sure whether it has made it into mainline:

https://lore.kernel.org/r/20211103221256.725080-1-suzuki.poulose@arm.com

-- 
Catalin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: export this_cpu_has_cap
  2021-11-11 15:32 ` Catalin Marinas
@ 2021-11-11 16:59   ` Suzuki K Poulose
  0 siblings, 0 replies; 3+ messages in thread
From: Suzuki K Poulose @ 2021-11-11 16:59 UTC (permalink / raw)
  To: Catalin Marinas, Jackie Liu
  Cc: will, mark.rutland, linux-arm-kernel, mathieu.poirier

On 11/11/2021 15:32, Catalin Marinas wrote:
> On Thu, Nov 11, 2021 at 11:21:38AM +0800, Jackie Liu wrote:
>> From: Jackie Liu <liuyun01@kylinos.cn>
>>
>> After commit 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling"),
>> driver coresight use this_cpu_has_cap for check feature, but if we compile it
>> as a module, it will cause a compilation error.
>>
>> [...]
>> ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined!
>> make[1]: *** [scripts/Makefile.modpost:134: modules-only.symvers] Error 1
>> make[1]: *** Deleting file 'modules-only.symvers'
>> make: *** [Makefile:1765: modules] Error 2
>> make: *** Waiting for unfinished jobs....
>> [...]
>>
>> Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling")
>> Reported-by: kernelbot <kernel-bot@kylinos.cn>
>> Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
> 
> There is a patch already, not sure whether it has made it into mainline:
> 
> https://lore.kernel.org/r/20211103221256.725080-1-suzuki.poulose@arm.com

This is queued in Greg's char-misc tree (char-misc-linus branch) and
should be sent out at rc1.

https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git/log/?h=char-misc-linus


Suzuki

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-11-11 17:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-11  3:21 [PATCH] arm64: export this_cpu_has_cap Jackie Liu
2021-11-11 15:32 ` Catalin Marinas
2021-11-11 16:59   ` Suzuki K Poulose

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.