From: Petri Latvala <petri.latvala@intel.com> To: Rob Clark <robdclark@gmail.com> Cc: igt-dev@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Jordan Crouse <jordan@cosmicpenguin.net>, Akhil P Oommen <akhilpo@codeaurora.org>, Rob Clark <robdclark@chromium.org> Subject: Re: [PATCH igt v2 1/3] lib/igt_debugfs: Add helper for writing debugfs files Date: Thu, 11 Nov 2021 14:13:32 +0200 [thread overview] Message-ID: <YY0I7Ld6xa4vdutc@platvala-desk.ger.corp.intel.com> (raw) In-Reply-To: <20211110184213.649787-2-robdclark@gmail.com> On Wed, Nov 10, 2021 at 10:42:11AM -0800, Rob Clark wrote: > From: Rob Clark <robdclark@chromium.org> > > Signed-off-by: Rob Clark <robdclark@chromium.org> Reviewed-by: Petri Latvala <petri.latvala@intel.com> > --- > v2: Fix headerdoc comments > > lib/igt_debugfs.c | 17 +++++++++++++++++ > lib/igt_debugfs.h | 13 +++++++++++++ > 2 files changed, 30 insertions(+) > > diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c > index a5bb95ca..dd6f2995 100644 > --- a/lib/igt_debugfs.c > +++ b/lib/igt_debugfs.c > @@ -351,6 +351,23 @@ void __igt_debugfs_read(int fd, const char *filename, char *buf, int size) > close(dir); > } > > +/** > + * __igt_debugfs_write: > + * @fd: the drm device file fd > + * @filename: file name > + * @buf: buffer to be written to the debugfs file > + * @size: size of the buffer > + * > + * This function opens the debugfs file, writes it, then closes the file. > + */ > +void __igt_debugfs_write(int fd, const char *filename, const char *buf, int size) > +{ > + int dir = igt_debugfs_dir(fd); > + > + igt_sysfs_write(dir, filename, buf, size); > + close(dir); > +} > + > /** > * igt_debugfs_search: > * @filename: file name > diff --git a/lib/igt_debugfs.h b/lib/igt_debugfs.h > index d43ba6c6..b4867681 100644 > --- a/lib/igt_debugfs.h > +++ b/lib/igt_debugfs.h > @@ -40,6 +40,7 @@ int igt_debugfs_pipe_dir(int device, int pipe, int mode); > > int igt_debugfs_open(int fd, const char *filename, int mode); > void __igt_debugfs_read(int fd, const char *filename, char *buf, int size); > +void __igt_debugfs_write(int fd, const char *filename, const char *buf, int size); > int igt_debugfs_simple_read(int dir, const char *filename, char *buf, int size); > bool igt_debugfs_search(int fd, const char *filename, const char *substring); > > @@ -54,6 +55,18 @@ bool igt_debugfs_search(int fd, const char *filename, const char *substring); > #define igt_debugfs_read(fd, filename, buf) \ > __igt_debugfs_read(fd, (filename), (buf), sizeof(buf)) > > +/** > + * igt_debugfs_write: > + * @fd: the drm device file fd > + * @filename: name of the debugfs file > + * @buf: buffer to be written to the debugfs file > + * > + * This is just a convenience wrapper for __igt_debugfs_write. See its > + * documentation. > + */ > +#define igt_debugfs_write(fd, filename, buf) \ > + __igt_debugfs_write(fd, (filename), (buf), sizeof(buf)) > + > /* > * Pipe CRC > */ > -- > 2.31.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Petri Latvala <petri.latvala@intel.com> To: Rob Clark <robdclark@gmail.com> Cc: Rob Clark <robdclark@chromium.org>, linux-arm-msm@vger.kernel.org, Akhil P Oommen <akhilpo@codeaurora.org>, Jordan Crouse <jordan@cosmicpenguin.net>, igt-dev@lists.freedesktop.org, freedreno@lists.freedesktop.org Subject: Re: [igt-dev] [PATCH igt v2 1/3] lib/igt_debugfs: Add helper for writing debugfs files Date: Thu, 11 Nov 2021 14:13:32 +0200 [thread overview] Message-ID: <YY0I7Ld6xa4vdutc@platvala-desk.ger.corp.intel.com> (raw) In-Reply-To: <20211110184213.649787-2-robdclark@gmail.com> On Wed, Nov 10, 2021 at 10:42:11AM -0800, Rob Clark wrote: > From: Rob Clark <robdclark@chromium.org> > > Signed-off-by: Rob Clark <robdclark@chromium.org> Reviewed-by: Petri Latvala <petri.latvala@intel.com> > --- > v2: Fix headerdoc comments > > lib/igt_debugfs.c | 17 +++++++++++++++++ > lib/igt_debugfs.h | 13 +++++++++++++ > 2 files changed, 30 insertions(+) > > diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c > index a5bb95ca..dd6f2995 100644 > --- a/lib/igt_debugfs.c > +++ b/lib/igt_debugfs.c > @@ -351,6 +351,23 @@ void __igt_debugfs_read(int fd, const char *filename, char *buf, int size) > close(dir); > } > > +/** > + * __igt_debugfs_write: > + * @fd: the drm device file fd > + * @filename: file name > + * @buf: buffer to be written to the debugfs file > + * @size: size of the buffer > + * > + * This function opens the debugfs file, writes it, then closes the file. > + */ > +void __igt_debugfs_write(int fd, const char *filename, const char *buf, int size) > +{ > + int dir = igt_debugfs_dir(fd); > + > + igt_sysfs_write(dir, filename, buf, size); > + close(dir); > +} > + > /** > * igt_debugfs_search: > * @filename: file name > diff --git a/lib/igt_debugfs.h b/lib/igt_debugfs.h > index d43ba6c6..b4867681 100644 > --- a/lib/igt_debugfs.h > +++ b/lib/igt_debugfs.h > @@ -40,6 +40,7 @@ int igt_debugfs_pipe_dir(int device, int pipe, int mode); > > int igt_debugfs_open(int fd, const char *filename, int mode); > void __igt_debugfs_read(int fd, const char *filename, char *buf, int size); > +void __igt_debugfs_write(int fd, const char *filename, const char *buf, int size); > int igt_debugfs_simple_read(int dir, const char *filename, char *buf, int size); > bool igt_debugfs_search(int fd, const char *filename, const char *substring); > > @@ -54,6 +55,18 @@ bool igt_debugfs_search(int fd, const char *filename, const char *substring); > #define igt_debugfs_read(fd, filename, buf) \ > __igt_debugfs_read(fd, (filename), (buf), sizeof(buf)) > > +/** > + * igt_debugfs_write: > + * @fd: the drm device file fd > + * @filename: name of the debugfs file > + * @buf: buffer to be written to the debugfs file > + * > + * This is just a convenience wrapper for __igt_debugfs_write. See its > + * documentation. > + */ > +#define igt_debugfs_write(fd, filename, buf) \ > + __igt_debugfs_write(fd, (filename), (buf), sizeof(buf)) > + > /* > * Pipe CRC > */ > -- > 2.31.1 >
next prev parent reply other threads:[~2021-11-11 12:14 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-10 18:42 [PATCH igt v2 0/3] msm: Add tests for gpu fault handling Rob Clark 2021-11-10 18:42 ` [igt-dev] " Rob Clark 2021-11-10 18:42 ` [PATCH igt v2 1/3] lib/igt_debugfs: Add helper for writing debugfs files Rob Clark 2021-11-10 18:42 ` [igt-dev] " Rob Clark 2021-11-11 12:13 ` Petri Latvala [this message] 2021-11-11 12:13 ` Petri Latvala 2021-11-10 18:42 ` [PATCH igt v2 2/3] msm: Add helper for cmdstream building and submission Rob Clark 2021-11-10 18:42 ` [igt-dev] " Rob Clark 2021-11-10 18:42 ` [PATCH igt v2 3/3] msm: Add recovery tests Rob Clark 2021-11-10 18:42 ` [igt-dev] " Rob Clark 2021-11-10 19:00 ` Rob Clark 2021-11-10 19:00 ` [igt-dev] " Rob Clark 2021-11-11 12:12 ` Petri Latvala 2021-11-11 12:12 ` [igt-dev] " Petri Latvala 2021-11-11 17:35 ` Rob Clark 2021-11-11 17:35 ` [igt-dev] " Rob Clark 2021-11-12 10:10 ` Petri Latvala 2021-11-12 10:10 ` [igt-dev] " Petri Latvala 2021-11-10 19:23 ` [igt-dev] ✓ Fi.CI.BAT: success for msm: Add tests for gpu fault handling (rev2) Patchwork 2021-11-10 22:43 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YY0I7Ld6xa4vdutc@platvala-desk.ger.corp.intel.com \ --to=petri.latvala@intel.com \ --cc=akhilpo@codeaurora.org \ --cc=freedreno@lists.freedesktop.org \ --cc=igt-dev@lists.freedesktop.org \ --cc=jordan@cosmicpenguin.net \ --cc=linux-arm-msm@vger.kernel.org \ --cc=robdclark@chromium.org \ --cc=robdclark@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.