* [PATCH 1/1] max96712: Select VIDEO_V4L2
@ 2021-11-01 13:25 Sakari Ailus
2021-11-01 13:30 ` Niklas Söderlund
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Sakari Ailus @ 2021-11-01 13:25 UTC (permalink / raw)
To: linux-media; +Cc: Niklas Söderlund
Select VIDEO_V4L2 for the driver actually depends on it, failing to
compile otherwise.
Fixes: 51758f8b32134bacbf30bd217f7c2074e9b4b51e ("media: staging: max96712: Add basic support for MAX96712 GMSL2 deserializer")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/staging/media/max96712/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/max96712/Kconfig b/drivers/staging/media/max96712/Kconfig
index 258d47644cbd..492a7ff70dd8 100644
--- a/drivers/staging/media/max96712/Kconfig
+++ b/drivers/staging/media/max96712/Kconfig
@@ -6,6 +6,7 @@ config VIDEO_MAX96712
select V4L2_FWNODE
select VIDEO_V4L2_SUBDEV_API
select MEDIA_CONTROLLER
+ select VIDEO_V4L2
help
This driver supports the Maxim MAX96712 Quad GMSL2 Deserializer.
--
2.30.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] max96712: Select VIDEO_V4L2
2021-11-01 13:25 [PATCH 1/1] max96712: Select VIDEO_V4L2 Sakari Ailus
@ 2021-11-01 13:30 ` Niklas Söderlund
2021-11-01 16:30 ` Kieran Bingham
2021-11-25 8:34 ` Niklas Söderlund
2 siblings, 0 replies; 7+ messages in thread
From: Niklas Söderlund @ 2021-11-01 13:30 UTC (permalink / raw)
To: Sakari Ailus; +Cc: linux-media
Hi Sakari,
Thanks for your patch.
On 2021-11-01 15:25:02 +0200, Sakari Ailus wrote:
> Select VIDEO_V4L2 for the driver actually depends on it, failing to
> compile otherwise.
>
> Fixes: 51758f8b32134bacbf30bd217f7c2074e9b4b51e ("media: staging: max96712: Add basic support for MAX96712 GMSL2 deserializer")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/staging/media/max96712/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/max96712/Kconfig b/drivers/staging/media/max96712/Kconfig
> index 258d47644cbd..492a7ff70dd8 100644
> --- a/drivers/staging/media/max96712/Kconfig
> +++ b/drivers/staging/media/max96712/Kconfig
> @@ -6,6 +6,7 @@ config VIDEO_MAX96712
> select V4L2_FWNODE
> select VIDEO_V4L2_SUBDEV_API
> select MEDIA_CONTROLLER
> + select VIDEO_V4L2
> help
> This driver supports the Maxim MAX96712 Quad GMSL2 Deserializer.
>
> --
> 2.30.2
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] max96712: Select VIDEO_V4L2
2021-11-01 13:25 [PATCH 1/1] max96712: Select VIDEO_V4L2 Sakari Ailus
2021-11-01 13:30 ` Niklas Söderlund
@ 2021-11-01 16:30 ` Kieran Bingham
2021-11-01 16:55 ` Niklas Söderlund
2021-11-25 8:34 ` Niklas Söderlund
2 siblings, 1 reply; 7+ messages in thread
From: Kieran Bingham @ 2021-11-01 16:30 UTC (permalink / raw)
To: Sakari Ailus, linux-media; +Cc: Niklas Söderlund
Hi Sakari,
Quoting Sakari Ailus (2021-11-01 13:25:02)
> Select VIDEO_V4L2 for the driver actually depends on it, failing to
> compile otherwise.
>
> Fixes: 51758f8b32134bacbf30bd217f7c2074e9b4b51e ("media: staging: max96712: Add basic support for MAX96712 GMSL2 deserializer")
I guess this is a local commit in your tree so far, I can't identify it.
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> drivers/staging/media/max96712/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/max96712/Kconfig b/drivers/staging/media/max96712/Kconfig
> index 258d47644cbd..492a7ff70dd8 100644
> --- a/drivers/staging/media/max96712/Kconfig
> +++ b/drivers/staging/media/max96712/Kconfig
> @@ -6,6 +6,7 @@ config VIDEO_MAX96712
> select V4L2_FWNODE
> select VIDEO_V4L2_SUBDEV_API
> select MEDIA_CONTROLLER
> + select VIDEO_V4L2
I don't see any other driver 'select' VIDEO_V4L2...
Most 'depend' on VIDEO_V4L2 instead.
And curiously, I already see
- Add 'depends on VIDEO_V4L2'
in Niklas' v4.
Is this one a special case that 'needs' to select it?
--
Kieran
> help
> This driver supports the Maxim MAX96712 Quad GMSL2 Deserializer.
>
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] max96712: Select VIDEO_V4L2
2021-11-01 16:30 ` Kieran Bingham
@ 2021-11-01 16:55 ` Niklas Söderlund
2021-11-01 17:08 ` Kieran Bingham
0 siblings, 1 reply; 7+ messages in thread
From: Niklas Söderlund @ 2021-11-01 16:55 UTC (permalink / raw)
To: Kieran Bingham; +Cc: Sakari Ailus, linux-media
Hi Kieran,
On 2021-11-01 16:30:09 +0000, Kieran Bingham wrote:
> Hi Sakari,
>
> Quoting Sakari Ailus (2021-11-01 13:25:02)
> > Select VIDEO_V4L2 for the driver actually depends on it, failing to
> > compile otherwise.
> >
> > Fixes: 51758f8b32134bacbf30bd217f7c2074e9b4b51e ("media: staging: max96712: Add basic support for MAX96712 GMSL2 deserializer")
>
> I guess this is a local commit in your tree so far, I can't identify it.
>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > ---
> > drivers/staging/media/max96712/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/staging/media/max96712/Kconfig b/drivers/staging/media/max96712/Kconfig
> > index 258d47644cbd..492a7ff70dd8 100644
> > --- a/drivers/staging/media/max96712/Kconfig
> > +++ b/drivers/staging/media/max96712/Kconfig
> > @@ -6,6 +6,7 @@ config VIDEO_MAX96712
> > select V4L2_FWNODE
> > select VIDEO_V4L2_SUBDEV_API
> > select MEDIA_CONTROLLER
> > + select VIDEO_V4L2
>
> I don't see any other driver 'select' VIDEO_V4L2...
> Most 'depend' on VIDEO_V4L2 instead.
>
> And curiously, I already see
> - Add 'depends on VIDEO_V4L2'
>
> in Niklas' v4.
I noticed too late that v3 was already in the media staging tree so I
submitted a v4 with this fix. I should probably have submitted a Fixes
patch like this one instead of a v4 if I knew it was already picked-up.
>
> Is this one a special case that 'needs' to select it?
Both 'select' and 'depends on' solves the problem reported by the bot,
which one is more correct I do not know.
> --
> Kieran
>
>
>
> > help
> > This driver supports the Maxim MAX96712 Quad GMSL2 Deserializer.
> >
> > --
> > 2.30.2
> >
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] max96712: Select VIDEO_V4L2
2021-11-01 16:55 ` Niklas Söderlund
@ 2021-11-01 17:08 ` Kieran Bingham
0 siblings, 0 replies; 7+ messages in thread
From: Kieran Bingham @ 2021-11-01 17:08 UTC (permalink / raw)
To: Niklas Söderlund; +Cc: Sakari Ailus, linux-media
Quoting Niklas Söderlund (2021-11-01 16:55:02)
> Hi Kieran,
>
> On 2021-11-01 16:30:09 +0000, Kieran Bingham wrote:
> > Hi Sakari,
> >
> > Quoting Sakari Ailus (2021-11-01 13:25:02)
> > > Select VIDEO_V4L2 for the driver actually depends on it, failing to
> > > compile otherwise.
> > >
> > > Fixes: 51758f8b32134bacbf30bd217f7c2074e9b4b51e ("media: staging: max96712: Add basic support for MAX96712 GMSL2 deserializer")
> >
> > I guess this is a local commit in your tree so far, I can't identify it.
> >
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > > ---
> > > drivers/staging/media/max96712/Kconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/staging/media/max96712/Kconfig b/drivers/staging/media/max96712/Kconfig
> > > index 258d47644cbd..492a7ff70dd8 100644
> > > --- a/drivers/staging/media/max96712/Kconfig
> > > +++ b/drivers/staging/media/max96712/Kconfig
> > > @@ -6,6 +6,7 @@ config VIDEO_MAX96712
> > > select V4L2_FWNODE
> > > select VIDEO_V4L2_SUBDEV_API
> > > select MEDIA_CONTROLLER
> > > + select VIDEO_V4L2
> >
> > I don't see any other driver 'select' VIDEO_V4L2...
> > Most 'depend' on VIDEO_V4L2 instead.
> >
> > And curiously, I already see
> > - Add 'depends on VIDEO_V4L2'
> >
> > in Niklas' v4.
>
> I noticed too late that v3 was already in the media staging tree so I
> submitted a v4 with this fix. I should probably have submitted a Fixes
> patch like this one instead of a v4 if I knew it was already picked-up.
>
> >
> > Is this one a special case that 'needs' to select it?
>
> Both 'select' and 'depends on' solves the problem reported by the bot,
> which one is more correct I do not know.
Aha, I see. Well - consistency would tell me that 'depends on' would
match almost every other driver.
I notice that the MAX9286 suffers the same problem. I'll send a patch.
--
Kieran
> > --
> > Kieran
> >
> >
> >
> > > help
> > > This driver supports the Maxim MAX96712 Quad GMSL2 Deserializer.
> > >
> > > --
> > > 2.30.2
> > >
>
> --
> Regards,
> Niklas Söderlund
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] max96712: Select VIDEO_V4L2
2021-11-01 13:25 [PATCH 1/1] max96712: Select VIDEO_V4L2 Sakari Ailus
2021-11-01 13:30 ` Niklas Söderlund
2021-11-01 16:30 ` Kieran Bingham
@ 2021-11-25 8:34 ` Niklas Söderlund
2021-11-26 8:04 ` Sakari Ailus
2 siblings, 1 reply; 7+ messages in thread
From: Niklas Söderlund @ 2021-11-25 8:34 UTC (permalink / raw)
To: Sakari Ailus; +Cc: linux-media
Hi Sakari,
I noticed this patch is marked as Rejected in patchwork, but it's still
needed. Will you resurrect this patch?
On 2021-11-01 15:25:02 +0200, Sakari Ailus wrote:
> Select VIDEO_V4L2 for the driver actually depends on it, failing to
> compile otherwise.
>
> Fixes: 51758f8b32134bacbf30bd217f7c2074e9b4b51e ("media: staging: max96712: Add basic support for MAX96712 GMSL2 deserializer")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> drivers/staging/media/max96712/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/max96712/Kconfig b/drivers/staging/media/max96712/Kconfig
> index 258d47644cbd..492a7ff70dd8 100644
> --- a/drivers/staging/media/max96712/Kconfig
> +++ b/drivers/staging/media/max96712/Kconfig
> @@ -6,6 +6,7 @@ config VIDEO_MAX96712
> select V4L2_FWNODE
> select VIDEO_V4L2_SUBDEV_API
> select MEDIA_CONTROLLER
> + select VIDEO_V4L2
> help
> This driver supports the Maxim MAX96712 Quad GMSL2 Deserializer.
>
> --
> 2.30.2
>
--
Kind Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] max96712: Select VIDEO_V4L2
2021-11-25 8:34 ` Niklas Söderlund
@ 2021-11-26 8:04 ` Sakari Ailus
0 siblings, 0 replies; 7+ messages in thread
From: Sakari Ailus @ 2021-11-26 8:04 UTC (permalink / raw)
To: Niklas Söderlund; +Cc: linux-media
Hi Niklas,
On Thu, Nov 25, 2021 at 09:34:26AM +0100, Niklas Söderlund wrote:
> Hi Sakari,
>
> I noticed this patch is marked as Rejected in patchwork, but it's still
> needed. Will you resurrect this patch?
Good point.
I noticed Kieran submitted something alike but it seems to have been for a
different driver.
I'll send one that uses depends instead.
--
Regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-11-26 8:08 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-01 13:25 [PATCH 1/1] max96712: Select VIDEO_V4L2 Sakari Ailus
2021-11-01 13:30 ` Niklas Söderlund
2021-11-01 16:30 ` Kieran Bingham
2021-11-01 16:55 ` Niklas Söderlund
2021-11-01 17:08 ` Kieran Bingham
2021-11-25 8:34 ` Niklas Söderlund
2021-11-26 8:04 ` Sakari Ailus
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.