* [LTP] [PATCH v1] netns_netlink: Ensure tuntap is enabled in kernel
@ 2021-11-03 10:02 Bogdan Lezhepekov via ltp
2021-11-04 13:26 ` Cyril Hrubis
2021-11-04 14:10 ` Cyril Hrubis
0 siblings, 2 replies; 6+ messages in thread
From: Bogdan Lezhepekov via ltp @ 2021-11-03 10:02 UTC (permalink / raw)
To: ltp
---
testcases/kernel/containers/netns/netns_netlink.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/testcases/kernel/containers/netns/netns_netlink.c b/testcases/kernel/containers/netns/netns_netlink.c
index ddd8ce910..f9ae255f5 100644
--- a/testcases/kernel/containers/netns/netns_netlink.c
+++ b/testcases/kernel/containers/netns/netns_netlink.c
@@ -120,6 +120,7 @@ static struct tst_test test = {
.forks_child = 1,
.needs_kconfigs = (const char *[]) {
"CONFIG_NET_NS=y",
+ "CONFIG_TUN=y",
NULL
},
};
--
2.33.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [LTP] [PATCH v1] netns_netlink: Ensure tuntap is enabled in kernel
2021-11-03 10:02 [LTP] [PATCH v1] netns_netlink: Ensure tuntap is enabled in kernel Bogdan Lezhepekov via ltp
@ 2021-11-04 13:26 ` Cyril Hrubis
2021-11-04 13:51 ` Bogdan Lezhepekov via ltp
2021-11-04 14:10 ` Cyril Hrubis
1 sibling, 1 reply; 6+ messages in thread
From: Cyril Hrubis @ 2021-11-04 13:26 UTC (permalink / raw)
To: Bogdan Lezhepekov; +Cc: ltp
Hi!
> testcases/kernel/containers/netns/netns_netlink.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/testcases/kernel/containers/netns/netns_netlink.c b/testcases/kernel/containers/netns/netns_netlink.c
> index ddd8ce910..f9ae255f5 100644
> --- a/testcases/kernel/containers/netns/netns_netlink.c
> +++ b/testcases/kernel/containers/netns/netns_netlink.c
> @@ -120,6 +120,7 @@ static struct tst_test test = {
> .forks_child = 1,
> .needs_kconfigs = (const char *[]) {
> "CONFIG_NET_NS=y",
> + "CONFIG_TUN=y",
Shouldn't that be just "CONFIG_TUN" as that would match both
"CONFIG_TUN=y" and "CONFIG_TUN=m"?
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [LTP] [PATCH v1] netns_netlink: Ensure tuntap is enabled in kernel
2021-11-04 13:26 ` Cyril Hrubis
@ 2021-11-04 13:51 ` Bogdan Lezhepekov via ltp
2021-11-04 13:58 ` Cyril Hrubis
0 siblings, 1 reply; 6+ messages in thread
From: Bogdan Lezhepekov via ltp @ 2021-11-04 13:51 UTC (permalink / raw)
To: Cyril Hrubis; +Cc: ltp
[-- Attachment #1.1: Type: text/plain, Size: 1152 bytes --]
Hi Cyril,
I was missing that it's possible with the test API. Then of course it would be better.
Should I submit V2?
Thanks,
Bogdan
________________________________
From: Cyril Hrubis <chrubis@suse.cz>
Sent: Thursday, November 4, 2021 15:26
To: Bogdan Lezhepekov <bogdan.lezhepekov@suse.com>
Cc: ltp@lists.linux.it <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v1] netns_netlink: Ensure tuntap is enabled in kernel
Hi!
> testcases/kernel/containers/netns/netns_netlink.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/testcases/kernel/containers/netns/netns_netlink.c b/testcases/kernel/containers/netns/netns_netlink.c
> index ddd8ce910..f9ae255f5 100644
> --- a/testcases/kernel/containers/netns/netns_netlink.c
> +++ b/testcases/kernel/containers/netns/netns_netlink.c
> @@ -120,6 +120,7 @@ static struct tst_test test = {
> .forks_child = 1,
> .needs_kconfigs = (const char *[]) {
> "CONFIG_NET_NS=y",
> + "CONFIG_TUN=y",
Shouldn't that be just "CONFIG_TUN" as that would match both
"CONFIG_TUN=y" and "CONFIG_TUN=m"?
--
Cyril Hrubis
chrubis@suse.cz
[-- Attachment #1.2: Type: text/html, Size: 2983 bytes --]
[-- Attachment #2: Type: text/plain, Size: 60 bytes --]
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [LTP] [PATCH v1] netns_netlink: Ensure tuntap is enabled in kernel
2021-11-04 13:51 ` Bogdan Lezhepekov via ltp
@ 2021-11-04 13:58 ` Cyril Hrubis
0 siblings, 0 replies; 6+ messages in thread
From: Cyril Hrubis @ 2021-11-04 13:58 UTC (permalink / raw)
To: Bogdan Lezhepekov; +Cc: ltp
Hi!
> I was missing that it's possible with the test API. Then of course it would be better.
Actually the config parser implements full boolean expressions :-).
> Should I submit V2?
No need, I will remove the =y before applying.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [LTP] [PATCH v1] netns_netlink: Ensure tuntap is enabled in kernel
2021-11-03 10:02 [LTP] [PATCH v1] netns_netlink: Ensure tuntap is enabled in kernel Bogdan Lezhepekov via ltp
2021-11-04 13:26 ` Cyril Hrubis
@ 2021-11-04 14:10 ` Cyril Hrubis
2021-11-04 15:46 ` Bogdan Lezhepekov via ltp
1 sibling, 1 reply; 6+ messages in thread
From: Cyril Hrubis @ 2021-11-04 14:10 UTC (permalink / raw)
To: Bogdan Lezhepekov; +Cc: ltp
Hi!
I've fixed the kconfig line and also added your Signed-off-by and
pushed, thanks.
Please make sure that you commit your patches with -s
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [LTP] [PATCH v1] netns_netlink: Ensure tuntap is enabled in kernel
2021-11-04 14:10 ` Cyril Hrubis
@ 2021-11-04 15:46 ` Bogdan Lezhepekov via ltp
0 siblings, 0 replies; 6+ messages in thread
From: Bogdan Lezhepekov via ltp @ 2021-11-04 15:46 UTC (permalink / raw)
To: Cyril Hrubis; +Cc: ltp
[-- Attachment #1.1: Type: text/plain, Size: 510 bytes --]
Hi,
Thanks a lot!
-Bogdan
________________________________
From: Cyril Hrubis <chrubis@suse.cz>
Sent: Thursday, November 4, 2021 16:10
To: Bogdan Lezhepekov <bogdan.lezhepekov@suse.com>
Cc: ltp@lists.linux.it <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v1] netns_netlink: Ensure tuntap is enabled in kernel
Hi!
I've fixed the kconfig line and also added your Signed-off-by and
pushed, thanks.
Please make sure that you commit your patches with -s
--
Cyril Hrubis
chrubis@suse.cz
[-- Attachment #1.2: Type: text/html, Size: 1736 bytes --]
[-- Attachment #2: Type: text/plain, Size: 60 bytes --]
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-11-04 15:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-03 10:02 [LTP] [PATCH v1] netns_netlink: Ensure tuntap is enabled in kernel Bogdan Lezhepekov via ltp
2021-11-04 13:26 ` Cyril Hrubis
2021-11-04 13:51 ` Bogdan Lezhepekov via ltp
2021-11-04 13:58 ` Cyril Hrubis
2021-11-04 14:10 ` Cyril Hrubis
2021-11-04 15:46 ` Bogdan Lezhepekov via ltp
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.