All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Trevor Wu <trevor.wu@mediatek.com>,
	devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	tiwai@suse.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	linux-mediatek@lists.infradead.org, yc.hung@mediatek.com,
	matthias.bgg@gmail.com, daniel.baluta@nxp.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] ASoC: mediatek: mt8195: separate the common code from machine driver
Date: Fri, 5 Nov 2021 16:41:51 +0000	[thread overview]
Message-ID: <YYVez/V9ocCXhYmg@sirena.org.uk> (raw)
In-Reply-To: <e404d241-0685-643b-4b9d-d85bb8783385@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1692 bytes --]

On Fri, Nov 05, 2021 at 11:16:05AM -0500, Pierre-Louis Bossart wrote:
> On 11/5/21 10:38 AM, Mark Brown wrote:

> > We shouldn't be requiring people to load completely different drivers
> > based on software configuration, what if a system wants to bypass the
> > DSP in some but not all configurations?  Can we not just have controls
> > allowing users to route round the DSP where appropriate?

> It was my understanding the card relies on separate components

> - a SOF-based component to provide support for DSP-managed interfaces
> - a 'non-SOF' component for 'regular' interfaces not handled by the DSP.

> this was the basis for the changes discussed in
> https://github.com/thesofproject/linux/pull/3217 and
> https://github.com/thesofproject/linux/pull/3236

So it's actually supposed to end up as two different cards which can't
possibly be interlinked?  That doesn't seem to add up entirely given
that there's stuff being moved out of the current card, and I thought
these systems had a fairly comprehensive audio muxing capability.
Trevor, could you be a bit more specific about what's actually going on
here physically please?

> But indeed if the same interface can be managed by the DSP or not,
> depending on software choices it's a different problem altogether.

> We've looked into this recently, if the choice to involve the DSP or not
> is at the interface level, it might be better to have both components
> expose different DAIs for the same interface, with some sort of run-time
> mutual exclusion, so that all possible/allowed permutations are allowed.

Yes, if the interface can optionally be completely hidden by the DSP
that's adding another layer of complication.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Trevor Wu <trevor.wu@mediatek.com>,
	devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	tiwai@suse.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	linux-mediatek@lists.infradead.org, yc.hung@mediatek.com,
	matthias.bgg@gmail.com, daniel.baluta@nxp.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] ASoC: mediatek: mt8195: separate the common code from machine driver
Date: Fri, 5 Nov 2021 16:41:51 +0000	[thread overview]
Message-ID: <YYVez/V9ocCXhYmg@sirena.org.uk> (raw)
In-Reply-To: <e404d241-0685-643b-4b9d-d85bb8783385@linux.intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 1692 bytes --]

On Fri, Nov 05, 2021 at 11:16:05AM -0500, Pierre-Louis Bossart wrote:
> On 11/5/21 10:38 AM, Mark Brown wrote:

> > We shouldn't be requiring people to load completely different drivers
> > based on software configuration, what if a system wants to bypass the
> > DSP in some but not all configurations?  Can we not just have controls
> > allowing users to route round the DSP where appropriate?

> It was my understanding the card relies on separate components

> - a SOF-based component to provide support for DSP-managed interfaces
> - a 'non-SOF' component for 'regular' interfaces not handled by the DSP.

> this was the basis for the changes discussed in
> https://github.com/thesofproject/linux/pull/3217 and
> https://github.com/thesofproject/linux/pull/3236

So it's actually supposed to end up as two different cards which can't
possibly be interlinked?  That doesn't seem to add up entirely given
that there's stuff being moved out of the current card, and I thought
these systems had a fairly comprehensive audio muxing capability.
Trevor, could you be a bit more specific about what's actually going on
here physically please?

> But indeed if the same interface can be managed by the DSP or not,
> depending on software choices it's a different problem altogether.

> We've looked into this recently, if the choice to involve the DSP or not
> is at the interface level, it might be better to have both components
> expose different DAIs for the same interface, with some sort of run-time
> mutual exclusion, so that all possible/allowed permutations are allowed.

Yes, if the interface can optionally be completely hidden by the DSP
that's adding another layer of complication.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org, tiwai@suse.com, robh+dt@kernel.org,
	linux-mediatek@lists.infradead.org,
	Trevor Wu <trevor.wu@mediatek.com>,
	yc.hung@mediatek.com, matthias.bgg@gmail.com,
	daniel.baluta@nxp.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] ASoC: mediatek: mt8195: separate the common code from machine driver
Date: Fri, 5 Nov 2021 16:41:51 +0000	[thread overview]
Message-ID: <YYVez/V9ocCXhYmg@sirena.org.uk> (raw)
In-Reply-To: <e404d241-0685-643b-4b9d-d85bb8783385@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1692 bytes --]

On Fri, Nov 05, 2021 at 11:16:05AM -0500, Pierre-Louis Bossart wrote:
> On 11/5/21 10:38 AM, Mark Brown wrote:

> > We shouldn't be requiring people to load completely different drivers
> > based on software configuration, what if a system wants to bypass the
> > DSP in some but not all configurations?  Can we not just have controls
> > allowing users to route round the DSP where appropriate?

> It was my understanding the card relies on separate components

> - a SOF-based component to provide support for DSP-managed interfaces
> - a 'non-SOF' component for 'regular' interfaces not handled by the DSP.

> this was the basis for the changes discussed in
> https://github.com/thesofproject/linux/pull/3217 and
> https://github.com/thesofproject/linux/pull/3236

So it's actually supposed to end up as two different cards which can't
possibly be interlinked?  That doesn't seem to add up entirely given
that there's stuff being moved out of the current card, and I thought
these systems had a fairly comprehensive audio muxing capability.
Trevor, could you be a bit more specific about what's actually going on
here physically please?

> But indeed if the same interface can be managed by the DSP or not,
> depending on software choices it's a different problem altogether.

> We've looked into this recently, if the choice to involve the DSP or not
> is at the interface level, it might be better to have both components
> expose different DAIs for the same interface, with some sort of run-time
> mutual exclusion, so that all possible/allowed permutations are allowed.

Yes, if the interface can optionally be completely hidden by the DSP
that's adding another layer of complication.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Trevor Wu <trevor.wu@mediatek.com>,
	devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	tiwai@suse.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	linux-mediatek@lists.infradead.org, yc.hung@mediatek.com,
	matthias.bgg@gmail.com, daniel.baluta@nxp.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] ASoC: mediatek: mt8195: separate the common code from machine driver
Date: Fri, 5 Nov 2021 16:41:51 +0000	[thread overview]
Message-ID: <YYVez/V9ocCXhYmg@sirena.org.uk> (raw)
In-Reply-To: <e404d241-0685-643b-4b9d-d85bb8783385@linux.intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 1692 bytes --]

On Fri, Nov 05, 2021 at 11:16:05AM -0500, Pierre-Louis Bossart wrote:
> On 11/5/21 10:38 AM, Mark Brown wrote:

> > We shouldn't be requiring people to load completely different drivers
> > based on software configuration, what if a system wants to bypass the
> > DSP in some but not all configurations?  Can we not just have controls
> > allowing users to route round the DSP where appropriate?

> It was my understanding the card relies on separate components

> - a SOF-based component to provide support for DSP-managed interfaces
> - a 'non-SOF' component for 'regular' interfaces not handled by the DSP.

> this was the basis for the changes discussed in
> https://github.com/thesofproject/linux/pull/3217 and
> https://github.com/thesofproject/linux/pull/3236

So it's actually supposed to end up as two different cards which can't
possibly be interlinked?  That doesn't seem to add up entirely given
that there's stuff being moved out of the current card, and I thought
these systems had a fairly comprehensive audio muxing capability.
Trevor, could you be a bit more specific about what's actually going on
here physically please?

> But indeed if the same interface can be managed by the DSP or not,
> depending on software choices it's a different problem altogether.

> We've looked into this recently, if the choice to involve the DSP or not
> is at the interface level, it might be better to have both components
> expose different DAIs for the same interface, with some sort of run-time
> mutual exclusion, so that all possible/allowed permutations are allowed.

Yes, if the interface can optionally be completely hidden by the DSP
that's adding another layer of complication.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-11-05 16:42 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03 10:00 [PATCH 0/4] ASoC: mediatek: Update MT8195 machine driver Trevor Wu
2021-11-03 10:00 ` Trevor Wu
2021-11-03 10:00 ` Trevor Wu
2021-11-03 10:00 ` Trevor Wu
2021-11-03 10:00 ` [PATCH 1/4] ASoC: mediatek: mt8195: add headset codec rt5682s support Trevor Wu
2021-11-03 10:00   ` Trevor Wu
2021-11-03 10:00   ` Trevor Wu
2021-11-03 10:00   ` Trevor Wu
2021-11-03 10:00 ` [PATCH 2/4] dt-bindings: mediatek: mt8195: add model property Trevor Wu
2021-11-03 10:00   ` Trevor Wu
2021-11-03 10:00   ` Trevor Wu
2021-11-03 10:00   ` Trevor Wu
2021-11-12 20:10   ` Rob Herring
2021-11-12 20:10     ` Rob Herring
2021-11-12 20:10     ` Rob Herring
2021-11-12 20:10     ` Rob Herring
2021-11-03 10:00 ` [PATCH 3/4] ASoC: mediatek: mt8195: separate the common code from machine driver Trevor Wu
2021-11-03 10:00   ` Trevor Wu
2021-11-03 10:00   ` Trevor Wu
2021-11-03 10:00   ` Trevor Wu
2021-11-04 15:39   ` Mark Brown
2021-11-04 15:39     ` Mark Brown
2021-11-04 15:39     ` Mark Brown
2021-11-04 15:39     ` Mark Brown
2021-11-05  4:11     ` Trevor Wu
2021-11-05  4:11       ` Trevor Wu
2021-11-05  4:11       ` Trevor Wu
2021-11-05  4:11       ` Trevor Wu
2021-11-05 15:38       ` Mark Brown
2021-11-05 15:38         ` Mark Brown
2021-11-05 15:38         ` Mark Brown
2021-11-05 15:38         ` Mark Brown
2021-11-05 16:16         ` Pierre-Louis Bossart
2021-11-05 16:16           ` Pierre-Louis Bossart
2021-11-05 16:16           ` Pierre-Louis Bossart
2021-11-05 16:41           ` Mark Brown [this message]
2021-11-05 16:41             ` Mark Brown
2021-11-05 16:41             ` Mark Brown
2021-11-05 16:41             ` Mark Brown
2021-11-08  9:40             ` YC Hung
2021-11-08  9:40               ` YC Hung
2021-11-08  9:40               ` YC Hung
2021-11-08  9:40               ` YC Hung
2021-11-16  9:33               ` Trevor Wu
2021-11-16  9:33                 ` Trevor Wu
2021-11-16  9:33                 ` Trevor Wu
2021-11-16  9:33                 ` Trevor Wu
2021-11-16 14:59                 ` Mark Brown
2021-11-16 14:59                   ` Mark Brown
2021-11-16 14:59                   ` Mark Brown
2021-11-16 14:59                   ` Mark Brown
2021-11-03 10:00 ` [PATCH 4/4] ASoC: mediatek: mt8195: add machine driver for MT8195 SOF support Trevor Wu
2021-11-03 10:00   ` Trevor Wu
2021-11-03 10:00   ` Trevor Wu
2021-11-03 10:00   ` Trevor Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YYVez/V9ocCXhYmg@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=daniel.baluta@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=robh+dt@kernel.org \
    --cc=tiwai@suse.com \
    --cc=trevor.wu@mediatek.com \
    --cc=yc.hung@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.