[GIT PULL] Modules updates for v5.16-rc1

[GIT PULL] Modules updates for v5.16-rc1

[Luis Chamberlain]

Hi Linus,

As requested by Jessica, I'm stepping in to help with modules
maintenance. This is my my first pull request, so if there are any
issues with it please let me know so I can fix things for the next
time around to make it even smoother for you.

Nothing exciting here, except a warning enhancement and a fix for
insanely large modules.

Thank you,

  Luis

The following changes since commit 7fd982f394c42f25a73fe9dfbf1e6b11fa26b40a:

  module: change to print useful messages from elf_validity_check() (2021-11-05 15:13:10 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/ tags/modules-5.16-rc1

for you to fetch changes up to 7fd982f394c42f25a73fe9dfbf1e6b11fa26b40a:

  module: change to print useful messages from elf_validity_check() (2021-11-05 15:13:10 -0700)

----------------------------------------------------------------
modules patches for 5.16-rc1

As requested by Jessica I'm stepping in to help with modules
maintenance. This is my first pull request to you.

I've collected only two patches for modules for the 5.16-rc1 merge
window. These patches are from Shuah Khan as she debugged some corner
case error with modules. The error messages are improved for
elf_validity_check(). While doing this work a corner case fix was
spotted on validate_section_offset() due to a possible overflow bug
on 64-bit. The impact of this fix is low given this just limits
module section headers placed within the 32-bit boundary, and we
obviously don't have insane module sizes. Even if a specially crafted
module is constructed later checks would invalidate the module right
away.

I've let this sit through 0-day testing since October 15th with no
issues found.

Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>

----------------------------------------------------------------

Re: [GIT PULL] Modules updates for v5.16-rc1

[Linus Torvalds]

On Fri, Nov 5, 2021 at 3:33 PM Luis Chamberlain <mcgrof@kernel.org> wrote:
>
> As requested by Jessica, I'm stepping in to help with modules
> maintenance. This is my my first pull request, so if there are any
> issues with it please let me know so I can fix things for the next
> time around to make it even smoother for you.

Well, I want to see what I'm getting.

That's what "git request-pull" is all about - it does most of the
formatting particularly if you have a tag with the explanations
already like you seem to have.

That very much includes a diffstat and a shortlog, so that I see that
"yes, what I got is actually what you intended for me to get" (and so
that I can do a first quick scan of "this is what's coming" before I
even do the pull - sometimes I use that to judge whether I should do
the pull now,. or leave it for later when I have more time to go
through something).

                 Linus

Re: [GIT PULL] Modules updates for v5.16-rc1

[Luis Chamberlain]

On Sun, Nov 07, 2021 at 11:08:02AM -0800, Linus Torvalds wrote:
> On Fri, Nov 5, 2021 at 3:33 PM Luis Chamberlain <mcgrof@kernel.org> wrote:
> >
> > As requested by Jessica, I'm stepping in to help with modules
> > maintenance. This is my my first pull request, so if there are any
> > issues with it please let me know so I can fix things for the next
> > time around to make it even smoother for you.
> 
> Well, I want to see what I'm getting.
> 
> That's what "git request-pull" is all about - it does most of the
> formatting particularly if you have a tag with the explanations
> already like you seem to have.
> 
> That very much includes a diffstat and a shortlog, so that I see that
> "yes, what I got is actually what you intended for me to get" (and so
> that I can do a first quick scan of "this is what's coming" before I
> even do the pull - sometimes I use that to judge whether I should do
> the pull now,. or leave it for later when I have more time to go
> through something).

Odd, so I used 'git request-pull' and this page for guidence:

https://www.kernel.org/doc/html/latest/maintainer/pull-requests.html

Sadly, no diffstat or shortlog was provided in:

git request-pull modules-linus git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/ modules-5.16-rc1

  Luis

Re: [GIT PULL] Modules updates for v5.16-rc1

[Linus Torvalds]

On Mon, Nov 8, 2021 at 8:05 AM Luis Chamberlain <mcgrof@kernel.org> wrote:
>
> Sadly, no diffstat or shortlog was provided in:

So I don';t know what your local names are, but I suspect that what is
going on is:

> git request-pull modules-linus git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/ modules-5.16-rc1

That 'modules-linus' is supposed to be the upstream that your work was based on.

If the 'modules-linus' is your own branch, and has all your work in
it, then the diff and the shortlog will be empty, because that
'modules-5.16-rc1' thing doesn't have anything new wrt it.

So if your 'origin' remote branch is the one that tracks upstream, the
command line should be something like

   git request-pull origin/master git://git.kernel.org/....

please give that a try (but don't update your origin tree before you
do, since I've just pulled things, and then you'll get the same
"nothing to pull").

It should have given you something like

Shuah Khan (2):
      module: fix validate_section_offset() overflow bug on 64-bit
      module: change to print useful messages from elf_validity_check()

 kernel/module.c | 79 ++++++++++++++++++++++++++++++++++++++++++---------------
 1 file changed, 58 insertions(+), 21 deletions(-)

I'll pull this as-is, since the rest looks fine and it's small and I
do see that it's just two commits from Shuah like you described
verbally. But for anything bigger I really do want to see proper pull
requests.

                   Linus

Re: [GIT PULL] Modules updates for v5.16-rc1

[pr-tracker-bot]

The pull request you sent on Fri, 5 Nov 2021 15:33:46 -0700:

> git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/ tags/modules-5.16-rc1

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/67b7e1f2410ecb94b86749cfbd1edf6d66ca237d

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

Re: [GIT PULL] Modules updates for v5.16-rc1

[Luis Chamberlain]

On Mon, Nov 08, 2021 at 09:07:58AM -0800, Linus Torvalds wrote:
> So if your 'origin' remote branch is the one that tracks upstream, the
> command line should be something like
> 
>    git request-pull origin/master git://git.kernel.org/....
> 
> please give that a try (but don't update your origin tree before you
> do, since I've just pulled things, and then you'll get the same
> "nothing to pull").

Yes, I see the diff stat now thanks! Will be sure to make it smoother on
the next rounds.

  Luis