All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Joe Perches <joe@perches.com>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Jianqun Xu <jay.xu@rock-chips.com>,
	Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-rockchip@lists.infradead.org" 
	<linux-rockchip@lists.infradead.org>,
	Bamvor Jian Zhang <bamv2005@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Gregory Clement <gregory.clement@bootlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Patrice Chotard <patrice.chotard@foss.st.com>,
	Michal Simek <michal.simek@xilinx.com>,
	Andy Shevchenko <andy@kernel.org>
Subject: Re: [PATCH v1 14/19] pinctrl: st: Use temporary variable for struct device
Date: Tue, 9 Nov 2021 14:07:16 +0200	[thread overview]
Message-ID: <YYpkdAPtLWm9pLOM@smile.fi.intel.com> (raw)
In-Reply-To: <CACRpkdZQsR1yisaCgmSDfG8OtkYgu1tWPBa_mw25o++suLjf4A@mail.gmail.com>

On Tue, Nov 09, 2021 at 12:55:44PM +0100, Linus Walleij wrote:
> On Mon, Nov 8, 2021 at 10:26 AM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> 
> > > IMO: the strarray variants introduction and use should be a separate
> > > patchset from the rest.
> >
> > It will add unnecessary churn. Yeah, I have planned to send just that, but then
> > it took more and more cleanups and I have to stop at some point, the code there
> > is bad (historically or by other reasons, dunno).
> 
> I trust your judgement and taste to a large extent so this will not be
> necessary. I can queue the whole series in pinctrl when you
> think it's mature.
> 
> The library bits I kind of feel uncertain about who maintains, but I might just
> apply it.

No worries, Andrew usually applies that in case it's _solely_ library code.
Otherwise it's on certain maintainer shoulders to decide. Note, that I'm one
of the designated reviewers for lib/string*.

Thanks!

-- 
With Best Regards,
Andy Shevchenko



WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Joe Perches <joe@perches.com>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Jianqun Xu <jay.xu@rock-chips.com>,
	Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	 "linux-rockchip@lists.infradead.org"
	<linux-rockchip@lists.infradead.org>,
	Bamvor Jian Zhang <bamv2005@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Gregory Clement <gregory.clement@bootlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Patrice Chotard <patrice.chotard@foss.st.com>,
	Michal Simek <michal.simek@xilinx.com>,
	Andy Shevchenko <andy@kernel.org>
Subject: Re: [PATCH v1 14/19] pinctrl: st: Use temporary variable for struct device
Date: Tue, 9 Nov 2021 14:07:16 +0200	[thread overview]
Message-ID: <YYpkdAPtLWm9pLOM@smile.fi.intel.com> (raw)
In-Reply-To: <CACRpkdZQsR1yisaCgmSDfG8OtkYgu1tWPBa_mw25o++suLjf4A@mail.gmail.com>

On Tue, Nov 09, 2021 at 12:55:44PM +0100, Linus Walleij wrote:
> On Mon, Nov 8, 2021 at 10:26 AM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> 
> > > IMO: the strarray variants introduction and use should be a separate
> > > patchset from the rest.
> >
> > It will add unnecessary churn. Yeah, I have planned to send just that, but then
> > it took more and more cleanups and I have to stop at some point, the code there
> > is bad (historically or by other reasons, dunno).
> 
> I trust your judgement and taste to a large extent so this will not be
> necessary. I can queue the whole series in pinctrl when you
> think it's mature.
> 
> The library bits I kind of feel uncertain about who maintains, but I might just
> apply it.

No worries, Andrew usually applies that in case it's _solely_ library code.
Otherwise it's on certain maintainer shoulders to decide. Note, that I'm one
of the designated reviewers for lib/string*.

Thanks!

-- 
With Best Regards,
Andy Shevchenko



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Joe Perches <joe@perches.com>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Jianqun Xu <jay.xu@rock-chips.com>,
	Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	 "linux-rockchip@lists.infradead.org"
	<linux-rockchip@lists.infradead.org>,
	Bamvor Jian Zhang <bamv2005@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Gregory Clement <gregory.clement@bootlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Patrice Chotard <patrice.chotard@foss.st.com>,
	Michal Simek <michal.simek@xilinx.com>,
	Andy Shevchenko <andy@kernel.org>
Subject: Re: [PATCH v1 14/19] pinctrl: st: Use temporary variable for struct device
Date: Tue, 9 Nov 2021 14:07:16 +0200	[thread overview]
Message-ID: <YYpkdAPtLWm9pLOM@smile.fi.intel.com> (raw)
In-Reply-To: <CACRpkdZQsR1yisaCgmSDfG8OtkYgu1tWPBa_mw25o++suLjf4A@mail.gmail.com>

On Tue, Nov 09, 2021 at 12:55:44PM +0100, Linus Walleij wrote:
> On Mon, Nov 8, 2021 at 10:26 AM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> 
> > > IMO: the strarray variants introduction and use should be a separate
> > > patchset from the rest.
> >
> > It will add unnecessary churn. Yeah, I have planned to send just that, but then
> > it took more and more cleanups and I have to stop at some point, the code there
> > is bad (historically or by other reasons, dunno).
> 
> I trust your judgement and taste to a large extent so this will not be
> necessary. I can queue the whole series in pinctrl when you
> think it's mature.
> 
> The library bits I kind of feel uncertain about who maintains, but I might just
> apply it.

No worries, Andrew usually applies that in case it's _solely_ library code.
Otherwise it's on certain maintainer shoulders to decide. Note, that I'm one
of the designated reviewers for lib/string*.

Thanks!

-- 
With Best Regards,
Andy Shevchenko



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-11-09 12:07 UTC|newest]

Thread overview: 144+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-05 12:42 [PATCH v1 01/19] lib/string_helpers: Introduce kasprintf_strarray() Andy Shevchenko
2021-11-05 12:42 ` Andy Shevchenko
2021-11-05 12:42 ` Andy Shevchenko
2021-11-05 12:42 ` [PATCH v1 02/19] lib/string_helpers: Introduce managed variant of kasprintf_strarray() Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-05 12:42 ` [PATCH v1 03/19] pinctrl/rockchip: Drop wrong kernel doc annotation Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-06 16:32   ` Heiko Stübner
2021-11-06 16:32     ` Heiko Stübner
2021-11-06 16:32     ` Heiko Stübner
2021-11-05 12:42 ` [PATCH v1 04/19] pinctrl/rockchip: Use temporary variable for struct device Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-08 12:46   ` Heiko Stübner
2021-11-08 12:46     ` Heiko Stübner
2021-11-08 12:46     ` Heiko Stübner
2021-11-05 12:42 ` [PATCH v1 05/19] pinctrl/rockchip: Make use of the devm_platform_get_and_ioremap_resource() Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-08 12:48   ` Heiko Stübner
2021-11-08 12:48     ` Heiko Stübner
2021-11-08 12:48     ` Heiko Stübner
2021-11-05 12:42 ` [PATCH v1 06/19] pinctrl/rockchip: Convert to use dev_err_probe() Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-08 12:49   ` Heiko Stübner
2021-11-08 12:49     ` Heiko Stübner
2021-11-08 12:49     ` Heiko Stübner
2021-11-05 12:42 ` [PATCH v1 07/19] pinctrl/rockchip: Switch to use devm_kasprintf_strarray() Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-08 12:51   ` Heiko Stübner
2021-11-08 12:51     ` Heiko Stübner
2021-11-08 12:51     ` Heiko Stübner
2021-11-05 12:42 ` [PATCH v1 08/19] pinctrl: armada-37xx: Fix function name in the kernel doc Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-08 10:37   ` Gregory CLEMENT
2021-11-08 10:37     ` Gregory CLEMENT
2021-11-08 10:37     ` Gregory CLEMENT
2021-11-05 12:42 ` [PATCH v1 09/19] pinctrl: armada-37xx: Use temporary variable for struct device Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-08 10:49   ` Gregory CLEMENT
2021-11-08 10:49     ` Gregory CLEMENT
2021-11-08 10:49     ` Gregory CLEMENT
2021-11-05 12:42 ` [PATCH v1 10/19] pinctrl: armada-37xx: Make use of the devm_platform_ioremap_resource() Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-08 10:56   ` Gregory CLEMENT
2021-11-08 10:56     ` Gregory CLEMENT
2021-11-08 10:56     ` Gregory CLEMENT
2021-11-05 12:42 ` [PATCH v1 11/19] pinctrl: armada-37xx: Convert to use dev_err_probe() Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-08 10:59   ` Gregory CLEMENT
2021-11-08 10:59     ` Gregory CLEMENT
2021-11-08 10:59     ` Gregory CLEMENT
2021-11-05 12:42 ` [PATCH v1 12/19] pinctrl: armada-37xx: Switch to use devm_kasprintf_strarray() Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-08 11:09   ` Gregory CLEMENT
2021-11-08 11:09     ` Gregory CLEMENT
2021-11-08 11:09     ` Gregory CLEMENT
2021-11-05 12:42 ` [PATCH v1 13/19] pinctrl: st: Drop wrong kernel doc annotations Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-09 11:32   ` Linus Walleij
2021-11-09 11:32     ` Linus Walleij
2021-11-09 11:32     ` Linus Walleij
2021-11-09 12:04     ` Andy Shevchenko
2021-11-09 12:04       ` Andy Shevchenko
2021-11-09 12:04       ` Andy Shevchenko
2021-11-05 12:42 ` [PATCH v1 14/19] pinctrl: st: Use temporary variable for struct device Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-06  7:50   ` Joe Perches
2021-11-06  7:50     ` Joe Perches
2021-11-06  7:50     ` Joe Perches
     [not found]     ` <CAHp75Ve0Bv9VsWFFZxL9wYk=Z_Mm7nat-vf7g8HHTiROi7EY=Q@mail.gmail.com>
2021-11-06  8:28       ` Joe Perches
2021-11-06  8:28         ` Joe Perches
2021-11-06  8:28         ` Joe Perches
2021-11-08  9:26         ` Andy Shevchenko
2021-11-08  9:26           ` Andy Shevchenko
2021-11-08  9:26           ` Andy Shevchenko
2021-11-09 11:55           ` Linus Walleij
2021-11-09 11:55             ` Linus Walleij
2021-11-09 11:55             ` Linus Walleij
2021-11-09 12:07             ` Andy Shevchenko [this message]
2021-11-09 12:07               ` Andy Shevchenko
2021-11-09 12:07               ` Andy Shevchenko
2021-11-09 12:09             ` Andy Shevchenko
2021-11-09 12:09               ` Andy Shevchenko
2021-11-09 12:09               ` Andy Shevchenko
2021-11-05 12:42 ` [PATCH v1 15/19] pinctrl: st: Make use of the devm_platform_ioremap_resource_byname() Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-09 11:33   ` Linus Walleij
2021-11-09 11:33     ` Linus Walleij
2021-11-09 11:33     ` Linus Walleij
2021-11-05 12:42 ` [PATCH v1 16/19] pinctrl: st: Convert to use dev_err_probe() Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-09 11:34   ` Linus Walleij
2021-11-09 11:34     ` Linus Walleij
2021-11-09 11:34     ` Linus Walleij
2021-11-05 12:42 ` [PATCH v1 17/19] pinctrl: st: Switch to use devm_kasprintf_strarray() Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-09 11:34   ` Linus Walleij
2021-11-09 11:34     ` Linus Walleij
2021-11-09 11:34     ` Linus Walleij
2021-11-05 12:42 ` [PATCH v1 18/19] pinctrl: zynqmp: Unify pin naming Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-09 11:34   ` Linus Walleij
2021-11-09 11:34     ` Linus Walleij
2021-11-09 11:34     ` Linus Walleij
2021-11-05 12:42 ` [PATCH v1 19/19] gpio: mockup: Switch to use kasprintf_strarray() Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-05 12:42   ` Andy Shevchenko
2021-11-09 11:35   ` Linus Walleij
2021-11-09 11:35     ` Linus Walleij
2021-11-09 11:35     ` Linus Walleij
2021-11-16  9:12   ` Bartosz Golaszewski
2021-11-16  9:12     ` Bartosz Golaszewski
2021-11-16  9:12     ` Bartosz Golaszewski
2021-11-06  7:34 ` [PATCH v1 01/19] lib/string_helpers: Introduce kasprintf_strarray() Joe Perches
2021-11-06  7:34   ` Joe Perches
2021-11-06  7:34   ` Joe Perches
2021-11-09 11:42 ` Linus Walleij
2021-11-09 11:42   ` Linus Walleij
2021-11-09 11:42   ` Linus Walleij
2021-11-15 11:23   ` Andy Shevchenko
2021-11-15 11:23     ` Andy Shevchenko
2021-11-15 11:23     ` Andy Shevchenko
2021-11-18 16:56     ` Andy Shevchenko
2021-11-18 16:56       ` Andy Shevchenko
2021-11-18 16:56       ` Andy Shevchenko
2021-11-18 20:30       ` Bartosz Golaszewski
2021-11-18 20:30         ` Bartosz Golaszewski
2021-11-18 20:30         ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YYpkdAPtLWm9pLOM@smile.fi.intel.com \
    --to=andy.shevchenko@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=andrew@lunn.ch \
    --cc=andy@kernel.org \
    --cc=bamv2005@gmail.com \
    --cc=brgl@bgdev.pl \
    --cc=gregory.clement@bootlin.com \
    --cc=heiko@sntech.de \
    --cc=jay.xu@rock-chips.com \
    --cc=joe@perches.com \
    --cc=lakshmi.sai.krishna.potthuri@xilinx.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=michal.simek@xilinx.com \
    --cc=patrice.chotard@foss.st.com \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.