From: Andi Shyti <andi.shyti@linux.intel.com>
To: "Stimson, Dale B" <dale.b.stimson@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>,
intel-gfx@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>,
dri-devel@lists.freedesktop.org,
Venkata Sandeep Dhanalakota <venkata.s.dhanalakota@intel.com>
Subject: Re: [PATCH v3 05/10] drm/i915: Prepare for multiple gts
Date: Thu, 11 Nov 2021 00:30:31 +0100 [thread overview]
Message-ID: <YYxWF8TEIbJZH5lF@intel.intel> (raw)
In-Reply-To: <20211110232018.GA33197@dbstims-dev.fm.intel.com>
Hi,
> > +#define for_each_gt(i915__, id__, gt__) \
> > + for ((id__) = 0; \
> > + (id__) < I915_MAX_TILES; \
> > + (id__)++) \
> > + for_each_if(((gt__) = (i915__)->gts[(id__)]))
>
> In this patch set, symbol I915_MAX_TILES is introduced.
> In a later patch set of this series, I915_MAX_TILES is renamed to I915_MAX_GTS.
> How about using name I915_MAX_GTS consistently through the patch series?
>
> It will make the history easier to understand, and should this patch series
> be merged in pieces, it will avoid having to do the rename in software that
> depends on this.
speaking of which I915_MAX_GTS is not a great choice of a name:
as Jani pointed out in one of his prevoius reviews, how do we
intrepret it, GTS or GTs?
Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Shyti <andi.shyti@linux.intel.com>
To: "Stimson, Dale B" <dale.b.stimson@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v3 05/10] drm/i915: Prepare for multiple gts
Date: Thu, 11 Nov 2021 00:30:31 +0100 [thread overview]
Message-ID: <YYxWF8TEIbJZH5lF@intel.intel> (raw)
In-Reply-To: <20211110232018.GA33197@dbstims-dev.fm.intel.com>
Hi,
> > +#define for_each_gt(i915__, id__, gt__) \
> > + for ((id__) = 0; \
> > + (id__) < I915_MAX_TILES; \
> > + (id__)++) \
> > + for_each_if(((gt__) = (i915__)->gts[(id__)]))
>
> In this patch set, symbol I915_MAX_TILES is introduced.
> In a later patch set of this series, I915_MAX_TILES is renamed to I915_MAX_GTS.
> How about using name I915_MAX_GTS consistently through the patch series?
>
> It will make the history easier to understand, and should this patch series
> be merged in pieces, it will avoid having to do the rename in software that
> depends on this.
speaking of which I915_MAX_GTS is not a great choice of a name:
as Jani pointed out in one of his prevoius reviews, how do we
intrepret it, GTS or GTs?
Andi
next parent reply other threads:[~2021-11-10 23:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211110232018.GA33197@dbstims-dev.fm.intel.com>
2021-11-10 23:30 ` Andi Shyti [this message]
2021-11-10 23:30 ` [Intel-gfx] [PATCH v3 05/10] drm/i915: Prepare for multiple gts Andi Shyti
2021-11-10 23:33 Stimson, Dale B
-- strict thread matches above, loose matches on Subject: below --
2021-10-29 3:28 [PATCH v3 00/10] i915: Initial multi-tile support Matt Roper
2021-10-29 3:28 ` [PATCH v3 05/10] drm/i915: Prepare for multiple gts Matt Roper
2021-11-01 23:11 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYxWF8TEIbJZH5lF@intel.intel \
--to=andi.shyti@linux.intel.com \
--cc=dale.b.stimson@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=tvrtko.ursulin@intel.com \
--cc=venkata.s.dhanalakota@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.