* [PATCH] staging: rtl8723bs: replace printk(KERN_CRIT...) by netdev_crit()
@ 2021-11-20 16:01 Satoshi Ikeke
2021-11-25 16:43 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Satoshi Ikeke @ 2021-11-20 16:01 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel
Replace printk(KERN_CRIT...) by netdev_crit() for more uniform error reporting. Issue found by checkpatch.
Signed-off-by: Satoshi Ikeke <satoshi.ikeke@gmail.com>
---
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
index 490431484524..8c90cb3a68ed 100644
--- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
+++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
@@ -73,7 +73,7 @@ static int sdio_alloc_irq(struct dvobj_priv *dvobj)
err = sdio_claim_irq(func, &sd_sync_int_hdl);
if (err) {
dvobj->drv_dbg.dbg_sdio_alloc_irq_error_cnt++;
- printk(KERN_CRIT "%s: sdio_claim_irq FAIL(%d)!\n", __func__, err);
+ netdev_crit(dvobj->if1->pnetdev, "%s: sdio_claim_irq FAIL(%d)!\n", __func__, err);
} else {
dvobj->drv_dbg.dbg_sdio_alloc_irq_cnt++;
dvobj->irq_alloc = 1;
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8723bs: replace printk(KERN_CRIT...) by netdev_crit()
2021-11-20 16:01 [PATCH] staging: rtl8723bs: replace printk(KERN_CRIT...) by netdev_crit() Satoshi Ikeke
@ 2021-11-25 16:43 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-11-25 16:43 UTC (permalink / raw)
To: Satoshi Ikeke; +Cc: linux-staging, linux-kernel
On Sat, Nov 20, 2021 at 11:01:34AM -0500, Satoshi Ikeke wrote:
> Replace printk(KERN_CRIT...) by netdev_crit() for more uniform error reporting. Issue found by checkpatch.
Please properly wrap your changelog comments at the correct line width.
Please fix up and send a v2.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-25 16:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-20 16:01 [PATCH] staging: rtl8723bs: replace printk(KERN_CRIT...) by netdev_crit() Satoshi Ikeke
2021-11-25 16:43 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.