[LTP] [PATCH 1/2] kernel/Makefile: Add irq to Makefile

[LTP] [PATCH 1/2] kernel/Makefile: Add irq to Makefile

[Yang Xu]

Fixes: f8fb073708 ("kernel/irq: Add irqbalance01")
Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
---
 testcases/kernel/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/testcases/kernel/Makefile b/testcases/kernel/Makefile
index f3a608f38..4604f1f38 100644
--- a/testcases/kernel/Makefile
+++ b/testcases/kernel/Makefile
@@ -28,6 +28,7 @@ SUBDIRS			+= connectors \
 			   input \
 			   io \
 			   ipc \
+			   irq \
 			   logging \
 			   mem \
 			   numa \
-- 
2.23.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH 2/2] scenario_groups/default: Add irq into default run

[Yang Xu]

Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
---
 scenario_groups/default | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scenario_groups/default b/scenario_groups/default
index 439783dac..1dc2987d5 100644
--- a/scenario_groups/default
+++ b/scenario_groups/default
@@ -6,6 +6,7 @@ dio
 io
 mm
 ipc
+irq
 sched
 math
 nptl
-- 
2.23.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/2] kernel/Makefile: Add irq to Makefile

[Petr Vorel]

Hi Xu,

obviously correct, thus pushed.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 2/2] scenario_groups/default: Add irq into default run

[Petr Vorel]

Hi,

yes, it should go to default scenario group as well.

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 2/2] scenario_groups/default: Add irq into default run

[Richard Palethorpe]

Hello,

Yang Xu <xuyang2018.jy@fujitsu.com> writes:

> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> ---
>  scenario_groups/default | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/scenario_groups/default b/scenario_groups/default
> index 439783dac..1dc2987d5 100644
> --- a/scenario_groups/default
> +++ b/scenario_groups/default
> @@ -6,6 +6,7 @@ dio
>  io
>  mm
>  ipc
> +irq
>  sched
>  math
>  nptl
> -- 
> 2.23.0

I'm not sure this should go in the default group at this time. The only
test in irq (irqbalance), only works on some configurations. As
discussed in the test review, the user must figure out if they should
run it or not.

Perhaps we need a new scenario group?

-- 
Thank you,
Richard.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 2/2] scenario_groups/default: Add irq into default run

[xuyang2018.jy]

Hi Richard
> Hello,
> 
> Yang Xu<xuyang2018.jy@fujitsu.com>  writes:
> 
>> Signed-off-by: Yang Xu<xuyang2018.jy@fujitsu.com>
>> ---
>>   scenario_groups/default | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/scenario_groups/default b/scenario_groups/default
>> index 439783dac..1dc2987d5 100644
>> --- a/scenario_groups/default
>> +++ b/scenario_groups/default
>> @@ -6,6 +6,7 @@ dio
>>   io
>>   mm
>>   ipc
>> +irq
>>   sched
>>   math
>>   nptl
>> -- 
>> 2.23.0
> 
> I'm not sure this should go in the default group at this time. The only
> test in irq (irqbalance), only works on some configurations. As
> discussed in the test review, the user must figure out if they should
> run it or not.

It is hard to say moving this case into default run at this time is good
or bad.

With an optimistic attitude, I want to add it into default run(add some
comment in irqbalance01.c that irqbalance01 may fail because it needs
some configuration in service or hardware)and then listen whether many
users complain about this failure.

ps: Many people still use runltp to test ltp instead of runltp-ng and
they usually only run default group. That is a important reason that I
want to add this case into default group.
> 
> Perhaps we need a new scenario group?
I don't have objection. So do you want to cover what scenario(advanced
or experimental scenario group)?

Best Regards
Yang Xu
> 

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 2/2] scenario_groups/default: Add irq into default run

[Cyril Hrubis]

Hi!
> >> Signed-off-by: Yang Xu<xuyang2018.jy@fujitsu.com>
> >> ---
> >>   scenario_groups/default | 1 +
> >>   1 file changed, 1 insertion(+)
> >>
> >> diff --git a/scenario_groups/default b/scenario_groups/default
> >> index 439783dac..1dc2987d5 100644
> >> --- a/scenario_groups/default
> >> +++ b/scenario_groups/default
> >> @@ -6,6 +6,7 @@ dio
> >>   io
> >>   mm
> >>   ipc
> >> +irq
> >>   sched
> >>   math
> >>   nptl
> >> -- 
> >> 2.23.0
> > 
> > I'm not sure this should go in the default group at this time. The only
> > test in irq (irqbalance), only works on some configurations. As
> > discussed in the test review, the user must figure out if they should
> > run it or not.
> 
> It is hard to say moving this case into default run at this time is good
> or bad.
> 
> With an optimistic attitude, I want to add it into default run(add some
> comment in irqbalance01.c that irqbalance01 may fail because it needs
> some configuration in service or hardware)and then listen whether many
> users complain about this failure.
> 
> ps: Many people still use runltp to test ltp instead of runltp-ng and
> they usually only run default group. That is a important reason that I
> want to add this case into default group.

Well there are two wrong choices.

If we add it to the default scenario people will complain that the test
fails for no good reason.

If we do not, the test will be largerly unused and probably bitrot over
the time.

However if majority here things that we should enable it by default, we
can try that and revert it if we got too many complaints.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 2/2] scenario_groups/default: Add irq into default run

[xuyang2018.jy]

Hi Cyril
> Hi!
>>>> Signed-off-by: Yang Xu<xuyang2018.jy@fujitsu.com>
>>>> ---
>>>>    scenario_groups/default | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/scenario_groups/default b/scenario_groups/default
>>>> index 439783dac..1dc2987d5 100644
>>>> --- a/scenario_groups/default
>>>> +++ b/scenario_groups/default
>>>> @@ -6,6 +6,7 @@ dio
>>>>    io
>>>>    mm
>>>>    ipc
>>>> +irq
>>>>    sched
>>>>    math
>>>>    nptl
>>>> --
>>>> 2.23.0
>>>
>>> I'm not sure this should go in the default group at this time. The only
>>> test in irq (irqbalance), only works on some configurations. As
>>> discussed in the test review, the user must figure out if they should
>>> run it or not.
>>
>> It is hard to say moving this case into default run at this time is good
>> or bad.
>>
>> With an optimistic attitude, I want to add it into default run(add some
>> comment in irqbalance01.c that irqbalance01 may fail because it needs
>> some configuration in service or hardware)and then listen whether many
>> users complain about this failure.
>>
>> ps: Many people still use runltp to test ltp instead of runltp-ng and
>> they usually only run default group. That is a important reason that I
>> want to add this case into default group.
>
> Well there are two wrong choices.
>
> If we add it to the default scenario people will complain that the test
> fails for no good reason.
>
> If we do not, the test will be largerly unused and probably bitrot over
> the time.
>
> However if majority here things that we should enable it by default, we
> can try that and revert it if we got too many complaints.
Yes, that's what I was thinking too.

Best Regards
Yang Xu
>

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 2/2] scenario_groups/default: Add irq into default run

[Petr Vorel]

Hi all,

> Hi Cyril
> > Hi!
> >>>> Signed-off-by: Yang Xu<xuyang2018.jy@fujitsu.com>
> >>>> ---
> >>>>    scenario_groups/default | 1 +
> >>>>    1 file changed, 1 insertion(+)

> >>>> diff --git a/scenario_groups/default b/scenario_groups/default
> >>>> index 439783dac..1dc2987d5 100644
> >>>> --- a/scenario_groups/default
> >>>> +++ b/scenario_groups/default
> >>>> @@ -6,6 +6,7 @@ dio
> >>>>    io
> >>>>    mm
> >>>>    ipc
> >>>> +irq
> >>>>    sched
> >>>>    math
> >>>>    nptl
> >>>> --
> >>>> 2.23.0

> >>> I'm not sure this should go in the default group at this time. The only
> >>> test in irq (irqbalance), only works on some configurations. As
> >>> discussed in the test review, the user must figure out if they should
> >>> run it or not.

> >> It is hard to say moving this case into default run at this time is good
> >> or bad.

> >> With an optimistic attitude, I want to add it into default run(add some
> >> comment in irqbalance01.c that irqbalance01 may fail because it needs
> >> some configuration in service or hardware)and then listen whether many
> >> users complain about this failure.

> >> ps: Many people still use runltp to test ltp instead of runltp-ng and
> >> they usually only run default group. That is a important reason that I
> >> want to add this case into default group.

> > Well there are two wrong choices.

> > If we add it to the default scenario people will complain that the test
> > fails for no good reason.

> > If we do not, the test will be largerly unused and probably bitrot over
> > the time.

> > However if majority here things that we should enable it by default, we
> > can try that and revert it if we got too many complaints.
> Yes, that's what I was thinking too.

OK, merged, let's see if it's ok to run for majority (we can always revert it).

Kind regards,
Petr

> Best Regards
> Yang Xu

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp