* [PATCH] tty: serial: jsm: jsm_neo: fixed a conditional statement coding style issue
@ 2021-11-16 10:34 Sahil Patidar
2021-11-16 10:36 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Sahil Patidar @ 2021-11-16 10:34 UTC (permalink / raw)
To: gregkh; +Cc: linux-serial, linux-kernel, Sahil Patidar
Fixed a coding style issue
Signed-off-by: Sahil Patidar <sahilpatidar4051@gmail.com>
---
drivers/tty/serial/jsm/jsm_neo.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/tty/serial/jsm/jsm_neo.c b/drivers/tty/serial/jsm/jsm_neo.c
index c6f927a76c3b..9b828989d13f 100644
--- a/drivers/tty/serial/jsm/jsm_neo.c
+++ b/drivers/tty/serial/jsm/jsm_neo.c
@@ -668,8 +668,7 @@ static void neo_flush_uart_read(struct jsm_channel *ch)
jsm_dbg(IOCTL, &ch->ch_bd->pci_dev,
"Still flushing RX UART... i: %d\n", i);
udelay(10);
- }
- else
+ } else
break;
}
}
--
2.33.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tty: serial: jsm: jsm_neo: fixed a conditional statement coding style issue
2021-11-16 10:34 [PATCH] tty: serial: jsm: jsm_neo: fixed a conditional statement coding style issue Sahil Patidar
@ 2021-11-16 10:36 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-11-16 10:36 UTC (permalink / raw)
To: Sahil Patidar; +Cc: linux-serial, linux-kernel
On Tue, Nov 16, 2021 at 04:04:11PM +0530, Sahil Patidar wrote:
> Fixed a coding style issue
What issue?
And why in a tty driver?
I would recommend doing coding style fixes in drivers/staging/, where
they are welcome and you can learn the basics of kernel patches first,
before going out into the rest of the kernel.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-16 10:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-16 10:34 [PATCH] tty: serial: jsm: jsm_neo: fixed a conditional statement coding style issue Sahil Patidar
2021-11-16 10:36 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.